Mahara

Remove references to tutor role from core code

Bug #827762 reported by Richard Mansfield
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Richard Mansfield
Mahara 1.5.0

Bug Description

The grouptype plugins exist to make it possible to customise Mahara with group types that have a different set of roles. I only know of one instance in which this has actually been done, but we should try to make sure it remains possible. Admin and member are the only compulsory roles that must exist in all group types, so core code should avoid references to the tutor role, and defer to the grouptype instead.

Richard Mansfield (richard-mansfield)
Changed in mahara:
status: New → Confirmed
importance: Undecided → Wishlist
assignee: nobody → Richard Mansfield (richard-mansfield)
milestone: none → 1.5.0
Richard Mansfield (richard-mansfield)
summary: - Roles other than admin, member belong in grouptype
+ Remove references to tutor role from core code
Revision history for this message
François Marier (fmarier) wrote :

https://reviews.mahara.org/#change,602

Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/602
Committed: http://gitorious.org/mahara/mahara/commit/57a9d96e50274eb6b6222cce3745a16274e4825e
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit 57a9d96e50274eb6b6222cce3745a16274e4825e
Author: Richard Mansfield <email address hidden>
Date: Wed Aug 17 14:35:07 2011 +1200

    Remove hardcoded references to 'tutor' role in core code (bug #827762)

    Change-Id: I7e72a77375cff65dd20189ba1b93cf9dbda3be42
    Signed-off-by: Richard Mansfield <email address hidden>

Richard Mansfield (richard-mansfield)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/670
Committed: http://gitorious.org/mahara/mahara/commit/aa3d90424493831ceca13c362083c29a53c6e20e
Submitter: Hugh Davenport (<email address hidden>)
Branch: master

commit aa3d90424493831ceca13c362083c29a53c6e20e
Author: Piers Harding <email address hidden>
Date: Fri Sep 9 10:00:29 2011 +1200

    Include grouptype class when changing group roles (bug #827762)

    Changes to the group_update function in commit 57a9d96e50 added a
    call to the grouptype's get_roles method, without first including
    the grouptype class. The grouptype class is not available when
    this function is called from the webservice api, so group_update
    will call a method that doesn't exist.

    Change-Id: I10c861f7e692192621ec8372e7a7f5f25cbd8f6f
    Signed-off-by: Richard Mansfield <email address hidden>

Revision history for this message
Melissa Draper (melissa) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPjrYkAAoJECXBtiziiXdcBjUH+gOs1qGQ20HFISw5maAWKxaU
yT4JUSRYzcVk8g5FgnONKIDVMKo9ZiyZD0xTWoevwRamE5IiE00ltsoxtaVecvBx
Km/hOBIiaTCfNlZ/nCULO+FUflYWhuzjb8szGQNCLTJLXzHq1Q/BRJAWPzKvUweo
zKe23pNiXtMlRkqEs+IwWnf04M3YH8O6tqcoirtLWPmLRJxtW19qT5LOGdkFojVP
ode3BhogyPMFWxS9mhn0AgE9j/GdNMXbPxKCSqLhrcDCQvC+wXNqvWC/Fp7jMe0n
5mPXBmBPLCiQAIQ7a9GNV/71GhLEB6YkZ1HZj+EkCuXvdejKe/MutEVgHIiZUus=
=Yjja
-----END PGP SIGNATURE-----

Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.