Invalid declation of DebconfError in install.py will likely to crash Ubiquity in most hardware configurations.

Bug #83008 reported by Joel Bryan Juliano
2
Affects Status Importance Assigned to Milestone
ubiquity (Ubuntu)
Fix Released
Undecided
Colin Watson

Bug Description

Binary package hint: ubiquity

At line 991 in the ubiquity install.py will likely to make the installer crash, since the declaration of DebconfError is not defined. It's a #NameError and will likely to cause the crash on most hardware and software configurations.

I think the solutions are to change the DebconfError: to debconf.DebconfError:
Here's the lines involving the NameError syntax.

             participate = self.db.get('popularity-contest/participate')
             self.set_debconf('popularity-contest/participate', participate)
- except DebconfError:
+ except debconf.DebconfError:
             pass

         self.chrex('mount', '-t', 'proc', 'proc', '/proc')

Related branches

Revision history for this message
Joel Bryan Juliano (joelbryan) wrote :

Here's a simple patch in the current lines.

description: updated
Revision history for this message
Colin Watson (cjwatson) wrote :

Thanks, applied. This didn't come up in testing because in fact it's limited to cases where an exception actually gets thrown (e.g. popularity-contest isn't installed in the live session or in the target system). As a demonstration:

$ python
Python 2.5 (release25-maint, Jan 15 2007, 19:47:09)
[GCC 4.1.2 20070106 (prerelease) (Ubuntu 4.1.1-21ubuntu7)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> try:
... pass
... except NonexistentError:
... pass
...
>>> try:
... raise Exception
... except NonexistentError:
... pass
...
Traceback (most recent call last):
  File "<stdin>", line 3, in <module>
NameError: name 'NonexistentError' is not defined
>>>

Changed in ubiquity:
assignee: nobody → kamion
status: Unconfirmed → Fix Committed
Revision history for this message
Colin Watson (cjwatson) wrote :

ubiquity (1.3.18) feisty; urgency=low

  * New partitioner:
    - Disable the mountpoint combo box when creating or editing a partition
      if the method is changed to something other than a filesystem.
    - Handle partman/exception_handler and partman/exception_handler_note
      (LP: #82848).
    - Note that unadorned sizes are assumed to be in megabytes (LP: #82848).
    - Display current partition sizes in megabytes (part of LP: #83166).
    - Implement resizing. Ask for the size using a spinbutton (in megabytes)
      rather than a text entry field.
    - Offer 'fat16' and 'fat32' filesystem types for new partitions rather
      than the non-existent 'fat' (LP: #83211).
    - Fix crash when backing up to automatic partitioning page (LP: #83230).
  * doc/README: Add comment about language pack installation following a
    query from Telmo Baía.
  * Fix crash due to underqualification of debconf.DebconfError (thanks,
    Joel Bryan Juliano; LP: #83008).
  * Automatic update of included source packages: partman-partitioning
    45ubuntu1.

 -- Colin Watson <email address hidden> Mon, 5 Feb 2007 13:17:27 +0000

Changed in ubiquity:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.