Unity

unity-panel-service memory leak when starting various applications

Bug #835646 reported by Hernando Torque on 2011-08-27

This bug affects 16 people

	Status	Importance	Assigned to	Milestone
Application Menu Indicator	Fix Released	Undecided	Ted Gould
DBus Menu	Fix Released	Undecided	Michael Terry	DBus Menu 0.5.1
Unity	Invalid	High	Ted Gould	Unity 4.26.0 "SRU1"
Unity Distro Priority	Fix Released	Undecided	Unassigned
indicator-appmenu (Ubuntu)	Fix Released	High	Unassigned
unity (Ubuntu)	Invalid	Undecided	Unassigned

Bug Description

Opening various programs causes unity-panel-service to use more and more resident memory (that won't be freed after program termination).

Attaching a valgrind log of unity-panel-service containing ten starts of Kile (which caused unity-panel-service to go from 23 MB to 119 MB resident memory usage):

==8130== LEAK SUMMARY:
==8130== definitely lost: 45,015 bytes in 508 blocks
==8130== indirectly lost: 203,173 bytes in 5,553 blocks
==8130== possibly lost: 23,453 bytes in 450 blocks
==8130== still reachable: 28,961,416 bytes in 525,544 blocks

TEST CASE:
1. Open a gnome-terminal window.
2. Run 'while true; do ps aux | grep unity-panel-service | grep -v grep; sleep 1; done' and monitor the sixth column (resident memory usage in KB).
3a. Open and close Gimp, or if zou don't have that installed:
3b. Open and close Nautilus.

RESULTS:
For 3a: memory increases by ~12 MB.
For 3b: memory increases by ~2 MB.

I'm currently running Unity from trunk (r1455) but this also happens with Unity from Oneiric and a daily live CD (amd64 - 20110827). This also affectes unity-2d

See original description

Tags:

Related branches

lp:indicator-appmenu/0.3

lp:~dbusmenu-team/libdbusmenu/ubuntu

Rejected for merging into lp:~ubuntu-desktop/libdbusmenu/ubuntu

Ken VanDine: Disapprove on 2011-10-13

Superseded for merging into lp:libdbusmenu/0.5

Ken VanDine: Pending requested 2011-01-27

Diff: 67319 lines (+66205/-527)

110 files modified

.bzrignore (+0/-229)
AUTHORS (+17/-0)
ChangeLog (+5918/-0)
Makefile.in (+821/-0)
aclocal.m4 (+10063/-0)
autogen.sh (+0/-12)
compile (+143/-0)
config.guess (+1502/-0)
config.h.in (+86/-0)
config.sub (+1714/-0)
configure (+16483/-0)
debian/changelog (+657/-0)
debian/control (+225/-0)
debian/copyright (+40/-0)
debian/gir1.2-dbusmenu-glib-0.4.install (+1/-0)
debian/gir1.2-dbusmenu-gtk-0.4.install (+1/-0)
debian/gir1.2-dbusmenu-gtk3-0.4.install (+1/-0)
debian/libdbusmenu-glib-dev.install (+6/-0)
debian/libdbusmenu-glib-doc.install (+1/-0)
debian/libdbusmenu-glib3.install (+1/-0)
debian/libdbusmenu-gtk-dev.install (+6/-0)
debian/libdbusmenu-gtk-doc.install (+1/-0)
debian/libdbusmenu-gtk3-3.install (+1/-0)
debian/libdbusmenu-gtk3-dev.install (+5/-0)
debian/libdbusmenu-gtk3.install (+1/-0)
debian/libdbusmenu-jsonloader-dev.install (+4/-0)
debian/libdbusmenu-jsonloader3.install (+1/-0)
debian/libdbusmenu-tools.install (+3/-0)
debian/rules (+45/-0)
debian/source/format (+1/-0)
debian/watch (+2/-0)
depcomp (+630/-0)
docs/Makefile.in (+613/-0)
docs/libdbusmenu-glib/Makefile.in (+613/-0)
docs/libdbusmenu-glib/reference/Makefile.in (+689/-0)
docs/libdbusmenu-glib/reference/html/annotation-glossary.html (+71/-0)
docs/libdbusmenu-glib/reference/html/api-index-full.html (+406/-0)
docs/libdbusmenu-glib/reference/html/ch01.html (+48/-0)
docs/libdbusmenu-glib/reference/html/index.html (+46/-0)
docs/libdbusmenu-glib/reference/html/index.sgml (+120/-0)
docs/libdbusmenu-glib/reference/html/libdbusmenu-glib-DbusmenuClient.html (+427/-0)
docs/libdbusmenu-glib/reference/html/libdbusmenu-glib-DbusmenuClientMenuitem.html (+92/-0)
docs/libdbusmenu-glib/reference/html/libdbusmenu-glib-DbusmenuMenuitem.html (+1326/-0)
docs/libdbusmenu-glib/reference/html/libdbusmenu-glib-DbusmenuMenuitemProxy.html (+154/-0)
docs/libdbusmenu-glib/reference/html/libdbusmenu-glib-DbusmenuServer.html (+260/-0)
docs/libdbusmenu-glib/reference/html/libdbusmenu-glib.devhelp (+109/-0)
docs/libdbusmenu-glib/reference/html/libdbusmenu-glib.devhelp2 (+109/-0)
docs/libdbusmenu-glib/reference/html/object-tree.html (+32/-0)
docs/libdbusmenu-glib/reference/html/style.css (+266/-0)
docs/libdbusmenu-glib/reference/tmpl/client-menuitem.sgml (+52/-0)
docs/libdbusmenu-glib/reference/tmpl/client.sgml (+168/-0)
docs/libdbusmenu-glib/reference/tmpl/menuitem-proxy.sgml (+57/-0)
docs/libdbusmenu-glib/reference/tmpl/menuitem.sgml (+520/-0)
docs/libdbusmenu-glib/reference/tmpl/server.sgml (+112/-0)
docs/libdbusmenu-glib/reference/version.xml (+1/-0)
docs/libdbusmenu-glib/reference/xml/annotation-glossary.xml (+64/-0)
docs/libdbusmenu-glib/reference/xml/api-index-deprecated.xml (+8/-0)
docs/libdbusmenu-glib/reference/xml/api-index-full.xml (+105/-0)
docs/libdbusmenu-glib/reference/xml/client-menuitem.xml (+70/-0)
docs/libdbusmenu-glib/reference/xml/client.xml (+322/-0)
docs/libdbusmenu-glib/reference/xml/menuitem-proxy.xml (+103/-0)
docs/libdbusmenu-glib/reference/xml/menuitem.xml (+915/-0)
docs/libdbusmenu-glib/reference/xml/server.xml (+199/-0)
docs/libdbusmenu-gtk/Makefile.in (+613/-0)
docs/libdbusmenu-gtk/reference/Makefile.in (+685/-0)
docs/libdbusmenu-gtk/reference/html/api-index-full.html (+122/-0)
docs/libdbusmenu-gtk/reference/html/ch01.html (+42/-0)
docs/libdbusmenu-gtk/reference/html/index.html (+39/-0)
docs/libdbusmenu-gtk/reference/html/index.sgml (+33/-0)
docs/libdbusmenu-gtk/reference/html/libdbusmenu-gtk-DbusmenuGtkClient.html (+316/-0)
docs/libdbusmenu-gtk/reference/html/libdbusmenu-gtk-DbusmenuGtkMenu.html (+169/-0)
docs/libdbusmenu-gtk/reference/html/libdbusmenu-gtk-menuitem.html (+256/-0)
docs/libdbusmenu-gtk/reference/html/libdbusmenu-gtk.devhelp (+36/-0)
docs/libdbusmenu-gtk/reference/html/libdbusmenu-gtk.devhelp2 (+36/-0)
docs/libdbusmenu-gtk/reference/html/object-tree.html (+42/-0)
docs/libdbusmenu-gtk/reference/html/style.css (+266/-0)
docs/libdbusmenu-gtk/reference/libdbusmenu-gtk-sections.txt (+70/-0)
docs/libdbusmenu-gtk/reference/libdbusmenu-gtk.types (+3/-0)
docs/libdbusmenu-gtk/reference/tmpl/client.sgml (+115/-0)
docs/libdbusmenu-gtk/reference/tmpl/genericmenuitem.sgml (+22/-0)
docs/libdbusmenu-gtk/reference/tmpl/libdbusmenu-gtk-unused.sgml (+118/-0)
docs/libdbusmenu-gtk/reference/tmpl/menu.sgml (+67/-0)
docs/libdbusmenu-gtk/reference/tmpl/menuitem.sgml (+84/-0)
docs/libdbusmenu-gtk/reference/version.xml (+1/-0)
docs/libdbusmenu-gtk/reference/xml/api-index-deprecated.xml (+8/-0)
docs/libdbusmenu-gtk/reference/xml/api-index-full.xml (+33/-0)
docs/libdbusmenu-gtk/reference/xml/client.xml (+214/-0)
docs/libdbusmenu-gtk/reference/xml/genericmenuitem.xml (+36/-0)
docs/libdbusmenu-gtk/reference/xml/menu.xml (+118/-0)
docs/libdbusmenu-gtk/reference/xml/menuitem.xml (+165/-0)
install-sh (+520/-0)
libdbusmenu-glib/Doxyfile (+0/-257)
libdbusmenu-glib/Makefile.in (+958/-0)
libdbusmenu-glib/client-marshal.c (+131/-0)
libdbusmenu-glib/client-marshal.h (+28/-0)
libdbusmenu-glib/dbus-menu-clean.xml.c (+132/-0)
libdbusmenu-glib/dbus-menu-clean.xml.h (+1/-0)
libdbusmenu-glib/menuitem-marshal.c (+170/-0)
libdbusmenu-glib/menuitem-marshal.h (+45/-0)
libdbusmenu-glib/server-marshal.c (+164/-0)
libdbusmenu-glib/server-marshal.h (+36/-0)
libdbusmenu-gtk/Makefile.in (+1005/-0)
ltmain.sh (+8413/-0)
missing (+376/-0)
mkinstalldirs (+162/-0)
po/Makefile.in.in (+217/-0)
tests/Makefile.in (+2204/-0)
tools/Makefile.in (+858/-0)
tools/testapp/CMakeLists.txt (+0/-29)
tools/testapp/Makefile.in (+619/-0)

lp:ubuntu/precise/libdbusmenu

Revision history for this message

Hernando Torque (htorque) wrote on 2011-08-27:

valgrind_kile_u-p-s.log Edit (2.2 MiB, text/plain)

Revision history for this message

Hernando Torque (htorque) wrote on 2011-08-27:

This seems to affect various applications ranging from 1-2MB (nautilus, gedit, banshee) to 7-12MB for inkscape, gimp. It doesn't matter if I start those applications throught the launcher or via command line.

Although I'm seeing this on two different systems, I'll try a live CD to make sure it's not some issue with my installations.

Revision history for this message

Hernando Torque (htorque) wrote on 2011-08-27:

Same thing happens with today's live CD (amd64 - 20110827).

summary:

- unity-panel-service memory leak with Kile
+ unity-panel-service memory leak when starting various applications

Hernando Torque (htorque) on 2011-08-27

description:

updated

Roland (Rolandixor) Taylor (rolandixor) on 2011-08-27

Changed in unity:
status:	New → Confirmed
Changed in unity (Ubuntu):
status:	New → Confirmed

Omer Akram (om26er) on 2011-08-28

Changed in unity:
importance:	Undecided → High
Changed in unity (Ubuntu):
importance:	Undecided → High

Hernando Torque (htorque) on 2011-08-29

description:	updated
tags:	added: oneiric unity unity-2d

Revision history for this message

Neil J. Patel (njpatel) wrote on 2011-09-01:

Hey Hernando, could you try testing `/usr/lib/libindicator/indicator-loader /usr/lib/indicators3/6/libappmenu.so` and see if that is leaking for you (probably from metacity, without an exsiting global menu)? I'd like to try and isolate it to one of the indciators or the service itself (which shows leaking if one of the indicators leaks).

Thanks!

Changed in unity:
assignee:	nobody → Neil J. Patel (njpatel)
milestone:	none → 4.14.0

Revision history for this message

Hernando Torque (htorque) wrote on 2011-09-01:

valgrind.log Edit (518.9 KiB, text/plain)

Just a correction of #4: you need indicator-loader3 from the libindicator3-tools package.

Adding valgrind log of opening GIMP and Kile a couple of times.

Revision history for this message

Neil J. Patel (njpatel) wrote on 2011-09-07:

Using this to track the issue as it's pretty high priority, but the problem is in indicator-appmenu, so assigning it to Ted.

Changed in indicator-appmenu:
assignee:	nobody → Ted Gould (ted)
Changed in unity:
assignee:	Neil J. Patel (njpatel) → Ted Gould (ted)

Didier Roche-Tolomelli (didrocks) on 2011-09-08

Changed in unity:
milestone:	4.14.0 → 4.16.0

Revision history for this message

Ted Gould (ted) wrote on 2011-09-14:

valgrind.log Edit (6.9 MiB, text/plain)

So, I've spend the better part of today looking through this and I can't really find anything. One small leak, but I'm pretty sure that it isn't big enough to be an issue here. I'm attaching a "turn it up to 11" valgrind log where I went through all the stacks that included dbusmenu or appmenu and couldn't find anything noticible in the code. I'm not quite sure where to go from here on this bug.

Didier Roche-Tolomelli (didrocks) on 2011-09-15

Changed in unity:
milestone:	4.16.0 → 4.18.0

Revision history for this message

Michael Terry (mterry) wrote on 2011-09-22:

FYI, I'm taking a look at this too. If I comment out the gtkclient bits of window_menus_new in indicator-appmenu, (perhaps unsurprisingly) I don't get the leak anymore. I'm looking into dbusmenu now for why that might be.

Didier Roche-Tolomelli (didrocks) on 2011-09-26

Changed in unity:
milestone:	4.18.0 → 4.20.0

Didier Roche-Tolomelli (didrocks) on 2011-09-29

affects:	unity (Ubuntu) → libappindicator (Ubuntu)
affects:	libappindicator (Ubuntu) → indicator-appmenu (Ubuntu)

Didier Roche-Tolomelli (didrocks) on 2011-09-29

Changed in unity:
milestone:	4.20.0 → 4.22.0

Didier Roche-Tolomelli (didrocks) on 2011-09-30

Changed in unity (Ubuntu):
status:	New → Confirmed

Didier Roche-Tolomelli (didrocks) on 2011-10-04

Changed in unity:
milestone:	4.22.0 → 4.24.0

Revision history for this message

Michael Terry (mterry) wrote on 2011-10-05:

I've been doing some work on this. With the following merges on top of current oneiric, I think we're mostly good:

https://code.launchpad.net/~mterry/dbusmenu/unref-gtkmenuitems/+merge/78156
https://code.launchpad.net/~mterry/dbusmenu/fix-bad-image-set/+merge/78303
https://code.launchpad.net/~mterry/indicator-appmenu/double-ref-of-entry-label/+merge/78300

Probably better as a couple SRUs at this late juncture?

Revision history for this message

Hernando Torque (htorque) wrote on 2011-10-06:

#10

It still raises pretty fast from 20 to 50 MB but then it seems to slow down and applications don't add the same amount of memory on every start (or none at all, like restarting GIMP at that time doesn't add anything).

At least the times of u-p-s using 500+ MB seem to be over, good job! :-)

Revision history for this message

Michael Terry (mterry) wrote on 2011-10-06:

#11

Hernando, you were testing with my branches?

Revision history for this message

Hernando Torque (htorque) wrote on 2011-10-06:

#12

Yeah, I was testing you branches. I simply patched the Ubuntu sources and rebuilt the packages (didn't want to screw things up, as I wasn't sure if '--prefix=/usr' was all that's needed for building).

It's definitely an improvement, but I'd still like to see the memory usage actually go down when I close a program (u-p-s is currently using ~60 MB and would stay the same if I'd close all running programs).

Revision history for this message

Michael Terry (mterry) wrote on 2011-10-06:

#13

I couldn't find any more obvious problems with my methods (using gobject-list [1], valgrind, and printfs). I'm going to stop looking at this for now.

[1] http://blogs.gnome.org/danni/2011/02/17/ld_preload-gobject-lifetime-debugging-tool/

Ted Gould (ted) on 2011-10-12

Changed in dbusmenu:
status:	New → Fix Committed
assignee:	nobody → Michael Terry (mterry)
milestone:	none → 0.5.1

Ted Gould (ted) on 2011-10-13

Changed in dbusmenu:
status:	Fix Committed → Fix Released

Revision history for this message

Ken VanDine (ken-vandine) wrote on 2011-10-13:

#14

This was fixed in 0.3.1-0ubuntu2

Changed in indicator-appmenu (Ubuntu):
status:	Confirmed → Fix Released

Didier Roche-Tolomelli (didrocks) on 2011-10-17

Changed in unity:
milestone:	4.24.0 → 4.26.0

Marco Trevisan (Treviño) (3v1n0) on 2011-10-18

Changed in unity:
status:	Confirmed → Invalid
Changed in unity (Ubuntu):
status:	Confirmed → Invalid

Didier Roche-Tolomelli (didrocks) on 2011-10-28

Changed in unity-distro-priority:
status:	New → Fix Committed

Tim Penhey (thumper) on 2011-11-14

tags:

added: udp

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) wrote on 2011-11-14:

#15

Also the accessible description of indicator sound leaks some memory when changing the volume level. This branch fixes the issue: https://code.launchpad.net/~3v1n0/indicator-sound/add-name-hint_fix-memleak

Didier Roche-Tolomelli (didrocks) on 2011-11-16

Changed in unity-distro-priority:
status:	Fix Committed → Fix Released

Ted Gould (ted) on 2011-11-17

Changed in indicator-appmenu:
status:	New → Fix Released

Revision history for this message

Colin Harrington (colin-harrington) wrote on 2012-05-21:

#16

Wow, I'm running 12.04 and saw the unity-panel-service hit 517.9 MiB Does this warrant a new bug?

Revision history for this message

Jan Vlnas (jnv) wrote on 2012-07-29:

#17

This particular issue was fixed. If unity-panel-service is still leaking for you, see bug #987060.

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Bug attachments

Add attachment

Remote bug watches

Bug watches keep track of this bug in other bug trackers.