Original Building Site Graphic Is Visible During Construction Sequence

The question is, what would be the best solution?
The problem simply is, that there must be the old building at the beginning, when there's actually only 0% build of the enhancement - so currently I believe the best would be to remove the old building animation after the first build segment was finished - this would keep the current animations of upgradeable buildings (with just one frame) as they are and should still be enough for better (multi frame) build animations.

What do you think?

okay I just checked the code - actually it is already the way I wrote above (constructionsite.cc:571 ff) - the main problem is, that the last image is always completely drawn at the beginning and the build animation is drawn on top (like a transparent layer).

So the fix should basically be like:
* the last animation frame (in first place the old building animation) is drawn completely
* once the next animation is drawn line by line, the line where the new animation is drawn should first be erased from the underlying old animation.

However I am not yet sure how to do this. Anyone of the graphic developers an idea?

nevermind about #3 - was a bit blind ;)

Fix is in bzr including a test animation for the citadel - looking forward to see it replaced :).

Thanks, Peter! I'm going to take that new code for a test run right away! :)

@Peter: When upgrading the barbarian fortress to a citadel, immediately after selecting the upgrade icon, the FIRST build frame of the fortress is displayed. This is not a logical progression, i.e. taking the construction site back that far in its history.

If a different frame is needed immediately at that point, I would suggest the LAST frame of the fortress build or the first frame of the citadel build.

To test, upgrade a fortress to a citadel with rev. 5972.

A third possibility is to display the "unoccupied" graphic of the first building as its occupants immediately are ejected.

To mitigate a drastic change in the fortress-citadel transition, I have accounted for the "dismantling" of the fortress in the first couple frames of the citadel build sequence. (see attached
I think that graphicians, by planning accordingly, should be able to resolve the transition from old to new without going back to "square #1" for the first building.

Sorry for my late reply - actually I fixed that problem some days ago, but currently have no possibility to push it to trunk, as I am not at home.
It is a simpe one word change, so could someone of you please fix this :) ?

Fix is in http://bazaar.launchpad.net/~widelands-dev/widelands/trunk/view/head:/src/logic/constructionsite.cc#L583 (src/logic/constructionsite.cc line 583)

"build" must be replaced with "unoccupied"

alright. Fix is in trunk bzr rev. 5973 :)

Released in build17-rc1.