Temporarily lock accounts after too many bad passwords

Bug #843561 reported by François Marier
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Melissa Draper

Bug Description

To deter brute-forcing of passwords (and prevent ensuing DoS attacks), we should temporarily lock accounts once they've had too many (4? 5?) bad passwords.

Considerations:

- This should be as fast as possible and ideally not use extra queries. In a DoS setting, we want brute-forcers to add as little load as possible on the server.

- To avoid adding a "locked until" field to the user table which needs to be updated constantly, maybe we should just unlock all users every time cron runs (every 5 min?) and tell users they've been locked out for up to 5 min.

This will be particularly helpful once we fix bug 547469.

Changed in mahara:
importance: Undecided → Medium
status: New → Triaged
milestone: none → 1.5.0
Revision history for this message
Melissa Draper (melissa) wrote :

https://reviews.mahara.org/#change,679 has been pushed to review for this.

Changed in mahara:
status: Triaged → In Progress
assignee: nobody → Melissa Draper (melissa)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/679
Committed: http://gitorious.org/mahara/mahara/commit/51c4d530a7f402887cefd51f621188af904a2721
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit 51c4d530a7f402887cefd51f621188af904a2721
Author: Melissa Draper <email address hidden>
Date: Fri Sep 9 17:58:58 2011 +1200

    Add a lock for accounts after 5 tries (bug #843561)

    To deter brute-forcing of passwords (and prevent ensuing DoS attacks),
    this patch temporarily lock accounts after 5 tries, and every 5 minutes
    counts above 0 get reset.

    Change-Id: Iee9739a69b95b906b6f485f7d90041b50968dcc6
    Signed-off-by: Melissa Draper <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
tags: added: passwords
removed: password
tags: added: newfeature
Melissa Draper (melissa)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.