source_xorg.py crashed with ValueError in attach_graphic_card_pci_info(): need more than 1 value to unpack

     for paragraph in display_pci.split('\n\n'):
        for line in paragraph.split('\n'):
            if ':' not in line:
                continue
            key, value = line.split(': ', 1)
            value = value.strip()
            key = key.strip()

The ValueError occurs on the line
    key, value = line.split(': ', 1)

The problem is line.split returns ['\t\tDevCap:\tMaxPayload 128 bytes, PhantFunc 0, Latency L0s <4us, L1 unlimited']
Note :\t is not matched by the split on ': '

Fix:

--- /usr/share/apport/package-hooks/xserver-xorg-core.py.orig 2011-09-14 03:00:44.392362002 +0100
+++ /usr/share/apport/package-hooks/xserver-xorg-core.py 2011-09-14 03:01:52.102362002 +0100
@@ -338,7 +338,10 @@
         for line in paragraph.split('\n'):
             if ':' not in line:
                 continue
- key, value = line.split(': ', 1)
+ m = re.match(r'(.*?):\s(.*)', line)
+ if not m:
+ continue
+ key, value = m.group(1), m.group(2)
             value = value.strip()
             key = key.strip()
             if "VGA compatible controller" in key:

Formatting..

This is still a problem with xdiagnose-1.2. The crash only happens when xserver-xorg-core.py is run as root:

$ sudo /usr/share/apport/package-hooks/xserver-xorg-core.py
 lsb_release -sc
attach_gpu_hang_info
attach_xorg_package_versions
attach_dist_upgrade_status
attach_hardware
attach_graphic_card_pci_info
Traceback (most recent call last):
  File "/usr/share/apport/package-hooks/xserver-xorg-core.py", line 680, in <module>
    if not add_info(report, None):
  File "/usr/share/apport/package-hooks/xserver-xorg-core.py", line 653, in add_info
    attach_graphic_card_pci_info(report, ui)
  File "/usr/share/apport/package-hooks/xserver-xorg-core.py", line 341, in attach_graphic_card_pci_info
    key, value = line.split(': ', 1)
ValueError: need more than 1 value to unpack