Don't check internal auth instances for automatic user creation

Bug #850617 reported by Richard Mansfield
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Richard Mansfield

Bug Description

When a user logs in with an unknown username, all the authinstances on the site are checked one by one, with separate queries, to see if they want to create the user automatically. It's easy to restrict the check to non-internal authinstances, and cuts out a lot of useless work because internal authinstances can never automatically create users.

Changed in mahara:
assignee: nobody → Richard Mansfield (richard-mansfield)
importance: Undecided → Low
milestone: none → 1.5.0
status: New → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/696
Committed: http://gitorious.org/mahara/mahara/commit/e98b352e2e1f209f3353ed8f2f0050edce27c527
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit e98b352e2e1f209f3353ed8f2f0050edce27c527
Author: Richard Mansfield <email address hidden>
Date: Thu Sep 15 17:22:22 2011 +1200

    Skip checks of internal authinstances when auto-creating users (bug #850617)

    Change-Id: I31b8d70169e3665167f50f06d07ce263b33464e5
    Signed-off-by: Richard Mansfield <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Melissa Draper (melissa) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPjqY0AAoJECXBtiziiXdcrpMIAKO5qOyhN9AQn9fCr32yAEba
wyQwhMOm1wS5eB4Qa29Hbr3c0xgXcwgsIFHfe0SCL92Gt2W3UjB8klrrRYssj5iu
o7DlmKBJhXo7i/AC005KeMTQZfY7ZX/tI8Lqux3FjfhSpRhCPatLLPr/hZHTbB4X
XXI47L8e304a6AwmDgsa9UUejDIjOwmOF7fFTeul8OgS4zSg3GUDQ1tTMW3+7Sns
YNmS3iU2+e0Z1CQlg5BqKwHVzCByuPPXuotvUkBkcLP53k1gUOn3OnMODTfbbrvf
UOVYo510SEKrkMCi0B4rLQHg8Ck2cUc1wS4GhxCOMrAcYDokjgTM98AerGB2sGE=
=uHSn
-----END PGP SIGNATURE-----

Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.