Spurious navigation history entry added when clearing a search

Bug #854047 reported by Matthew Paul Thomas
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
software-center (Ubuntu)
Fix Released
Low
Matthew McGowan

Bug Description

(This is the sequel to bug 844068.)

Ubuntu Software Center 4.1.23.3, Ubuntu 11.10 beta 1

1. Navigate to "Games" > "Board Games".
2. Do a search, e.g. "chess".
3. Click the clear button in the search field.
4. Click Back.
5. Click Back again.
6. Click Back again.

What happens: USC navigates to
3. "Board Games"
4. search results for "chess"
5. "Board Games" (wot, again?)
6. "Games"

What should happen: USC navigates to
3. "Board Games"
4. "Games"
5. the home screen
6. Back is insensitive.

So it looks like clearing the search field is adding an extra entry to the navigation history and navigating forward to it, when it should be just navigating back. I think it would even be okay for it to behave purely like Back, leaving Forward sensitive to redo the search.

Changed in software-center (Ubuntu):
importance: Undecided → Low
Changed in software-center (Ubuntu):
status: New → In Progress
assignee: nobody → Matthew McGowan (mmcg069)
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (4.2 KiB)

This bug was fixed in the package software-center - 4.1.23.4

---------------
software-center (4.1.23.4) oneiric; urgency=low

  [ Matthew McGowan ]
  * utils/submit_review_gtk3.py:
    - fix crash when submitting a review (LP: #852016)
  * fix the overlay icon position in the (lobby|subcat) featured tiles
  * fix the backforward button such that the border-radius is switched
    when in rtl mode.
  * softwarecenter/ui/gtk3/views/appdetailsview_gtk.py:
    - fix stray dotted lines at bottom of the "not found"
      screen (LP: #853514)
  * softwarecenter/ui/gtk3/widgets/buttons.py:
    - add a focus ring for the "More" buttons on the
      home screen (LP: #854177)
  * softwarecenter/ui/gtk3/widgets/exhibits.py:
    - add a focus ring for the exhibits banner (LP: #854168)
  * check the button-release occurs within the exhibit banner
    (LP: #848805)
  * add additional checks to ensure we bail on a NoneType within
    apptreeview._on_button_press_event. also switch some StateType's
    to the Gtk3 correct StateFlags'
  * reimplement the focal frames for focal CellRendererButtons
    in the apptreeview
  * lp:~mmcg069/software-center/rtl-improvements
    - make the appview progress bar fill in the correct direction when in rtl
      mode
    - also improve the positioning of the installed overlay icon in both ltr
      and rtl modes.
  * lp:~mmcg069/software-center/nav-improvements
    - correct the navhistory behaviour when a user clears the search_entry,
      remove spurious navhistory items, improve unit test (LP: #854047)
  * lp:~mmcg069/software-center/lobby-work
    - update the lobby and subcat views when selecting to view "Canonical
      Maintained Software", other lobby fixes and cleanup (LP: #835025)
  * lp:~mmcg069/software-center/description-improvements:
    - improvements to the description area in the details view, make
      description text selectable, update unit test (LP: #854368)
  * lp:~mmcg069/software-center/Bug846204:
    - a solution to LP: #846204

  [ Kiwinote ]
  * softwarecenter/db/application.py:
    - fix UnicodeDecodeError in __init__ (LP: #838791)
  * softwarecenter/db/debfile.py:
    - fix UnicodeDecodeError in __init__ (LP: #835887)
  * softwarecenter/ui/gtk3/widgets/buttons.py:
    - draw focus-line for category tiles and subcategory tiles
    - make featuredtiles accessible
  * softwarecenter/ui/gtk3/widgets/description.py:
    - fix crash in rendering bullet points in rtl layouts
  * softwarecenter/ui/gtk3/widgets/exhibits.py:
    - make exhibits accessible

  [ Gary Lasker ]
  * utils/submit_review_gtk3.py:
    - fix crash if an error occurs while submitting
      a review (LP: #854187)
  * softwarecenter/ui/gtk3/widgets/apptreeview.py:
    - check that a category is not selected before updating,
      fixes a crash on e.g. a network change event (LP: #848085)
  * softwarecenter/ui/gtk3/panes/installedpane.py:
    - display a spinner while loading the oneconf
      list view
  * pyflakes fixes

  [ Michael Vogt ]
  * softwarecenter/ui/gtk3/views/purchaseview.py,
    test/gtk3/test_purchase.py:
    - ensure to never log sensitive oauth token data to the console
      from webkit and add test
  * debian/c...

Read more...

Changed in software-center (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.