flashplugin-installer upgrade failed during Oneiric upgrade

Bug #859373 reported by Stuart Bishop
174
This bug affects 26 people
Affects Status Importance Assigned to Milestone
network-manager (Ubuntu)
Fix Released
High
Unassigned
Oneiric
Fix Released
High
Mathieu Trudel-Lapierre
Precise
Fix Released
High
Unassigned
update-manager (Ubuntu)
Invalid
Undecided
Unassigned
Oneiric
Invalid
Undecided
Unassigned
Precise
Invalid
Undecided
Unassigned

Bug Description

[Impact]
This would affect any user connected to only wifi or 3G (or a VPN) while upgrading. Users connected to wired (which is a considered as a system-wide connection) are unaffected. A release-note text was provided to help mitigate the issue.

[Development Fix]
Tested locally in a PPA (http://ppa.launchpad.net/mathieu-tl/nm/ubuntu) which depends on manually changing the sources.list to point to oneiric, add that PPA (remove any others listed for natty) and running 'apt-get dist-upgrade'. Version is network-manager 0.9.1.90-0ubuntu4~mtrudel~nm1; to be 0.9.1.90-0ubuntu4.

[Stable Fix]
See http://bazaar.launchpad.net/~mathieu-tl/network-manager/lp859373/view/head:/debian/patches/lp859373_upgrade_policy_fix.patch?start_revid=375.

[Test Case]
On a machine connected to _ONLY WIFI_, run 'apt-get dist-upgrade' from a newly-installed Natty system after changing the sources to point to Oneiric. (will require making sure oneiric-proposed is enabled)

[Regression Potential]
Very low. The missing policy is only in use on the Natty system with the natty version of NetworkManager running while the upgrade is being done; after the upgrade complete and NetworkManager (or the system) is restarted, that policy is no longer referred to.

---

Upgrade failed as the flashplugin-installer package failed to upgrade. I suspect this was because the network was unavailable at this point in the process.

ProblemType: Bug
DistroRelease: Ubuntu 11.10
Package: update-manager 1:0.152.19
ProcVersionSignature: Ubuntu 3.0.0-11.18-generic 3.0.4
Uname: Linux 3.0.0-11-generic x86_64
ApportVersion: 1.23-0ubuntu1
Architecture: amd64
Date: Mon Sep 26 11:47:22 2011
EcryptfsInUse: Yes
InstallationMedia: Ubuntu 10.04 LTS "Lucid Lynx" - Release amd64 (20100429)
PackageArchitecture: all
ProcEnviron:
 LANGUAGE=en_AU:en_GB:en
 PATH=(custom, user)
 LANG=en_AU.utf8
 SHELL=/bin/bash
SourcePackage: update-manager
UpgradeStatus: Upgraded to oneiric on 2011-09-25 (0 days ago)

Revision history for this message
Stuart Bishop (stub) wrote :
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

Thanks for your report.

From term log, your system failed to resolve archive.canonical.com

Setting up flashplugin-downloader:i386 (10.3.183.10ubuntu2) ...
Downloading...
--2011-09-26 10:44:03-- http://archive.canonical.com/pool/partner/a/adobe-flashplugin/adobe-flashplugin_10.3.183.10.orig.tar.gz
Resolving archive.canonical.com... failed: Name or service not known.
wget: unable to resolve host address 'archive.canonical.com'
download failed
The Flash plugin is NOT installed.
Setting up flashplugin-installer (10.3.183.10ubuntu2) ...
nspluginwrapper: /usr/lib/flashplugin-installer/libflashplayer.so is not a valid NPAPI plugin
dpkg: error processing flashplugin-installer (--configure):
 subprocess installed post-installation script returned error exit status 1

Changed in update-manager (Ubuntu):
status: New → Confirmed
Revision history for this message
Roman Yepishev (rye) wrote :

This happens because the installer attempts to download the file after downloading all the other packages. At that time it is possible that the wireless network connection will fail (network manager being updated/ natty network applet being still running etc.). This makes the upgrade look like it is failed.

Revision history for this message
Michael Vogt (mvo) wrote :

NetworkManager should keep the current connections up, even when being upgraded, I add a bugtask for it.

Revision history for this message
Michael Vogt (mvo) wrote :

What is confusing about this is that all network-manager releated packages are up configured AFAICT from the log when the failure is happening.

Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

Stuart, does it work if you run the command below from the command line:
wget http://archive.canonical.com/pool/partner/a/adobe-flashplugin/adobe-flashplugin_11.0.1.152.orig.tar.gz

If not does it work if you run
wget -4 http://archive.canonical.com/pool/partner/a/adobe-flashplugin/adobe-flashplugin_11.0.1.152.orig.tar.gz

Are you on an IPv6 network ?

Changed in update-manager (Ubuntu):
status: Confirmed → Incomplete
Revision history for this message
Michael Vogt (mvo) wrote :

From irc:
<rye> mvo ooh. NetworkManager[417]: <warn> error requesting auth for org.freedesktop.NetworkManager.use-user-connections: (0) GDBus.Error:org.freedesktop.PolicyKit1.Error.Failed: Action org.freedesktop.NetworkManager.use-user-connections is not registered
 ryanakca rye
<rye> mvo, once nm gets this it shuts down the network connection :-/
<rye> mvo, happens during install libnm-gtk-common

Revision history for this message
Roman Yepishev (rye) wrote :

Here are the log files during the upgrade - the network connection seem to have dropped around 15:18:13. The presence of eth0 entries is me connecting the wired network to be able to pastebin the logs.

.xsession-errors: http://pasteubuntu.com/707306/
syslog: http://paste.ubuntu.com/707307/
dpkg.log: http://paste.ubuntu.com/707309/

syslog:
Oct 13 15:18:13 buka NetworkManager[417]: <warn> error requesting auth for org.freedesktop.NetworkManager.use-user-connections: (0) GDBus.Error:org.freedesktop.PolicyKit1.Error.Failed: Action org.freedesktop.NetworkManager.use-user-connections is not registered

dpkg.log:
2011-10-13 15:18:10 status triggers-pending gconf2 2.32.2-0ubuntu2
2011-10-13 15:18:10 status half-installed network-manager-gnome 0.8.4~git.20110318t152954.9c4c9a0-0ubuntu1
2011-10-13 15:18:10 status half-installed network-manager-gnome 0.8.4~git.20110318t152954.9c4c9a0-0ubuntu1
2011-10-13 15:18:10 status unpacked network-manager-gnome 0.9.1.90-0ubuntu6
2011-10-13 15:18:10 status unpacked network-manager-gnome 0.9.1.90-0ubuntu6
2011-10-13 15:18:11 upgrade network-manager 0.8.4~git.20110319t175609.d14809b-0ubuntu3 0.9.1.90-0ubuntu3
2011-10-13 15:18:11 status half-configured network-manager 0.8.4~git.20110319t175609.d14809b-0ubuntu3
2011-10-13 15:18:11 status unpacked network-manager 0.8.4~git.20110319t175609.d14809b-0ubuntu3
2011-10-13 15:18:11 status half-installed network-manager 0.8.4~git.20110319t175609.d14809b-0ubuntu3
2011-10-13 15:18:11 status triggers-pending ureadahead 0.100.0-11
2011-10-13 15:18:11 status half-installed network-manager 0.8.4~git.20110319t175609.d14809b-0ubuntu3
2011-10-13 15:18:12 status triggers-pending ureadahead 0.100.0-11
2011-10-13 15:18:12 status half-installed network-manager 0.8.4~git.20110319t175609.d14809b-0ubuntu3
2011-10-13 15:18:12 status half-installed network-manager 0.8.4~git.20110319t175609.d14809b-0ubuntu3
2011-10-13 15:18:13 status unpacked network-manager 0.9.1.90-0ubuntu3
2011-10-13 15:18:13 status unpacked network-manager 0.9.1.90-0ubuntu3
2011-10-13 15:18:13 install libnm-gtk-common <none> 0.9.1.90-0ubuntu6
2011-10-13 15:18:13 status half-installed libnm-gtk-common 0.9.1.90-0ubuntu6
2011-10-13 15:18:14 status unpacked libnm-gtk-common 0.9.1.90-0ubuntu6
2011-10-13 15:18:14 status unpacked libnm-gtk-common 0.9.1.90-0ubuntu6
2011-10-13 15:18:14 install libnm-gtk0 <none> 0.9.1.90-0ubuntu6

Revision history for this message
Stuart Bishop (stub) wrote :

@jibel - yes, wget for that file works just fine. I'm not on IPv6.

Changed in update-manager (Ubuntu):
status: Incomplete → New
Changed in network-manager (Ubuntu):
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Mathieu Trudel-Lapierre (mathieu-tl)
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

The issue is pretty clearly in NetworkManager: the use-user-connections policy gets dropped (it's no longer needed upstream) when the files are unpacked; but the currently running instance of NM is still expecting it to be there. Otherwise, it's as if it's not permitted, hence why the wifi and any other user-specific connections are dropped.

I can ship the policy in an SRU; there's basically no adverse effect since it's not being referred to anywhere in NM code; it will just be useless once the system is restarted after the upgrade, but at least the upgrade won't give out errors for flash (and ttf fonts?)

Changed in update-manager (Ubuntu):
status: New → Invalid
description: updated
Changed in network-manager (Ubuntu Oneiric):
status: New → In Progress
Changed in update-manager (Ubuntu Oneiric):
status: New → Invalid
Changed in network-manager (Ubuntu Oneiric):
importance: Undecided → Medium
assignee: nobody → Mathieu Trudel-Lapierre (mathieu-tl)
Changed in network-manager (Ubuntu):
assignee: Mathieu Trudel-Lapierre (mathieu-tl) → nobody
description: updated
Revision history for this message
Casper Aleva (tonus) wrote :

This will be hosing a lot of upgraders systems. Anyone with wifi?
The fix in bug #861584 (the exit 1, in itself a good idea) is probably what's causing the actual upgrade to fail here.
Whether or not the bug is in network manager, after downloading the packages, the upgrade process should no longer be depending on an internet connection, if you ask me. More importantly, the upgrade should not exit fatally if it does depend but doesn't have one for some reason.

Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Hello Stuart, or anyone else affected,

Accepted network-manager into oneiric-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in network-manager (Ubuntu Oneiric):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Marius Gedminas (mgedmin) wrote :

Other than avoiding flashplugin errors on upgrade, it would be nice not to kick the user offline as soon as the upgrade process begins. The upgrade takes an hour, I'd have appreciated being able to browse the web using wifi during it.

Revision history for this message
David Grant (davidgrant) wrote :

What's the process to recover after this failed installation?

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

It's fixed with the package in proposed; from there you wouldn't get thrown offline due to the new policy preventing the use of wireless (or using a wired connection is also a good workaround).

To recover after a "failed" upgrade; you should be able to reboot the system safely and issue the following commands once booted:

sudo dpkg --configure -a
sudo apt-get -f install

The issue with flash appears to happens late enough during the upgrade process that the upgrade is already mostly done.

The complications in testing this lie in the fact that you can't just proceed with the upgrade normally to test this package; one will need to change the sources.list file to point to oneiric manually, then use 'sudo apt-get dist-upgrade' to upgrade.

Steve Langasek (vorlon)
Changed in network-manager (Ubuntu Oneiric):
importance: Medium → High
Changed in network-manager (Ubuntu):
importance: Medium → High
description: updated
tags: added: testcase
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

SRU verification for Oneiric:
I have reproduced the problem with network-manager 0.9.1.90-0ubuntu3 in oneiric and have verified that the version of network-manager 0.9.1.90-0ubuntu4 in -proposed fixes the issue.

Marking as verification-done

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package network-manager - 0.9.1.90-0ubuntu4

---------------
network-manager (0.9.1.90-0ubuntu4) oneiric-proposed; urgency=low

  * debian/patches/lp859373_upgrade_policy_fix.patch: keep providing the
    use-user-connections PolicyKit policy to help with upgrades from previous
    releases. (LP: #859373)
 -- Mathieu Trudel-Lapierre <email address hidden> Thu, 13 Oct 2011 17:59:26 -0400

Changed in network-manager (Ubuntu):
status: In Progress → Fix Released
Changed in network-manager (Ubuntu Oneiric):
status: Fix Committed → Fix Released
Changed in network-manager (Ubuntu Oneiric):
milestone: none → oneiric-updates
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.