OVS plugin exception when retrieving vif ports

(From email thread)

On Mon, Sep 26, 2011 at 10:04 AM, Dan Wendlandt <email address hidden> wrote:
On Mon, Sep 26, 2011 at 9:47 AM, Salvatore Orlando <email address hidden> wrote:
> I’m letting quantum manager plug vifs, and I think I might have spotted the issue.

> Xapi_get_port retrieves xs-vm-uuid from the OVS DB ‘interface’ record, external-ids column, then retrieves the name-label
> for that particular vm, and sets the external id ‘iface-id’ in OVS DB to the name-label for the VM.

yeah, this is the out-of-date behavior that I incorrectly thought we had removed a while back.

> I think iface-id should contain the Quantum interface identifier (at least this is what I gather from daemon_loop). To this aim
> iface-Id should be set to the value of Nicira-iface-id which is stored in other-config for the VIF record in xenserver. Therefore
> xapi_get_port should use xs-vif-uuid in external_ids and retrieve other-config:Nicira-iface-id from the corresponding VIF record.
> Would that work in your opinion?

Actually, OVS takes care of syncing the other_config:nicira-iface-id with the 'iface-id' attribute in the OVSDB, so as I mentioned in my previous mail, I believe the correct behavior is just to get rid of the xenserver-specific branch of the if statement, letting the KVM and XenServer code-path be identical. This is what I thought I did a long while back, but apparently didn't :)

Instead it should just be:

    def get_vif_ports(self):
        edge_ports = []
        port_names = self.get_port_name_list()
        for name in port_names:
            external_ids = self.db_get_map("Interface", name, "external_ids")
            if "iface-id" in external_ids and "attached-mac" in external_ids:
                ofport = self.db_get_val("Interface", name, "ofport")
                p = VifPort(name, ofport, external_ids["iface-id"],
                            external_ids["attached-mac"], self)
                edge_ports.append(p)
        return edge_ports

Since this is the only place that calls xapi_get_ports, that entire function can be removed as well.

Dan

Reviewed: https://review.openstack.org/664
Committed: http://github.com/openstack/quantum/commit/73feb9bf0144df15df4320746d280b36b3de1aaa
Submitter: Jenkins
Branch: master

 status fixcommitted
 done

commit 73feb9bf0144df15df4320746d280b36b3de1aaa
Author: Brad Hall <email address hidden>
Date: Fri Sep 23 21:44:05 2011 -0700

    Remove hack for figuring out the vif interface identifier (lp859864)

    Change-Id: I5a62d5663df28294f86c3935e18acb1d6163f37e