Maildisabled preference not respected in activity notifications

Bug #860090 reported by Richard Mansfield
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Richard Mansfield

Bug Description

Commit a8102e9129 tried to fetch all users' maildisabled preferences in the activity_get_users function, but failed because it used the wrong table alias, so maildisabled is not being respected by the email_user function whenever email_user is called by an activity notification (which is most of the time).

Changed in mahara:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Richard Mansfield (richard-mansfield)
milestone: none → 1.4.1
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/743
Committed: http://gitorious.org/mahara/mahara/commit/91d8620545bb33ced4fd094e913eccf57fdf886a
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit 91d8620545bb33ced4fd094e913eccf57fdf886a
Author: Richard Mansfield <email address hidden>
Date: Tue Sep 27 11:03:22 2011 +1300

    Fix maildisbled preference in activity_get_users (bug #860090)

    Commit a8102e9129 tried to fetch all users' maildisabled preferences
    in the activity_get_users function, but failed because it used the
    wrong table alias, so maildisabled is not being respected by the
    email_user function whenever email_user is called by an activity
    notification (most of the time).

    Change-Id: I2a9cf1afa3f8661ff8a52f1ce5aed5d15adaa9da
    Signed-off-by: Richard Mansfield <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/742
Committed: http://gitorious.org/mahara/mahara/commit/b439d3bc9cc4c481c360a5657fd954b25e4a7cbc
Submitter: Francois Marier (<email address hidden>)
Branch: 1.4_STABLE

commit b439d3bc9cc4c481c360a5657fd954b25e4a7cbc
Author: Richard Mansfield <email address hidden>
Date: Tue Sep 27 11:03:22 2011 +1300

    Fix maildisbled preference in activity_get_users (bug #860090)

    Commit a8102e9129 tried to fetch all users' maildisabled preferences
    in the activity_get_users function, but failed because it used the
    wrong table alias, so maildisabled is not being respected by the
    email_user function whenever email_user is called by an activity
    notification (most of the time).

    Change-Id: I2a9cf1afa3f8661ff8a52f1ce5aed5d15adaa9da
    Signed-off-by: Richard Mansfield <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.