Checkbox

mediacard after_suspend test depend on power-management/suspend_advanced instead of suspend/suspend_advanced

Bug #860651 reported by Brendan Donegan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Checkbox
Fix Released
Medium
Jeff Lane 
Checkbox 0.12.8 "oneiric_fixes_3"

Bug Description

The dependencies for the mediacard tests are wrong. They depend on power-management/suspend_advanced which was the old name for suspend/suspend_advanced. They dependencies need to be changed so that they work properly and the after_suspend tests actually run after suspending the system.

Related branches

lp:~bladernr/checkbox/860651_redo
Daniel Manrique (community): Approve
Diff: 57 lines (+6/-6)
1 file modified
jobs/mediacard.txt.in (+6/-6)
lp:~roadmr/ubuntu/oneiric/checkbox/0.12.8
Mathieu Trudel-Lapierre: Approve
Ubuntu branches: Pending requested
Diff: 12410 lines (+2530/-1911)
31 files modified
checkbox/job.py (+1/-1)
checkbox/lib/transport.py (+14/-4)
checkbox_gtk/gtk_interface.py (+5/-2)
data/whitelists/default.whitelist (+3/-14)
debian/changelog (+56/-0)
debian/po/de.po (+28/-16)
debian/po/it.po (+10/-9)
debian/po/pt_BR.po (+9/-7)
gtk/checkbox-gtk.desktop.in (+1/-1)
jobs/mediacard.txt.in (+6/-6)
jobs/miscellanea.txt.in (+2/-2)
jobs/suspend.txt.in (+3/-3)
plugins/apport_prompt.py (+2/-0)
plugins/intro_prompt.py (+14/-7)
plugins/launchpad_exchange.py (+6/-2)
plugins/suites_prompt.py (+4/-0)
po/de.po (+457/-301)
po/gl.po (+274/-301)
po/hu.po (+16/-16)
po/it.po (+36/-37)
po/pt_BR.po (+431/-339)
po/ru.po (+491/-321)
po/sl.po (+461/-227)
po/zh_HK.po (+126/-213)
scripts/connect_wireless (+4/-3)
scripts/cpu_scaling_test (+50/-9)
scripts/internet_test (+2/-2)
scripts/network_check (+3/-5)
scripts/reconnect (+0/-5)
scripts/resolution_test (+14/-57)
scripts/usb_test (+1/-1)
lp:ubuntu/oneiric/checkbox
Brendan Donegan (brendan-donegan)
Changed in checkbox:
milestone: none → 0.12.8
assignee: nobody → Brendan Donegan (brendan-donegan)
status: New → In Progress
importance: Undecided → Medium
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

I corrected the dependencies but they still run one after the other. I need to investigate why this is and it might make fixing this a lot more tricky.

Brendan Donegan (brendan-donegan)
Changed in checkbox:
assignee: Brendan Donegan (brendan-donegan) → nobody
status: In Progress → Triaged
Revision history for this message
Jeff Lane  (bladernr) wrote :

It appears that the dependencies only apply to suites...

Currently, mediacard.txt contains both mediacard/sd and mediacard/sd_after_suspend

These both run when checkbox runs the "mediacard" suite rather than picking and choosing.

So you can not hop from one suite to the next like this:

suspend/pre-test-1
suspend/pre-test-2
suspend/suspend_advanced
suspend/post-test1
mediacard/post-test2
suspend/post-test-3
someothersuite/post-test4

if I create a sd_after_suspend test in the suspend suite, however, then the new suspend/sd_after_suspend test IS held until after suspend/suspend_advanced is run, while mediacard/sd and mediacard/sd_after_suspend are both run BEFORE, but run at the same time (while mediacard is run).

I'm thinking that this is a limitation of checkbox's design and I'm thinking that this is not going to be fixed in time for oneiric.

Jeff Lane  (bladernr)
Changed in checkbox:
assignee: nobody → Jeff Lane (bladernr)
status: Triaged → Fix Committed
Revision history for this message
Jeff Lane  (bladernr) wrote :

Merge request is ONLY for renaming the dependencies to clean that up. bug #861218 directly affects this and could resolve the rest of the issues without making it necessary to move the jobs to the suspend.txt file...

though as the ONLY post-suspend jobs that are not part of suspend.txt are the media card ones, I'd be happier moving them anyway...

Revision history for this message
Jeff Lane  (bladernr) wrote :

bug #861218 is now resolved. Tested this patch with Marc's patch from that bug and this is resolved as well.

Ara Pulido (ara)
Changed in checkbox:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.