Missing accept form for some users on pending friends list

Bug #861888 reported by Richard Mansfield
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Richard Mansfield

Bug Description

The query to get user data on the my friends and find friends pages has an unnecessary union, with one select to get pending friends, and another to get everyone else.

The result of this is that pending friends are sometimes not shown as pending if their record was returned by both parts of the query, and so the logged-in user sometimes can't accept requests on these pages.

Changed in mahara:
status: New → In Progress
importance: Undecided → Low
assignee: nobody → Richard Mansfield (richard-mansfield)
milestone: none → 1.5.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/749
Committed: http://gitorious.org/mahara/mahara/commit/43d739ebaea07278d5d3bc22ceb9bfa50130e411
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit 43d739ebaea07278d5d3bc22ceb9bfa50130e411
Author: Richard Mansfield <email address hidden>
Date: Thu Sep 29 11:25:31 2011 +1300

    Simplify query to get user data for find/my friends (bug #861888)

    The query to get user data on the my friends and find friends pages
    has an unnecessary union, with one select to get pending friends, and
    another to get everyone else.

    The result of this is that pending friends are sometimes not shown as
    pending if their record was returned by both parts of the query, and
    so the logged-in user sometimes can't accept requests on these pages.

    Change-Id: I31347d680988f94d9329abb5c2338c0c8c285b00
    Signed-off-by: Richard Mansfield <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Melissa Draper (melissa) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPjqY0AAoJECXBtiziiXdcrpMIAKO5qOyhN9AQn9fCr32yAEba
wyQwhMOm1wS5eB4Qa29Hbr3c0xgXcwgsIFHfe0SCL92Gt2W3UjB8klrrRYssj5iu
o7DlmKBJhXo7i/AC005KeMTQZfY7ZX/tI8Lqux3FjfhSpRhCPatLLPr/hZHTbB4X
XXI47L8e304a6AwmDgsa9UUejDIjOwmOF7fFTeul8OgS4zSg3GUDQ1tTMW3+7Sns
YNmS3iU2+e0Z1CQlg5BqKwHVzCByuPPXuotvUkBkcLP53k1gUOn3OnMODTfbbrvf
UOVYo510SEKrkMCi0B4rLQHg8Ck2cUc1wS4GhxCOMrAcYDokjgTM98AerGB2sGE=
=uHSn
-----END PGP SIGNATURE-----

Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.