The _path_is_dir function in file system notifications on windows is broken
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu One Client |
Fix Released
|
High
|
Manuel de la Peña |
Bug Description
The function _path_is_dir does not work as expected, the following implementation is wrong:
@is_
def _path_is_dir(self, path):
"""Check if the path is a dir and update the local subdir list."""
is_dir = False
if os.path.
is_dir = os.path.isdir(path)
else:
# we removed the path, we look in the internal list
if path in self._subdirs:
if is_dir:
return is_dir
This can brake terribly.
Related branches
- Natalia Bidart (community): Approve
- Roberto Alsina (community): Approve
-
Diff: 400 lines (+149/-38)3 files modifiedrun-tests.bat (+1/-0)
tests/platform/windows/test_filesystem_notifications.py (+115/-22)
ubuntuone/platform/windows/filesystem_notifications.py (+33/-16)
Changed in ubuntuone-client: | |
status: | New → Fix Committed |
Changed in ubuntuone-client: | |
status: | Fix Committed → Fix Released |