UVF exception: geany 0.10 -> 0.10.2

Bug #87563 reported by Lionel Le Folgoc
4
Affects Status Importance Assigned to Milestone
geany (Ubuntu)
Fix Released
Undecided
Lionel Le Folgoc

Bug Description

Binary package hint: geany

This new upstream release is a bugfix release (about 30 bugs fixed, see attached NEWS diff). Most changes affects internationalisation and documentation (see attached upstream diff).

It builds/installs/upgrades/removes/purges fine in a feisty pbuilder (at least for i386, build log attached), and runs fine on feisty.

The source package is on REVU: http://revu.tauware.de/details.py?upid=4483

Revision history for this message
Lionel Le Folgoc (mrpouit) wrote :
Revision history for this message
Lionel Le Folgoc (mrpouit) wrote :
Revision history for this message
Lionel Le Folgoc (mrpouit) wrote :
Changed in geany:
assignee: nobody → motu-uvf
Revision history for this message
Lionel Le Folgoc (mrpouit) wrote :

New upstream version 0.10.2 (bugfix again). There is only one source file changed (and documentation and i18n of course) :

Geany 0.10.2 (February 25, 2007)

    Bugs fixed:
    * Fixed serious crash of complete X session when using the Stop
      command when Geany is run from the program menu (closes #1668017).

--- geany-0.10.1/src/build.c 2007-02-12 18:21:57.000000000 +0100
+++ geany-0.10.2/src/build.c 2007-02-25 19:38:43.000000000 +0100
@@ -1466,13 +1466,13 @@
         * perforce necessary for just killing a process). But we must use a signal which we can
         * ignore because the main process get it too, it is declared to ignore in main.c. */

- gint resultpg, result;
+ gint result;
+
+ g_return_if_fail(*pid > 1);

- // sent SIGQUIT to all the processes to the processes' own process group
        result = kill(*pid, SIGQUIT);
- resultpg = killpg(0, SIGQUIT);

- if (result != 0 || resultpg != 0)
+ if (result != 0)
                msgwin_status_add(_("Process could not be stopped (%s)."), g_strerror(errno));
        else
        {

I've updated the package (it still builds/installs/upgrades/removes/purges fine): http://revu.tauware.de/details.py?upid=4500

Full diff here: http://revu.tauware.de/diff.py?upid1=4483&upid2=4500

Revision history for this message
Andrew Mitchell (ajmitch) wrote :

OK by me

Revision history for this message
Daniel Holbach (dholbach) wrote :

Looks good to me too.

Changed in geany:
assignee: motu-uvf → mrpouit
status: Unconfirmed → Confirmed
Revision history for this message
Lionel Le Folgoc (mrpouit) wrote :

Uploaded to feisty.

Changed in geany:
status: Confirmed → Fix Committed
Changed in geany:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.