Origen: device tree not enabled at Ubuntu

whats the progress on this one from landing team side? When can we expect a first DT enabled hwpack?

Origen device-tree support was pushed to samsung-soc on Nov 1. We hope
to incorporate it into our 3.1 kernel and we are targeting 11.11 for
3.1

On Wed, Nov 9, 2011 at 6:07 PM, Alexander Sack <email address hidden> wrote:
> whats the progress on this one from landing team side? When can we
> expect a first DT enabled hwpack?
>
> --
> You received this bug notification because you are a member of Linaro
> Landing Team: Samsung, which is subscribed to the bug report.
> https://bugs.launchpad.net/bugs/880451
>
> Title:
>  Origen: device tree not enabled at Ubuntu
>
> Status in Linaro Samsung Landing Team Project:
>  New
> Status in Linaro Ubuntu Evaluation Builds:
>  Confirmed
>
> Bug description:
>  Hwpack: hwpack_linaro-lt-origen_20111022-0_armel_supported.tar.gz
>  Image: linaro-o-ubuntu-desktop-tar-20111023-0.tar.gz
>
>  Not loaded during boot, so not enabled at the kernel/hwpack.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/linaro-landing-team-samsung/+bug/880451/+subscriptions
>

--
Angus Ainslie <email address hidden>
Team Lead, Samsung Landing Team

3.1 is not going to land in Nov release

Still an issue with the 11.11 RC, as it's still using the 3.0 series kernel.

Hwpack: hwpack_linaro-lt-origen_20111122-2_armel_supported.tar.gz

Angus, this is fix committed on your side but I still can't see any dtb file at your kernel packages (checked both 3.1 and 3.2).

Maybe it's just missing a few patches at the packaging side.

During the kernel build process the device tree files are not being properly generated:

imake[1]: Entering directory `/home/rsalveti/projects/linaro/kernel/linux-linaro'
  GEN /home/rsalveti/projects/linaro/kernel/linux-linaro/debian/build/build-origen/Makefile
  CHK include/linux/version.h
  CHK include/generated/utsrelease.h
make[3]: Nothing to be done for `arch/arm/boot/dtbs'.
  Using /home/rsalveti/projects/linaro/kernel/linux-linaro as source for kernel
make[3]: `include/generated/mach-types.h' is up to date.

Are you sure this is properly enabled at Origen?

Opening the bug again as it's still not part of the kernel package:

./boot/dt-3.2.0-1000-origen/
./boot/dt-3.2.0-1000-origen/README

We should have the dt file for origen here.

Still need to validate DT support. Will target next month.

With 3.2 kernel, there is a system hang while booting with DT. Will attack this bug once that has been fixed.

"make dtbs" (the official way to generate the device tree file) is still not building the device tree for origen.

https://wiki.linaro.org/Boards/Origen/DeviceTree says it should be generated by calling "make exynos4210-origen.dtb", but this is not what is defined at the kernel source:
make ARCH=arm help
....
Architecture specific targets (arm):
* zImage - Compressed kernel image (arch/arm/boot/zImage)
  Image - Uncompressed kernel image (arch/arm/boot/Image)
* xipImage - XIP kernel image, if configured (arch/arm/boot/xipImage)
  uImage - U-Boot wrapped zImage
  bootpImage - Combined zImage and initial RAM disk
                  (supply initrd image via make variable INITRD=<path>)
  dtbs - Build device tree blobs for enabled boards
  install - Install uncompressed kernel
  zinstall - Install compressed kernel
  uinstall - Install U-Boot wrapped compressed kernel
                  Install using (your) ~/bin/installkernel or
                  (distribution) /sbin/installkernel or
                  install to $(INSTALL_PATH) and run lilo

Usman, can we get this bug targeted properly for the LT? It's still targeted for 12.02.

Also, this is becoming quite critical already, once we get more and more support for device tree at Origen.

Device tree enablement scheduled for 12.05 cycle.

Changes required in linaro-leb-origen hwpack:
dtb_addr=0x41f00000
dtb_file=boot/dt-*-origen/exynos4210-origen.dtb

Changes required in linaro-image-tools:
=== modified file 'linaro_image_tools/media_create/boards.py'
--- linaro_image_tools/media_create/boards.py 2011-12-14 13:01:43 +0000
+++ linaro_image_tools/media_create/boards.py 2012-04-12 11:40:47 +0000
@@ -1424,9 +1424,11 @@

 class OrigenConfig(SamsungConfig):
    uboot_flavor = 'origen'
+ dtb_name = 'exynos4210-origen.dtb'
    serial_tty = 'ttySAC2'
    _extra_serial_opts = 'console=%s,115200n8'
    kernel_addr = '0x40007000'
+ dtb_addr = '0x41f00000'
    initrd_addr = '0x42000000'
    load_addr = '0x40008000'
    kernel_flavors = ['origen']

Observed on build:

http://snapshots.linaro.org/precise/hwpacks/leb-origen/45/hwpack_linaro-leb-origen_20120426-45_armhf_supported.tar.gz

with the ubuntu image:

http://snapshots.linaro.org/precise/images/ubuntu-desktop/119/linaro-precise-ubuntu-desktop-20120426-119.tar.gz

Although there are "dtb" files under the "/boot" partition:

root@linaro-ubuntu-desktop:/boot# ls -l /boot/dt*
total 28
-rw-r--r-- 1 root root 12643 Apr 26 2012 exynos4210-origen.dtb
-rw-r--r-- 1 root root 10162 Apr 26 2012 exynos4210-smdkv310.dtb
root@linaro-ubuntu-desktop:/boot#

The u-boot didn't load Device Tree while board booting:

Welcome to minicom 2.4

OPTIONS: I18n
Compiled on Jun 3 2010, 13:48:00.
Port /dev/ttyUSB0

Press CTRL-A Z for help on special keys

U-Boot 2012.04.01 (Apr 25 2012 - 15:25:13) for ORIGEN

CPU: S5PC210@1000MHz

Board: ORIGEN
DRAM: 1 GiB
WARNING: Caches not enabled
MMC: SAMSUNG SD/MMC: 0
In: serial
Out: serial
Err: serial
Hit any key to stop autoboot: 0
reading uImage

4377032 bytes read
reading uInitrd

2132445 bytes read
## Booting kernel from Legacy Image at 40007000 ...
   Image Name: Linux
   Image Type: ARM Linux Kernel Image (uncompressed)
   Data Size: 4376968 Bytes = 4.2 MiB
   Load Address: 40008000
   Entry Point: 40008000
   Verifying Checksum ... OK
## Loading init Ramdisk from Legacy Image at 42000000 ...
   Image Name: initramfs
   Image Type: ARM Linux RAMDisk Image (uncompressed)
   Data Size: 2132381 Bytes = 2 MiB
   Load Address: 00000000
   Entry Point: 00000000
   Verifying Checksum ... OK
   Loading Kernel Image ... OK
OK

Starting kernel ... ...

HDMI is not working with DT. DT support will be enabled once HDMI starts working. Targeting 2012.06 release.

Observed on hardware pack:

http://snapshots.linaro.org/precise/hwpacks/leb-origen/109/hwpack_linaro-leb-origen_20120524-109_armhf_supported.tar.gz

with ubuntu image:

http://snapshots.linaro.org/precise/images/ubuntu-desktop/179/linaro-precise-ubuntu-desktop-20120525-179.tar.gz

Even when we manually enable DT support at the hwpack, to make u-boot to load the correct DT file, it doesn't even boot the board.

This is what I have at my boot.scr file:
"""
setenv bootcmd "fatload mmc 0:2 0x40007000 uImage; fatload mmc 0:2 0x42000000 uInitrd; fatload mmc 0:2 0x41f00000 board.dtb; bootm 0x40007000 0x42000000 0x41f00000"
setenv bootargs "console=tty0 console=ttySAC2,115200n8 root=UUID=8bdf5cf7-09b2-466d-849f-c3f368fb0d8b rootwait ro"
boot
"""

And the result:
U-Boot 2012.04.01 (May 18 2012 - 00:11:41) for ORIGEN

CPU: S5PC210@1000MHz

Board: ORIGEN
DRAM: 1 GiB
WARNING: Caches not enabled
MMC: SAMSUNG SD/MMC: 0
In: serial
Out: serial
Err: serial
Hit any key to stop autoboot: 0
reading uImage

4389720 bytes read
reading uInitrd

1849785 bytes read
reading board.dtb

12643 bytes read
## Booting kernel from Legacy Image at 40007000 ...
   Image Name: Linux
   Image Type: ARM Linux Kernel Image (uncompressed)
   Data Size: 4389656 Bytes = 4.2 MiB
   Load Address: 40008000
   Entry Point: 40008000
   Verifying Checksum ... OK
## Loading init Ramdisk from Legacy Image at 42000000 ...
   Image Name: initramfs
   Image Type: ARM Linux RAMDisk Image (uncompressed)
   Data Size: 1849721 Bytes = 1.8 MiB
   Load Address: 00000000
   Entry Point: 00000000
   Verifying Checksum ... OK
## Flattened Device Tree blob at 41f00000
   Booting using the fdt blob at 0x41f00000
   Loading Kernel Image ... OK
OK
   Loading Ramdisk to 4fe3c000, end 4ffff979 ... OK
   Loading Device Tree to 4fe35000, end 4fe3b162 ... OK

Starting kernel ...

Uncompressing Linux... done, booting the kernel.
----> STOP

This is using the latest 3.4 kernel available at the LT tree, hash: e2c8996352c54db5a1f7f7316672c659948a2745 (today's hwpack).

With 3.5-rc2 kernel, manual DT booting should work. We can boot till home screen. Once verified, we should close this bug and open new ones to track individual DT-components like audio, HDMI, USB, touch etc.

Great, we should have the package available later today/tomorrow. Once integrated will test and then report back the results at this bug.

While the new 3.5 kernel works fine with device tree, we can't yet switch to the 3.5 kernel as not many peripherals are support (USB doesn't work, for example).

Moving this to 12.07 as hopefully the kernel will be working better by then.

Adding DT support to peripherals might take some time. Hence moving the milestone to 12.07.

Observed on hardware pack:

http://snapshots.linaro.org/precise/hwpacks/leb-origen/175/hwpack_linaro-leb-origen_20120626-175_armhf_supported.tar.gz

with ubuntu rootfs image:

http://snapshots.linaro.org/precise/images/ubuntu-desktop/247/linaro-precise-ubuntu-desktop-20120626-247.tar.gz

As suggested by Tushar, closing this bug as basic DT has been enabled in Ubuntu and booting till home screen has been possible (confirmed by Ricardo).
New bug to be filed for specific peripheral support.

@Sachin, I still can't find the relevant string in serial console output to prove the device tree support exist:
################################################
U-Boot 2012.04.01 (May 18 2012 - 00:11:41) for ORIGEN

CPU: S5PC210@1000MHz

Board: ORIGEN
DRAM: 1 GiB
WARNING: Caches not enabled
MMC: SAMSUNG SD/MMC: 0
In: serial
Out: serial
Err: serial
Hit any key to stop autoboot: 0
reading uImage

4389720 bytes read
reading uInitrd

2132833 bytes read
## Booting kernel from Legacy Image at 40007000 ...
   Image Name: Linux
   Image Type: ARM Linux Kernel Image (uncompressed)
   Data Size: 4389656 Bytes = 4.2 MiB
   Load Address: 40008000
   Entry Point: 40008000
   Verifying Checksum ... OK
## Loading init Ramdisk from Legacy Image at 42000000 ...
   Image Name: initramfs
   Image Type: ARM Linux RAMDisk Image (uncompressed)
   Data Size: 2132769 Bytes = 2 MiB
   Load Address: 00000000
   Entry Point: 00000000
   Verifying Checksum ... OK
   Loading Kernel Image ... OK
OK

Starting kernel ...

Uncompressing Linux... done, booting the ...

@Botao,
You need to build the dtb file and supply it with the kernel Image.
Ricardo has already tested the same (#19)

@Sachin, OK, then let's wait until 12.07 or further.

USB is still not working when we enable device tree support with the latest 3.5 kernel used by the 12.07 release. Moving it to 12.08.

Same behavior as comment #13, observed on hardware pack:

http://snapshots.linaro.org/precise/hwpacks/leb-origen/245/hwpack_linaro-leb-origen_20120729-245_armhf_supported.tar.gz

with ubuntu rootfs image:

http://snapshots.linaro.org/precise/images/ubuntu-desktop/321/linaro-precise-ubuntu-desktop-20120729-321.tar.gz

For Samsung Origen board, same behaviour observed as comment #13 on Linaro ubuntu pre-built image:

http://snapshots.linaro.org/precise/pre-built/leb-origen/259/leb-origen-precise_ubuntu-desktop_20120805-259.img.gz

Please refer to attachment to get boot log in serial console.

For Samsung Origen board, same behaviour observed as comment #13 on Linaro ubuntu pre-built image:

http://snapshots.linaro.org/precise/pre-built/leb-origen/273/leb-origen-precise_ubuntu-desktop_20120812-273.img.gz

Please refer to attachment to get boot log in serial console.

For Samsung Origen board, same behaviour observed as comment #13 on Linaro ubuntu pre-built image:

http://snapshots.linaro.org/precise/pre-built/leb-origen/287/leb-origen-precise_ubuntu-desktop_20120819-287.img.gz

Please refer to attachment to get boot log in serial console.

Now device tree works well on Origen ubuntu Linaro pre-built image:

http://snapshots.linaro.org/precise/pre-built/leb-origen/312/leb-origen-precise_ubuntu-desktop_20120828-312.img.gz

From boot log, there is:

## Flattened Device Tree blob at 41f00000
   Booting using the fdt blob at 0x41f00000
   Loading Kernel Image ... OK
OK
   Loading Ramdisk to 4fc53000, end 4ffff6bf ... OK
   Loading Device Tree to 4fc4c000, end 4fc5284f ... OK

Starting kernel ...

From "/proc" directory, there is:

root@linaro-ubuntu-desktop:/proc/device-tree# pwd
/proc/device-tree

root@linaro-ubuntu-desktop:/proc/device-tree# ls
#address-cells i2c@138D0000 pd-mfc
#size-cells i2s@03830000 pd-tv
aliases interrupt-controller-wakeup-eint power-domain-lcd0
amba interrupt-controller@10440000 rtc@10070000
asoc_dma interrupt-controller@10490000 sdhci@12510000
chosen interrupt-parent sdhci@12520000
compatible keypad@100A0000 sdhci@12530000
fimd@11C00000 lcd_panel0 sdhci@12540000
gpio-controllers memory serial@13800000
gpio_keys model serial@13810000
i2c@13860000 name serial@13820000
i2c@13870000 origen_audio serial@13830000
i2c@13880000 pd-cam usb@12580000
i2c@13890000 pd-g3d usb@12590000
i2c@138A0000 pd-gps watchdog@10060000
i2c@138B0000 pd-lcd0
i2c@138C0000 pd-lcd1

What's left to do in linaro-image-tools?

marking invalid for l-i-t. obsoleted by hwpack v3 file format support (landed on lit 2012.09)

observed with origen ubuntu 12.11 release builds

http://snapshots.linaro.org/precise/pre-built/leb-origen/494/leb-origen-precise_ubuntu-desktop_20121127-494.img.gz

Device tree is not available.

On 28 November 2012 22:43, Soumya Basak wrote:
> Device tree is not available.

According to LAVA bootlog, the device tree is available:
Loading Device Tree to 4fc56000, end 4fc5d14c ... OK

the test case should be updated (validation step 2):
https://wiki.linaro.org/Platform/QA/TestCases/Ubuntu#Device_Tree

hi fabo
for the samsung origen 12.11 ubuntu release images

http://snapshots.linaro.org/precise/pre-built/leb-origen/494/leb-origen-precise_ubuntu-desktop_20121127-494.img.gz

Device Tree is available.

changed is updated on the wiki page.

https://wiki.linaro.org/Platform/QA/TestCases/Ubuntu#Device_Tree