Race Condition setting active source at startup
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Banshee |
Fix Released
|
Medium
|
|||
| banshee (Ubuntu) |
Fix Released
|
High
|
dobey | ||
| Oneiric |
Fix Released
|
High
|
dobey | ||
| Precise |
Fix Released
|
High
|
dobey | ||
Bug Description
It appears there is a race condition when setting the active source, at startup. We need to do this in the U1MS extension, when a u1ms:// link is passed into banshee. If banshee is already running, this doesn't seem to be an issue, as things are relatively idle. However, at startup, there is a lot more activity happening, and active source notification seems to race with the main loop, sometimes failing, causing the source switch to not happen, or causing the source to switch, but leaving the selected source in the source tree list on the sidebar, to be incorrect.
TESTCASE:
This is an extremely difficult bug to replicate. In order to do so, you would need to have the libubuntuone 0.11.0-0ubuntu3 packages installed from oneiric-proposed (or libubuntuone from the U1 Nightlies PPA), and a version of banshee with the patch to fix bug #872972, but without the patch to fix this bug. Under these conditions, opening a u1ms:// link without banshee already running will result in either the U1MS source not being switched to at all, or with it being displayed by default, but with the source selection in the tree of sources on the left sidebar remaining on the Music library source.
Related branches
- Ubuntu branches: Pending requested
-
Diff: 137 lines (+91/-2)5 files modifieddebian/changelog (+9/-0)
debian/control (+2/-2)
debian/patches/91_u1ms_switch_faster.patch (+54/-0)
debian/patches/92_avoid_source_race.patch (+24/-0)
debian/patches/series (+2/-0)
- Ubuntu Development Team: Pending requested
-
Diff: 52 lines (+29/-0)3 files modifieddebian/changelog (+7/-0)
debian/patches/90_u1ms_idle_activate.patch (+21/-0)
debian/patches/series (+1/-0)
| Changed in banshee (Ubuntu): | |
| assignee: | nobody → Rodney Dawes (dobey) |
| importance: | Undecided → High |
| status: | New → In Progress |
| milestone: | none → oneiric-updates |
| Changed in banshee: | |
| importance: | Unknown → Medium |
| status: | Unknown → Fix Released |
| Michael Terry (mterry) wrote | #1 |
| description: | updated |
| Martin Pitt (pitti) wrote Please test proposed package | #2 |
| Changed in banshee (Ubuntu Oneiric): | |
| status: | New → Fix Committed |
| tags: | added: verification-needed |
| Bertrand Lorentz (bertrand-lorentz) wrote | #3 |
| Changed in banshee: | |
| status: | Fix Released → Confirmed |
| Chow Loong Jin (hyperair) wrote Banshee 2.2.1 | #4 |
| dobey (dobey) wrote | #5 |
| Changed in banshee (Ubuntu Oneiric): | |
| status: | Fix Committed → In Progress |
| assignee: | nobody → Rodney Dawes (dobey) |
| tags: |
added: verification-failed removed: verification-needed |
| Changed in banshee (Ubuntu Precise): | |
| milestone: | oneiric-updates → none |
| Changed in banshee (Ubuntu Oneiric): | |
| milestone: | none → oneiric-updates |
| importance: | Undecided → High |
| Changed in banshee: | |
| status: | Confirmed → Fix Released |
| Chris Halse Rogers (raof) wrote | #6 |
| dobey (dobey) wrote | #7 |
| Martin Pitt (pitti) wrote Please test proposed package | #8 |
| Changed in banshee (Ubuntu Oneiric): | |
| status: | In Progress → Fix Committed |
| tags: | removed: verification-failed |
| tags: | added: verification-needed |
| dobey (dobey) wrote | #9 |
| Changed in banshee (Ubuntu Precise): | |
| status: | In Progress → Fix Released |
| tags: |
added: verification-done removed: verification-needed |
| Launchpad Janitor (janitor) wrote | #10 |
| Changed in banshee (Ubuntu Oneiric): | |
| status: | Fix Committed → Fix Released |
I pushed your branch to oneiric-proposed. Subscribing ubuntu-sru