nova.compute.manager has unreachable path

Bug #894172 reported by Nachi Ueno(Instance3)
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Mark McLoughlin

Bug Description

nova.compute.manager has unreachable path

https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L306
if not ((bdm['snapshot_id'] is None) or
          (bdm['volume_id'] is not None)):

is equivalent to this:
  if ((bdm['snapshot_id'] is not None) and
      (bdm['volume_id'] is None)):

bdm['volume_id'] is always set L304 if bdm['snapshot_id'] is not None and bdm['volume_id'] is None
https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L304

description: updated
Revision history for this message
Mark McLoughlin (markmc) wrote :
Thierry Carrez (ttx)
Changed in nova:
assignee: nobody → Mark McLoughlin (markmc)
importance: Undecided → Low
status: New → In Progress
Mark McLoughlin (markmc)
Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → essex-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: essex-3 → 2012.1
Tom Fifield (fifieldt)
no longer affects: openstack-qa
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.