OpenStack Compute (nova)

rpc calls are broken when remote procedure returns None

Bug #897155 reported by Chris Behrens
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Chris Behrens
OpenStack Compute (nova) 2012.1 "essex"
Diablo
Fix Released
Undecided
Unassigned
OpenStack Compute (nova) 2011.3.1

Bug Description

Unfortunately a None response is used to signify the end of a multicall. But None can be a valid response. This causes the caller to end reading from the queue early. We need to signify the end of a rpc call in a different manner.

This would cause bug 855030, but I cannot be sure that's the real cause of that bug, so I'm filing this separately.

Chris Behrens (cbehrens)
Changed in nova:
assignee: nobody → Chris Behrens (cbehrens)
status: New → In Progress
Revision history for this message
Chris Behrens (cbehrens) wrote :

https://review.openstack.org/1934

Chris Behrens (cbehrens)
Changed in nova:
importance: Undecided → High
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/1934
Committed: http://github.com/openstack/nova/commit/84693b4a16413830be61f465f602de9d13b45161
Submitter: Jenkins
Branch: master

 status fixcommitted
 done

commit 84693b4a16413830be61f465f602de9d13b45161
Author: Chris Behrens <email address hidden>
Date: Tue Nov 29 09:01:16 2011 -0800

    Fix RPC responses to allow None response correctly.

    Fixes bug 897155

    Also adds a new fake rpc implementation that tests use by default.
    This speeds up the test run by ~10% on my system. We can decide to
    ditch fake_rabbit at some point later..

    Change-Id: I8877fad3d41ae055c15b1adff99e535c34e9ce92

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote :

Reviewed: https://review.openstack.org/2043
Committed: http://github.com/openstack/nova/commit/5f72723b4137ec59b4c6b376ddf6e7cb42df26b5
Submitter: Jenkins
Branch: master

 status fixcommitted
 done

commit 5f72723b4137ec59b4c6b376ddf6e7cb42df26b5
Author: Duncan McGreggor <email address hidden>
Date: Fri Dec 2 09:48:15 2011 -0800

    Add missing documentation for shared folder issue with unit tests and Python
    lock file.

    Addresses documentation need raised in bug 897155

    Change-Id: Idc95c12f939948bbbefd84a79b3785e3c2fd752c

Revision history for this message
Duncan McGreggor (oubiwann) wrote :

Not sure how this bug number made it into the commit log, but the last message is incorrect -- it should point to bug 882933 instead.

Sorry folks!

Thierry Carrez (ttx)
Changed in nova:
milestone: none → essex-2
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/diablo)

Reviewed: https://review.openstack.org/2232
Committed: http://github.com/openstack/nova/commit/475f3624245500c5382faf5b2708a59fcec2c9ad
Submitter: Jenkins
Branch: stable/diablo

commit 475f3624245500c5382faf5b2708a59fcec2c9ad
Author: Chris Behrens <email address hidden>
Date: Tue Nov 29 09:01:16 2011 -0800

    Fix RPC responses to allow None response correctly.

    Fixes bug 897155

    Cherry picked from 84693b4a16413830be61f465f602de9d13b45161

    Also adds a new fake rpc implementation that tests use by default.
    This speeds up the test run by ~10% on my system. We can decide to
    ditch fake_rabbit at some point later..

    Change-Id: I8877fad3d41ae055c15b1adff99e535c34e9ce92

tags: added: in-stable-diablo
Thierry Carrez (ttx)
Changed in nova:
milestone: essex-2 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.