binary ancestry calculation broken for new binary packages

The upload 20070226-234514-304164-641647 (thunar-volman-plugin 0.1.2-0ubuntu1 on i386) is incorrectly rejected.

lp_buildd@drescher:/srv/launchpad.net/builddmaster$ BID=301985; DIR=20070216-194511-301985-633973; PYTHONPATH=/srv/launchpad.net/codelines/current/lib LPCONFIG=ftpmaster /srv/launchpad.net/codelines/current/scripts/process-upload.py -Mvv --log-file=incoming/$DIR/uploader.retry.log -C buildd -d ubuntu -r $(~/build-to-suite $BID) -b $BID -J $DIR .

The log follows:

10:46:40 INFO creating lockfile
10:46:40 DEBUG Initialising connection.
10:46:42 DEBUG Beginning processing
10:46:42 DEBUG Checked in /srv/launchpad.net/builddmaster/incoming, found ['20070226-234514-304164-641647', '20070302-092504-305125-644005', '20070302-093256-305150-644030', '20070302-093258-305239-644119', '
20070302-093400-305155-644035', '20070302-093659-305217-644097', '20070302-093527-305160-644040', '20070302-093529-305170-644050', '20070302-105002-305204-644084', '20070216-194511-301985-633973']
10:46:42 DEBUG Considering upload 20070226-234514-304164-641647
10:46:42 DEBUG Skipping 20070226-234514-304164-641647 -- does not match 20070216-194511-301985-633973
10:46:42 DEBUG Considering upload 20070302-092504-305125-644005
10:46:42 DEBUG Skipping 20070302-092504-305125-644005 -- does not match 20070216-194511-301985-633973
10:46:42 DEBUG Considering upload 20070302-093256-305150-644030
10:46:42 DEBUG Skipping 20070302-093256-305150-644030 -- does not match 20070216-194511-301985-633973
10:46:42 DEBUG Considering upload 20070302-093258-305239-644119
10:46:42 DEBUG Skipping 20070302-093258-305239-644119 -- does not match 20070216-194511-301985-633973
10:46:42 DEBUG Considering upload 20070302-093400-305155-644035
10:46:42 DEBUG Skipping 20070302-093400-305155-644035 -- does not match 20070216-194511-301985-633973
10:46:42 DEBUG Considering upload 20070302-093659-305217-644097
10:46:42 DEBUG Skipping 20070302-093659-305217-644097 -- does not match 20070216-194511-301985-633973
10:46:42 DEBUG Considering upload 20070302-093527-305160-644040
10:46:42 DEBUG Skipping 20070302-093527-305160-644040 -- does not match 20070216-194511-301985-633973
10:46:42 DEBUG Considering upload 20070302-093529-305170-644050
10:46:42 DEBUG Skipping 20070302-093529-305170-644050 -- does not match 20070216-194511-301985-633973
10:46:42 DEBUG Considering upload 20070302-105002-305204-644084
10:46:42 DEBUG Skipping 20070302-105002-305204-644084 -- does not match 20070216-194511-301985-633973
10:46:42 DEBUG Considering upload 20070216-194511-301985-633973
10:46:42 DEBUG Considering changefile thunar-volman-plugin_0.1.2-0ubuntu1_i386.changes
10:46:42 DEBUG Finding fresh policy
10:46:42 INFO Processing upload /srv/launchpad.net/builddmaster/incoming/20070216-194511-301985-633973/thunar-volman-plugin_0.1.2-0ubuntu1_i386.changes
10:46:42 DEBUG Beginning processing.
10:46:42 DEBUG Changes file can be unsigned, storing None
10:46:42 DEBUG Verifying the changes file.
10:46:42 DEBUG Verifying files in upload.
10:46:42 DEBUG Verifying binary thunar-volman-plugin_0.1.2-0ubuntu1_i386.deb
10:46:43 DEBUG Verifying timestamps in thunar-volman-plugin_0.1.2-0ubuntu1_i386.deb
10:46:43 DEBUG Finding and applying overrides.
10:46:43 DEBUG Checking for thunar-volman-plugin/0.1.2-0ubuntu1/i386 binary ancestry
10:46:43 DEBUG thunar-volman-plugin: (binary) exists in amd64/RELEASE
10:46:43 DEBUG No signer, therefore ACL not processed
10:46:43 DEBUG No signer, therefore no point verifying signer against ACL
10:46:43 DEBUG Finished checking upload.
10:46:43 DEBUG Building recipients list.
10:46:43 DEBUG Changes file is unsigned, adding changer as recipient
10:46:43 DEBUG Adding recipient: 'Gauvain Pocentek <email address hidden>'
10:46:43 INFO Would be sending a mail:
10:46:43 INFO Subject: thunar-volman-plugin_0.1.2-0ubuntu1_i386.changes Rejected
10:46:43 INFO Recipients: Gauvain Pocentek <email address hidden>
10:46:43 INFO Body:
10:46:43 INFO Rejected:
10:46:43 INFO thunar-volman-plugin_0.1.2-0ubuntu1_i386.deb: Version older than that in the archive. 0.1.2-0ubuntu1 <= 0.1.2-0ubuntu1
10:46:43 INFO
10:46:43 INFO Format: 1.7
10:46:43 INFO Date: Sat, 27 Jan 2007 11:21:54 +0100
10:46:43 INFO Source: thunar-volman-plugin
10:46:43 INFO Binary: thunar-volman-plugin
10:46:43 INFO Architecture: i386_translations i386
10:46:43 INFO Version: 0.1.2-0ubuntu1
10:46:43 INFO Distribution: autobuild
10:46:43 INFO Urgency: low
10:46:43 INFO Maintainer: Ubuntu/i386 Build Daemon <email address hidden>
10:46:43 INFO Changed-By: Gauvain Pocentek <email address hidden>
10:46:43 INFO Description:
10:46:43 INFO thunar-volman-plugin - enables automatic management of medias in Thunar
10:46:43 INFO Changes:
10:46:43 INFO thunar-volman-plugin (0.1.2-0ubuntu1) feisty; urgency=low
10:46:43 INFO .
10:46:43 INFO * Initial release
10:46:43 INFO Files:
10:46:43 INFO 3c1c85c7be8461187cb670743b83a278 11121 raw-translations - thunar-volman-plugin_0.1.2-0ubuntu1_i386_translations.tar.gz
10:46:43 INFO e7d95727f44c9f89205631b40d31f71c 60336 x11 optional thunar-volman-plugin_0.1.2-0ubuntu1_i386.deb
10:46:43 INFO
10:46:43 INFO
10:46:43 INFO ===
10:46:43 INFO
10:46:43 INFO If you don't understand why your files were rejected, or if the
10:46:43 INFO override file requires editing, reply to this email.
10:46:43 INFO Committing the transaction and any mails associated with this upload.
10:46:43 DEBUG Moving upload directory /srv/launchpad.net/builddmaster/incoming/20070216-194511-301985-633973 to /srv/launchpad.net/builddmaster/rejected/20070216-194511-301985-633973
10:46:43 DEBUG Rolling back any remaining transactions.
10:46:43 DEBUG Removing lock file: /var/lock/process-upload.lock

Specifically, note this:

10:46:43 DEBUG Checking for thunar-volman-plugin/0.1.2-0ubuntu1/i386 binary ancestry
10:46:43 DEBUG thunar-volman-plugin: (binary) exists in amd64/RELEASE

The fallback to other distroarchreleases in NascentUpload.getBinaryAncestry is wrong. Perhaps it's trying to get overrides from the other architectures? That would make a certain amount of sense. However, performing version checks based on the versions present on other architectures is absolutely wrong, and in this case breaks whenever we try to upload binaries that have never been seen before on this architecture but have been published on some other architectures (a common situation!).

It's possible that this code may be trying to ensure that we perform version checks against other architectures in the case of Architecture: all packages. However, the current code is already broken in this regard (at best, it will check *one* other architecture, not all) and so I don't think you should worry about breaking it further in the course of fixing this.

Please address this ASAP, as it is rejecting valid binary uploads.