Asus K54C wireless led is always off

Bug #901105 reported by Keng-Yu Lin
26
This bug affects 4 people
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Fix Released
Medium
AceLan Kao
Nominated for Oneiric by Ayan George
Nominated for Precise by Ayan George
Nominated for Raring by Anthony Wong
Quantal
Won't Fix
Medium
AceLan Kao

Bug Description

The LED is always off no matter when there is wifi connected or not.

Keng-Yu Lin (lexical)
Changed in linux (Ubuntu):
status: New → In Progress
importance: Undecided → Low
assignee: nobody → Keng-Yü Lin (lexical)
tags: added: blocks-hwcert-enablement
Revision history for this message
Keng-Yu Lin (lexical) wrote :

the patch is sent upstream for review. This bug is opened for SRU for Oneric once it gets merged mainline.

tags: added: patch
Revision history for this message
Keng-Yu Lin (lexical) wrote :

upstream nack'ed this patch and asked for quirking and handling the led trigger in a correct way. need more work.

Keng-Yu Lin (lexical)
Changed in linux (Ubuntu):
status: In Progress → Triaged
assignee: Keng-Yu Lin (lexical) → Anthony Wong (anthonywong)
Jesse Sung (wenchien)
Changed in linux (Ubuntu):
assignee: Anthony Wong (anthonywong) → Jesse Sung (wenchien)
Changed in linux (Ubuntu):
importance: Low → Medium
Jesse Sung (wenchien)
Changed in linux (Ubuntu):
status: Triaged → In Progress
Revision history for this message
Jesse Sung (wenchien) wrote :

Since I can't find a machine with this wifi card to test, this patch is not verified yet...
Kernel packages for test can be found at http://people.canonical.com/~jesse/lp901105/

Revision history for this message
AceLan Kao (acelankao) wrote :

finally, we will update the wlan LED through rfkill led trigger

Changed in linux (Ubuntu):
assignee: Jesse Sung (wenchien) → AceLan Kao (acelankao)
Revision history for this message
AceLan Kao (acelankao) wrote :

The patch for this issue is discussing in the platform-x86 mailing list
http://www.spinics.net/lists/platform-driver-x86/msg03652.html

Revision history for this message
AceLan Kao (acelankao) wrote :

patch is accepted by asus-wmi driver maintainer

Changed in linux (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "0001-Add-a-quirk-of-wlan-LED-for-certain-Asus-WLAN-cards.patch" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

Revision history for this message
Andy Whitcroft (apw) wrote :

@AceLan -- I don't see this in Quantal as yet. Perhaps you could send this patch up to the kernel-team@ list.

Revision history for this message
AceLan Kao (acelankao) wrote :

Andy, this patch requires another commit in rfkill(linux-wireless),
once they all enter linus' tree, I'll send the request to kernel-team.

Revision history for this message
AceLan Kao (acelankao) wrote :

Quantal and Precise SRU sent

Revision history for this message
Anthony Wong (anthonywong) wrote :

Patch has not landed in Quantal, reset to Confirmed.

Changed in linux (Ubuntu Quantal):
status: Fix Committed → Confirmed
Revision history for this message
AceLan Kao (acelankao) wrote :

Yes, the SRU was rejected because that patch was in linux-next, not in mainstream kernel tree at that time.
I'll re-submit it soon.

Revision history for this message
AceLan Kao (acelankao) wrote :

I just check the status of the patches, there is one commit not in linus' tree yet.
I just wrote to the maintainer of the platform-x86 tree to ask him to submit the queued patch.
Once the commit get merged into mainstream kernel, I'll submit the SRU.

Revision history for this message
AceLan Kao (acelankao) wrote :

The patch is still in platform-x86 maintainer's tree, for requiring another patch goes into linus' tree first.
I think this patch will land on 3.8 kernel soon.

Revision history for this message
AceLan Kao (acelankao) wrote :

The required patches are in 3.5 and 3.8 mainstream kernel.

commit 06d7de831dab8b93adb86e039a2f3d36604a9197
Author: AceLan Kao <email address hidden>
Date: Thu Jul 26 09:51:08 2012 +0800

    Revert "rfkill: remove dead code"

    This reverts commit 2e48928d8a0f38c1b5c81eb3f1294de8a6382c68.

    Those functions are needed and should not be removed, or
    there is no way to set the rfkill led trigger name.

    Signed-off-by: AceLan Kao <email address hidden>
    Signed-off-by: Johannes Berg <email address hidden>

commit 6cae06e603339f99334bc6b276e2ac619cf0d476
Author: AceLan Kao <email address hidden>
Date: Fri Jul 27 16:51:59 2012 +0800

    asus-wmi: update wlan LED through rfkill led trigger

    For those machines with wapf=4, BIOS won't update the wireless LED,
    since wapf=4 means user application will take in chage of the wifi and bt.
    So, we have to update wlan LED status explicitly.

    But I found there is another wireless LED bug in launchpad and which is
    not in the wapf=4 quirk.
    So, it might be better to set wireless LED status explicitly for all
    machines.

    BugLink: https://launchpad.net/bugs/901105

    Signed-off-by: AceLan Kao <email address hidden>
    Signed-off-by: Matthew Garrett <email address hidden>

Revision history for this message
Anthony Wong (anthonywong) wrote :

Acelan, 6cae06e603339f99334bc6b276e2ac619cf0d476 is not yet in Raring, could you cherry-pick it for Raring kernel?

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux - 3.9.0-0.2

---------------
linux (3.9.0-0.2) saucy; urgency=low

  [ Tim Gardner ]

  * Enable extras packaging for amd64/i386.
    Fixes build depenencies with brittany and linux-meta.
 -- Tim Gardner <email address hidden> Mon, 29 Apr 2013 05:37:01 -0600

Changed in linux (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Gabriel Devenyi (ace-staticwave) wrote :

This change appears to break UX32VD function keys

https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1173107

Changed in linux (Ubuntu Quantal):
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.