PEP8 glance cleanup

Bug #911547 reported by Zhongyue Luo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Low
Zhongyue Luo

Bug Description

The None, True, and False values are singletons.

All variable *comparisons* to singletons should use 'is' or 'is not'.
All variable *evaluations* to boolean should use 'if' or 'if not'.
All Object type comparisons should use isinstance() instead of comparing types directly.

Zhongyue Luo (zyluo)
Changed in glance:
assignee: nobody → LZY (lzyeval)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/2770

Changed in glance:
status: New → In Progress
Zhongyue Luo (zyluo)
summary: - PEP8 cleanup
+ PEP8 glance cleanup
Jay Pipes (jaypipes)
Changed in glance:
milestone: none → essex-3
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/2770
Committed: http://github.com/openstack/glance/commit/5e5d2ebde45d5c76b95e4f49ae15a18797265682
Submitter: Jenkins
Branch: master

commit 5e5d2ebde45d5c76b95e4f49ae15a18797265682
Author: lzyeval <email address hidden>
Date: Wed Jan 4 09:20:53 2012 +0800

    PEP8 glance cleanup

    Fixes bug #911547

    All Object type comparisons should use isinstance()
    instead of comparing types directly.

    Change-Id: I9ddabd5cc7333fc63790b140ee52bf995a66cc9c

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: essex-3 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.