register_models in db/sqlalchemy/models.py references non-existent ExportDevice

Bug #914907 reported by Armando Migliaccio
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Armando Migliaccio

Bug Description

ExportDevice was removed by Vish during change: I1b1626f40bebe8466ab410fb174683293c7c474f (https://github.com/openstack/nova/commit/eb03d47fecd3bfc24243da29ee01679b334a08fe#nova/db/sqlalchemy/models.py)

This is still referenced in db/sqlalchemy/models.py:

def register_models():
    """Register Models and create metadata.

    Called from nova.db.sqlalchemy.__init__ as part of loading the driver,
    it will never need to be called explicitly elsewhere unless the
    connection is lost and needs to be reestablished.
    """
    from sqlalchemy import create_engine
    models = (Service, Instance, InstanceActions, InstanceTypes,
              Volume, ExportDevice, IscsiTarget, FixedIp, FloatingIp,
              Network, SecurityGroup, SecurityGroupIngressRule,
              SecurityGroupInstanceAssociation, AuthToken, User,
              Project, Certificate, ConsolePool, Console, Zone,
              VolumeMetadata, VolumeTypes, VolumeTypeExtraSpecs,
              AgentBuild, InstanceMetadata, InstanceTypeExtraSpecs, Migration,
              VirtualStorageArray, SMFlavors, SMBackendConf, SMVolume,
              InstanceFault, Aggregate, AggregateMetadata)
    engine = create_engine(FLAGS.sql_connection, echo=False)
    for model in models:
        model.metadata.create_all(engine)

This looks like an accidental omission to me, unless I am missing something.

Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

needless to say I am looking at trunk

Changed in nova:
status: New → Confirmed
assignee: nobody → Armando Migliaccio (armando-migliaccio)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/2969

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/2969
Committed: http://github.com/openstack/nova/commit/568577bc009a1803cca77b4bb02ccb4dbcd2f35c
Submitter: Jenkins
Branch: master

commit 568577bc009a1803cca77b4bb02ccb4dbcd2f35c
Author: Armando Migliaccio <email address hidden>
Date: Wed Jan 11 18:11:48 2012 +0000

    Bug #914907: register_models in db/sqlalchemy/models.py references non-existent ExportDevice

    Remove ExportDevice from register_models as this no longer exists.

    Change-Id: I68555eb33e035fa3669e4ac4b77cb2c0598cf52c

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.