Mahara

Make 'Student ID' specific for the institution when mapped from an LDAP server

Bug #918442 reported by Iñaki Arenaza
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Iñaki Arenaza

Bug Description

When Bug #906996 added the ability to map Student ID and Display from a LDAP server, we completely forgot that the Student ID can be specific for the institution. In fact, if we don't store the Student ID in usr_institution we are not able to search for the user in the institution users page using the Studend ID.

Full credit goes to Patrick Pollet for discovering the bug and proposing a fix for it.

As Bug #906996 is for master only, the patch-set sent to gerrit is for master only too.

Saludos.
Iñaki.

Tags: bite-sized
Revision history for this message
Hugh Davenport (hugh-davenport) wrote :

Hi Inaki,

Had Patrick developed a solution for this bug? I can't find it in the review system. Can you get him to either push it to gerrit or add it here?

Cheers,

Hugh

Changed in mahara:
status: New → Incomplete
François Marier (fmarier)
tags: removed: patch
Revision history for this message
Iñaki Arenaza (iarenaza) wrote :

Sorry Hugh and François,

I run out of time before being able to send the patch to gerrit and have been busy at work since then.

I've just pushed it to gerrit.

Saludos.
Iñaki.

Revision history for this message
François Marier (fmarier) wrote :

https://reviews.mahara.org/#change,1008

Changed in mahara:
status: Incomplete → In Progress
importance: Low → Medium
assignee: nobody → Iñaki Arenaza (iarenaza)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/1008
Committed: http://gitorious.org/mahara/mahara/commit/fce5c16cf7e6f39d8dec868f7fbdf5d8fc5cf268
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit fce5c16cf7e6f39d8dec868f7fbdf5d8fc5cf268
Author: I��aki Arenaza <email address hidden>
Date: Thu Jan 26 23:42:22 2012 +0100

    Make 'Student ID' specific for the institution when using LDAP (bug #918442)

    When we added the ability to map Student ID and Display from a LDAP
    server, we completely forgot that the Student ID can be specific for
    the institution. In fact, if we don't store the Student ID in
    usr_institution we are not able to search for the user in the
    institution users page using the Studend ID.

    Full credit goes to Patrick Pollet for discovering the bug and
    proposing a fix for it.

    Change-Id: I545bbcb5addf837364ed1178be340d170d4114e3
    Signed-off-by: I��aki Arenaza <email address hidden>

Richard Mansfield (richard-mansfield)
Changed in mahara:
status: In Progress → Fix Committed
status: Fix Committed → Fix Released
milestone: 1.5.0 → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.