live-build example auto/config script has a typo

Bug #923355 reported by Rigved Rakshit
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
live-build (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

Description: Ubuntu precise (development branch)
Release: 12.04

live-build:
  Installed: 3.0~a24-1ubuntu22
  Candidate: 3.0~a24-1ubuntu22
  Version table:
 *** 3.0~a24-1ubuntu22 0
        500 http://in.archive.ubuntu.com/ubuntu/ precise/main i386 Packages
        100 /var/lib/dpkg/status

Expected Outcome: The example script in auto/config should allow one to build a simple live image.

Actual Outcome: The typo in the example auto/config script causes the build to fail. The typo is: "package-lists" has been mistakenly written as "packages-lists".

ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: live-build 3.0~a24-1ubuntu22
ProcVersionSignature: Ubuntu 3.2.0-12.20-generic 3.2.2
Uname: Linux 3.2.0-12-generic i686
ApportVersion: 1.91-0ubuntu1
Architecture: i386
CheckboxSubmission: da29d507ee0e5fa36c9fd9e32f64b95a
CheckboxSystem: 174dd9663cefed283ef72538c1136ee0
Date: Sun Jan 29 19:46:08 2012
EcryptfsInUse: Yes
InstallationMedia: Ubuntu 12.04 LTS "Precise Pangolin" - Alpha i386 (20111215)
PackageArchitecture: all
SourcePackage: live-build
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
Rigved Rakshit (rigved) wrote :
Rigved Rakshit (rigved)
description: updated
Revision history for this message
Rigved Rakshit (rigved) wrote :

The bug seems to have been fixed in a newer version.

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "debdiff of the version in precise and the version in the live-build launchpad trunk" of this bug report has been identified as being a patch in the form of a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-sponsors team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags: added: patch
Revision history for this message
Dave Walker (davewalker) wrote :

Hi Rigved, thanks for raising this issue and proposing a patch.

It seems there might have been an issue generating the attached debdiff as it is very large and seems to include things not related to this issue. Please can you confirm it is correct.

In addition, can you confirm where you saw this issue fixed/raised in a newer version..

Thanks.

Changed in live-build (Ubuntu):
status: New → Incomplete
importance: Undecided → Medium
Revision history for this message
Rigved Rakshit (rigved) wrote :

Yes. The patch includes fixes for other issues as well. If required, I can create a separate branch which fixes only this typo and ask for review. Should I do that?

Yes, this bug has been fixed in the version of live-build in trunk on Launchpad. This version in trunk is also the latest version in upstream, which also has the fix.

Revision history for this message
Rigved Rakshit (rigved) wrote :

Here is the link to the page where I saw the issue fixed: http://bazaar.launchpad.net/~vcs-imports/live-build/trunk/revision/1974

I saw the problem when I tried to use the example auto/config script to build a live image.

Revision history for this message
Jani Monoses (jani) wrote :

Rigved, could you attach a minimal debdiff (changelog + the upstream changes fixing the two occurences of the issue) ?
Thanks.
If not, the sponsoring team can be unsubscribed and this treated as a bug-report with someone else getting on it.

Revision history for this message
Rigved Rakshit (rigved) wrote :

I have attached a debdiff for version 3.0~a24-1ubuntu26, which includes the fix for the typo in examples/auto/config. The file cron/live-build-cron-images does not exist in the source package; so that typo cannot be fixed.

Revision history for this message
Rigved Rakshit (rigved) wrote :
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

Thanks for the debdiff Rigved! Everything looks fine and I have uploaded your fix. For the future, when using quilt and adding DEP-3 comments, you do not have to prepend with '##'. I have adjusted the DEP-3 comments to be:

Description: Removed left over use of --packages-lists in examples/auto/config.
 Correct usage is --package-lists, as shown here:
 http://live.debian.net/manual/html/live-manual.en.html#319
Author: Rigved Rakshit <email address hidden>
Bug-Ubuntu: https://launchpad.net/bugs/923355

Thanks again. :)

Changed in live-build (Ubuntu):
importance: Medium → Low
status: Incomplete → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package live-build - 3.0~a24-1ubuntu27

---------------
live-build (3.0~a24-1ubuntu27) precise; urgency=low

  * debian/patches/examples-auto-config-typo.patch: Fixing left over
    use of --packages-lists in examples/auto/config (LP: #923355)
 -- Rigved Rakshit <email address hidden> Fri, 24 Feb 2012 16:10:47 +0530

Changed in live-build (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.