QBzr

qrevert: press OK without selecting files: got traceback

Bug #942744 reported by Alexander Belchenko
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
QBzr
Fix Released
Medium
Alexander Belchenko
QBzr 0.23.0 "Birch"

Bug Description

André Bachmann wrote:

Yesterday, a co-worker reported a slight problem with qrevert: If you
open Bazaar, Work, Revert Working Tree... and click OK without doing
anything, you get a BzrCommandError (as it is raised in revert.py in
the function validate). Well, such a message isn't quite user-
friendly. Turning this in to a nicer QtGui.QMessageBox.warning and
returning False isn't a problem. I have changed

raise errors.BzrCommandError("You have not selected anything to
revert.")

to

warningbox = QtGui.QMessageBox.warning(self, self.windowTitle(),
gettext("You have not selected anything to revert."))
return False

---------------

We should have appropriate check in validate method to prevent action to start.

See original description

Related branches

lp:~bialix/qbzr/validate
IWATA Hidetaka: Pending requested
QBzr Developers: Pending requested
Diff: 943 lines (+291/-231)
16 files modified
NEWS.txt (+3/-0)
lib/add.py (+10/-2)
lib/bind.py (+7/-8)
lib/commit.py (+46/-57)
lib/export.py (+32/-29)
lib/getnew.py (+33/-24)
lib/getupdates.py (+29/-11)
lib/ignore.py (+1/-3)
lib/init.py (+10/-8)
lib/pull.py (+4/-8)
lib/revert.py (+35/-26)
lib/send.py (+32/-28)
lib/switch.py (+2/-3)
lib/tag.py (+8/-18)
lib/uncommit.py (+3/-6)
lib/util.py (+36/-0)
lp:~andrebachmann-dd/qbzr/revert-fix-no_files
Alexander Belchenko: Approve
Diff: 41 lines (+15/-5)
2 files modified
NEWS.txt (+3/-0)
lib/revert.py (+12/-5)
Alexander Belchenko (bialix)
description: updated
Alexander Belchenko (bialix)
Changed in qbzr:
assignee: nobody → Alexander Belchenko (bialix)
status: Confirmed → Fix Committed
milestone: none → 0.23beta1
Revision history for this message
André Bachmann (andrebachmann-dd) wrote :

I had the time to change the validate method of qrevert - now it shows a warning if the user wants to revert without selecting files.
The check if there are files selected to revert also now does a real check.
Please check my branch and tell me your opinion about it.

Revision history for this message
Alexander Belchenko (bialix) wrote : Re: [Bug 942744] Re: qrevert: press OK without selecting files: got traceback

André Bachmann пишет:
> I had the time to change the validate method of qrevert - now it shows a warning if the user wants to revert without selecting files.
> The check if there are files selected to revert also now does a real check.
> Please check my branch and tell me your opinion about it.

Your branch has dropped a very important check for pending merges:

if (not self.has_pending_merges or not self.merges_groupbox.isChecked())

which is not right. The check for actually selected files instead of
"select all" is right for me.

--
All the dude wanted was his rug back

Revision history for this message
André Bachmann (andrebachmann-dd) wrote :

You are right, I had the same thought yesterday night right before sleeping. I will change that immediately.

Alexander Belchenko (bialix)
Changed in qbzr:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.