need to provide totally offline ./run_tests.sh to support downstream packaging

Bug #948495 reported by Joseph Heck
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
High
Joseph Heck

Bug Description

Ubuntu (at least) packaging needs a way to run the tests to verify some integrity, but their packaging system has no online access to do things like grab git. The current run_tests.sh uses git to do integration testing against other systems, and we need a way to turn that off to enable packaging.

Revision history for this message
Jesse Andrews (anotherjesse) wrote :

what about having python-keystoneclient as a git submodule?

Revision history for this message
termie (termie) wrote :

i'd be mostly okay with that, but it will be our first submodule stuff in the project

Revision history for this message
Joseph Heck (heckj) wrote :

I'm not totally conversant on submodules - and I'm not sure that will actually solve their problem. My impression (not knowledge) is that they're working from a tarball that we generate and packaging with that independent of any network access.

I guess as long as the git submodule work populates data that rolls into that tarball, we'll be fine. If we try and invoke it during the process flow under ./run_test.sh, it's going to present the same issues for them.

Revision history for this message
Thierry Carrez (ttx) wrote :

Yeah, that would not work. keystone tarball should just contain keystone, not a copy of python-keystoneclient. The need for Ubuntu (and most other distros) is to build a package from a source tarball + other packages pre-installed as build dependencies, and no network access, while running a reasonable amount of tests (the idea being to be able to repeat the build in a controllable environment).

So they either need to:
* be able to run the full tests without network access, using just keystone source tarball and other packages installed as build dependencies (including python-keystoneclient if that's needed)
or
* be able to disable the specific tests that require networking

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/5192

Changed in keystone:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/5192
Committed: http://github.com/openstack/keystone/commit/259d9380e835d03d7358e4d953404b8207b8e8d7
Submitter: Jenkins
Branch: master

commit 259d9380e835d03d7358e4d953404b8207b8e8d7
Author: Joe Heck <email address hidden>
Date: Fri Mar 9 22:41:47 2012 -0800

    enables run_test option to skip integration

    * fixes bug 948495

    Change-Id: I274bfe9611d677c44117a0d9ff67394790794fc4

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: essex-rc1 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.