OpenStack Dashboard (Horizon)

Attributes from one action instance can affect another

Bug #954592 reported by Gabriel Hurley
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Gabriel Hurley
OpenStack Dashboard (Horizon) 2012.1 "essex"

Bug Description

Because actions are only instantiated once at the table level, the attributes dict ends up being shared between the various instances. This is inappropriate.

See original description
Gabriel Hurley (gabriel-hurley)
Changed in horizon:
assignee: nobody → Gabriel Hurley (gabriel-hurley)
importance: Undecided → High
milestone: none → essex-rc1
status: New → In Progress
Gabriel Hurley (gabriel-hurley)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/5307

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/5307
Committed: http://github.com/openstack/horizon/commit/753ebd673c164cc0469a3de1b9ce40fefe92e99b
Submitter: Jenkins
Branch: master

commit 753ebd673c164cc0469a3de1b9ce40fefe92e99b
Author: Gabriel Hurley <email address hidden>
Date: Tue Mar 13 17:27:18 2012 -0700

    Moved ajax updating from Action to Row.

    This fixes the problem of having to "hide" the update action
    in the row's actions column. Fixes bug 948397.

    Additionally, added some protection for spillover between
    the attrs dictionary on action instances. Fixes bug 954592.

    FWIW, the code involved in the AJAX updating is largely identical,
    it's just been moved from Action to Row and had few data accessors
    renamed to account for the differing relation to Table and Row.
    This also allowed the javascript to be significantly cleaner.

    Change-Id: Ic8932a33ca6956a56c8eee09bb0a4d1f59e0ab3a

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: essex-rc1 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.