Configurable SafeIframe site list

Bug #971282 reported by Richard Mansfield
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Richard Mansfield

Bug Description

The hardcoded list of sites from which iframes are allowed should be made configurable by the site admin.

See https://wiki.mahara.org/index.php/Developer_Area/Specifications_in_Development/External_media_block_extension

Changed in mahara:
milestone: none → 1.6.0
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/1138
Committed: http://gitorious.org/mahara/mahara/commit/f3182dd6a527ab20d140eda2be29a40b217dc346
Submitter: Hugh Davenport (<email address hidden>)
Branch: master

commit f3182dd6a527ab20d140eda2be29a40b217dc346
Author: Richard Mansfield <email address hidden>
Date: Wed Mar 28 17:35:31 2012 +1300

    Admin page to manage SafeIframe sites (bug #971282)

    Adds a new page for Site admins to manage the list of sites for which
    iframes are allowed by htmlpurifier. Whenever an item is added,
    edited, or deleted, the regex used by HTMLPurifier is updated. Sites
    are identified by favicon, and by a string entered by the Admin to be
    used as the alt/title text for the favicon image. The source of the
    favicon image can be modified in config.php, but the google service is
    used by default.

    Change-Id: I4117de82691a002bf250ea71622eccfad4d5f8df
    Signed-off-by: Richard Mansfield <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/1137
Committed: http://gitorious.org/mahara/mahara/commit/4b8c5170f44c162fbd56cc1b6519ba613ac38f5c
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit 4b8c5170f44c162fbd56cc1b6519ba613ac38f5c
Author: Richard Mansfield <email address hidden>
Date: Fri Mar 23 15:31:52 2012 +1300

    Move the list of safe iframe sources to the database (bug #971282)

    Builds the htmlpurifier safe iframe regexp from a list of sites stored
    in the database, instead of a hardcoded array.

    Each site in the safe iframe list is associated with a name. This
    will allow several regexp items to be grouped together under the same
    name when they're matching urls from the same site.

    Additionally, the domain part of each site is stored in a second list
    along with the names, so that it will be easy to fetch the favicon for
    display in places such as the external media block configuration form.

    Change-Id: I7fd2bfefbff0881e70b94beb9e8d3efb43f0f9e7
    Signed-off-by: Richard Mansfield <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/1169
Committed: http://gitorious.org/mahara/mahara/commit/ab160d78817c52016d1b4319f59a4ab3e656ea89
Submitter: Hugh Davenport (<email address hidden>)
Branch: master

commit ab160d78817c52016d1b4319f59a4ab3e656ea89
Author: Richard Mansfield <email address hidden>
Date: Thu Apr 26 16:41:00 2012 +1200

    Change version of safe iframe sources upgrade (bug #971282)

    We have just committed to master a database upgrade with a version
    number less than the current version number of the 1.5 branch. This
    means that an upgrade from the current 1.5 to master will not add the
    safeiframe tables.

    This patch changes the version number on master to ensure the upgrade
    is applied.

    This occurred because the 1.5_STABLE branch's version leapfrogged over
    the master version during the release candidate stage. This will be
    fixed in the release script (see bug #988682).

    Change-Id: Ic2929fa9f17719a6068494ab63e7f00558c2fdcc
    Signed-off-by: Richard Mansfield <email address hidden>

tags: added: newfeature1.6
Revision history for this message
Hugh Davenport (hugh-davenport) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iJwEAQECAAYFAlCbHO8ACgkQuMoJ2LQ3zxH8TAP/YN4BiCJZsn5a899/0UzV31Qg
lM8LXAwZWa6zFv6t0BQUHCqe6eFK9wPp51qgCWWXjUZ3vvvVcsyeWp6626aBFKSU
pCQXI9E7huPw802nJQ9WcZXRBUmgw87ww72Tx4mybnu7SPSrkZgXdnPGSMwDs89N
oWvTpl7Xuac48e6p0lU=
=ouU+
-----END PGP SIGNATURE-----

Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.