Ubuntu
task package

deleting certain UUIDs deletes all tasks

Bug #992852 reported by Bryce Harrington
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
task (Ubuntu)
Fix Released
High
Bryce Harrington
Precise
Fix Released
High
Unassigned

Bug Description

[Impact]
When referencing tasks by their uuid (instead of id), certain uuids get interpreted as durations rather than uuids, which can result in mass-deletion of tasks.

[Development Fix]
Cherrypick of upstream patch, uploaded to quantal.

[Stable Fix]
Since we ship the same task version in quantal and precise, use the same patch.

[Test Case]
1. Create tasks until one gets generated which has a 'd' before the first dash
2. Attempt to delete this task using its uuid
    (Similarly for modify, done, etc.)

Broken Behavior: Prompts to delete ALL tasks
Fixed Behavior: Just deletes the specified task

[Regression Potential]
None. Patch is upstream, and confirmed to fix the issue without causing other problems.
The scope of risk is narrow as well; most task users reference tasks by ids, not uuids; uuids are more used with scripts and such.

[Original Report]
Executed this:
task 8e27016d-5695-4d4c-8bc0-99895f73a8e3 done

Task 1 'blah blah blah' is neither pending nor waiting.
- End will be set to '4/27/2012'.
- Status will be changed from 'pending' to 'completed'.
Complete task 2 'foo foo foo'? (yes/no/all/quit) ^C

See http://taskwarrior.org/issues/995

See original description
Revision history for this message
Bryce Harrington (bryce) wrote :

Fixed in upstream commit f4bfa1b2fddd79ff4bf57665593d27bf65299072

Changed in task (Ubuntu):
assignee: nobody → Bryce Harrington (bryce)
importance: Undecided → High
status: New → Triaged
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package task - 2.0.0.release-0ubuntu3

---------------
task (2.0.0.release-0ubuntu3) quantal; urgency=low

  * Add 100_fix_uuid_confusion.patch: Fix issue where deleting certain
    UUIDs results in deletion of all tasks.
    (LP: #992852)
  * Add 101_typo_edit_command.patch: Fix invalid command syntax in
    task edit command.
    (LP: #992866)
  * Add 102_fix_incorrect_projects_headers.patch: Fix inverted priority
    labels in task projects report.
    (LP: #992868)
 -- Bryce Harrington <email address hidden> Wed, 16 May 2012 20:13:39 -0700

Changed in task (Ubuntu):
status: Triaged → Fix Released
Bryce Harrington (bryce)
description: updated
Bryce Harrington (bryce)
Changed in task (Ubuntu Precise):
status: New → Fix Committed
importance: Undecided → High
Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Hello Bryce, or anyone else affected,

Accepted task into precise-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

tags: added: verification-needed
Revision history for this message
Bryce Harrington (bryce) wrote :

Confirmed fixed behavior after installing task from precise-proposed:

$ task 7ea17e6d-fc77-8153-8bdc-0e14f512ad21 editLaunching 'emacs -nw "task.22922.0.task"' now...
Editing complete.
No edits were detected.
$

It properly edited the correct task, without iterating through all tasks.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package task - 2.0.0.release-0ubuntu2.1

---------------
task (2.0.0.release-0ubuntu2.1) precise-proposed; urgency=low

  * Add 100_fix_uuid_confusion.patch: Fix issue where deleting certain
    UUIDs results in deletion of all tasks.
    (LP: #992852)
  * Add 101_typo_edit_command.patch: Fix invalid command syntax in
    task edit command.
    (LP: #992866)
  * Add 102_fix_incorrect_projects_headers.patch: Fix inverted priority
    labels in task projects report.
    (LP: #992868)
 -- Bryce Harrington <email address hidden> Wed, 16 May 2012 20:13:39 -0700

Changed in task (Ubuntu Precise):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.