Improvements to Python bindings

Bug #51304 reported by Jelmer Vernooij on 2006-06-29
16
Affects Status Importance Assigned to Milestone
Bazaar Subversion Plugin
Critical
Jelmer Vernooij
subversion (Ubuntu)
Medium
Matthias Klose

Bug Description

The attached patch fixes a bunch of issues with the Python bindings to Subversion. These changes are required for the Subversion integration into Bazaar (http://bazaar-vcs.org/BzrSvn).

Tested with 1.3.1-3ubuntu1.

The changes are all pulled from Subversion trunk (which will become 1.5).

Also available as a Bazaar branch from http://people.samba.org/bzr/jelmer/svn-1.3.1-python.

See bug report.

Changed in bzr-svn:
importance: Untriaged → Critical
status: Unconfirmed → Fix Committed

I missed a patch. Included now.

Jelmer Vernooij (jelmer) wrote :

Here's a short summary of the changes:

Fix svn_client_info()

Add some tests for the python ra bindings.

Make the SWIG bindings throw an exception whenever a svn_ra_callbacks2_t argument is NULL, and allow the user to pass in a Python object for the callbacks.

Make svn_ra_get_dir2 work in the python bindings by adding some typemaps.

Fix for partial logs requested from old servers.

Create typemaps for the input arguments of svn.ra.get_commit_editor2().

Add tests for Python bindings to svn_ra_get_commit_editor2() and svn_ra_do_update().

Add testsuite for the Python bindings to svn.wc.

Don't crash when NULL revisions are passed to the python bindings.

More test coverage for the svn.wc Python bindings.

Improve test coverage of the Python bindings for svn.client.

Fix Python bindings for svn.ra.get_file_revs().

Fix Python bindings for svn.wc.crawl_revisions2().

Allow the text_checksum argument to svn.delta.editor_invoke_close_file() to be None (as the API allows).

Fix Python bindings to svn.wc.get_ignores().

Add test for Python bindings to svn.ra.get_locations().

Fix tests, wrap svn_commit_info.

Updated version of the patch (passes the testsuite now)

Updated rpath patch to match changes by python-fixes patch.

Also includes fixes for missing python reference counter increment on svn_stream_t.

With this patch, the bzr-svn testsuite now passes on ubuntu.

Another update of the patch, this time updated to allow callbacks for opening temporary files as used by Subversions webdav ra implementation.

Simon Law (sfllaw) wrote :

Jelmer, it is likely that these patches will only get merged when
we pull Subversion 1.5 in from Debian.

Is there anything in your patch that hasn't made it upstream?

Changed in subversion:
importance: Untriaged → Medium
status: Unconfirmed → Confirmed
Jelmer Vernooij (jelmer) wrote :

My patch is only in Subversion 1.5, which is still very far away (even 1.4 is still a couple of months away), so it'll be at least a year or so before it'll enter the debian package.

Jelmer Vernooij (jelmer) wrote :

Reassign to Adam Conrad (after discussion on IRC)

Changed in subversion:
assignee: nobody → adconrad
Jelmer Vernooij (jelmer) wrote :

Ping - any news on this?

Jelmer Vernooij (jelmer) on 2006-09-13
Changed in bzr-svn:
assignee: nobody → jelmer
status: Fix Committed → Confirmed
Matthias Klose (doko) wrote :

fixed in 1.3.2-3ubuntu2

Changed in subversion:
assignee: adconrad → doko
status: Confirmed → Fix Released
Jelmer Vernooij (jelmer) on 2006-10-09
Changed in bzr-svn:
status: Confirmed → Fix Released
Martin Pool (mbp) wrote :

(For Robert's benefit, doko's fixes are now in edgy.)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers