--- webkit-1.1.1.orig/WebCore/ChangeLog +++ webkit-1.1.1/WebCore/ChangeLog @@ -0,0 +1,64921 @@ +2009-03-05 Gustavo Noronha Silva + + Reviewed by Alexey Proskuryakov. + + https://bugs.webkit.org/show_bug.cgi?id=24389 + WebKitGTK+ crashes when cancelling plugin loads + + Remove bogus calls to the client's didFinishLoading method from + our ResourceHandle::cancel implementation. Calling + didFinishLoading here is mostly inoffensive for most loads, but + causes crashes when plugin loads are cancelled. + + * platform/network/soup/ResourceHandleSoup.cpp: + (WebCore::ResourceHandle::cancel): + +2009-03-05 Steve Falkenburg + + Windows build fix. + + * WebCore.vcproj/QTMovieWin.vcproj: + +2009-03-05 Adam Treat + + Build fix for when ENABLE_NETSCAPE_PLUGIN_API = 0. The method + ScriptController::jsObjectForPluginElement(HTMLPlugInElement*); is not + protected by an #if and uses HTMLPlugInElement so it must be included. + + * bindings/js/ScriptController.cpp: + +2009-03-05 Dimitri Glazkov + + GTK Build fix. + + * inspector/ConsoleMessage.h: Use proper header. + +2009-03-05 Dimitri Glazkov + + Reviewed by Timothy Hatcher. + + https://bugs.webkit.org/show_bug.cgi?id=24376 + Split InspectorController.cpp file into separate classes. + + * GNUmakefile.am: Modified to include new files. + * WebCore.pro: Ditto. + * WebCore.scons: Ditto. + * WebCore.vcproj/WebCore.vcproj: Ditto. + * WebCore.xcodeproj/project.pbxproj: Ditto. + * WebCoreSources.bkl: Ditto. + * inspector/ConsoleMessage.cpp: Added. + * inspector/ConsoleMessage.h: Added. + * inspector/InspectorController.cpp: + * inspector/InspectorDOMStorageResource.cpp: Added. + * inspector/InspectorDOMStorageResource.h: Added. + * inspector/InspectorDatabaseResource.cpp: Added. + * inspector/InspectorDatabaseResource.h: Added. + * inspector/InspectorResource.cpp: Added. + * inspector/InspectorResource.h: Added. + +2009-03-05 Eric Carlson + + Reviewed by Darin Adler + + https://bugs.webkit.org/show_bug.cgi?id=24387 + Remove media element bufferingRate attribute. No test necessary as there + were none for this attribute. + + * html/HTMLMediaElement.cpp: + (WebCore::HTMLMediaElement::HTMLMediaElement): Don't initialize m_bufferingRate. + (WebCore::HTMLMediaElement::loadInternal): Ditto. + (WebCore::HTMLMediaElement::setNetworkState): Ditto. + (WebCore::HTMLMediaElement::progressEventTimerFired): Don't calculate m_bufferingRate. + * html/HTMLMediaElement.h: Remove m_bufferingRate. + * html/HTMLMediaElement.idl: Ditto. + +2009-03-05 Xan Lopez + + Reviewed by Mark Rowe. + + https://bugs.webkit.org/show_bug.cgi?id=24377 + [GTK] Comply better with coding style guidelines in ResourceHandleSoup + + Use C++ booleans, 0 instead of NULL, prefix boolean variables with + 'is', do not use 'else if' if the previous if had a return, delete + trailing whitespace, etc. + + * platform/network/ResourceHandleInternal.h: + (WebCore::ResourceHandleInternal::ResourceHandleInternal): + * platform/network/soup/ResourceHandleSoup.cpp: + (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): + (WebCore::fillResponseFromMessage): + (WebCore::restartedCallback): + (WebCore::finishedCallback): + (WebCore::parseDataUrl): + (WebCore::ensureSessionIsInitialized): + (WebCore::ResourceHandle::startHttp): + (WebCore::reportUnknownProtocolError): + (WebCore::ResourceHandle::start): + (WebCore::cleanupGioOperation): + (WebCore::closeCallback): + (WebCore::readCallback): + (WebCore::openCallback): + (WebCore::queryInfoCallback): + (WebCore::ResourceHandle::startGio): + +2009-03-04 Simon Fraser + + Reviewed by Eric Seidel + + https://bugs.webkit.org/show_bug.cgi?id=24328 + + If an element has backface-visibility: hidden, hit testing should not + hit the back sides of elements. Test for that by inverting the accumulated + transform and looking at the z vector. + + Tested by transforms/3d/hit-testing/backface-hit-test.html + + * rendering/RenderLayer.cpp: + (WebCore::RenderLayer::hitTestLayer): + +2009-03-04 Adam Langley + + Reviewed by Darin Fisher. + + r41362 mistakenly added functions "RenderThemeWin::" into + RenderThemeChromiumGtk.cpp. When correcting this, I somehow changed + them to void return types. This patch switches them back to ints. + + https://bugs.webkit.org/show_bug.cgi?id=24360 + + * rendering/RenderThemeChromiumLinux.cpp: + (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingLeft): + (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingRight): + (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingTop): + (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingBottom): + +2009-03-04 Adam Langley + + Reviewed by Darin Fisher. + + Chromium Linux: change some metrics to better match Windows after + r41416. Aesthetically this may be worse, but web-compat is king. + + Also, the previous code had an off by one error when drawing + scrollbars which caused the scrollbar to overflow it's bounds by 1px + at the right and bottom edges. + + https://bugs.webkit.org/show_bug.cgi?id=24369 + + * rendering/RenderThemeChromiumLinux.cpp: + (WebCore::): + (WebCore::RenderThemeChromiumLinux::systemFont): + * platform/chromium/ScrollbarThemeChromiumLinux.cpp: + (WebCore::ScrollbarThemeChromium::paintTrackPiece): + +2009-03-04 Eric Seidel + + Reviewed by Adam Roben. + + Add an ASSERT to better demonstrate the cause of the crash in + https://bugs.webkit.org/show_bug.cgi?id=23736 + + * loader/DocLoader.cpp: + (WebCore::DocLoader::~DocLoader): + +2009-03-04 David Levin + + Reviewed by Alexey Proskuryakov. + + Bug 24337: Assert when doing sync XHR in a worker for a cacheable response. + + + Tests: http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html + http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found.html + + * loader/mac/ResourceLoaderMac.mm: + (WebCore::ResourceLoader::willCacheResponse): + An identifier is only asssigned if resource load callbacks are done. So don't send + willCacheResponse which uses identifier if resource load callbacks aren't being sent. + +2009-03-04 David Levin + + Reviewed by Alexey Proskuryakov. + + Bug 24330: Sync xhr in workers should send an abort exception when the worker is terminated. + + + Test: http/tests/xmlhttprequest/workers/abort-exception-assert.html + + * dom/ExceptionCode.cpp: + (WebCore::xmlHttpRequestExceptionNames): + Added missing ABORT_ERR whose absence caused an assert. + + * loader/WorkerThreadableLoader.cpp: + (WebCore::WorkerThreadableLoader::loadResourceSynchronously): + (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel): + Add more logic to handle the termination case for sync xhr. + +2009-03-04 Eric Carlson + + Reviewed by Antti Koivisto. + + https://bugs.webkit.org/show_bug.cgi?id=24364 + Add support for HTMLMediaElement canPlayType method. Make + MediaPlayer::supportsType take a ContentType instead of a + separate mime type and codecs parameter. + + Test: media/video-can-play-type.html + + * dom/DOMImplementation.cpp: + (WebCore::DOMImplementation::createDocument): + * html/HTMLMediaElement.cpp: + (WebCore::HTMLMediaElement::canPlayType): Add canPlayType method. + (WebCore::HTMLMediaElement::loadInternal): selectMediaURL returns a ContentType. + (WebCore::HTMLMediaElement::selectMediaURL): Return a ContentType instead of raw MIME type. + (WebCore::HTMLMediaElement::initialURL): selectMediaURL returns a ContentType. + * html/HTMLMediaElement.h: Add prototype. + * html/HTMLMediaElement.idl: Ditto. + * platform/graphics/MediaPlayer.cpp: + (WebCore::MediaPlayer::load): Take a ContentType instead of raw MIME type. + (WebCore::MediaPlayer::supportsType): Ditto. + * platform/graphics/MediaPlayer.h: + +2009-03-04 Antti Koivisto + + Reviewed by Dave Hyatt. + + https://bugs.webkit.org/show_bug.cgi?id=24359 + Repaint throttling mechanism + + Excessive repainting can slow down page loadind. This implements a timer + based throttling mechanism. It is behind ENABLE(REPAINT_THROTTLING) and not + enabled by default. + + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::checkCompleted): + * page/EventHandler.cpp: + (WebCore::EventHandler::dispatchDragEvent): + (WebCore::EventHandler::dispatchMouseEvent): + (WebCore::EventHandler::keyEvent): + (WebCore::EventHandler::handleTextInputEvent): + * page/FrameView.cpp: + (WebCore::FrameView::FrameView): + (WebCore::FrameView::reset): + (WebCore::FrameView::repaintContentRectangle): + (WebCore::FrameView::beginDeferredRepaints): + (WebCore::FrameView::endDeferredRepaints): + (WebCore::FrameView::checkStopDelayingDeferredRepaints): + (WebCore::FrameView::doDeferredRepaints): + (WebCore::FrameView::updateDeferredRepaintDelay): + (WebCore::FrameView::resetDeferredRepaintDelay): + (WebCore::FrameView::adjustedDeferredRepaintDelay): + (WebCore::FrameView::deferredRepaintTimerFired): + (WebCore::FrameView::paintContents): + * page/FrameView.h: + +2009-03-04 Sam Weinig + + Rubber-stamped by Antti Koivisto. + + Remove LOW_BANDWIDTH_DISPLAY as it is not being used by any platforms. + + * dom/Document.cpp: + (WebCore::Document::Document): + * dom/Document.h: + (WebCore::Document::haveStylesheetsLoaded): + * html/HTMLTokenizer.cpp: + (WebCore::HTMLTokenizer::scriptHandler): + * loader/Cache.cpp: + (WebCore::Cache::requestResource): + * loader/CachedCSSStyleSheet.cpp: + (WebCore::CachedCSSStyleSheet::checkNotify): + * loader/DocLoader.h: + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::FrameLoader): + (WebCore::FrameLoader::requestFrame): + (WebCore::FrameLoader::stopLoading): + (WebCore::FrameLoader::begin): + (WebCore::FrameLoader::write): + (WebCore::FrameLoader::endIfNotLoadingMainResource): + (WebCore::FrameLoader::checkCompleted): + (WebCore::FrameLoader::requestObject): + (WebCore::FrameLoader::loadItem): + * loader/FrameLoader.h: + +2009-03-02 Xan Lopez + + Reviewed by Mark Rowe. + + https://bugs.webkit.org/show_bug.cgi?id=24287 + [GTK] Move auth dialog feature to WebKit/ + + Remove WebKitSoupAuthDialog files from build and stop using it. + + * GNUmakefile.am: + * platform/network/soup/ResourceHandleSoup.cpp: + (WebCore::ensureSessionIsInitialized): + * platform/network/soup/webkit-soup-auth-dialog.c: Removed. + * platform/network/soup/webkit-soup-auth-dialog.h: Removed. + +2009-03-04 Simon Fraser + + Reviewed by Dave Hyatt + + https://bugs.webkit.org/show_bug.cgi?id=24361 + + Reinstate code that sets result.innerNode when hitTest() returns true, + but never filled in the innerNode. Fixes hit testing of generated content. + + Test: fast/css-generated-content/hit-test-generated-content.html + + * rendering/RenderLayer.cpp: + (WebCore::RenderLayer::hitTestContents): + +2009-03-04 Adam Barth + + Reviewed by Alexey Proskuryakov. + + https://bugs.webkit.org/show_bug.cgi?id=24356 + + Fix WebKit style for allowUniversalAccessFromFileURLs. + + * WebCore.base.exp: + * dom/Document.cpp: + (WebCore::Document::initSecurityContext): + * page/Settings.cpp: + (WebCore::Settings::Settings): + (WebCore::Settings::setAllowUniversalAccessFromFileURLs): + * page/Settings.h: + (WebCore::Settings::allowUniversalAccessFromFileURLs): + +2009-03-04 Brady Eidson + + Reviewed by Darin Adler + + Quick Look of vCards stuck on image of first card opened. + + I narrowed this down to http://trac.webkit.org/changeset/39304 which, among other things, + consolidated some of the various decision making pieces of the Cache into the new method + FrameLoader::cachePolicy(). + + Before 39304, when deciding whether to use an existing CachedResource, we checked if the FrameLoader + is reloading. If it is, we'd evict any existing resource then recreate it. Quick looks uses the + same URL for this image every time and expects it to be reloaded with each new card. + + The FrameLoader::isReloading() check did one thing - Ask the DocumentLoader if it's cache policy + is "ReloadIgnoringCacheData". This check was lost in the consolidation to the new method. + + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::cachePolicy): Restore the DocumentLoader's cachePolicy check as a possible + condition for returning CachePolicyReload. + +2009-03-04 Timothy Hatcher + + * English.lproj/localizedStrings.js: Update strings to include "DATABASES", + "LOCAL STORAGE" and "SESSION STORAGE". + +2009-03-04 Timothy Hatcher + + Fix a regression where the Web Inspector console would not animate + in or out correctly. + + Reviewed by Anders Carlsson. + + * inspector/front-end/inspector.css: Move a z-index to a child element + to get the correct stacking order during the animation. + +2009-03-03 David Hyatt + + https://bugs.webkit.org/show_bug.cgi?id=24201, pathologically bad block layout. + + Make sure to factor clear deltas into y position estimates. Also avoid doing the comparison of + the final position against the y position estimate until after the clear has happened. This gets rid + of some duplicated cut/pasted code and also ensures a layout delta only has to be put in once. + + Reviewed by Dan Bernstein + + Added fast/block/float/nested-clearance.html + + * rendering/RenderBlock.cpp: + (WebCore::RenderBlock::collapseMargins): + (WebCore::RenderBlock::clearFloatsIfNeeded): + (WebCore::RenderBlock::estimateVerticalPosition): + (WebCore::RenderBlock::layoutBlockChildren): + (WebCore::RenderBlock::getClearDelta): + * rendering/RenderBlock.h: + +2009-03-02 Kim Grönholm + + Reviewed by Simon Hausmann. + + Improvement to 3d transformations rendering in QtWebKit. QTransform is used + instead of QMatrix. This allows perspective transformations since QTransform is + a true 3x3 matrix. + + * platform/graphics/qt/GraphicsContextQt.cpp: Use QTransform instead of QMatrix everywhere. + (WebCore::GraphicsContext::getCTM): + (WebCore::GraphicsContext::restorePlatformState): + (WebCore::GraphicsContext::fillPath): + (WebCore::GraphicsContext::strokePath): + (WebCore::GraphicsContext::fillRect): + (WebCore::GraphicsContext::translate): + (WebCore::GraphicsContext::rotate): + (WebCore::GraphicsContext::scale): + (WebCore::GraphicsContext::concatCTM): + * platform/graphics/qt/ImageQt.cpp: + (WebCore::Image::drawPattern): + * platform/graphics/qt/PathQt.cpp: + (WebCore::Path::translate): + (WebCore::Path::transform): + * platform/graphics/qt/PatternQt.cpp: + (WebCore::Pattern::createPlatformPattern): + * platform/graphics/qt/TransformationMatrixQt.cpp: + (WebCore::TransformationMatrix::operator QTransform): Replace the conversion operator + to QMatrix with one to QTransform. + * platform/graphics/transforms/TransformationMatrix.h: + * platform/graphics/qt/FontQt.cpp: + +2009-02-24 Laszlo Gombos + + Reviewed by Simon Hausmann. + + https://bugs.webkit.org/show_bug.cgi?id=24151 + Fix Qt/S60 build break + + * platform/FileSystem.h: Create a default case for non-win and non-mac Qt builds + * platform/qt/FileSystemQt.cpp: Ditto + (WebCore::unloadModule): + +2009-03-03 Mike Belshe + + Reviewed by Alexey Proskuryakov. + + https://bugs.webkit.org/show_bug.cgi?id=21939 + Uninitialized ExceptionCode in DOMWindow::postMessage + + * dom/MessagePort.cpp: + (WebCore::MessagePort::postMessage): + +2009-03-03 David Kilzer + + WebCore and WebKit should install the same set of headers during installhdrs phase as build phase + + Reviewed by Mark Rowe. + + The fix is to add INSTALLHDRS_COPY_PHASE = YES and + INSTALLHDRS_SCRIPT_PHASE = YES to WebCore.xcconfig, then to make + sure various build phase scripts work with the installhdrs build + phase. + + * Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME + based on PLATFORM_NAME to work around the missing definition on + Tiger. + * Configurations/WebCore.xcconfig: Added + JAVASCRIPTCORE_PRIVATE_HEADERS_DIR variable to simplify logic in + the "Generate Derived Sources" script. Added + INSTALLHDRS_COPY_PHASE = YES and INSTALLHDRS_SCRIPT_PHASE = YES. + + * WebCore.xcodeproj/project.pbxproj: + - Added shell code to prevent running "Check For Global + Initializers", "Check For Exit Time Destructors" and "Check + For Weak VTables" scripts during the installhdrs build phase. + - Made "Generate Derived Sources" work for the installhdrs build + phase. Also simplified setting of CREATE_HASH_TABLE by using + JAVASCRIPTCORE_PRIVATE_HEADERS_DIR. + +2009-03-02 Adam Langley + + Reviewed by Darin Fisher. + + Chromium Linux: Switch to using Skia to render widgets. + + In order to sandbox the Chromium renderer on Linux we need to remove + the X connection. GTK cannot render without an X connection so, for + now, we render widgets ourselves. + + Previously didn't use anti-alias fonts in order to match Windows font + rendering exactly. This was helpful when bootstrapping our layout + tests. Now, however, we are ready to enable it. + + https://bugs.webkit.org/show_bug.cgi?id=24244 + + * platform/chromium/ScrollbarThemeChromium.cpp: + (WebCore::ScrollbarThemeChromium::buttonSize): + * platform/chromium/ScrollbarThemeChromiumLinux.cpp: + (WebCore::ScrollbarThemeChromium::scrollbarThickness): + (WebCore::ScrollbarThemeChromium::paintTrackPiece): + (WebCore::ScrollbarThemeChromium::paintButton): + (WebCore::ScrollbarThemeChromium::paintThumb): + * platform/graphics/chromium/FontPlatformDataLinux.cpp: + (WebCore::FontPlatformData::setupPaint): + * platform/graphics/skia/PlatformContextSkia.cpp: + (PlatformContextSkia::PlatformContextSkia): + (PlatformContextSkia::~PlatformContextSkia): + * platform/graphics/skia/PlatformContextSkia.h: + * rendering/RenderThemeChromiumGtk.cpp: Removed. + * rendering/RenderThemeChromiumGtk.h: Removed. + * rendering/RenderThemeChromiumLinux.cpp: Added. + * rendering/RenderThemeChromiumLinux.h: Added. + +2009-03-03 Dimitri Glazkov + + Reviewed by Darin Fisher. + + https://bugs.webkit.org/show_bug.cgi?id=24261 + Fix return types. + + Test: LayoutTests/dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.svg + + * bindings/v8/V8Binding.h: + (WebCore::toInt32): change return type to int + (WebCore::toFloat): change return type to float. + +2009-03-03 Anders Carlsson + + Reviewed by John Sullivan. + + https://bugs.webkit.org/show_bug.cgi?id=22884 + + modified layout test crashes Safari + + Null check NPStream before dereferencing it. + + * plugins/PluginView.cpp: + (WebCore::PluginView::destroyStream): + +2009-03-03 Eric Carlson + + Reviewed by Simon Fraser. + + Fix for + Don't call QTKit to get movie properties until movie metadata has been loaded. + + * platform/graphics/mac/MediaPlayerPrivateQTKit.h: + (WebCore::MediaPlayerPrivate::metaDataAvailable): defined + * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: + (WebCore::MediaPlayerPrivate::createQTTime): return default if !metaDataAvailable. + (WebCore::MediaPlayerPrivate::play): Ditto. + (WebCore::MediaPlayerPrivate::pause): Ditto. + (WebCore::MediaPlayerPrivate::duration): Ditto. + (WebCore::MediaPlayerPrivate::currentTime): Ditto. + (WebCore::MediaPlayerPrivate::seek): Ditto. + (WebCore::MediaPlayerPrivate::seekTimerFired): Ditto. + (WebCore::MediaPlayerPrivate::paused): Ditto. + (WebCore::MediaPlayerPrivate::seeking): Ditto. + (WebCore::MediaPlayerPrivate::naturalSize): Ditto. + (WebCore::MediaPlayerPrivate::hasVideo): Ditto. + (WebCore::MediaPlayerPrivate::setVolume): Ditto. + (WebCore::MediaPlayerPrivate::setRate): Ditto. + (WebCore::MediaPlayerPrivate::dataRate): Ditto. + (WebCore::MediaPlayerPrivate::maxTimeLoaded): Ditto. + (WebCore::MediaPlayerPrivate::totalBytes): Ditto. + +2009-03-03 Kevin McCullough + + - Spelling fix. + + * page/Console.cpp: + (WebCore::Console::profile): + +2009-03-03 Dimitri Glazkov + + Reviewed by Darin Fisher. + + https://bugs.webkit.org/show_bug.cgi?id=23657 + Remove Database API callback IDLs from the project. + They were removed in r40633. + + * WebCore.xcodeproj/project.pbxproj: Removed IDL files from the project. + +2009-03-03 Kevin McCullough + + Reviewed by Oliver Hunt. + + console.profile() doesn't work without a title + + * page/Console.cpp: + (WebCore::Console::profile): If there is no title assume this is a user + initiated profile and give it the next incremented title name. + +2009-03-03 Timothy Hatcher + + Fix a regression that broke dirxml and caused an ASSERT in debug builds. Also simplified + the console code and refactored things to have fewer code paths and duplication. + + rdar://problem/6367127 + https://bugs.webkit.org/show_bug.cgi?id=24329 + + Reviewed by Kevin McCullough. + + Test: manual-tests/inspector/console-dir.html + + * bindings/js/JSInspectedObjectWrapper.cpp: + (WebCore::JSInspectedObjectWrapper::wrap): Use the lexicalGlobalObject instead of dynamicGlobalObject + to fix an ASSERT about using a wrapper from the wrong ExecState. + * bindings/js/JSQuarantinedObjectWrapper.cpp: + (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper): Ditto. + (WebCore::JSQuarantinedObjectWrapper::allowsUnwrappedAccessFrom): Ditto. + * inspector/front-end/Console.js: + (WebInspector.Console.prototype._format): Remove the inline argument and add forceObjectFormat. + When forceObjectFormat is true, the only formatter used is _formatobject. + (WebInspector.Console.prototype._formatvalue): Remove the inline argument. + (WebInspector.Console.prototype._formatstring): Ditto. + (WebInspector.Console.prototype._formatregexp): Ditto. + (WebInspector.Console.prototype._formatarray): Ditto. + (WebInspector.Console.prototype._formatnode): Remove the inline argument and make a DOM tree instead of an anchor. + (WebInspector.Console.prototype._formatobject): Remove the inline argument and always make a property graph. + (WebInspector.Console.prototype._formaterror): Remove the inline argument. + (WebInspector.ConsoleMessage): Remove the case for MessageLevel.Node and + simplify the case for MessageLevel.Object to use the normal _format code path with the %O formatter. + (WebInspector.ConsoleMessage.prototype._format.formatForConsole): Don't pass an additional true argument for inline. + (WebInspector.ConsoleMessage.prototype._format.formatAsObjectForConsole): Added. Pass a true argument for forceObjectFormat. + (WebInspector.ConsoleMessage.prototype._format): Added support for the %O formatter. Use formatForConsole for all arguments. + (WebInspector.ConsoleMessage.prototype.toString): Add the other message levels. + * inspector/front-end/inspector.css: Tweak styles to look and work correctly. + * inspector/front-end/utilities.js: + (Object.type): Return "node" for Node objects. + (Object.describe): Handle the "node" type. + * page/Console.cpp: + (WebCore::printMessageSourceAndLevelPrefix): Fix an assert by adding the other message level types. + (WebCore::Console::dirxml): Use the standard log fuction since it prints a DOM tree for nodes by default. + * page/Console.h: + (WebCore::enum MessageLevel): Removed NodeMessageLevel. Added a FIXME. + +2009-03-03 Scott Violet + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=24325 + Crash on replacing document contents during drop. + + Makes sure a node is in the document during a move before using it. + + Test: fast/events/crash-on-mutate-during-drop.html + + * editing/MoveSelectionCommand.cpp: + (WebCore::MoveSelectionCommand::doApply): + +2009-03-03 Jungshik Shin + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=23028 + Enable dynamic web font support to Chromium on Windows. + Files that were omitted by mistake in the latest patch + that was landed. + + * loader/CachedFont.cpp: + (WebCore::CachedFont::~CachedFont): + (WebCore::CachedFont::ensureCustomFontData): + (WebCore::CachedFont::platformDataFromCustomData): + (WebCore::CachedFont::allClientsRemoved): + * platform/graphics/chromium/FontCustomPlatformData.cpp: + (WebCore::EOTStream::EOTStream): + (WebCore::createFontCustomPlatformData): + * platform/graphics/win/FontCustomPlatformData.cpp: + (WebCore::EOTStream::EOTStream): + (WebCore::createFontCustomPlatformData): + +2009-03-03 Gustavo Noronha Silva + + Reviewed by Alexey Proskuryakov. + + https://bugs.webkit.org/show_bug.cgi?id=16826 + [Gtk] Implement WebKitDownload + + Make the Soup backend able to handle requests without a frame, + since we may have such things now that we support downloads. + + * platform/network/ResourceHandleInternal.h: + * platform/network/soup/ResourceHandleSoup.cpp: + (WebCore::ResourceHandle::start): + +2009-03-03 Dimitri Glazkov + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=24331 + Add custom V8 bindings for Element, Attr, HTMLFrame, and HTMLIFrame. + + * bindings/v8/custom/V8AttrCustom.cpp: Added. + * bindings/v8/custom/V8CustomBinding.cpp: Added. + * bindings/v8/custom/V8CustomBinding.h: Added attribute-checking helpers. + * bindings/v8/custom/V8ElementCustom.cpp: Added. + * bindings/v8/custom/V8HTMLFrameElementCustom.cpp: Added. + * bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Added. + +2009-03-03 Brady Eidson + + Reviewed by Darin Adler + + - Quick looks of various file types is broken + + In http://trac.webkit.org/changeset/40553 there was an attempt to prevent NSURLRequest churn + for non-HTTP loads when the underlying ResourceRequest changed. Unfortunately it was a little + overzealous as the mainDocumentURL is relevant for all loads, not only HTTP/HTTPS loads. + + Partially reverted behavior to always set the mainDocumentURL in situations when we would've + before that patch. + + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::addExtraFieldsToRequest): + + * platform/network/ResourceRequestBase.cpp: + (WebCore::ResourceRequestBase::setMainDocumentURL): + +2009-03-03 Chris Marrin + + Reviewed by Simon Fraser. + + https://bugs.webkit.org/show_bug.cgi?id=24256 + + Added a WebCoreForceSoftwareAnimation flag. + + * platform/graphics/mac/GraphicsLayerCA.mm: + (WebCore::forceSoftwareAnimation): + (WebCore::GraphicsLayerCA::setOpacity): + (WebCore::GraphicsLayerCA::animateTransform): + (WebCore::GraphicsLayerCA::animateFloat): + +2009-03-02 Chris Marrin + + Reviewed by Sam Weinig. + + https://bugs.webkit.org/show_bug.cgi?id=24257 + + Added prototype properties for several classes with constructors that + were missing them, including the one mentioned in the bug. + + Test: fast/dom/Window/custom-constructors.html + + * bindings/js/JSAudioConstructor.cpp: + (WebCore::JSAudioConstructor::JSAudioConstructor): + * bindings/js/JSDOMWindowBase.cpp: + (jsDOMWindowBaseWebKitCSSMatrix): + * bindings/js/JSImageConstructor.cpp: + (WebCore::JSImageConstructor::JSImageConstructor): + * bindings/js/JSOptionConstructor.cpp: + (WebCore::JSOptionConstructor::JSOptionConstructor): + * bindings/js/JSWebKitCSSMatrixConstructor.cpp: + (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor): + * bindings/js/JSWebKitCSSMatrixConstructor.h: + * bindings/js/JSWebKitPointConstructor.cpp: + (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor): + * bindings/js/JSWorkerConstructor.cpp: + (WebCore::JSWorkerConstructor::JSWorkerConstructor): + +2009-03-03 Dimitri Glazkov + + Reviewed by Darin Fisher. + + https://bugs.webkit.org/show_bug.cgi?id=24321 + Add V8 bindings headers. + + * bindings/v8/V8Binding.h: Added. + * bindings/v8/V8Proxy.h: Added. + * bindings/v8/custom/V8CustomBinding.h: Added. + * bindings/v8/custom/V8CustomEventListener.h: Added. + +2009-03-03 Jungshik Shin + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=23803 + Fix an 'off-by-1' error in ChromiumWin's font fallback. + + * platform/graphics/chromium/FontCacheChromiumWin.cpp: + (WebCore::FontCache::getFontDataForCharacters): + +2009-03-03 Jungshik Shin + + Reviewed by Eric Seidel. + + http://bugs.webkit.org/show_bug.cgi?id=23028 + Enable dynamic web font support to Chromium on Windows: Part 1 + - Move OpenTypeUtilities.{cpp,h} to platform/graphics/opentype + from platform/graphics/win because both Windows port and Chromium Windows + port will use them. + - Adjust WebCore.vcproj accordingly. + + * WebCore.vcproj/WebCore.vcproj: + * platform/graphics/opentype: Added. + * platform/graphics/opentype/OpenTypeUtilities.cpp: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.cpp. + * platform/graphics/opentype/OpenTypeUtilities.h: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.h. + * platform/graphics/win/OpenTypeUtilities.cpp: Removed. + * platform/graphics/win/OpenTypeUtilities.h: Removed. + +2009-03-03 Simon Fraser + + Reviewed by Dave Hyatt + + https://bugs.webkit.org/show_bug.cgi?id=24312 + + Take 3D transforms into account when hit testing: + + 1. Maintain a bit on each RenderLayer that is set when the layer + has 3d descendants, so that we know when to fall into the slow + hit testing path. + + 2. Make a ref-counted HitTestingTransformState, which is used to store + an accumulated transform, and the hit test point, and hitTestRect + in the plane of the ancestor non-3d ('flattening') layer. + + It's ref-counted so we can heap allocate it (to avoid stack bloat), + and avoid copying when hitTestLayer calls itself after applying the transform. + + 3. Add logic to hitTestLayer to depth-test just direct descendants, if any have + 3D transforms, or to do deep depth-testing when traversing a preserves-3d + hierarchy. When hit, layers compute a z-offset from the ancestor flattening + layer, which allows for correct depth testing. + + The existing early-return codepath is unaffected when there are no 3d transforms + and no preserve-3d. + + * rendering/RenderLayer.cpp: + (WebCore::RenderLayer::RenderLayer): + (WebCore::RenderLayer::updateTransform): + (WebCore::RenderLayer::dirty3DTransformedDescendantStatus): + (WebCore::RenderLayer::update3DTransformedDescendantStatus): + (WebCore::RenderLayer::hitTest): + (WebCore::computeZOffset): + (WebCore::RenderLayer::createLocalTransformState): + (WebCore::RenderLayer::hitTestLayer): + (WebCore::RenderLayer::hitTestContents): + * rendering/RenderLayer.h: + (WebCore::RenderLayer::preserves3D): + (WebCore::RenderLayer::has3DTransform): + (WebCore::RenderLayer::setHas3DTransformedDescendant): + (WebCore::RenderLayer::has3DTransformedDescendant): + * rendering/RenderLayerBacking.cpp: + * rendering/TransformState.cpp: + (WebCore::TransformState::flatten): + (WebCore::TransformState::mappedPoint): + (WebCore::HitTestingTransformState::move): + (WebCore::HitTestingTransformState::applyTransform): + (WebCore::HitTestingTransformState::flatten): + (WebCore::HitTestingTransformState::mappedPoint): + (WebCore::HitTestingTransformState::mappedQuad): + * rendering/TransformState.h: + (WebCore::TransformState::TransformState): + (WebCore::HitTestingTransformState::create): + (WebCore::HitTestingTransformState::move): + (WebCore::HitTestingTransformState::HitTestingTransformState): + +2009-03-03 Brett Wilson + + Fix uninitialized memory reads in the Chromium Windows transparency + code that were identified by Purify, + + Reviewed by Darin Fisher. + + * platform/graphics/chromium/TransparencyWin.cpp: + (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers): + (WebCore::TransparencyWin::initializeNewContext): + +2009-03-03 Simon Fraser + + Reviewed by Dave Hyatt + + https://bugs.webkit.org/show_bug.cgi?id=24312 + + Factor the code that compute a transform relative to the container + into RenderObject::transformFromContainer(). + + * rendering/RenderBox.cpp: + (WebCore::RenderBox::mapLocalToAbsolutePoint): + (WebCore::RenderBox::mapAbsoluteToLocalPoint): + * rendering/RenderObject.cpp: + (WebCore::RenderObject::transformFromContainer): + * rendering/RenderObject.h: + +2009-03-03 Simon Fraser + + Reviewed by Dave Hyatt + + https://bugs.webkit.org/show_bug.cgi?id=24317 + + Always return |true| from RenderTextControlMultiLine::nodeAtPoint() if + the superclass found a node, otherwise we set the innerNode of the + HitTestResult, but don't actually report that we found a hit. + + * rendering/RenderTextControlMultiLine.cpp: + (WebCore::RenderTextControlMultiLine::nodeAtPoint): + +2009-03-03 Onne Gorter + + Reviewed by Anders Carlsson. + + https://bugs.webkit.org/show_bug.cgi?id=23707 + resizing plugins does not work, because the plugin never gets informed + + Make gtk plugins resize correctly, by sending them the setwindow event + correctly. Also ensure that all plugin eventing is done with correct + locking/calling. Mostly copied from mac implementation. + + manual test: manual-tests/gtk/plugin-resize-scroll.html + + * plugins/PluginView.h: + * plugins/gtk/PluginViewGtk.cpp: + (WebCore::PluginView::dispatchNPEvent): + ensure locking/calling for NPEvents + (WebCore::PluginView::updatePluginWidget): + if something changed, let setNPWindowIfNeeded handle it + (WebCore::PluginView::paint): + (WebCore::PluginView::handleKeyboardEvent): + (WebCore::PluginView::handleMouseEvent): + ensure calling conventions + (WebCore::PluginView::setNPWindowRect): + just pass control to setNPWindowIfNeeded + (WebCore::PluginView::setNPWindowIfNeeded): + event the plugin correctly of new window + (WebCore::PluginView::init): + init through the new setup + +2009-03-03 Mike Belshe + + Reviewed by Darin Fisher. + + https://bugs.webkit.org/show_bug.cgi?id=24311 + Make IDL returning DOMObject use [V8Custom] + + * dom/Document.idl: + * html/HTMLCanvasElement.idl: + +2009-03-02 Simon Fraser + + Reviewed by Adele Peterson + + https://bugs.webkit.org/show_bug.cgi?id=24313 + + If RenderTextControlSingleLine::nodeAtPoint() pokes a node into the + HitTestResult, then it had better well return |true|. And m_innerBlock + could never have been set as the hit node by the superclass, because + the superclass knows nothing about m_innerBlock. + + Test: fast/forms/input-hit-test-border.html + + * rendering/RenderTextControlSingleLine.cpp: + (WebCore::RenderTextControlSingleLine::nodeAtPoint): + +2009-03-02 Sam Weinig + + Reviewed by Mark Rowe. + + Enable Geolocation (except on Tiger and Leopard). + + * Configurations/WebCore.xcconfig: + +2009-03-02 Ojan Vafai + + Reviewed by Adele Peterson. + + Fix https://bugs.webkit.org/show_bug.cgi?id=24307 + Null out m_highlightedNode on hideHighlight(). + Ran WebCore/manual-tests/inspector/highlight-nodes.html. + + * inspector/InspectorController.cpp: + (WebCore::InspectorController::hideHighlight): + +2009-03-02 Sam Weinig + + Reviewed by Geoffrey Garen. + + Fix for Add Geolocation support. + + This is not yet turned on for any Mac platform. + + * WebCore.xcodeproj/project.pbxproj: + * page/Chrome.cpp: + (WebCore::Chrome::shouldAllowGeolocationForFrame): + * page/Chrome.h: + * page/ChromeClient.h: + (WebCore::ChromeClient::shouldAllowGeolocationForFrame): + * page/Geolocation.cpp: + (WebCore::Geolocation::Geolocation): + (WebCore::Geolocation::disconnectFrame): Remove call to setUsingGeolocation as the document + will not be alive at this point. + (WebCore::Geolocation::getCurrentPosition): Check if the embedding app allows geolocation and + return a PERMISSION_DENIED if not. + (WebCore::Geolocation::watchPosition): Ditto. + (WebCore::Geolocation::shouldAllowGeolocation): Perform request to embedding layer of whether + to allow geolocation and cache the result. + * page/Geolocation.h: + (WebCore::Geolocation::): + * platform/GeolocationService.cpp: + * platform/GeolocationService.h: + (WebCore::GeolocationService::~GeolocationService): + (WebCore::GeolocationService::stopUpdating): + * platform/mac/GeolocationServiceMac.h: Added. + (WebCore::GeolocationServiceMac::lastPosition): + (WebCore::GeolocationServiceMac::lastError): + * platform/mac/GeolocationServiceMac.mm: Added. + (WebCore::GeolocationService::create): + (WebCore::GeolocationServiceMac::GeolocationServiceMac): + (WebCore::GeolocationServiceMac::~GeolocationServiceMac): + (WebCore::GeolocationServiceMac::startUpdating): + (WebCore::GeolocationServiceMac::stopUpdating): + (WebCore::GeolocationServiceMac::suspend): + (WebCore::GeolocationServiceMac::resume): + (WebCore::GeolocationServiceMac::positionChanged): + (WebCore::GeolocationServiceMac::errorOccurred): + (-[WebCoreCoreLocationObserver initWithCallback:]): + (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]): + (-[WebCoreCoreLocationObserver locationManager:didFailWithError:]): + +2009-03-02 Kevin Ollivier + + Build fixes for wxWidgets Mac trunk build. + + * platform/wx/wxcode/mac/carbon/fontprops.cpp: + (wxFontProperties::wxFontProperties): + (GetTextExtent): + * webcore-wx.bkl: + +2009-03-02 Kevin Ollivier + + wxGTK missing header build fix. + + * platform/wx/wxcode/gtk/fontprops.cpp: + +2009-03-02 Dan Bernstein + + Reviewed by Adam Roben. + + - fix https://bugs.webkit.org/show_bug.cgi?id=21811 + REGRESSION: Windows Build Not Selecting Proper Font + + * platform/graphics/win/FontCacheWin.cpp: + (WebCore::createGDIFont): Added back code to verify that the created + HFONT has the requested face name. + +2009-03-02 Timothy Hatcher + + Fixes a regression caused by splitting the input and output of console commands. + + https://bugs.webkit.org/show_bug.cgi?id=24293 + + Reviewed by Kevin McCullough. + + * inspector/front-end/Console.js: + (WebInspector.Console.prototype.addMessage): Don't treat ConsoleCommandResult as a + normal ConsoleMessage when appending. This prevents resetting repeatCounts incorrectly. + +2009-03-02 Timothy Hatcher + + Make exception messages and logged Error objects display consistently. + + https://bugs.webkit.org/show_bug.cgi?id=18983 + + Reviewed by Adam Roben. + + * English.lproj/localizedStrings.js: Remove a string for line numbers. + * inspector/front-end/Console.js: + (WebInspector.Console.prototype._enterKeyPressed): Pass the exception + boolean to the ConsoleCommandResult constructor and don't pass level. + (WebInspector.Console.prototype._formatnode): Fix a className typo. + (WebInspector.Console.prototype._formaterror): Add an error-message + classed span around the message to show in red and remove the + console-message-url class from the link so it doesn't float right. + Instead enclose the link in parentheses and use displayNameForURL + to shorten the URL in the link. + (WebInspector.ConsoleMessage.prototype.toMessageElement): Simplify + how line numbers are shown since link underlining a string with + parentheses looks bad. + (WebInspector.ConsoleCommandResult): Take an exception boolean flag + instead of a level and get line and URL based on that flag. + * inspector/front-end/inspector.css: Tweaks to the styles. + +2009-03-02 Ojan Vafai + + Reviewed by Adele Peterson. + + Bug 24048: extra windows button padding doesn't apply when there's no appearance + + + Replace adjustButtonInnerStyle with buttonInternalPaddingLeft/Right/Top/Bottom. + + No tests added as existing tests already cover this behavior. + + * rendering/RenderButton.cpp: + (WebCore::RenderButton::setupInnerStyle): + * rendering/RenderTheme.cpp: + * rendering/RenderTheme.h: + (WebCore::RenderTheme::buttonInternalPaddingLeft): + (WebCore::RenderTheme::buttonInternalPaddingRight): + (WebCore::RenderTheme::buttonInternalPaddingTop): + * rendering/RenderThemeChromiumGtk.cpp: + (WebCore::RenderThemeWin::buttonInternalPaddingLeft): + (WebCore::RenderThemeWin::buttonInternalPaddingRight): + (WebCore::RenderThemeWin::buttonInternalPaddingTop): + (WebCore::RenderThemeWin::buttonInternalPaddingBottom): + * rendering/RenderThemeChromiumGtk.h: + * rendering/RenderThemeChromiumWin.cpp: + (WebCore::RenderThemeChromiumWin::buttonInternalPaddingLeft): + (WebCore::RenderThemeChromiumWin::buttonInternalPaddingRight): + (WebCore::RenderThemeChromiumWin::buttonInternalPaddingTop): + (WebCore::RenderThemeChromiumWin::buttonInternalPaddingBottom): + * rendering/RenderThemeChromiumWin.h: + * rendering/RenderThemeWin.cpp: + (WebCore::RenderThemeWin::buttonInternalPaddingLeft): + (WebCore::RenderThemeWin::buttonInternalPaddingRight): + (WebCore::RenderThemeWin::buttonInternalPaddingTop): + (WebCore::RenderThemeWin::buttonInternalPaddingBottom): + * rendering/RenderThemeWin.h: + +2009-03-02 Adam Treat + + Build fix for Qt port. Remove unnecessary assert. + + * platform/graphics/qt/ImageBufferQt.cpp: + (WebCore::ImageBuffer::putImageData): + +2009-03-02 Adam Treat + + Reviewed by Adam Roben and previously by Eric Seidel and Simon Fraser. + + https://bugs.webkit.org/show_bug.cgi?id=24227 + Ensure that the checkForSolidColor() optimization is correctly triggered + for all cases of drawPattern. Currently, the optimization was not triggered + when the check had not been previously performed via a request for the + image's NativeImagePtr. + + Implement the Qt version of the checkForSolidColor() method. Combined with + the bug fix this reduces the time it takes to draw a repeating background + of a 1x1 image from ~50msecs to ~0msecs on my machine. + + * platform/graphics/BitmapImage.cpp: + (WebCore::BitmapImage::BitmapImage): + * platform/graphics/BitmapImage.h: + (WebCore::BitmapImage::mayFillWithSolidColor): + * platform/graphics/Image.h: + (WebCore::Image::mayFillWithSolidColor): + * platform/graphics/cairo/ImageCairo.cpp: + (WebCore::BitmapImage::BitmapImage): + (WebCore::BitmapImage::checkForSolidColor): + * platform/graphics/cg/ImageCG.cpp: + (WebCore::BitmapImage::BitmapImage): + (WebCore::BitmapImage::checkForSolidColor): + * platform/graphics/qt/ImageQt.cpp: + (WebCore::BitmapImage::checkForSolidColor): + * platform/graphics/skia/ImageSkia.cpp: + (WebCore::BitmapImage::checkForSolidColor): + * platform/graphics/wx/ImageWx.cpp: + (WebCore::BitmapImage::checkForSolidColor): + +2009-03-02 Gustavo Noronha Silva + + Unreviewed build fix; adding missing files to EXTRA_DIST, so that + they show up in the tarball. + + * GNUmakefile.am: + +2009-03-02 Dirk Schulze + + Reviewed by Holger Freyther. + + Added putImageData to Qt. Discussed with Ariya Hidayat. + + [Qt] lacks putImageData support in Canvas + https://bugs.webkit.org/show_bug.cgi?id=22186 + + * platform/graphics/qt/ImageBufferQt.cpp: + (WebCore::ImageBuffer::putImageData): + +2009-03-02 Timothy Hatcher + + Show exception messages again when evaluating bad expressions in the + Web Inspector's console. + + https://bugs.webkit.org/show_bug.cgi?id=19890 + + Reviewed by Oliver Hunt. + + * bindings/js/JSQuarantinedObjectWrapper.cpp: + (WebCore::JSQuarantinedObjectWrapper::transferExceptionToExecState): + Fix the order in which the exception is set and cleared now that the + exception is stored in the shared GlobalData, not per ExecState. + +2009-02-28 Timothy Hatcher + + Make input in the Web Inspector console print before any output + that might be added by the called function. + + https://bugs.webkit.org/show_bug.cgi?id=19931 + + Reviewed by Oliver Hunt. + + * inspector/front-end/Console.js: + (WebInspector.Console.prototype._enterKeyPressed): Add the command + message before evaluating the result. Associate the originating + command to the result, so if they are adjacent there is no divider. + (WebInspector.ConsoleCommand): No longer take a result. + (WebInspector.ConsoleCommand.prototype.toMessageElement): Result + code removed since it isn't used now. + (WebInspector.ConsoleCommandResult): Subclass ConsoleMessage. + (WebInspector.ConsoleCommandResult.prototype.toMessageElement): + Call the ConsoleMessage toMessageElement and add a style class. + * inspector/front-end/inspector.css: Add a new style class for + adjacent results to hide the divider. Also tweak the position of + the disclosure triangle for objects to not use the left margin. + +2009-03-01 Chris Fleizach + + Reviewed by Oliver Hunt. + + Bug 24282: AX Palindrome error when asking for a specific index of the AXChildren array + + + When fetching an array of elements with a range, attachment views need to be returned + instead of the actual attachment. + + * page/mac/AccessibilityObjectWrapper.mm: + (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]): + (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]): + +2009-03-01 Ojan Vafai + + Reviewed by Eric Seidel. + + Bug 24251: Cleanup: replace positionForCoordinates with positionForPoint + + + Make RenderObject::positionForCoordinate non-virtual and + RenderObject::positionForPoint virtual in preparation for + removing positionFor* from RenderObject/RenderText. + + * page/Frame.cpp: + (WebCore::Frame::visiblePositionForPoint): + * rendering/RenderBR.cpp: + (WebCore::RenderBR::positionForPoint): + * rendering/RenderBR.h: + * rendering/RenderBlock.cpp: + (WebCore::RenderBlock::positionForPoint): + * rendering/RenderBlock.h: + * rendering/RenderBox.cpp: + (WebCore::RenderBox::positionForPoint): + * rendering/RenderBox.h: + * rendering/RenderInline.cpp: + (WebCore::RenderInline::positionForPoint): + * rendering/RenderInline.h: + * rendering/RenderObject.cpp: + (WebCore::RenderObject::positionForCoordinates): + (WebCore::RenderObject::positionForPoint): + * rendering/RenderObject.h: + * rendering/RenderReplaced.cpp: + (WebCore::RenderReplaced::positionForPoint): + * rendering/RenderReplaced.h: + * rendering/RenderSVGInlineText.cpp: + (WebCore::RenderSVGInlineText::positionForPoint): + * rendering/RenderSVGInlineText.h: + * rendering/RenderText.cpp: + (WebCore::RenderText::positionForPoint): + * rendering/RenderText.h: + +2009-03-01 Larry Ewing + + Reviewed by Alexey Proskuryakov. + + https://bugs.webkit.org/show_bug.cgi?id=24080 + NPN_GetValue casting to the wrong type and writing outside bounds + + Make sure to cast the value to the correct type so that only + memory owned by the value is written to. + + * plugins/gtk/PluginViewGtk.cpp (PluginView::getValueStatic): + * plugins/qt/PluginViewQt.cpp (PluginView::getValueStatic): + * plugins/mac/PluginViewMac.cpp (PluginView::getValueStatic): + (PluginView::getValue): + +2009-03-01 Jeremy Moskovich + + Reviewed by Simon Fraser. + + https://bugs.webkit.org/show_bug.cgi?id=24197 and + https://bugs.webkit.org/show_bug.cgi?id=23512 + + The Windows version of cgColor() is conditionally compiled using + !PLATFORM(MAC) change this to PLATFORM(WIN_OS) so that Chrome + can use the OS X version instead of the Windows version. + + Also rename cgColor() -> createCGColor() + + No observable change in behavior, so no test. + + * platform/graphics/Color.h: + * platform/graphics/cg/ColorCG.cpp: + (WebCore::createCGColor): + * platform/graphics/cg/GraphicsContextCG.cpp: + (WebCore::GraphicsContext::setPlatformShadow): + * platform/graphics/mac/ColorMac.mm: + (WebCore::createCGColor): + * platform/graphics/mac/GraphicsContextMac.mm: + (WebCore::GraphicsContext::drawFocusRing): + * platform/graphics/mac/GraphicsLayerCA.mm: + (WebCore::setLayerBorderColor): + (WebCore::setLayerBackgroundColor): + (WebCore::GraphicsLayerCA::setBackgroundColor): + * platform/graphics/win/GraphicsContextCGWin.cpp: + (WebCore::GraphicsContext::drawFocusRing): + * svg/graphics/filters/cg/SVGFEHelpersCg.mm: + (WebCore::ciColor): + +2009-03-01 David Levin + + Reviewed by Alexey Proskuryakov. + + Bug 24271: XMLHttpRequest needs js bindings for Workers. + + + Tests: http/tests/xmlhttprequest/workers/methods-async.html + http/tests/xmlhttprequest/workers/methods.html + + * bindings/js/JSWorkerContextBase.cpp: + (WebCore::JSWorkerContextBase::getOwnPropertySlot): + (jsWorkerContextBaseXMLHttpRequest): + (setJSWorkerContextBaseXMLHttpRequest): + Expose XMLHttpRequest to Workers. + + * bindings/js/JSWorkerContextBase.h: + + * bindings/js/JSXMLHttpRequestConstructor.cpp: + (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor): + (WebCore::constructXMLHttpRequest): + (WebCore::JSXMLHttpRequestConstructor::mark): + Removed the dependencies on Document. + + * bindings/js/JSXMLHttpRequestConstructor.h: + (WebCore::JSXMLHttpRequestConstructor::scriptExecutionContext): + * dom/EventException.idl: + * dom/EventListener.idl: + Change to have the NoStaticTables attribute since they are used from XHR. + + * loader/WorkerThreadableLoader.cpp: + (WebCore::workerContextDidFinishLoading): + (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading): + Fixed identifier to be unsigned long. + + * loader/WorkerThreadableLoader.h: + * workers/WorkerThread.cpp: + (WebCore::WorkerThread::workerThread): + Stop active objects when the thread is getting shutdown so that xhr gets properly shutdown. + + * xml/XMLHttpRequestUpload.cpp: + + * xml/XMLHttpRequest.idl: + * xml/XMLHttpRequestException.idl: + * xml/XMLHttpRequestProgressEvent.idl: + * xml/XMLHttpRequestUpload.idl: + Change to have the NoStaticTables attribute since they are used from XHR. + +2009-03-01 Horia Olaru + + Adding manual debugger test cases for bug. + + https://bugs.webkit.org/show_bug.cgi?id=21073 + + Reviewed by Kevin McCullough. + + * manual-tests/inspector/debugger-step-on-do-while-statements.html: Added. + * manual-tests/inspector/debugger-step-on-for-in-statements.html: Added. + * manual-tests/inspector/debugger-step-on-for-statements.html: Added. + * manual-tests/inspector/debugger-step-on-while-statements.html: Added. + * manual-tests/inspector/resources/loop-statements.js: Added. + +2009-03-01 Dan Bernstein + + Reviewed by Darin Adler. + + - fix Reproducible crash in RenderLayer::updateScrollCornerStyle() using full-page zoom at MobileMe Contacts + + Test: fast/events/scroll-during-zoom-change.html + + * dom/Document.cpp: + (WebCore::Document::recalcStyle): Pause scheduled events during style + reclaculation. Changes to the zoom property result in scroll events + being generated during style recalc, and those events need to be + deferred until the render tree is consistent. + * page/FrameView.cpp: + (WebCore::FrameView::layout): Changed to account for a case in which the + post-layout tasks trigger a nested layout, which reactivates the + post-layout task timer. + +2009-03-01 Ross Boucher + + Alphabetically sort scripts in the Script's panel file popup menu. + + https://bugs.webkit.org/show_bug.cgi?id=23395 + + Reviewed by Timothy Hatcher. + + * inspector/front-end/ScriptsPanel.js: + (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu): + * inspector/front-end/utilities.js: + (insertionIndexForObjectInListSortedByFunction): + (indexOfObjectInListSortedByFunction): + +2009-03-01 Yael Aharon + + Pass securityOrigin->host() instead of securityOrigin->domain() to WebInspector + when creating databases, localStorage or sessionStorage. Changing document.domain + should have no affect on databases, localStorage and sessionStorage in Web Inspector. + + https://bugs.webkit.org/show_bug.cgi?id=23844 + + Reviewed by Timothy Hatcher. + + * inspector/InspectorController.cpp: + (WebCore::InspectorController::addDOMStorageScriptResource): + (WebCore::InspectorController::didUseDOMStorage): + * storage/Database.cpp: + (WebCore::Database::openDatabase): + +2009-03-01 Gustavo Noronha Silva + + Reviewed by Holger Freyther. + + Avoid leaking errors when reporting GIO errors. + + * platform/network/soup/ResourceHandleSoup.cpp: + (WebCore::readCallback): + (WebCore::openCallback): + (WebCore::queryInfoCallback): + +2009-03-01 Gustavo Noronha Silva + + Reviewed by Holger Freyther. + + Fixes crash when the GIO backend is given the URI for a directory. + + * platform/network/soup/ResourceHandleSoup.cpp: + (WebCore::networkErrorForFile): + +2009-02-28 Dimitri Glazkov + + Reviewed by Darin Fisher. + + https://bugs.webkit.org/show_bug.cgi?id=24261 + Fix V8 custom binding scrubbing error. + + Test: fast/dom/TreeWalker/TreeWalker-currentNode.html + Test: traversal/exception-forwarding.html + TesT: traversal/stay-within-root.html + + * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: + * bindings/v8/custom/V8NodeIteratorCustom.cpp: + (WebCore::toV8): Replace v8::Undefined() return value with v8::Null(). + * bindings/v8/custom/V8TreeWalkerCustom.cpp: + (WebCore::toV8): Ditto. + +2009-02-28 Dimitri Glazkov + + Reviewed by Darin Fisher. + + https://bugs.webkit.org/show_bug.cgi?id=24261 + Fix V8 custom binding scrubbing error. + + Test: fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html + + * WebCore.xcodeproj/project.pbxproj: + * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: + (WebCore::cssPropertyName): Remove dubious checks, left over from + incomplete conversion of parameter from pointer to pass-by-ref. + (WebCore::NAMED_PROPERTY_GETTER): Initialize parameter. + (WebCore::NAMED_PROPERTY_SETTER): Ditto. + +2009-02-28 Xan Lopez + + Reviewed by Holger Freyther. + + https://bugs.webkit.org/show_bug.cgi?id=24263 + [GTK] ref ResourceHandle until we are finished with it + + Add a ref to the ResourceHandle in startHttp so we can keep it + alive untill all callbacks have been executed, and unref it when + soup tells us it's done with the SoupMessage (in + finishedCallback). Fixes a number of crashes when calling + didReceiveData whould crash because of the handle dying. + + * platform/network/soup/ResourceHandleSoup.cpp: + (WebCore::finishedCallback): + (WebCore::ResourceHandle::startHttp): + +2009-02-28 Adam Bergkvist + + Reviewed by Alexey Proskuryakov. + + https://bugs.webkit.org/show_bug.cgi?id=24226 + [SOUP] HTTP status text is never set + + Set HTTP status text to SoupMessage reason_phrase. + + * platform/network/soup/ResourceHandleSoup.cpp: + (WebCore::fillResponseFromMessage): + +2009-02-28 Dan Bernstein + + - fix malformed project file + + * WebCore.xcodeproj/project.pbxproj: + +2009-02-28 Dan Bernstein + + Reviewed by Oliver Hunt. + + - fix https://bugs.webkit.org/show_bug.cgi?id=23848 + REGRESSION: Crash when mouse cursor moves over a link on www.opportuno.de + + Test: fast/layers/inline-dirty-z-order-lists.html + + * rendering/RenderBox.cpp: + (WebCore::RenderBox::styleWillChange): Moved the code that dirties a + layer's and its stacking context's z-order lists when the layer's + z-index or visibility change from here... + * rendering/RenderBoxModelObject.cpp: + (WebCore::RenderBoxModelObject::styleWillChange): ...to here, so that + it will apply to RenderInline too. + +2009-02-27 Alexey Proskuryakov + + Reviewed by David Hyatt. + + Don't include TextResourceDecoder.h in Document.h + + This undoes inlining of Document::displayStringModifiedByEncoding() to avoid world rebuilds + when TextResourceDecoder.h is modified. Performance impact is expected to be negligible. + + * dom/Document.cpp: + (WebCore::Document::displayStringModifiedByEncoding): + (WebCore::Document::displayBufferModifiedByEncoding): + * dom/Document.h: + * WebCore.base.exp: + +2009-02-27 Matt Pennig + + Reviewed by David Hyatt. + + Resolves: https://bugs.webkit.org/show_bug.cgi?id=24107 + "Fixed elements have 0 as an offsetLeft property" + + Code also brings offsetLeft/Top in full conformance with the spec. + Added two tests, one for fixed-position elements, and one for . + + Tests: fast/dom/Element/fixed-position-offset-parent.html + fast/dom/Element/offsetLeft-offsetTop-html.html + + * rendering/RenderBoxModelObject.cpp: + (WebCore::RenderBoxModelObject::offsetLeft): + (WebCore::RenderBoxModelObject::offsetTop): + +2009-02-27 Dean Jackson + + Reviewed by Simon Fraser. + + renderer()->hasTransform() returns true for elements + with perspective, but no transform, so test for transform + when hit testing. This fixes ASSERT from + https://bugs.webkit.org/show_bug.cgi?id=24252 + + Test: transforms/no_transform_hit_testing.html + + * rendering/RenderLayer.cpp: + (WebCore::RenderLayer::hitTestLayer): + +2009-02-27 Dimitri Glazkov + + Reviewed by Darin Fisher. + + Fix scrubbing error -- a reversed condition. + + * bindings/v8/ScriptValue.h: + (WebCore::ScriptValue::clear): Change early exit for empty value, not the opposite. + +2009-02-27 Jian Li + + Reviewed by Alexey Proskuryakov. + + Add confirmMessageFromWorkerObject to WorkerObjectProxy. + https://bugs.webkit.org/show_bug.cgi?id=24152 + + * workers/WorkerMessagingProxy.cpp: + (WebCore::MessageWorkerContextTask::performTask): + (WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject): + * workers/WorkerMessagingProxy.h: + * workers/WorkerObjectProxy.h: + +2009-02-27 Anders Carlsson + + Reviewed by David Hyatt. + + Revert r41295, the fix for https://bugs.webkit.org/show_bug.cgi?id=24227 + because it leads to assertion failures in the Mac port. + + * platform/graphics/BitmapImage.cpp: + (WebCore::BitmapImage::BitmapImage): + * platform/graphics/BitmapImage.h: + (WebCore::BitmapImage::mayFillWithSolidColor): + * platform/graphics/Image.h: + (WebCore::Image::mayFillWithSolidColor): + * platform/graphics/cairo/ImageCairo.cpp: + (WebCore::BitmapImage::BitmapImage): + * platform/graphics/cg/ImageCG.cpp: + (WebCore::BitmapImage::BitmapImage): + (WebCore::BitmapImage::checkForSolidColor): + * platform/graphics/qt/ImageQt.cpp: + (WebCore::BitmapImage::checkForSolidColor): + * platform/graphics/skia/ImageSkia.cpp: + (WebCore::BitmapImage::checkForSolidColor): + * platform/graphics/wx/ImageWx.cpp: + (WebCore::BitmapImage::checkForSolidColor): + +2009-02-27 Adam Barth + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=20249 + + Add a preference to allow universal access from local URLs to mitigate + some attacks. Some clients still want to allow this access, so we + expose this as a preference. + + * WebCore.base.exp: + * dom/Document.cpp: + (WebCore::Document::initSecurityContext): + * page/SecurityOrigin.cpp: + (WebCore::SecurityOrigin::SecurityOrigin): + * page/Settings.cpp: + (WebCore::Settings::Settings): + (WebCore::Settings::setAllowUniversalAccessFromFileUrls): + * page/Settings.h: + (WebCore::Settings::allowUniversalAccessFromFileUrls): + +2009-02-27 Adam Treat + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=24229 + If an image has no alpha channel there is no reason to use SourceOver. + + * platform/graphics/qt/ImageQt.cpp: + (WebCore::Image::drawPattern): + (WebCore::BitmapImage::draw): + +2009-02-27 Adam Treat + + Reviewed by Eric Seidel and Simon Fraser. + + https://bugs.webkit.org/show_bug.cgi?id=24227 + Ensure that the checkForSolidColor() optimization is correctly triggered + for all cases of drawPattern. Currently, the optimization was not triggered + when the check had not been previously performed via a request for the + image's NativeImagePtr. + + Implement the Qt version of the checkForSolidColor() method. Combined with + the bug fix this reduces the time it takes to draw a repeating background + of a 1x1 image from ~50msecs to ~0msecs on my machine. + + * platform/graphics/BitmapImage.cpp: + (WebCore::BitmapImage::BitmapImage): + * platform/graphics/BitmapImage.h: + (WebCore::BitmapImage::mayFillWithSolidColor): + * platform/graphics/Image.h: + (WebCore::Image::mayFillWithSolidColor): + * platform/graphics/cairo/ImageCairo.cpp: + (WebCore::BitmapImage::BitmapImage): + * platform/graphics/cg/ImageCG.cpp: + (WebCore::BitmapImage::BitmapImage): + (WebCore::BitmapImage::checkForSolidColor): + * platform/graphics/qt/ImageQt.cpp: + (WebCore::BitmapImage::checkForSolidColor): + * platform/graphics/skia/ImageSkia.cpp: + (WebCore::BitmapImage::checkForSolidColor): + * platform/graphics/wx/ImageWx.cpp: + (WebCore::BitmapImage::checkForSolidColor): + +2009-02-27 Dirk Schulze + + Reviewed by Zack Rusin. + + Added support for gradients and pattern on Fonts for Qt. + + [Qt] gradients and patterns for FontQt + https://bugs.webkit.org/show_bug.cgi?id=24243 + + * platform/graphics/qt/FontQt.cpp: + (WebCore::Font::drawComplexText): + +2009-02-27 Jian Li + + Reviewed by Alexey Proskuryakov. + + WorkerContextProxy::create in WorkerMessagingProxy.cpp should only be provided for non-Chromium platform. + https://bugs.webkit.org/show_bug.cgi?id=24113 + + * workers/WorkerMessagingProxy.cpp: + +2009-02-27 Yael Aharon + + Added a refresh button to storage views. + + https://bugs.webkit.org/show_bug.cgi?id=24040 + + Reviewed by Timothy Hatcher. + + * inspector/front-end/DOMStorageItemsView.js: + (WebInspector.DOMStorageItemsView): + (WebInspector.DOMStorageItemsView.prototype.get statusBarItems): + (WebInspector.DOMStorageItemsView.prototype.update): + (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked): + * inspector/front-end/DatabaseTableView.js: + (WebInspector.DatabaseTableView): + (WebInspector.DatabaseTableView.prototype.get statusBarItems): + (WebInspector.DatabaseTableView.prototype._refreshButtonClicked): + * inspector/front-end/DatabasesPanel.js: + (WebInspector.DatabasesPanel): + (WebInspector.DatabasesPanel.prototype.get statusBarItems): + (WebInspector.DatabasesPanel.prototype.reset): + (WebInspector.DatabasesPanel.prototype.showDatabase): + (WebInspector.DatabasesPanel.prototype.showDOMStorage): + (WebInspector.DatabasesPanel.prototype._updateSidebarWidth): + * inspector/front-end/inspector.css: + +2009-02-27 Yael Aharon + + Added support for editing/deleting localStorage and sessionStorage items + directly from Web Inspector. + + https://bugs.webkit.org/show_bug.cgi?id=23866. + + Reviewed by Timothy Hatcher. + + * WebCore.vcproj/WebCore.vcproj: + * inspector/front-end/DOMStorageDataGrid.js: Added. + (WebInspector.DOMStorageDataGrid): + (WebInspector.DOMStorageDataGrid.prototype._ondblclick): + (WebInspector.DOMStorageDataGrid.prototype._startEditing): + (WebInspector.DOMStorageDataGrid.prototype._editingCommitted): + (WebInspector.DOMStorageDataGrid.prototype._editingCancelled): + (WebInspector.DOMStorageDataGrid.prototype.deleteSelectedRow): + * inspector/front-end/DOMStorageItemsView.js: + (WebInspector.DOMStorageItemsView): + (WebInspector.DOMStorageItemsView.prototype.get statusBarItems): + (WebInspector.DOMStorageItemsView.prototype.hide): + (WebInspector.DOMStorageItemsView.prototype.update): + (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked): + * inspector/front-end/DatabasesPanel.js: + (WebInspector.DatabasesPanel): + (WebInspector.DatabasesPanel.prototype.get statusBarItems): + (WebInspector.DatabasesPanel.prototype.reset): + (WebInspector.DatabasesPanel.prototype.showDOMStorage): + (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage): + (WebInspector.DatabasesPanel.prototype._updateSidebarWidth): + * inspector/front-end/WebKit.qrc: + * inspector/front-end/inspector.css: + * inspector/front-end/inspector.html: + +2009-02-26 Brett Wilson + + Fix Windows transparency for the Chromium port. Implement a helper + class for handling transparency on Windows. It allows semitransparent + ClearType and semitransparent form controls by making new layers in the + background. + + It also replaces the "ThemeHelper" which allows better + scaling and transforms on Windows form controls. In addition to the + functionality that the ThemeHelper did, but additionally handles the + antialiasing properly so that the form controls aren't composited on a + white square. + + https://bugs.webkit.org/show_bug.cgi?id=24101 + + Reviewed by Eric Seidel. + + * platform/graphics/chromium/FontChromiumWin.cpp: + (WebCore::): + (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter): + (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI): + (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter): + (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::drawGlyphs): + (WebCore::Font::drawGlyphs): + * platform/graphics/chromium/ThemeHelperChromiumWin.cpp: + * platform/graphics/chromium/ThemeHelperChromiumWin.h: + * platform/graphics/chromium/TransparencyWin.cpp: Added. + (WebCore::): + (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers): + (WebCore::TransparencyWin::OwnedBuffers::destBitmap): + (WebCore::TransparencyWin::OwnedBuffers::referenceBitmap): + (WebCore::TransparencyWin::OwnedBuffers::canHandleSize): + (WebCore::TransparencyWin::TransparencyWin): + (WebCore::TransparencyWin::~TransparencyWin): + (WebCore::TransparencyWin::init): + (WebCore::TransparencyWin::computeLayerSize): + (WebCore::TransparencyWin::setupLayer): + (WebCore::TransparencyWin::setupLayerForNoLayer): + (WebCore::TransparencyWin::setupLayerForOpaqueCompositeLayer): + (WebCore::TransparencyWin::setupLayerForTextComposite): + (WebCore::TransparencyWin::setupLayerForWhiteLayer): + (WebCore::TransparencyWin::setupTransform): + (WebCore::TransparencyWin::setupTransformForKeepTransform): + (WebCore::TransparencyWin::setupTransformForUntransform): + (WebCore::TransparencyWin::setupTransformForScaleTransform): + (WebCore::TransparencyWin::setTextCompositeColor): + (WebCore::TransparencyWin::initializeNewContext): + (WebCore::TransparencyWin::compositeOpaqueComposite): + (WebCore::TransparencyWin::compositeTextComposite): + (WebCore::TransparencyWin::makeLayerOpaque): + * platform/graphics/chromium/TransparencyWin.h: Added. + (WebCore::TransparencyWin::): + (WebCore::TransparencyWin::context): + (WebCore::TransparencyWin::platformContext): + (WebCore::TransparencyWin::drawRect): + * platform/graphics/skia/GraphicsContextSkia.cpp: + (WebCore::GraphicsContext::endTransparencyLayer): + * platform/graphics/skia/ImageSkia.cpp: + (WebCore::paintSkBitmap): + * rendering/RenderThemeChromiumWin.cpp: + (WebCore::): + (WebCore::RenderThemeChromiumWin::paintButton): + (WebCore::RenderThemeChromiumWin::paintMenuList): + (WebCore::RenderThemeChromiumWin::paintTextFieldInternal): + +2009-02-27 Dimitri Glazkov + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=24211 + Add ScheduledAction for V8. + + * bindings/v8/ScheduledAction.cpp: Added. + (WebCore::ScheduledAction::ScheduledAction): + (WebCore::ScheduledAction::~ScheduledAction): + (WebCore::ScheduledAction::execute): + * bindings/v8/ScheduledAction.h: Added. + (WebCore::ScheduledAction::ScheduledAction): + +2009-02-27 Zack Rusin + + Reviewed by Nikolas Zimmermann. + + Qt: be more reasonable about scrolled lines + + cMouseWheelPixelsPerLineStep is currently a constant set to 13.3. it doesn't + match our metrics meaning that Qt scrolls by ~2 lines by default which is quite + irritating. so lets scroll vertically by the Qt set number of lines * Qt default + single step scroll + + * platform/qt/WheelEventQt.cpp: + +2009-02-27 Xan Lopez + + Rubber-stamped by Alexey Proskuryakov. + + https://bugs.webkit.org/show_bug.cgi?id=24222 + [GTK] Remove checks for old glib versions + + libsoup, which is a hard dependency, needs at least glib 2.15.3, + so remove all glib checks for versions older than that. + + * platform/gtk/ContextMenuGtk.cpp: + (WebCore::ContextMenu::ContextMenu): + * platform/gtk/ContextMenuItemGtk.cpp: + (WebCore::ContextMenuItem::setSubMenu): + * platform/gtk/PopupMenuGtk.cpp: + (WebCore::PopupMenu::show): + * platform/gtk/WidgetGtk.cpp: + (WebCore::Widget::retainPlatformWidget): + * platform/network/soup/ResourceHandleSoup.cpp: + +2009-02-26 Dirk Schulze + + Reviewed by Oliver Hunt. + + Added support for Gradients and Patterns on filled or stroked Fonts + in Cairo. I also added support for globalAlpha on FontCairo. + + [CAIRO] SVG/Canvas fonts miss gradients/pattern support + https://bugs.webkit.org/show_bug.cgi?id=18617 + + * html/CanvasRenderingContext2D.cpp: + (WebCore::CanvasRenderingContext2D::drawTextInternal): + * platform/graphics/cairo/FontCairo.cpp: + (WebCore::Font::drawGlyphs): + +2009-02-26 Stephen White + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=23957 + + Fix for SVG gradient and pattern text for Chromium/skia. + Added accessors for the fill and stroke gradients to + GraphicsContext. Changed the paintSkiaText function to take a + GraphicsContext, so we can check for gradients/patterns. + Changed the skiaDrawText function to set the SkPaint shader + correctly, and to scale up the gradient shader matrix to + encompass the entire text string. Also offset each glyph + separately, rather than transforming the canvas, so that the + gradient/pattern stays fixed relative to the text origin. + + * platform/graphics/GraphicsContext.cpp: + (WebCore::GraphicsContext::getFillGradient): + (WebCore::GraphicsContext::getStrokeGradient): + (WebCore::GraphicsContext::getFillPattern): + (WebCore::GraphicsContext::getStrokePattern): + * platform/graphics/GraphicsContext.h: + * platform/graphics/chromium/FontChromiumWin.cpp: + (WebCore::Font::drawGlyphs): + * platform/graphics/chromium/UniscribeHelper.cpp: + (WebCore::UniscribeHelper::draw): + * platform/graphics/skia/SkiaFontWin.cpp: + (WebCore::windowsCanHandleTextDrawing): + (WebCore::skiaDrawText): + (WebCore::paintSkiaText): + * platform/graphics/skia/SkiaFontWin.h: + +2009-02-26 Dimitri Glazkov + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=24208 + Add custom V8 bindings for Navigator, Clipboard, Document, and Node. + + * bindings/v8/custom/V8ClipboardCustom.cpp: Added. + (WebCore::ACCESSOR_GETTER): + (WebCore::CALLBACK_FUNC_DECL): + * bindings/v8/custom/V8DocumentCustom.cpp: Added. + (WebCore::CALLBACK_FUNC_DECL): + * bindings/v8/custom/V8NavigatorCustom.cpp: Added. + (WebCore::ACCESSOR_GETTER): + * bindings/v8/custom/V8NodeCustom.cpp: Added. + (WebCore::CALLBACK_FUNC_DECL): + +2009-02-26 Gustavo Noronha Silva + + Unreviewed build fix for building with GNOME Keyring enabled. + + * platform/network/soup/webkit-soup-auth-dialog.c: + (show_auth_dialog): + +2009-02-26 Xan Lopez + + Reviewed by Holger Freyther. + + https://bugs.webkit.org/show_bug.cgi?id=16947 + [GTK] Missing HTTP Auth challenge + + Add HTTP authentication dialog with optional GNOME Keyring + storage. + + * GNUmakefile.am: + * platform/network/ResourceHandleInternal.h: + (WebCore::ResourceHandleInternal::ResourceHandleInternal): + * platform/network/soup/ResourceHandleSoup.cpp: + (WebCore::currentToplevelCallback): + (WebCore::ResourceHandle::startHttp): + (WebCore::ResourceHandle::start): + * platform/network/soup/webkit-soup-auth-dialog.c: Added. + (webkit_soup_auth_dialog_class_init): + (webkit_soup_auth_dialog_init): + (webkit_soup_auth_dialog_session_feature_init): + (free_authData): + (set_password_callback): + (response_callback): + (show_auth_dialog): + (find_password_callback): + (session_authenticate): + (attach): + * platform/network/soup/webkit-soup-auth-dialog.h: Added. + +2009-02-25 Ojan Vafai and Eric Seidel + + Reviewed by Dave Hyatt. + + After Ojan's positionForCoordinates fix http://trac.webkit.org/changeset/41191 + svg/custom/pointer-events-image.svg and svg/custom/pointer-events-text.svg + started failing because Ojan's new code was now *correctly* calling through to + SVG asking for the closest text offset in the last line box, instead of + just returning the offset at the end of the last line box when clicking below a box. + + But! The SVG code was wrong, in that it returned the character offset of the last + character when you asked for a character offset after the end of the box, instead + it should return the offset *after* the last character. This patch fixes + that behavior by reordering the last two clauses in svgCharacterHitsPosition. + + The SVG positionForCoordinates function is still wrong, and I've added some FIXMEs + to document what's wrong. I've also cleaned up the code a bit so it's clearer + what it is doing (which also makes more obvious what's wrong with it). + + * rendering/RenderSVGInlineText.cpp: + (WebCore::RenderSVGInlineText::positionForCoordinates): + * rendering/SVGInlineTextBox.cpp: + (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::SVGInlineTextBoxClosestCharacterToPositionWalker): + (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::chunkPortionCallback): + (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::offsetOfHitCharacter): + (WebCore::SVGInlineTextBox::closestCharacterToPosition): + (WebCore::SVGInlineTextBox::svgCharacterHitsPosition): + +2009-02-26 Darin Fisher + + Reviewed by Eric Seidel. + + Minor cleanup of ChromiumBridge: + Removing unused matchesMIMEType method and s/Javascript/JavaScript/ + + * platform/chromium/ChromiumBridge.h: + * platform/chromium/MimeTypeRegistryChromium.cpp: + (WebCore::MIMETypeRegistry::isSupportedImageMIMEType): + (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType): + (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType): + +2009-02-26 David Hyatt + + Reviewed by Sam Weinig + + Fix text-bottom vertical alignment. It was incorrectly aligning the bottom of the descent instead of including + the line-height below the descent. + + Added fast/inline/vertical-align-text-bottom.html + + * rendering/RenderBoxModelObject.cpp: + (WebCore::RenderBoxModelObject::verticalPosition): + +2009-02-26 Dirk Schulze + + Reviewed by Eric Seidel. + + Make SVG Masking platform independet with the use of ImageBuffer::getImageData(), + ImageBuffer::putImageData() and GraphicsContext::clipToImageBuffer(). Every platform has + just to implement this three methods to support SVG Masking now. + + Make SVG Masking platform aware + https://bugs.webkit.org/show_bug.cgi?id=19243 + + * GNUmakefile.am: + * WebCore.pro: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * svg/graphics/SVGResourceMasker.cpp: + (WebCore::SVGResourceMasker::applyMask): + * svg/graphics/cairo/SVGResourceMaskerCairo.cpp: Removed. + * svg/graphics/cg/SVGResourceMaskerCg.cpp: Removed. + * svg/graphics/cg/SVGResourceMaskerCg.mm: Removed. + * svg/graphics/qt/SVGResourceMaskerQt.cpp: Removed. + * svg/graphics/skia/SVGResourceMaskerSkia.cpp: Removed. + +2009-02-26 Yong Li + + Reviewed by Darin Adler, Antti Koivisto and Alexey Proskuryakov. + + Test: http/tests/misc/slow-preload-cancel.html + + https://bugs.webkit.org/show_bug.cgi?id=24133 + Clear all pending preloads in the DocLoader object when we decide to + cancel its all requests. + + * loader/DocLoader.cpp: + (WebCore::DocLoader::clearPendingPreloads): + * loader/DocLoader.h: + * loader/loader.cpp: + (WebCore::Loader::cancelRequests): + +2009-02-26 Dimitri Glazkov + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=24182 + Add NodeFilter, NodeIterator, and TreeWalker custom V8 bindings. + + * bindings/v8/custom/V8NodeFilterCustom.cpp: Added. + (WebCore::CALLBACK_FUNC_DECL): + * bindings/v8/custom/V8NodeIteratorCustom.cpp: Added. + (WebCore::toV8): + (WebCore::CALLBACK_FUNC_DECL): + * bindings/v8/custom/V8TreeWalkerCustom.cpp: Added. + (WebCore::toV8): + (WebCore::CALLBACK_FUNC_DECL): + +2009-02-26 Alexey Proskuryakov + + Reviewed by Darin Adler. + + https://bugs.webkit.org/show_bug.cgi?id=23500 + KURL::parse() incorrectly compares its result to original string + + * platform/KURL.cpp: (WebCore::KURL::parse): Take string length into account. + +2009-02-26 Ojan Vafai + + Reviewed by Kevin McCullough. + + Manual test for inspector node highlighting. + + * manual-tests/inspector/highlight-nodes.html: Added. + +2009-02-16 Anantanarayanan Iyengar + + Reviewed by Darin Fisher. + + https://bugs.webkit.org/show_bug.cgi?id=23973 + ScrollView::scrollContents can be invoked during view shutdown. In + this scenario the FrameView::hostWindow method can return NULL, which + indicates that the frame/page is being destroyed. This causes a crash + when we try to dereference a NULL hostWindow pointer. Fix is to add a + NULL check for this. + + * platform/ScrollView.cpp: + (WebCore::ScrollView::scrollContents): + +2009-02-26 Rahul Kuchhal + + Reviewed by Dave Hyatt. + + https://bugs.webkit.org/show_bug.cgi?id=24003 + Fix a crash caused by unsafe type conversion. + + Test: fast/block/positioning/absolute-in-inline-rtl-4.html + + * rendering/RenderBox.cpp: + (WebCore::RenderBox::calcAbsoluteHorizontalValues): + +2009-02-26 Ojan Vafai + + Reviewed by Adam Roben. + + https://bugs.webkit.org/show_bug.cgi?id=24202 + Have drawNodeHighlight clip instead of clearing. This makes it work for + both Safari and Chromium since Chromium draws the inspector highlighting + in the same buffer as the page. + + * inspector/InspectorController.cpp: + (WebCore::quadToPath): + (WebCore::drawOutlinedQuad): + (WebCore::drawOutlinedQuadWithClip): + (WebCore::drawHighlightForBox): + +2009-02-26 David Hyatt + + Reviewed by Dan Bernstein & Darin Adler + + Make sure the border/padding are properly omitted at the start of an inline that is a continuation. + + Added fast/inline/inline-continuation-borders.html + + * rendering/InlineFlowBox.cpp: + (WebCore::InlineFlowBox::determineSpacingForFlowBoxes): + +2009-02-26 Simon Fraser + + Build fix, no review. + + Try to fix the wx build after r41218. + + * WebCoreSources.bkl: + +2009-02-26 Alexey Proskuryakov + + Reviewed by Darin Adler. + + https://bugs.webkit.org/show_bug.cgi?id=19527 + ASSERTION FAILED: containerA && containerB + + Test: fast/dom/Range/bug-19527.html + + * dom/Range.cpp: + (WebCore::Range::isPointInRange): + (WebCore::Range::comparePoint): + Bring the behavior in line with current Firefox, making it impossible for these methods + to pass a null container to compareBoundaryPoints(). + +2009-02-26 Jonathon Jongsma + + Reviewed by Holger Freyther. + + https://bugs.webkit.org/show_bug.cgi?id=20358 + + * platform/graphics/gtk/SimpleFontDataGtk.cpp: + (WebCore::SimpleFontData::smallCapsFontData): the small-caps font data + should set the computed size rather than the specified size, otherwise + the caps just get rendered normal size. + +2009-02-26 Benjamin Meyer + + Reviewed by George Staikos. + + https://bugs.webkit.org/show_bug.cgi?id=24062 + QNetworkCookieJar expects the url and not the policy url. Sending the + policy url will cause QNetworkCookieJar to behave incorrectly. One + example would be a cookie that does not have a path or domain. + QNetworkCookieJar will use the url it is given to fill in default values. + This allows setting cookies on the url of the main frame from an iFrame + when the cookie should be set on the url of the iFrame. + + Originally noticed on http://writer.zoho.com/jsp/home.jsp?serviceurl=/index.do + + * platform/qt/CookieJarQt.cpp: + (WebCore::setCookies): + +2009-02-26 Charles Wei + + Reviewed by George Staikos. + + make WebKit/Qt compile with SVG disabled + + * WebCore.pro: + * platform/graphics/qt/FontPlatformDataQt.cpp: + +2009-02-25 Gustavo Noronha Silva + + Unreviewed build fix. Add WebCore/workers to the list of paths + searched by the bindings generator perl script. + + * GNUmakefile.am: + +2009-02-25 Sam Weinig + + Reviewed by Geoffrey Garen. + + Add canvas to the list of RenderObjects that can mark a page as + visually not empty. + + * rendering/RenderHTMLCanvas.cpp: + (WebCore::RenderHTMLCanvas::RenderHTMLCanvas): + +2009-02-25 Eric Carlson + + Reviewed by Dave Hyatt. + + * rendering/RenderBox.cpp: + (WebCore::RenderBox::nodeAtPoint): Remove assertion fired when child has layer + as RenderMedia with controls always has a layer. + +2009-02-25 Dan Bernstein + + Reviewed by Simon Fraser. + + - fix https://bugs.webkit.org/show_bug.cgi?id=24130 + Paint very slow when horizontally resizing + + Test: fast/gradients/background-clipped.html + + * rendering/RenderBoxModelObject.cpp: + (WebCore::RenderBoxModelObject::paintFillLayerExtended): Intersect the + destination rectangle passed to drawTiledImage() with the dirty + rectangle. This makes it more likely for the destination rect to be + contained in a single tile rect, which results in a faster code path + being taken down the road (just drawing a single tile instead of + tiling). + +2009-02-25 Ojan Vafai + + Reviewed by Eric Seidel. + + Fix test regressions from positionForCoordinates patch. + https://bugs.webkit.org/show_bug.cgi?id=24148 + + * rendering/RenderBlock.cpp: + (WebCore::positionForPointWithInlineChildren): + Remove ASSERT that placeholder text codepath is hitting. + +2009-02-25 Chris Fleizach + + Reviewed by Beth Dakin. + + Bug 24143: Crash occurs at WebCore::AccessibilityTable::isTableExposableThroughAccessibility() when applying a link in GMail + https://bugs.webkit.org/show_bug.cgi?id=24143 + + When an AX object is marked dirty, do not create AX elements while going up the parent chain. + Do not allow AXRenderObjects to remove their own IDs from the cache, all the cache to do that work + Make sure the AXObjectWrapper's have an object before calling them + In AXObjectCache, change get -> getOrCreate. Use get() to only retrieve an element if it exists + + Test: platform/mac-snowleopard/accessibility/table-updating.html + + * WebCore.base.exp: + * page/AXObjectCache.cpp: + (WebCore::AXObjectCache::~AXObjectCache): + (WebCore::AXObjectCache::get): + (WebCore::AXObjectCache::getOrCreate): + (WebCore::AXObjectCache::removeAXID): + (WebCore::AXObjectCache::handleActiveDescendantChanged): + (WebCore::AXObjectCache::handleAriaRoleChanged): + * page/AXObjectCache.h: + * page/AccessibilityImageMapLink.cpp: + (WebCore::AccessibilityImageMapLink::parentObject): + * page/AccessibilityListBox.cpp: + (WebCore::AccessibilityListBox::listBoxOptionAccessibilityObject): + (WebCore::AccessibilityListBox::doAccessibilityHitTest): + * page/AccessibilityListBoxOption.cpp: + (WebCore::AccessibilityListBoxOption::elementRect): + (WebCore::AccessibilityListBoxOption::parentObject): + * page/AccessibilityObject.cpp: + (WebCore::AccessibilityObject::detach): + (WebCore::AccessibilityObject::parentObjectIfExists): + (WebCore::replacedNodeNeedsCharacter): + (WebCore::AccessibilityObject::accessibilityObjectForPosition): + * page/AccessibilityObject.h: + * page/AccessibilityRenderObject.cpp: + (WebCore::AccessibilityRenderObject::firstChild): + (WebCore::AccessibilityRenderObject::lastChild): + (WebCore::AccessibilityRenderObject::previousSibling): + (WebCore::AccessibilityRenderObject::nextSibling): + (WebCore::AccessibilityRenderObject::parentObjectIfExists): + (WebCore::AccessibilityRenderObject::parentObject): + (WebCore::AccessibilityRenderObject::isAttachment): + (WebCore::AccessibilityRenderObject::headingLevel): + (WebCore::AccessibilityRenderObject::anchorElement): + (WebCore::AccessibilityRenderObject::menuForMenuButton): + (WebCore::AccessibilityRenderObject::menuButtonForMenu): + (WebCore::AccessibilityRenderObject::checkboxOrRadioRect): + (WebCore::AccessibilityRenderObject::internalLinkElement): + (WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers): + (WebCore::AccessibilityRenderObject::titleUIElement): + (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): + (WebCore::AccessibilityRenderObject::accessibilityParentForImageMap): + (WebCore::AccessibilityRenderObject::getDocumentLinks): + (WebCore::AccessibilityRenderObject::doAccessibilityHitTest): + (WebCore::AccessibilityRenderObject::focusedUIElement): + (WebCore::AccessibilityRenderObject::activeDescendant): + (WebCore::AccessibilityRenderObject::observableObject): + (WebCore::AccessibilityRenderObject::childrenChanged): + (WebCore::AccessibilityRenderObject::addChildren): + * page/AccessibilityRenderObject.h: + (WebCore::AccessibilityRenderObject::setRenderObject): + * page/AccessibilityTable.cpp: + (WebCore::AccessibilityTable::addChildren): + (WebCore::AccessibilityTable::headerContainer): + (WebCore::AccessibilityTable::cellForColumnAndRow): + * page/AccessibilityTableCell.cpp: + (WebCore::AccessibilityTableCell::isTableCell): + (WebCore::AccessibilityTableCell::titleUIElement): + * page/AccessibilityTableColumn.cpp: + (WebCore::AccessibilityTableColumn::headerObjectForSection): + * page/AccessibilityTableRow.cpp: + (WebCore::AccessibilityTableRow::isTableRow): + * page/gtk/AccessibilityObjectWrapperAtk.cpp: + * page/mac/AXObjectCacheMac.mm: + (WebCore::AXObjectCache::postNotification): + (WebCore::AXObjectCache::postNotificationToElement): + * page/mac/AccessibilityObjectWrapper.mm: + (textMarkerForVisiblePosition): + (AXLinkElementForNode): + (nsStringForReplacedNode): + (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]): + (-[AccessibilityObjectWrapper accessibilityActionNames]): + (-[AccessibilityObjectWrapper accessibilityAttributeNames]): + (-[AccessibilityObjectWrapper accessibilityFocusedUIElement]): + (-[AccessibilityObjectWrapper accessibilityHitTest:]): + (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]): + (-[AccessibilityObjectWrapper accessibilityIsIgnored]): + (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]): + (-[AccessibilityObjectWrapper accessibilityPerformPressAction]): + (-[AccessibilityObjectWrapper accessibilityPerformAction:]): + (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]): + (-[AccessibilityObjectWrapper _accessibilityParentForSubview:]): + (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]): + (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]): + (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]): + +2009-02-25 Beth Dakin + + Reviewed by Geoff Garen. + + Re-working of repro crash in + WebCore::CSSParser::parseFillImage copying entire contents of this + page + -and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172 + + Fixes a bunch of layout test failures I caused! + + * css/CSSParser.cpp: + (WebCore::CSSParser::parseValue): + (WebCore::CSSParser::parseContent): + (WebCore::CSSParser::parseFillImage): + (WebCore::CSSParser::parseFontFaceSrc): + (WebCore::CSSParser::parseBorderImage): + +2009-02-25 Dimitri Glazkov + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=24174 + Add more V8 custom bindings. + + * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: Added. + (WebCore::hasCSSPropertyNamePrefix): + (WebCore::cssPropertyName): + (WebCore::NAMED_PROPERTY_GETTER): + (WebCore::NAMED_PROPERTY_SETTER): + * bindings/v8/custom/V8DOMStringListCustom.cpp: Added. + (WebCore::INDEXED_PROPERTY_GETTER): + (WebCore::CALLBACK_FUNC_DECL): + * bindings/v8/custom/V8EventCustom.cpp: Added. + (WebCore::ACCESSOR_SETTER): + (WebCore::ACCESSOR_GETTER): + * bindings/v8/custom/V8HTMLDocumentCustom.cpp: Added. + (WebCore::NAMED_PROPERTY_DELETER): + (WebCore::NAMED_PROPERTY_SETTER): + (WebCore::NAMED_PROPERTY_GETTER): + * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: Added. + (WebCore::NAMED_PROPERTY_GETTER): + * bindings/v8/custom/V8NamedNodeMapCustom.cpp: Added. + (WebCore::INDEXED_PROPERTY_GETTER): + (WebCore::NAMED_PROPERTY_GETTER): + * bindings/v8/custom/V8NodeListCustom.cpp: Added. + (WebCore::NAMED_PROPERTY_GETTER): + * bindings/v8/custom/V8StyleSheetListCustom.cpp: Added. + (WebCore::NAMED_PROPERTY_GETTER): + +2009-02-25 Scott Violet + + Reviewed by Dave Hyatt. + + https://bugs.webkit.org/show_bug.cgi?id=24171 + Provides a RenderTheme method for getting the scroll bar size and + changes RenderListBox to use it. RenderTheme returns a size of regular, + and Mac's override to return small. Changes ScrollbarThemeChromium to + use the scrollbarsize of the scrollbar when getting the size + instead of passing in no-args. + + * platform/chromium/ScrollbarThemeChromium.cpp: + (WebCore::ScrollbarThemeChromium::trackRect): + (WebCore::ScrollbarThemeChromium::buttonSize): + * rendering/RenderListBox.cpp: + (WebCore::RenderListBox::createScrollbar): + * rendering/RenderTheme.h: + (WebCore::RenderTheme::scrollbarControlSizeForPart): + * rendering/RenderThemeChromiumMac.h: + (WebCore::RenderThemeChromiumMac::scrollbarControlSizeForPart): + * rendering/RenderThemeMac.h: + (WebCore::RenderThemeMac::scrollbarControlSizeForPart): + +2009-02-25 Beth Dakin + + Reviewed by Darin Adler. + + Fix for repro crash in + WebCore::CSSParser::parseFillImage copying entire contents of this + page + -and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172 + + * css/CSSParser.cpp: + (WebCore::CSSParser::parseValue): Null-check m_styleSheet + +2009-02-25 Adam Treat + + Fix the Qt build. + + * WebCore.pro: + +2009-02-25 Jan Michael Alonzo + + Gtk build fix. Not reviewed. + + Add files to the build per r41218. + Rename WebkitPoint.h to WebKitPoint.h in DOMWindow.cpp + + * GNUmakefile.am: + * page/DOMWindow.cpp: + +2009-02-25 Zan Dobersek + + Reviewed by Alexey Proskuryakov. + + https://bugs.webkit.org/show_bug.cgi?id=24043 + When faced with URLs with unsupported protocol on Gtk port, + report the error through an idle function and return true, so + a proper resource handle is created. + + * platform/network/soup/ResourceHandleSoup.cpp: + (WebCore::reportUnknownProtocolError): + (WebCore::ResourceHandle::start): + +2009-02-25 Steve Falkenburg + + Windows build fix. + Use struct to forward declare ResourceRequest. + + * history/HistoryItem.h: + * inspector/InspectorController.h: + * loader/DocumentThreadableLoader.h: + * loader/FrameLoaderClient.h: + * loader/MainResourceLoader.h: + * loader/SubresourceLoader.h: + * loader/SubresourceLoaderClient.h: + * loader/ThreadableLoader.h: + * loader/WorkerThreadableLoader.h: + * platform/CrossThreadCopier.h: + * platform/network/ResourceHandle.h: + * platform/network/ResourceHandleClient.h: + * platform/network/ResourceRequestBase.h: + * platform/network/cf/ResourceRequestCFNet.h: + * xml/XMLHttpRequest.h: + +2009-02-25 Steve Falkenburg + + Partial Windows build fix. + + * DerivedSources.cpp: + * WebCore.vcproj/WebCore.vcproj: + +2009-02-25 Dirk Schulze + + Reviewed by Oliver Hunt. + + Ported arcTo to Qt. Qt has no native support for arcTo. This changes + calculate the behavior of arcTo and draws it with lineTo and arc. + + [QT] implement Canvas arcTo + https://bugs.webkit.org/show_bug.cgi?id=23873 + + * platform/graphics/qt/PathQt.cpp: + (WebCore::Path::addArcTo): + +2009-02-25 Simon Fraser + + Reviewed by Dan Bernstein + + Remove idl files from Resources, and sort. + + * WebCore.xcodeproj/project.pbxproj: + +2009-02-25 Chris Marrin + + Reviewed by Simon Fraser. + + https://bugs.webkit.org/show_bug.cgi?id=23943 + + Added webkitConvertPointFromNodeToPage and webkitConvertPointFromPageToNode on + the window object. Also added WebKitPoint object, which is passed in and out + of these functions. + + Test: fast/dom/Window/webkitConvertPoint.html + + * DerivedSources.make: + * WebCore.pro: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * WebCoreSources.bkl: + * bindings/js/JSDOMWindowBase.cpp: + (jsDOMWindowBaseWebKitPoint): + (setJSDOMWindowBaseWebKitPoint): + * bindings/js/JSWebKitPointConstructor.cpp: Added. + (WebCore::): + (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor): + (WebCore::constructWebKitPoint): + (WebCore::JSWebKitPointConstructor::getConstructData): + * bindings/js/JSWebKitPointConstructor.h: Added. + (WebCore::JSWebKitPointConstructor::classInfo): + * dom/Node.cpp: + (WebCore::Node::convertToPage): + (WebCore::Node::convertFromPage): + * dom/Node.h: + * page/DOMWindow.cpp: + (WebCore::DOMWindow::webkitConvertPointFromNodeToPage): + (WebCore::DOMWindow::webkitConvertPointFromPageToNode): + * page/DOMWindow.h: + * page/DOMWindow.idl: + * page/WebKitPoint.h: Added. + (WebCore::WebKitPoint::create): + (WebCore::WebKitPoint::x): + (WebCore::WebKitPoint::y): + (WebCore::WebKitPoint::setX): + (WebCore::WebKitPoint::setY): + (WebCore::WebKitPoint::WebKitPoint): + * page/WebKitPoint.idl: Added. + +2009-02-25 Jian Li + + Reviewed by Alexey Proskuryakov. + + Remove "#if ENABLE(WORKERS)" wrap from CrossThreadCopier files. + https://bugs.webkit.org/show_bug.cgi?id=24145 + + * platform/CrossThreadCopier.cpp: + * platform/CrossThreadCopier.h: + +2009-02-25 David Levin + + Reviewed by Alexey Proskuryakov. + + Bug 23688: ThreadableLoader needs a sync implementation for Workers. + + + No observable change in behavior, so no test. + + * loader/ThreadableLoader.cpp: + (WebCore::ThreadableLoader::loadResourceSynchronously): + * loader/ThreadableLoaderClientWrapper.h: + (WebCore::ThreadableLoaderClientWrapper::clearClient): + (WebCore::ThreadableLoaderClientWrapper::done): + (WebCore::ThreadableLoaderClientWrapper::didFinishLoading): + (WebCore::ThreadableLoaderClientWrapper::didFail): + (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck): + (WebCore::ThreadableLoaderClientWrapper::ThreadableLoaderClientWrapper): + Expose whether the loader is done (based on what callbacks were done). + + * loader/WorkerThreadableLoader.cpp: + (WebCore::WorkerThreadableLoader::WorkerThreadableLoader): + (WebCore::WorkerThreadableLoader::loadResourceSynchronously): + Each loader is given its own mode so that only its callbacks get through the run loop. + + The xhr spec says that the readystatechange events are synchronous, so in the case of a + nested sync xhr no readystatechange events should be fired for the outer xhr. + + (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): + + * loader/WorkerThreadableLoader.h: + (WebCore::WorkerThreadableLoader::create): + (WebCore::WorkerThreadableLoader::done): + + * workers/WorkerRunLoop.cpp: + (WebCore::WorkerRunLoop::WorkerRunLoop): + * workers/WorkerRunLoop.h: + (WebCore::WorkerRunLoop::createUniqueId): + Simple method to create a uniqueId on demand with respect to the run loop. + + * workers/WorkerThread.h: + +2009-02-25 David Levin + + Reviewed by Alexey Proskuryakov. + + Bug 24089: ThreadableLoader::loadResourceSynchronously should do callbacks like the async code. + + + Make threadable loader callbacks to happen during the sync load call. + + Changes the behavior of sync xhr for insecure redirects in two ways: + + Sends an error event instead of an abort event (which is the same as async xhr's behavior). + + Throws a network exception which is what other browsers do and what the spec + says to do (http://www.w3.org/TR/XMLHttpRequest/). + + * loader/DocumentThreadableLoader.cpp: + (WebCore::DocumentThreadableLoader::loadResourceSynchronously): + * loader/DocumentThreadableLoader.h: + * loader/ThreadableLoader.cpp: + (WebCore::ThreadableLoader::loadResourceSynchronously): + * loader/ThreadableLoader.h: + * xml/XMLHttpRequest.cpp: + (WebCore::XMLHttpRequest::XMLHttpRequest): + (WebCore::XMLHttpRequest::loadRequestSynchronously): + (WebCore::XMLHttpRequest::loadRequestAsynchronously): + (WebCore::XMLHttpRequest::didFail): + (WebCore::XMLHttpRequest::didFailRedirectCheck): + * xml/XMLHttpRequest.h: + +2009-02-24 Chris Marrin + + Reviewed by David Hyatt. + + https://bugs.webkit.org/show_bug.cgi?id=23368 + + Added logic to correctly hit test accelerated layers. + + Tests: animations/animation-hit-test-transform.html + animations/animation-hit-test.html + transitions/transition-hit-test-transform.html + transitions/transition-hit-test.html + + * page/animation/KeyframeAnimation.cpp: + (WebCore::KeyframeAnimation::animate): + * rendering/RenderLayer.cpp: + (WebCore::RenderLayer::hitTestLayer): + (WebCore::RenderLayer::updateClipRects): + * rendering/RenderLayerBacking.cpp: + (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): + +2009-02-25 Alexey Proskuryakov + + Reviewed by Darin Adler. + + https://bugs.webkit.org/show_bug.cgi?id=24067 + REGRESSION: Crash in WebCore::Document::initSecurityContext + + The crash started to happen when we removed a check for frame->document() being null. + However, the original document shouldn't be null here, because it is needed to alias + security origins. So, this patch fixes the crash by correcting security origin behavior. + + Test: http/tests/security/aboutBlank/window-open-self-about-blank.html + This tests for not crashing, and for inheriting the domain from the document being replaced. + Preserving the aliasing cannot be tested for automatically, because we'd need a non-trivial + domain to remove a prefix from. + + * loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): Create a new document before + clearing the frame, so that Document::initSecurityContext() could access the old one. + +2009-02-25 Jay Campan + + Reviewed by Darin Fisher. + + https://bugs.webkit.org/show_bug.cgi?id=24066 + + Items in drop-downs were not painted correctly. Makes sure the + PopupListBox invalidates in the coordinates of the window as this is + FramelessScrollView::invalidateRect paints to. + + * platform/chromium/PopupMenuChromium.cpp: + (WebCore::PopupListBox::invalidateRow): + +2009-02-24 Simon Fraser + + Reviewed by Anders Carlsson + + https://bugs.webkit.org/show_bug.cgi?id=15081 + + Make display:none work for applet, emebed and object elements + by calling rendererIsNeeded() on superclasses. + + Tests: fast/replaced/applet-display-none.html + fast/replaced/embed-display-none.html + fast/replaced/object-display-none.html + + * html/HTMLAppletElement.cpp: + (WebCore::HTMLAppletElement::rendererIsNeeded): + * html/HTMLElement.cpp: + (WebCore::HTMLElement::rendererIsNeeded): + * html/HTMLEmbedElement.cpp: + (WebCore::HTMLEmbedElement::rendererIsNeeded): + * html/HTMLObjectElement.cpp: + (WebCore::HTMLObjectElement::rendererIsNeeded): + +2009-02-24 Simon Fraser + + Reviewed by Dave Hyatt + + https://bugs.webkit.org/show_bug.cgi?id=24137 + + Fix localToAbsolute() and absoluteToLocal() to map points through 3d transforms, + taking perspective and transform-style: preserve-3d into account. + + In order to support transform-style: preserve-3d, which keeps elements in a + 3d space, we have to carry along an accumulated matrix in TransformState. + We also need to apply the perspective from the parent, if any, with the + appropriate origin. + + * GNUmakefile.am: + * WebCore.base.exp: + * WebCore.pro: + * WebCore.scons: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * WebCoreSources.bkl: + * css/CSSComputedStyleDeclaration.cpp: + (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): + * platform/graphics/transforms/TransformationMatrix.cpp: + (WebCore::TransformationMatrix::translate): + (WebCore::TransformationMatrix::translate3d): + (WebCore::TransformationMatrix::translateRight3d): + * platform/graphics/transforms/TransformationMatrix.h: + * rendering/RenderBox.cpp: + (WebCore::RenderBox::mapLocalToAbsolutePoint): + (WebCore::RenderBox::mapAbsoluteToLocalPoint): + * rendering/RenderBox.h: + * rendering/RenderLayer.cpp: + (WebCore::RenderLayer::updateTransform): + (WebCore::RenderLayer::perspectiveTransform): + (WebCore::RenderLayer::perspectiveOrigin): + * rendering/RenderLayer.h: + * rendering/RenderLayerBacking.cpp: + (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): + * rendering/RenderLayerCompositor.cpp: + (WebCore::requiresCompositingLayerForTransform): + (WebCore::RenderLayerCompositor::layerHas3DContent): + * rendering/RenderObject.cpp: + (WebCore::RenderObject::localToAbsolute): + (WebCore::RenderObject::absoluteToLocal): + (WebCore::RenderObject::mapLocalToAbsolutePoint): + (WebCore::RenderObject::mapAbsoluteToLocalPoint): + * rendering/RenderObject.h: + * rendering/RenderTableCell.cpp: + (WebCore::RenderTableCell::mapLocalToAbsolutePoint): + (WebCore::RenderTableCell::mapAbsoluteToLocalPoint): + * rendering/RenderTableCell.h: + * rendering/RenderView.cpp: + (WebCore::RenderView::mapLocalToAbsolutePoint): + (WebCore::RenderView::mapAbsoluteToLocalPoint): + * rendering/RenderView.h: + * rendering/TransformState.cpp: Added. + (WebCore::TransformState::move): + (WebCore::TransformState::applyTransform): + (WebCore::TransformState::flatten): + * rendering/TransformState.h: Added. + (WebCore::TransformState::): + (WebCore::TransformState::TransformState): + (WebCore::TransformState::move): + * rendering/style/RenderStyle.h: + (WebCore::InheritedFlags::hasPerspective): + +2009-02-24 Sam Weinig + + Reviewed by David Hyatt. + + Fix for https://bugs.webkit.org/show_bug.cgi?id=23990 + Regression (r40837): JavaScript image popup doesn't work + + Make the getClientRects and getBoundingClientRect methods return rects + relative to the viewport. + + Test: fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport.html + + * dom/Element.cpp: + (WebCore::Element::getClientRects): + (WebCore::Element::getBoundingClientRect): + +2009-02-24 Ojan Vafai + + Reviewed by Eric Seidel. + + SVG pages don't have a body or an html element! + Don't return early if there is no body. + + * editing/VisiblePosition.cpp: + (WebCore::VisiblePosition::canonicalPosition): + +2009-02-23 David Hyatt + + Reviewed by Eric Seidel + + https://bugs.webkit.org/show_bug.cgi?id=23740, painting order wrong for normal flow elements with overflow: hidden + + This patch reworks the painting of overflow. There is now the concept of a "self-painting layer." All + layers are considered to be self-painting except for overflow layers that are normal flow (and that don't have + reflections or masks). + + If an overflow layer is not self-painting, then it ends up painted by its parent just like any other normal flow object. + The only difference is that the clip has to be pushed and popped when painting the object's children. + + The lightweight clipping scheme used for controls has been extended to cover overflow now in this simplified case. With + the code consolidated into reusable push/pop functions, all of the renderers that use overflow have been patched to + use the new functions. + + Hit testing has also been patched to check the overflow clip rect first before recurring into children. + + Scrollbar paint has been moved into RenderBlock for now, since none of the table objects support scrollbars + yet, and scrollbar hit testing was already there anyway. Now the two code paths are more symmetrical. + + Masks are now treated like normal flow layers (just like reflections). + + A couple of test cases have been added to fast/overflow to test the stacking order. + + * rendering/InlineFlowBox.cpp: + (WebCore::InlineFlowBox::nodeAtPoint): + (WebCore::InlineFlowBox::paint): + * rendering/RenderBlock.cpp: + (WebCore::RenderBlock::repaintOverhangingFloats): + (WebCore::RenderBlock::paint): + (WebCore::RenderBlock::paintChildren): + (WebCore::RenderBlock::paintObject): + (WebCore::RenderBlock::paintFloats): + (WebCore::RenderBlock::insertFloatingObject): + (WebCore::RenderBlock::floatRect): + (WebCore::RenderBlock::lowestPosition): + (WebCore::RenderBlock::rightmostPosition): + (WebCore::RenderBlock::leftmostPosition): + (WebCore::RenderBlock::addOverhangingFloats): + (WebCore::RenderBlock::nodeAtPoint): + (WebCore::RenderBlock::hitTestContents): + * rendering/RenderBox.cpp: + (WebCore::RenderBox::nodeAtPoint): + (WebCore::RenderBox::pushContentsClip): + (WebCore::RenderBox::popContentsClip): + * rendering/RenderBox.h: + (WebCore::RenderBox::paintObject): + * rendering/RenderBoxModelObject.cpp: + (WebCore::RenderBoxModelObject::hasSelfPaintingLayer): + * rendering/RenderBoxModelObject.h: + * rendering/RenderLayer.cpp: + (WebCore::RenderLayer::paintLayer): + (WebCore::RenderLayer::hitTestLayer): + (WebCore::RenderLayer::shouldBeNormalFlowOnly): + (WebCore::RenderLayer::isSelfPaintingLayer): + * rendering/RenderLayer.h: + * rendering/RenderTable.cpp: + (WebCore::RenderTable::paint): + (WebCore::RenderTable::paintObject): + (WebCore::RenderTable::nodeAtPoint): + * rendering/RenderTable.h: + * rendering/RenderTableCell.cpp: + (WebCore::RenderTableCell::paint): + * rendering/RenderTableRow.cpp: + (WebCore::RenderTableRow::nodeAtPoint): + (WebCore::RenderTableRow::paint): + * rendering/RenderTableRow.h: + * rendering/RenderTableSection.cpp: + (WebCore::RenderTableSection::paint): + (WebCore::RenderTableSection::paintObject): + (WebCore::RenderTableSection::nodeAtPoint): + * rendering/RenderTableSection.h: + * rendering/RenderTreeAsText.cpp: + (WebCore::write): + (WebCore::writeLayers): + +2009-02-24 David Levin + + Reviewed by NOBODY (build fix). + + Attempted build fix for wx-mac. + + * WebCoreSources.bkl: + +2009-02-24 David Levin + + Reviewed by NOBODY (build fix). + + Attempted build fixes for qt-linux and wx-mac. + + * WebCore.pro: + * webcore-base.bkl: + +2009-02-24 Ojan Vafai + + Reviewed by Sam Weinig. + + Fix null pointer error. If the node is the Document, then ownerDocument() + returns null, document() does not. + + * editing/VisiblePosition.cpp: + (WebCore::VisiblePosition::canonicalPosition): + +2009-02-24 Jian Li + + Reviewed by NOBODY (attempted build fixes). + + Fix build break for Windows and Linux. + + * GNUmakefile.am: + * WebCore.vcproj/WebCore.vcproj: + +2009-02-24 Dimitri Glazkov + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=24131 + Fix-up COM/RefCounted dichotomy in Chromium port. + + * page/chromium/AccessibilityObjectWrapper.h: + (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper): Added + explicit setting of recount. + +2009-02-24 Dimitri Glazkov + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=24141 + Add clarity to V8 interceptor helper function. + + * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp: + (WebCore::NAMED_PROPERTY_GETTER): Renamed to notHandledByInterceptor. + (WebCore::NAMED_PROPERTY_SETTER): Ditto. + (WebCore::INDEXED_PROPERTY_GETTER): Ditto. + (WebCore::INDEXED_PROPERTY_SETTER): Ditto. + +2009-02-24 Simon Fraser + + Reviewed by Eric Seidel + + Minor numeric cleanup: convert float literals to doubles. + + * platform/graphics/transforms/RotateTransformOperation.cpp: + (WebCore::RotateTransformOperation::blend): + +2009-02-24 Mark Mentovai + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=24139 + Add missing include. + + * bindings/v8/ScriptInstance.h: + +2009-02-24 Jian Li + + Reviewed by Alexey Proskuryakov. + + Move worker related files from dom directory to worker directory under WebCore. + https://bugs.webkit.org/show_bug.cgi?id=24123 + + * DerivedSources.make: + * GNUmakefile.am: + * WebCore.pro: + * WebCore.scons: + * WebCore.vcproj/MigrateIDLAndScripts: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * platform/CrossThreadCopier.cpp: Renamed from WebCore/dom/CrossThreadCopier.cpp. + * platform/CrossThreadCopier.h: Renamed from WebCore/dom/CrossThreadCopier.h. + * workers/GenericWorkerTask.h: Renamed from WebCore/dom/GenericWorkerTask.h. + * workers/Worker.cpp: Renamed from WebCore/dom/Worker.cpp. + * workers/Worker.h: Renamed from WebCore/dom/Worker.h. + * workers/Worker.idl: Renamed from WebCore/dom/Worker.idl. + * workers/WorkerContext.cpp: Renamed from WebCore/dom/WorkerContext.cpp. + * workers/WorkerContext.h: Renamed from WebCore/dom/WorkerContext.h. + * workers/WorkerContext.idl: Renamed from WebCore/dom/WorkerContext.idl. + * workers/WorkerContextProxy.h: Renamed from WebCore/dom/WorkerContextProxy.h. + * workers/WorkerLocation.cpp: Renamed from WebCore/dom/WorkerLocation.cpp. + * workers/WorkerLocation.h: Renamed from WebCore/dom/WorkerLocation.h. + * workers/WorkerLocation.idl: Renamed from WebCore/dom/WorkerLocation.idl. + * workers/WorkerMessagingProxy.cpp: Renamed from WebCore/dom/WorkerMessagingProxy.cpp. + * workers/WorkerMessagingProxy.h: Renamed from WebCore/dom/WorkerMessagingProxy.h. + * workers/WorkerObjectProxy.h: Renamed from WebCore/dom/WorkerObjectProxy.h. + * workers/WorkerRunLoop.cpp: Renamed from WebCore/dom/WorkerRunLoop.cpp. + * workers/WorkerRunLoop.h: Renamed from WebCore/dom/WorkerRunLoop.h. + * workers/WorkerThread.cpp: Renamed from WebCore/dom/WorkerThread.cpp. + * workers/WorkerThread.h: Renamed from WebCore/dom/WorkerThread.h. + +2009-02-05 Ojan Vafai and Eric Seidel + + Reviewed by Dave Hyatt. + + Make cursor positions match IE6/IE7/FF3 when clicking in margins/padding + around divs inside editable regions. + https://bugs.webkit.org/show_bug.cgi?id=23605 + + Fix clicks outside editable regions from focusing the editable region. + https://bugs.webkit.org/show_bug.cgi?id=23607 + + Removed editing/selection/contenteditable-click-outside.html as it's + not as useful as our new tests. + + Clean up RenderBlock::positionForCoordinates to remove dead code, + duplicate code, and generally make it more readable. + + Tests: editing/selection/click-in-margins-inside-editable-div.html + editing/selection/click-in-padding-with-multiple-line-boxes.html + editing/selection/click-outside-editable-div.html + + * editing/VisiblePosition.cpp: + (WebCore::VisiblePosition::canonicalPosition): + * rendering/RenderBlock.cpp: + (WebCore::positionForPointRespectingEditingBoundaries): + (WebCore::positionForPointWithInlineChildren): + (WebCore::RenderBlock::positionForCoordinates): + (WebCore::RenderBlock::updateFirstLetter): + +2009-02-24 Sam Weinig + + Reviewed by Geoffrey Garen. + + Related to + Allow disabling javascript: urls. + + * WebCore.base.exp: + * html/HTMLAnchorElement.cpp: + (WebCore::HTMLAnchorElement::parseMappedAttribute): + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::executeIfJavaScriptURL): + * page/Page.cpp: + (WebCore::Page::Page): + (WebCore::Page::setJavaScriptURLsAreAllowed): + (WebCore::Page::javaScriptURLsAreAllowed): + * page/Page.h: + +2009-02-24 Simon Fraser + + Fix build when ACCELERATED_COMPOSITING is turned on + (overflowList() -> normalFlowList()). + + * rendering/RenderLayerBacking.cpp: + (WebCore::RenderLayerBacking::hasNonCompositingContent): + (WebCore::RenderLayerBacking::paintIntoLayer): + * rendering/RenderLayerCompositor.cpp: + (WebCore::RenderLayerCompositor::calculateCompositedBounds): + (WebCore::RenderLayerCompositor::computeCompositingRequirements): + (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): + (WebCore::RenderLayerCompositor::recursiveRepaintLayerRect): + (WebCore::RenderLayerCompositor::layerHas3DContent): + +2009-02-24 Simon Fraser + + Reviewed by Darin Adler + + https://bugs.webkit.org/show_bug.cgi?id=24135 + + Round the FloatPoint returned by absoluteToLocal(), rather than + truncating it. + + * dom/MouseRelatedEvent.cpp: + (WebCore::MouseRelatedEvent::receivedTarget): + +2009-02-24 Beth Dakin + + Reviewed by Sam Weinig. + + Fix for https://bugs.webkit.org/show_bug.cgi?id=24004 REGRESSION: + Ordered list item marker misaligned when line height is not 1.2 + -and corresponding + + This is a regression from http://trac.webkit.org/changeset/40880 + where createInlineBox was taken off of RenderObject and moved to + RenderBox. The problem was that the RenderBox version still needs + to be virtual because there is still an existing implementation in + RenderListMarker. + + * rendering/RenderBox.h: + * rendering/RenderListMarker.cpp: + (WebCore::RenderListMarker::createInlineBox): + * rendering/RenderListMarker.h: + +2009-02-24 Dimitri Glazkov + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=24128 + Upstream more V8 custom bindings: constructors, XSLTProcessor. + + * bindings/v8/custom/V8DOMParserConstructor.cpp: Added. + (WebCore::CALLBACK_FUNC_DECL): + * bindings/v8/custom/V8MessageChannelConstructor.cpp: Added. + (WebCore::CALLBACK_FUNC_DECL): + * bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp: Added. + (WebCore::CALLBACK_FUNC_DECL): + * bindings/v8/custom/V8XMLSerializerConstructor.cpp: Added. + (WebCore::CALLBACK_FUNC_DECL): + * bindings/v8/custom/V8XPathEvaluatorConstructor.cpp: Added. + (WebCore::CALLBACK_FUNC_DECL): + * bindings/v8/custom/V8XSLTProcessorCustom.cpp: Added. + (WebCore::CALLBACK_FUNC_DECL): + +2009-02-24 David Levin + + Reviewed by Alexey Proskuryakov. + + Bug 24090: WorkerThreadableLoader needs to be able to post tasks for a mode. + + + No observable change in behavior, so no test. + + * dom/WorkerMessagingProxy.cpp: + (WebCore::WorkerMessagingProxy::postMessageToWorkerContext): + (WebCore::WorkerMessagingProxy::postTaskToWorkerContext): + Fixed the bug that m_unconfirmedMessageCount was getting incremented for non-message tasks. + + (WebCore::WorkerMessagingProxy::postTaskForModeToWorkerContext): + + * dom/WorkerMessagingProxy.h: + * loader/ThreadableLoader.cpp: + (WebCore::ThreadableLoader::create): + * loader/WorkerThreadableLoader.cpp: + (WebCore::WorkerThreadableLoader::WorkerThreadableLoader): + (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): + (WebCore::WorkerThreadableLoader::MainThreadBridge::didSendData): + (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse): + (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData): + (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading): + (WebCore::WorkerThreadableLoader::MainThreadBridge::didFail): + (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck): + (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveAuthenticationCancellation): + Changed these methods to post task using a mode. + + * loader/WorkerThreadableLoader.h: + (WebCore::WorkerThreadableLoader::create): + +2009-02-24 Alexey Proskuryakov + + Reviewed by Darin Adler. + + https://bugs.webkit.org/show_bug.cgi?id=24091 + Start of redirect chain ends up as master entry in Application Cache + + Test: http/tests/appcache/access-via-redirect.php + + * loader/appcache/ApplicationCacheGroup.cpp: + (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): Use the URL we ended up with, + not the original one. + +2009-02-24 Jian Li + + Reviewed by Alexey Proskuryakov. + + Change to include WorkerObjectProxy.h instead of WorkerMessagingProxy.h in WorkerContext.cpp and WorkerScriptController.cpp. + https://bugs.webkit.org/show_bug.cgi?id=24112 + + * bindings/js/WorkerScriptController.cpp: + * dom/WorkerContext.cpp: + +2009-02-23 Antti Koivisto + + Reviewed by Oliver Hunt. + + Extended text codecs registered on webview creation + + Comparing a text encoding with string "GBK" ended up constructing + TextEncoding("GBK") which in turn initialized all extended + text codecs. + + * platform/text/TextCodecICU.cpp: + (WebCore::TextCodecICU::decode): + +2009-02-23 Sam Weinig + + Fix Qt build. + + * bridge/qt/qt_runtime.cpp: + (JSC::Bindings::valueRealType): + +2009-02-23 Julien Chaffraix + + Reviewed by Darin Adler. + + Bug 23956: Safari crashes when cloneNode fails (cloning a XML element with an invalid nodeName) + + The crash occurred because Document::cloneNode would call Document::createElementNS. Unfortunately + element created with createElement could have a wrong nodeName (createElement sets the string as the + localName without checking for a prefix). + + The fix is to call Document::createElement(const QualifiedName&, bool) that will not do any checks on the QualifiedName + and will always succeed. + Also rolled-out the HTMLElement specialisation of clonedNode as it was equivalent to what is done now (added an ASSERT + to ensure that). + + Test: fast/dom/cloneNode.html + + * dom/Element.cpp: + (WebCore::Element::cloneNode): Call createElement(const QualifiedName&, bool) instead of createElementNS as it will + always return an element. + + * html/HTMLElement.cpp: + * html/HTMLElement.h: Removed HTMLElement::clonedNode as it is equivalent to what is now done. + +2009-02-23 Dimitri Glazkov + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=24109 + Upstream V8 Script abstractions, all except ScriptController. + + * bindings/v8/ScriptCachedFrameData.h: Added. + (WebCore::ScriptCachedFrameData::ScriptCachedFrameData): + (WebCore::ScriptCachedFrameData::~ScriptCachedFrameData): + (WebCore::ScriptCachedFrameData::restore): + (WebCore::ScriptCachedFrameData::clear): + (WebCore::ScriptCachedFrameData::domWindow): + * bindings/v8/ScriptCallFrame.cpp: Added. + (WebCore::ScriptCallFrame::ScriptCallFrame): + (WebCore::ScriptCallFrame::~ScriptCallFrame): + (WebCore::ScriptCallFrame::argumentAt): + * bindings/v8/ScriptCallFrame.h: Added. + (WebCore::ScriptCallFrame::functionName): + (WebCore::ScriptCallFrame::sourceURL): + (WebCore::ScriptCallFrame::lineNumber): + (WebCore::ScriptCallFrame::argumentCount): + * bindings/v8/ScriptCallStack.cpp: Added. + (WebCore::ScriptCallStack::ScriptCallStack): + (WebCore::ScriptCallStack::~ScriptCallStack): + (WebCore::ScriptCallStack::at): + * bindings/v8/ScriptCallStack.h: Added. + (WebCore::ScriptCallStack::size): + * bindings/v8/ScriptInstance.cpp: Added. + (WebCore::V8ScriptInstance::V8ScriptInstance): + (WebCore::V8ScriptInstance::~V8ScriptInstance): + (WebCore::V8ScriptInstance::instance): + (WebCore::V8ScriptInstance::clear): + (WebCore::V8ScriptInstance::set): + * bindings/v8/ScriptInstance.h: Added. + (WebCore::V8ScriptInstance::create): + * bindings/v8/ScriptSourceCode.h: Added. + (WebCore::ScriptSourceCode::ScriptSourceCode): + (WebCore::ScriptSourceCode::isEmpty): + (WebCore::ScriptSourceCode::source): + (WebCore::ScriptSourceCode::url): + (WebCore::ScriptSourceCode::startLine): + * bindings/v8/ScriptState.h: Added. + (WebCore::ScriptState::hadException): + (WebCore::ScriptState::setException): + (WebCore::ScriptState::exception): + * bindings/v8/ScriptString.h: Added. + (WebCore::ScriptString::ScriptString): + (WebCore::ScriptString::operator String): + (WebCore::ScriptString::isNull): + (WebCore::ScriptString::size): + (WebCore::ScriptString::operator=): + (WebCore::ScriptString::operator+=): + * bindings/v8/ScriptValue.cpp: Added. + (WebCore::ScriptValue::getString): + * bindings/v8/ScriptValue.h: Added. + (WebCore::ScriptValue::ScriptValue): + (WebCore::ScriptValue::operator=): + (WebCore::ScriptValue::operator==): + (WebCore::ScriptValue::operator!=): + (WebCore::ScriptValue::isNull): + (WebCore::ScriptValue::isUndefined): + (WebCore::ScriptValue::clear): + (WebCore::ScriptValue::~ScriptValue): + (WebCore::ScriptValue::v8Value): + +2009-02-23 Adam Treat + + Reviewed by Timothy Hatcher. + + https://bugs.webkit.org/show_bug.cgi?id=24106 + The Qt port is crashing on exit because the tear down procedure involves + the WebCore::InspectorController trying to access the JS execution context + for a page that is being deleted. This patch amends the inspector so + that it does not try and access the execution context of the WebCore::Page + in the midst of deletion. + + * inspector/InspectorController.cpp: + (WebCore::InspectorController::inspectedPageDestroyed): + (WebCore::InspectorController::stopUserInitiatedProfiling): + +2009-02-23 David Levin + + Reviewed by Alexey Proskuryakov. + + Bug 24088: ThreadableLoaderClient::didFailWillSendRequestCheck isn't wired up completely for workers and could use a better name. + + + No observable change in behavior, so no test. + + * loader/DocumentThreadableLoader.cpp: + (WebCore::DocumentThreadableLoader::create): + * loader/ThreadableLoaderClient.h: + (WebCore::ThreadableLoaderClient::didFailRedirectCheck): + * loader/ThreadableLoaderClientWrapper.h: + (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck): + * loader/WorkerThreadableLoader.cpp: + (WebCore::workerContextDidFailRedirectCheck): + (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck): + * loader/WorkerThreadableLoader.h: + * xml/XMLHttpRequest.cpp: + (WebCore::XMLHttpRequest::didFinishLoading): + * xml/XMLHttpRequest.h: + +2009-02-23 David Levin + + Reviewed by Alexey Proskuryakov. + + Bug 24047: Need to simplify nested if's in WorkerRunLoop::runInMode + + + Made a nested if inside of WorkerRunLoop::runInMode a lot simpler by + using only MessageQueue::waitForMessageFilteredWithTimeout instead + of three different MessageQueue methods. + + No observable change in behavior, so no test. + + * dom/WorkerRunLoop.cpp: + (WebCore::ModePredicate::operator()): + Minor clean-up to able to pass a const ref point for ModePredicate into runInMode. + (WebCore::WorkerRunLoop::runInMode): + * dom/WorkerRunLoop.h: + +2009-02-23 David Hyatt + + In preparation for making layers for multicol objects (so that they can properly split child layers + into multiple columns), rename all of the "overflowOnly" and "overflowList" members and functions + of RenderLayer to use the term "normal flow" instead. + + Reviewed by Cameron Zwarich + + * rendering/RenderLayer.cpp: + (WebCore::RenderLayer::RenderLayer): + (WebCore::RenderLayer::~RenderLayer): + (WebCore::RenderLayer::setHasVisibleContent): + (WebCore::RenderLayer::enclosingCompositingLayer): + (WebCore::RenderLayer::addChild): + (WebCore::RenderLayer::removeChild): + (WebCore::RenderLayer::paintLayer): + (WebCore::RenderLayer::hitTestLayer): + (WebCore::RenderLayer::dirtyNormalFlowList): + (WebCore::RenderLayer::updateNormalFlowList): + (WebCore::RenderLayer::collectLayers): + (WebCore::RenderLayer::updateLayerListsIfNeeded): + (WebCore::RenderLayer::shouldBeNormalFlowOnly): + (WebCore::RenderLayer::styleChanged): + * rendering/RenderLayer.h: + (WebCore::RenderLayer::isNormalFlowOnly): + (WebCore::RenderLayer::normalFlowList): + * rendering/RenderTreeAsText.cpp: + (WebCore::writeLayers): + +2009-02-23 David Hyatt + + Fix the stacking order for column rules in multi-column layout. Column rules should paint as part of the background of an element, just + after all other components of the background have been painted. This allows negative z-index children to still paint on top of the + column rules (rather than ending up above the background of the box but behind the column rules). + + Reviewed by Eric Seidel + + Added fast/multicol/column-rules-stacking.html + + * rendering/RenderBlock.cpp: + (WebCore::RenderBlock::paintColumnRules): + (WebCore::RenderBlock::paintColumnContents): + (WebCore::RenderBlock::paintObject): + * rendering/RenderBlock.h: + +2009-02-23 Adam Treat + + Reviewed by David Hyatt. + + No testcases have been added or modified since this patch should not result in + a behavior change for ports that have layout tests enabled. + + Currently, the implementation of GraphicsContext::drawLineForText amongst + the various ports differ in that some of them are honoring the context's + strokeStyle when drawing a text-decoration and some of them are not. + For instance, Apple's Mac port *does not* honor the context's strokeStyle(), + but the Cairo implementation does and has an explicit workaround that + sets the strokeStyle() temporarily. + + This patch fixes so that all ports are consistent by explicitly making sure + to set the GraphicsContext strokeStyle to SolidStroke whenever + painting the text-decoration of an InlineFlowBox or InlineTextBox as these + should always use a solid stroke. + + This patch addresses these bugs: + https://bugs.webkit.org/show_bug.cgi?id=19364 + https://bugs.webkit.org/show_bug.cgi?id=15659 + + * rendering/InlineFlowBox.cpp: + (WebCore::InlineFlowBox::paintTextDecorations): + * rendering/InlineTextBox.cpp: + (WebCore::InlineTextBox::paintDecoration): + +2009-02-23 Scott Violet + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=24098 + Bugs in ClipboardChromium + + Fixes the following bugs in ClipboardChromium: + * It's possible for the extension to be empty, resulting in a bad file + name, for example, 'foo.' or just '.'. + * We weren't restricting the size of the file to MAX_PATH. + * We weren't removing characters that are invalid for file system names. + + * platform/chromium/ClipboardChromium.cpp: + (WebCore::writeImageToDataObject): + * platform/chromium/ClipboardChromium.h: + * platform/chromium/ClipboardChromiumLinux.cpp: Added. + (WebCore::ClipboardChromium::validateFileName): + * platform/chromium/ClipboardChromiumMac.cpp: Added. + (WebCore::ClipboardChromium::validateFileName): + * platform/chromium/ClipboardChromiumWin.cpp: Added. + (WebCore::isInvalidFileCharacter): + (WebCore::ClipboardChromium::validateFileName): + +2009-02-23 Thiago Macieira + + Reviewed by Simon Hausmann. + + Fix the Copyright notices in a few files + + * platform/qt/RenderThemeQt.h: + +2009-02-23 Xan Lopez + + Reviewed by Alexey Proskuryakov. + + https://bugs.webkit.org/show_bug.cgi?id=22624 + [SOUP][GTK] Need API to get SoupSession from WebKit. + + Allow to retrieve the Soup session and modify the code to take + into account users changing features on it. + + * platform/network/ResourceHandle.h: + * platform/network/soup/CookieJarSoup.cpp: + (WebCore::defaultCookieJar): + (WebCore::setDefaultCookieJar): + * platform/network/soup/CookieJarSoup.h: + * platform/network/soup/ResourceHandleSoup.cpp: + (WebCore::createSoupSession): + (WebCore::ensureSessionIsInitialized): + (WebCore::ResourceHandle::startHttp): + (WebCore::ResourceHandle::cancel): + (WebCore::ResourceHandle::defaultSession): + +2009-02-23 Xan Lopez + + Reviewed by Alexey Proskuryakov. + + https://bugs.webkit.org/show_bug.cgi?id=22624 + [SOUP][GTK] Need API to get SoupSession from WebKit. + + Remove CURL support. + + * GNUmakefile.am: + +2009-02-23 Alexey Proskuryakov + + Reviewed by Mark Rowe. + + Test: fast/dom/empty-hash-and-search.html + + https://bugs.webkit.org/show_bug.cgi?id=21147 + hash property returns incorrect value for links w/o hash + + Make hash() and search() behavior for empty and missing parts match IE and Firefox. + + * platform/KURL.cpp: + (WebCore::KURL::query): Changed to return query without '?', as it is already done for ref(). + (WebCore::KURL::prettyURL): Append the query with the question mark. + + * page/Location.cpp: + (WebCore::Location::search): Return an empty string if query is empty or missing. + (WebCore::Location::hash): Return an empty string for empty hashes, not only missing ones. + + * dom/WorkerLocation.cpp: + (WebCore::WorkerLocation::search): + (WebCore::WorkerLocation::hash): + Match document.location fixes above. + + * html/HTMLAnchorElement.cpp: + (WebCore::HTMLAnchorElement::hash): + (WebCore::HTMLAnchorElement::search): + Return an empty string for empty and missing parts. + +2009-02-23 Alexey Proskuryakov + + Reviewed by Darin Adler. + + https://bugs.webkit.org/show_bug.cgi?id=20184 + SELECT with no name generates invalid query string + + Test: fast/forms/select-no-name.html + + * html/HTMLSelectElement.cpp: + (WebCore::HTMLSelectElement::appendFormData): Added a check for empty name. + +2009-02-23 Alexey Proskuryakov + + Apply review comments for the previous check-in (forgot to save the file, oops). + + * dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): + +2009-02-23 Alexey Proskuryakov + + Reviewed by Darin Adler. + + https://bugs.webkit.org/show_bug.cgi?id=15707 + Crash when manipulating document from within an iframe onload function + + Test: fast/dom/onload-open.html + + * dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Protect the container and + the current node, because anything can happen when dispatching events. + +2009-02-23 Alexey Proskuryakov + + Reviewed by Darin Adler. + + https://bugs.webkit.org/show_bug.cgi?id=18970 + Numerically named input fields cause document.forms loop problems + + Test: fast/forms/numeric-input-name.html + + * bindings/scripts/CodeGeneratorJS.pm: Try index getter before name getter, even if the + latter overrides properties. + +2009-02-23 Alexey Proskuryakov + + Reviewed by Sam Weinig. + + https://bugs.webkit.org/show_bug.cgi?id=24059 + Tokenizer::write() return value is never used + + * dom/Tokenizer.h: + * dom/XMLTokenizer.cpp: + (WebCore::XMLTokenizer::write): + * dom/XMLTokenizer.h: + * html/HTMLTokenizer.cpp: + (WebCore::HTMLTokenizer::write): + * html/HTMLTokenizer.h: + * loader/FTPDirectoryDocument.cpp: + (WebCore::FTPDirectoryTokenizer::write): + * loader/ImageDocument.cpp: + (WebCore::ImageTokenizer::write): + * loader/MediaDocument.cpp: + (WebCore::MediaTokenizer::write): + * loader/PluginDocument.cpp: + (WebCore::PluginTokenizer::write): + * loader/TextDocument.cpp: + (WebCore::TextTokenizer::write): + Made write() return void, not bool. + +2009-02-20 Geoffrey Garen + + Reviewed by Sam Weinig. + + Updated for JavaScriptCore changes to timeout checking. + + * bindings/js/JSCustomPositionCallback.cpp: + (WebCore::JSCustomPositionCallback::handleEvent): + * bindings/js/JSCustomPositionErrorCallback.cpp: + (WebCore::JSCustomPositionErrorCallback::handleEvent): + * bindings/js/JSCustomSQLStatementCallback.cpp: + (WebCore::JSCustomSQLStatementCallback::handleEvent): + * bindings/js/JSCustomSQLStatementErrorCallback.cpp: + (WebCore::JSCustomSQLStatementErrorCallback::handleEvent): + * bindings/js/JSCustomSQLTransactionCallback.cpp: + (WebCore::JSCustomSQLTransactionCallback::handleEvent): + * bindings/js/JSCustomSQLTransactionErrorCallback.cpp: + (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent): + * bindings/js/JSCustomVoidCallback.cpp: + (WebCore::JSCustomVoidCallback::handleEvent): + * bindings/js/JSCustomXPathNSResolver.cpp: + (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI): + * bindings/js/JSDOMWindowBase.cpp: + (WebCore::JSDOMWindowBase::JSDOMWindowBase): + (WebCore::JSDOMWindowBase::commonJSGlobalData): + * bindings/js/JSEventListener.cpp: + (WebCore::JSAbstractEventListener::handleEvent): + * bindings/js/ScheduledAction.cpp: + (WebCore::ScheduledAction::executeFunctionInContext): + * bindings/js/ScriptController.cpp: + (WebCore::ScriptController::evaluate): + * bindings/js/WorkerScriptController.cpp: + (WebCore::WorkerScriptController::evaluate): + (WebCore::WorkerScriptController::forbidExecution): + * bindings/objc/WebScriptObject.mm: + (-[WebScriptObject callWebScriptMethod:withArguments:]): + (-[WebScriptObject evaluateWebScript:]): + * bridge/NP_jsobject.cpp: + (_NPN_InvokeDefault): + (_NPN_Invoke): + (_NPN_Evaluate): + (_NPN_Construct): + * bridge/jni/jni_jsobject.mm: + (JavaJSObject::call): + (JavaJSObject::eval): + +2009-02-21 Hironori Bono + + Reviewed by Alexey Proskuryakov. + + https://bugs.webkit.org/show_bug.cgi?id=23786 + [Chromium] line-break characters in a complex text are treated as zero-width spaces + + This change prevents the UniscribeHelper class from treating the line-break characters + as whitespaces. + + Tests: fast/text/international/bidi-linebreak-001.html + fast/text/international/bidi-linebreak-002.html + fast/text/international/bidi-linebreak-003.html + + * platform/graphics/chromium/UniscribeHelper.cpp: + (WebCore::UniscribeHelper::adjustSpaceAdvances): + Make the UniscribeHelper::adjustSpaceAdvances() function treat all characters in + the treatAsSpace() function (e.g. U+0020, U+000A, U+000D, U+00A0) as whitespaces, + so does when Chromium renders a simple text. + +2009-02-20 Julien Chaffraix + + Reviewed by Alexey Proskuryakov. + + Bug 23940: Use Document::createElement(const QualifiedName&, bool) when creating a known element inside WebCore + + Document::createElement(const QualifiedName&, bool) does not check for the prefix as opposed the the one taking an AtomicString + or Document::createElementNS. This is perfectly fine internally because we know the type of element created and the check is + unneeded. + + It also removes the use of an ExceptionCode argument which was here only to check that the prefix check was fine. Finally it + enables us to use some generated QualifiedName. + + * bindings/js/JSOptionConstructor.cpp: + (WebCore::constructHTMLOptionElement): + * dom/Document.cpp: + (WebCore::Document::setTitle): + * dom/XMLTokenizer.cpp: + (WebCore::createXHTMLParserErrorHeader): + (WebCore::XMLTokenizer::insertErrorMessageBlock): + * editing/CompositeEditCommand.cpp: + (WebCore::createBlockPlaceholderElement): + * editing/htmlediting.cpp: + (WebCore::createTabSpanElement): + * html/HTMLSelectElement.cpp: + (WebCore::HTMLSelectElement::setLength): + * loader/FTPDirectoryDocument.cpp: + (WebCore::FTPDirectoryTokenizer::appendEntry): + (WebCore::FTPDirectoryTokenizer::createTDForFilename): + (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate): + (WebCore::FTPDirectoryTokenizer::createBasicDocument): + * loader/ImageDocument.cpp: + (WebCore::ImageDocument::createDocumentStructure): + * loader/MediaDocument.cpp: + (WebCore::MediaTokenizer::createDocumentStructure): + * loader/PluginDocument.cpp: + (WebCore::PluginTokenizer::createDocumentStructure): + * loader/TextDocument.cpp: + (WebCore::TextTokenizer::write): + * page/Frame.cpp: + (WebCore::Frame::selectionComputedStyle): + (WebCore::Frame::styleForSelectionStart): + Document::createElement(const AtomicString&, ...) to Document::createElement(const QualifiedName&, ...) switch. + + * xml/XPathFunctions.cpp: + (WebCore::XPath::FunLang::evaluate): Re-use langAttr instead of creating a new attribute. + * page/DragController.cpp: + (WebCore::documentFragmentFromDragData): Use the HTMLAnchorElement directly to get rid of the static cast. + +2009-02-19 Dimitri Glazkov + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=24060 + Fix up to accommodate for CanvasPixelArray return. + + * platform/graphics/skia/ImageBufferSkia.cpp: + (WebCore::ImageBuffer::getImageData): Added an extra data() to call. + (WebCore::ImageBuffer::putImageData): Ditto. + +2009-02-20 Eric Carlson + + Simon Fraser + + https://bugs.webkit.org/show_bug.cgi?id=24042 + Bug 24042: MediaPlayer should cache plug-in proxy + + The changes in https://bugs.webkit.org/show_bug.cgi?id=23917 assume that + MediaPlayer will always have created the private media player object before + the plug-in is instantiated and calls back with the proxy object. This is not + true on all platforms because of threading latency, so MediaPlayer should + cache the plug-in proxy so it can pass it to the media engine at a later time. + + * platform/graphics/MediaPlayer.cpp: + (WebCore::NullMediaPlayerPrivate::setPoster): Null media engine implementation of proxy methods. + (WebCore::NullMediaPlayerPrivate::deliverNotification): Ditto. + (WebCore::NullMediaPlayerPrivate::setMediaPlayerProxy): Ditto. + (WebCore::MediaPlayer::MediaPlayer): Initialize m_playerProxy. + (WebCore::MediaPlayer::load): Pass m_playerProxy to newly created engine. + (WebCore::MediaPlayer::setMediaPlayerProxy): Cache m_playerProxy. + * platform/graphics/MediaPlayer.h: Declare m_playerProxy. + +2009-02-20 Eric Carlson + + Simon Fraser. + + https://bugs.webkit.org/show_bug.cgi?id=24063 + Make it possible for a port to require a user gesture to play/pause an