pure-ftpd does not install correctly.

the package is auto-installed as identd, this configuration does not work without identd setup. In the debian package it asks whether or not you want identd or standalone. The standalone setup works.

This patch includes the folowing files...

rave@ubuntu:~/pure/pure-ftpd_1.0.19-5$ ls -l
totaal 636
-rw-r--r-- 1 rave rave 77729 2005-11-28 22:07 pure-ftpd_1.0.19-5.diff.gz
-rw-r--r-- 1 rave rave 764 2005-11-28 22:07 pure-ftpd_1.0.19-5.dsc
-rw-r--r-- 1 rave rave 1742 2005-11-28 22:07 pure-ftpd_1.0.19-5_i386.changes
-rw-r--r-- 1 rave rave 86872 2005-11-28 22:07 pure-ftpd_1.0.19-5_i386.deb
-rw-r--r-- 1 rave rave 155878 2005-11-28 22:07 pure-ftpd-common_1.0.19-5_all.deb
-rw-r--r-- 1 rave rave 93378 2005-11-28 22:07 pure-ftpd-ldap_1.0.19-5_i386.deb
-rw-r--r-- 1 rave rave 94892 2005-11-28 22:07 pure-ftpd-mysql_1.0.19-5_i386.deb
-rw-r--r-- 1 rave rave 94592 2005-11-28 22:07 pure-ftpd-postgresql_1.0.19-5_i386.deb
rave@ubuntu:~/pure/pure-ftpd_1.0.19-5$

The packagers of pure-ftpd wanted to serve inetd by default over standalone, you can find that back in the package change log.

(as from >=1.0.13a-3)

pure-ftpd (1.0.13a-3) unstable; urgency=low

  * moved /etc/ftpusers into the server packages to avoid clashes with
    other FTP daemons
  * ensure that we default to inetd mode in init script
  * added LDAPAuthentication directive to pure-ftpd-wrappnster
    (Closes: #171898, thanks to Mark Verboom <email address hidden>)

 -- Stefan Hornburg (Racke) <email address hidden> Thu, 5 Dec 2002 23:07:57 +0100

Thats okey but the inetd super server is not installed by default of ubuntu linux Breezy Badger (not for me). So the daemon now depends on the inetd package to be pressent when pure-ftpd gets installed. If this is not the case ubuntu will automaticly install it.

My Changelog entry is

pure-ftpd (1.0.19-5) unstable; urgency=low

  * pure-ftpd depends on inetd now. inetd isnt
    installed by default on ubunut linux but it will be now (Closes: ##3172)
   (https://launchpad.net/distros/ubuntu/+source/pure-ftpd/+bug/3172)

 -- rave <email address hidden> Mon, 28 Nov 2005 21:56:41 +0100

For more information:

ohnny Mast
rosiello developer

Web: http://www.rosiello.net
Mailto: <email address hidden> <mailto:<email address hidden>>
Mailto: <email address hidden> <mailto:<email address hidden>>
Pgp ID: 0x84A62F8D

I made a litle mistake in my prev post and attachted the whole source + deb file arghive

First 2 comments - version should be 1.0.19-4ubuntu1 with distribution dapper
And please post a debdiff which shows the differences between 1.0.19-4 & 1.0.19-4ubuntu1

You can do this by debdiff pure-ftpd_1.0.19-4.dsc pure-ftpd_1.0.19-4ubuntu1.dsc

Next comment is that you should base your changes off 1.0.19-7 which is in dapper (so any changes would become 1.0.19-7ubuntu1)

Andrew Mitchell schreef:

>Public bug report changed:
>https://launchpad.net/malone/bugs/3172
>
>Comment:
>First 2 comments - version should be 1.0.19-4ubuntu1 with distribution dapper
>And please post a debdiff which shows the differences between 1.0.19-4 & 1.0.19-4ubuntu1
>
>You can do this by debdiff pure-ftpd_1.0.19-4.dsc pure-
>ftpd_1.0.19-4ubuntu1.dsc
>
>
>
>
Thank you so so much i will rememeber this ... so sorry

The packagers of pure-ftpd wanted to serve inetd by default over standalone, you can find that back in the package change log.

(as from >=1.0.13a-3)

pure-ftpd (1.0.13a-3) unstable; urgency=low

  * moved /etc/ftpusers into the server packages to avoid clashes with
    other FTP daemons
  * ensure that we default to inetd mode in init script
  * added LDAPAuthentication directive to pure-ftpd-wrappnster
    (Closes: #171898, thanks to Mark Verboom <email address hidden>)

 -- Stefan Hornburg (Racke) <email address hidden> Thu, 5 Dec 2002 23:07:57 +0100

Thats okey but the inetd super server is not installed by default of ubuntu linux Breezy Badger (not for me). So the daemon now depends on the inetd package to be pressent when pure-ftpd gets installed. If this is not the case ubuntu will automaticly install it.

My Changelog entry is

pure-ftpd (1.0.19-7ubuntu1) unstable; urgency=low

  * pure-ftpd depends on inetd now. inetd isnt
    installed by default on ubunut linux but it will be now (Closes: ##3172)
   (https://launchpad.net/distros/ubuntu/+source/pure-ftpd/+bug/3172)

 -- rave <email address hidden> Mon, 28 Nov 2005 21:56:41 +0100

For more information:

Johnny Mast
rosiello developer

Web: http://www.rosiello.net
Mailto: <email address hidden> <mailto:<email address hidden>>
Mailto: <email address hidden> <mailto:<email address hidden>>
Pgp ID: 0x84A62F8D

please just attach the a debdiff to your fixed package, not the complete .diff.gz. This makes it very very hard to review what changes you did

Reinhard Tartler schreef:

>Public bug report changed:
>https://launchpad.net/malone/bugs/3172
>
>Comment:
>please just attach the a debdiff to your fixed package, not the complete
>.diff.gz. This makes it very very hard to review what changes you did
>
>
>
>
Yes im aware of that fact. this bug fix in fact was my first real bug
fix for ubuntu. I got redirected on what todo and in an other email i
attacked
the outcome of

debdiff pure-ftpd_1.0.19-4 pure-ftpd_1.0.19-7 >>
pure-ftpd_1.0.19.7ubuntu1.diff

--

Johnny Mast
rosiello developer

Ubuntu: Linux for Human Beings
Download your copy now !: http://www.ubuntulinux.org/download/

Web: http://www.rosiello.net
Mailto: <email address hidden> <mailto:<email address hidden>>
Mailto: <email address hidden> <mailto:<email address hidden>>
Pgp ID: 0x84A62F8D

The diff is a bit long becuase i made changes in

debian/pure-ftpd-commmon.prostinst
debian/rules

and added

debian/pure-ftpd-common.xinetd

On 12/5/05, Johnny Mast <email address hidden> wrote:
> Public bug report changed:
> https://launchpad.net/malone/bugs/3172
>
> - Changed attachments:
> Added: Dapper 1.0.19-7 to 1.0.9-7Ubuntu1
> http://librarian.launchpad.net/1188263/pure-ftpd_1.0.19-7ubuntu1.diff

This patch is a bit too big I think. No need to patch Makefile imo. If
nobody can polish this now, I will do tonight and upload a fixed
version.

--
regards,
    Reinhard

Reinhard Tartler schreef:

>Public bug report changed:
>https://launchpad.net/malone/bugs/3172
>
>Comment:
>On 12/5/05, Johnny Mast <email address hidden> wrote:
>
>
>>Public bug report changed:
>>https://launchpad.net/malone/bugs/3172
>>
>> - Changed attachments:
>> Added: Dapper 1.0.19-7 to 1.0.9-7Ubuntu1
>> http://librarian.launchpad.net/1188263/pure-ftpd_1.0.19-7ubuntu1.diff
>>
>>
>
>This patch is a bit too big I think. No need to patch Makefile imo. If
>nobody can polish this now, I will do tonight and upload a fixed
>version.
>
>--
>regards,
> Reinhard
>
>
>
>
Every thing was done how it should be done. Like the comments say i
fixed 3 files and added one. So i wondered as well about the size of the
diff file.

--

Johnny Mast
rosiello developer

Ubuntu: Linux for Human Beings
Download your copy now !: http://www.ubuntulinux.org/download/

Web: http://www.rosiello.net
Mailto: <email address hidden> <mailto:<email address hidden>>
Mailto: <email address hidden> <mailto:<email address hidden>>
Pgp ID: 0x84A62F8D

the patch is still about 500k big, there is still much unneccesary cruft left. Please use your real name in the changelog, and please reread it.

Furthermore, I'm not that happy why you change this package to install xinetd by default. Could you please give some pointer to discussion why you did this change?

I am unsure why xinetd is required also? why not just give the blue screen that the debian package gives and ask the user to choose? and default to standalone? then the user can choose if he/she wants xinetd. I'm a bit confused why this package got altered from the debian version which runs perfectly.

can you please check the current version in dapper? did the situation improve?

Please let me summarise this bug: Is this bug only because there is no inetd installed by default and the default configuration of pure-ftpd expects that?

In this case I think we should change the default configuration to run in standalone mode and add netkit-inetd | openbsd-inetd to Recommends and xinetd to suggest.

Do you agree to this?

basicly, currently the package needs to let the user choose if he/she wants inetd (if you install the debian package, can see how they do it) or standalone, as the identd is not installed on ubuntu by default, and identd is the default setup, but its not installed when this package is.

hope that makes sense.

I don't understand what this has to do with 'identd'. Do you perhaps mix up 'identd' with 'inetd'?

What do you think about the approache I outlined in my last comment?

yeah should solve the problem.

ok. then I will look into an upload of this this evening.

Changes:
 pure-ftpd (1.0.21-1ubuntu1) dapper; urgency=low
 .
   * Change the default answer for the debconf question that ask whether you
     want pure-ftpd start via inetd or standalone to standalone. (Closes:
     M#3172)
   * Add Suggests: netkit-inetd | openbsd-inetd | xinetd to pure-ftpd.