Revision 1117 - 2009-08-16
-------------------------------------
Continued cleanup of exec command classes
Fix 311013 - Specifying non-existent data or index directory does not give an error
Fix for memory overflow error on Solaris in readdir_r
Revision 1116 - 2009-08-14
-------------------------------------
Diz 412684: Fix memory corruption on Solaris
More dead code elimination
Revision 1115 - 2009-08-11
-------------------------------------
Fixes for Solaris with ufs filesystem headers
Renamed access_type to access_method due to conflicts on Solaris
Added both direct subunit to junit output targets as well as the general ability to inject extra flags into test-run via environmentRemoved unused add(Listen) methods
Renamed PluginRegistry to plugin::Registry
Moved ListenHandler to slot::Listen
Added ListenHandler as a member of PluginRegistry
pandora-build v0.41 - added more warning exceptions for protobuf
Removed myisamchk from what we install
pandora-build v0.40
Cleanup of optimizer JoinTable and Join class members
Reverts {0}; back to memset() due to compilation errors on GCC 4.2 Mac and Solaris SunStudio
Refactoring and cleanup of Listen and Protocol
Revision 1114 - 2009-08-10
-------------------------------------
lcov dead code removal
Revision 1113 - 2009-08-10
-------------------------------------
Code cleanup for BLACKHOLE,a dded more tests
Removed the typedef for nested_join_map and instead just declare these
Modified the nested_join_map typedef to be std::bitset instead of uint64_t
Fix bug 405131 - Out of memory error when trying to compile drizzletest.cc
Revision 1112 - 2009-08-06
-------------------------------------
Fix bug 394272 - Fail to create temp tables if the installation directory contains uppercase characters
Fix bug 408694 - func_main fails due to precision error on freebsd
Move global.h include into .cc file, not .h
Fix to make sure make_db_list gets the directory entries in sorted order, with I_S first
Renamed find_databases() to find_schemas() for consistency. Changed return type from int to bool
Renamed find_dirs() to find_databases()
Replace my_dir in find_files() with CachedDirectory.
Renamed find_files() to find_dirs() to more accurately reflect what it is doing after removing dead code inside it
pandora-build v0.38 - Make umem the default on solaris and not mtmalloc
Extracted the ROLLBACK command into a class with its own implementation files
Extracted the COMMIT command into its own class and implementation files
Correct some wrong resolutions that resulted from the merge with trunk
Extracted the LOAD command into its own class and implementation files
Extracted the show processlist command into a class with its own implmentation
Extracted the checksum command into its own class and implementation
Extracted the show create command into its own class and implementation
Extracted the assign to keycache command into its own class and implementation
Extracted the SHOW ENGINE STATUS command into its own class and implementation
Extracted the SHOW ERRORS command into its own class
Extracted the SHOW WARNINGS command from the huge switch statement into its own implementation
Extracting the empty query case label from the switch statement in mysql_execute_command into a command class
TBB removal from build
Revision 1111 - 2009-08-05
-------------------------------------
More extraction from sql_base
More Table refactor
Applying refactor of tmp table bits back to session
Revision 1110 - 2009-08-04
-------------------------------------
Made subunit output optional
Fix mtr to work with dbx
Fix for 32 bit Solaris builds. Issue was with conversion of 64-bit unsigned
Revision 1109 - 2009-08-03
-------------------------------------
Remove Insane Clown Posse - ICP
Remove dead functions and variables
Removal of multi-update/delete
Revision 1108 - 2009-08-03
-------------------------------------
Remove multi-update from parser/tests
Removal of multi-keycache code
Heap is now tmp only table
Revision 1107 - 2009-08-02
-------------------------------------
Collection of Valgrind fixes
Correct conditional free() on parts of HEAP share. fixes valgrind leak warnings
Fix for sys_var
Fixed plugin string valgrind leak
Fix cleanup of thread specific stuff
Reverted CreateField::interval_list to a List<String>.Fixes memory leaks introduced by converting it to a vector from previous merge
Added a valgrind suppression for pcreCorrected how memory is freed for each command
Put command::Select into sql_alloc by handReverted sql_alloc-ing of command classes
Put CreateField into the Session mem_rootCleanup a couple of delete/free mismatches
Attach commands to the Session mem_root
Revision 1106 - 2009-07-29
-------------------------------------
Fixed make dist - renamed the proto file in Makefile
Forgot to use the nothrow form of the new operatorMissed a namespace in command_log
Finished cleaning up using namespace stuffRenamed DefaultSelect to Select now that the evil global define Select is gone
Removed the Select define in sql_yacc.yy
Fixed the first set of using namespace
transaction.pb.h is now replication.pb.h
Ensure std::string buffer is initialized to a blank string, otherwise crybaby Solaris segfaults
Corrected mistake in pthread_traits fetch_and_store() method where new_value was not being stored
Restores original read bit on fields read during call to val_str in ReplicationServices::updateRecord()Was not passing length in network byte order
Rename the TransactionServices component in the kernel to ReplicationServices
Rename the transaction.proto to replication proto and updates the various programs referencing drizzled/message/transaction.pb.h
Add a public method to the kernel's ReplicationServices component: getLastAppliedTimestamp() which returns the timestamp of the last Command message which was successfully sent to a registered Applier plugin (the Command was "applied")
Update ReplicationServices::push() method to update an atomic timestamp when a Command is successfully applied by a replicator to an applier
Reset SerialEventLog::log_offset back to its original offset when a crash occurs to enable error reporting to include an accurate offset.
Handle EINTR in a while loop on pwrite() in SerialEventLog::apply()
Fixed up command_reader.cc to use korr.h macros when reading encoded length since the SerialEventLog uses those macros when writing
Add call to set read bit on fields being read in updateRecord()
Renames serial event log to command log
Had to set read bitmap for fields in insertRecord() now that certain asserts have been placed in Field classes
Updated results file for whitespace-trimmed wc output
Added tr -d ' ' to cut whitespace on Solaris/BSD from the wc program in truncate log test
Added explicit call to atomic<>.fetch_and_add() method
Added while loop on EINTR for ftruncate and no ignore of the result
Added static to methods in command_reader.cc
Merge in Padraig's fix for segfault
Fixed bug in serial event log applier which could cause a segmentation fault
Adds log truncation debugging functionality to the serial event log plugin
Fixes to Solaris atomics for atomic<bool> and signed integer pointers
Cleans up malloc/realloc in command_reader.cc
Comment out tests that currently do not work, a run of ./dtr --suite=serial_event_log now works
Add truncate test
Add code to transaction_services.cc to populate a DeleteRecord
Fix update function in command_reader add the update.inc to the all.test
Add new all.test that runs various include files and concats the result
Add test all which combines test no result file checked in yet for it
Add test for rename and rand()
Add tests for alter, database, truncate, delete, temp tables
Add DELETE test, update result files for insert and update
Add simple update and insert tests for bin log
Fixes up UPDATE test case for serial event log and TransactionServices::updateRecord to properly add the WHERE clause fields for primary/unique keys on the table
Adds multi-value INSERT test, modifies TransactionServices to support UPDATE statements
Fixes up a Solaris warning about non-reachable path by making the while loop in command_reader.cc more clear
Cleans up command_reader.cc to not call unecessary memset and to properly check all calls to read()
Add comments describing the atomic operations used in the serial event log plugin
Fixed the master.opt file for the simple serial event log test
Call realloc() and memset() only when needed in command_reader.cc
Changes the way the log_offset is atomically incremented and its value retrieved
Remove lock on serial event log and use a file offset to pwrite() to the logfileadd on --serial-event-log-enable option for the serial event log plugin
Add optimization to the registration process of replicators and appliers for TransactionServies which evaluates active plugins on attach and detach of a replicator and applier
Ignore command_reader program (BZRIGNORE)
Fixed up some comments and include guard in plugin/default_replicator/default_replicator.h
Add serial event log plugin
Add default repliactor plugin
Add command reader test program
Add serial_event_log test suite
Removed the need for the all_tables member of command classes
Adding doxygen comments to the sql_commands header file
Beginnings of reworking the mysql_execute_command() method
Converted Item_sum::outer_fields to vector<Item_field*>
Converted Tmp_Table_Param::copy_funcs to a std::deque. Delete saved_copy_funcs member of same class, as it was essentially unused and didn't affect anything
Took Sql_alloc inheritance off of Tmp_Table_Param and changed calls to session->c/alloc to new
Converted the 3 instances of List<Cached_item> to vector<Cache_item*>
Converted another local List usage to a vector
Converted a couple small local variable List<Table>s to vector<Table*>s
Adds public getConnectMicroseconds() call to Session object. Protects connect_microseconds member variable and sets it correctly.
Correct logging_xxx plugins to use getConnectMicroseconds() API call properly. Fixes Bug #402855
Add missing comma between third to last and penultimate columns in CSV output. Fixes Bug# 402831
table_map defined as uint64_t, not pointer type, so change initialization to 0 from NULL
Revision 1105 - 2009-07-29
-------------------------------------
Fix indentation of temporal_interval.h per IRC conversation with clint
Build fix - we were testing the wrong macro value
Fix for gnulib mktime test & replacement
Fix read_many_rows_innodb test to use InnoDB instead of MyISAM for now
Using static_cast and uint32_t per coding standards
Using constants for magic numbers and true/false instead of 1/0. renamed getIntervalInfo -> getIntervalFromString for clarity
Use C++ style cast for int_type
Coding standards cleanup
Style/documentation cleanups and replacing copyright notices
Refactoring INTERVAL into C++ class
Remove dead options
Revision 1104 - 2009-07-28
-------------------------------------
Removing semi_join code
Revision 1103 - 2009-07-28
-------------------------------------
Removal of all basic MRR
Revision 1102 - 2009-07-28
-------------------------------------
Removed more unreachable code path in StorageEngine to fix Solaris compile failure
Removed unreachable path in archive handler
Merge Stewart's basic discovery branch
Only try to delete table proto if engine does not have own data dictionary
Misc codestyle fixes. usually around if ( and associated conditions
Remove passing table proto to TableNameIterator as it is currently unused
Fix error path in rea_create_table for failure to create proto
s/Impl/Implementation/
Fix location of #include for my_dir.h
Add missing table_proto.h
Fix TableNameIterator for the case where last engine has a impl
Fix up const ref parameters for database names in TableNameIterators and class constructors
ARCHIVE TableNameIterator. This fixes SHOW TABLES for ARCHIVE tables. Although it is important to note that the *order* of tables in SHOW TABLES is no longer 'sorted'
Iterate over StorageEngines and use their TableNameIterators before the default DFE Iterator
Move to TableNameIterator and impl type interface. basic TableNameIterator just uses DFE iterator
Start using an iterator like object for traversing tables in a database (SHOW TABLES)
Remove need to write table proto to disk in .dfe if engine can handle it (new StorageEngine flag)
Fix up delete_table_proto code paths to work properly with engines handling their own protos
Move writing the proto out from filling it so we can later override it with engines
Refactor CREATE TABLE LIKE so that there's only one place where we write the proto
get_table_category doesn't need table name and can be static to table.cc
Remove requirement of having to re-read table proto on CREATE TABLE. Now we only have to do it if we didn't have a table_proto passed to ha_create_table
Return with error from create_table_proto_file if unable to write proto. This means we err out for ER_BAD_DB_ERROR sooner and don't continue into ha_create_table
Moved file based flag up to engine (from handler). checkLowercaseNames() is now a ember of StorageEngine
Add small test for the (very basic) discovery in ARCHIVE engine
Implement ArchiveEngine::getTableProtoImpl
Preserve stored proto in ARZ across OPTIMIZE TABLE
Refactor ha_resolve_by_name to accept std::string instead of LEX_STRING
Refactor create_table to only have one call to create_table_proto_file and not have a is_like parameter which was only used in one place
Use StorageEngine::getTableProto instead of drizzle_read_table_proto. We only read the proto file now in SE::getTableProto
Remove ha_table_exists_in_engine and use StorageEngine::getTableProto() instead
StorageEngine::getTableProto() instead of table_proto_exists. allowing engines to implement their own getTableProtoImpl() to check if table exists. if proto is not null, should fill proto. This is next step (replacing calls to read_table_proto with calls to SE::getTableProto
Merge ARCHIVE storing table proto
Merge table proto passed to createTable and ARCHIVE storing proto in ARZ
Make ARCHIVE engine write table proto into 'frm' part of ARZ header. i.e. table proto now in .ARZ like the FRM was in MySQL (except cleaner, as we're not reading it off disk, we just deal with the data structure directly)
Start passing down table proto to createTable. This enables future code cleanup, including fixing ARCHIVE embedding table definition and table proto in parser
Move drizzle_proto_exists and drizzle_read_table_proto out of unireg.h and into table_proto.h
Remove copy_table_proto_file and replace with read and write proto calls. affects CREATE TABLE LIKE
Make writing the proto file sep to just creating the table. this allows the future removal of copy_table_proto_file. Add table_proto.h header for table proto manipulation stuff
Revision 1101 - 2009-07-27
-------------------------------------
Merge Monty's pandora build tree
Fixed the md5 linking error
Add no-cast-align on libpars.la
Removed drizzlecheck references from test-run.pl
Removed drizzlecheck program and the myisamcheck test
Added support for conditionally building plugin's test suite if the plugin is built
Turned off Werror in gnulib/
Rearranged two orderings
Avoid cast-align warnings on InnoDB
Tured off warnings for gnulib build. Stop innobase from setting global CFLAGS
Fixed an accidental revert of lib-prefix.m4
Fixed the way pthreads were being compiled/linked. Eek
Get things compiling on FreeBSD (7.1)
Revision 1100 - 2009-07-26
-------------------------------------
Small optimization to make table listing simpler
Refactor TableShare has to be behind class
Revision 1099 - 2009-07-22
-------------------------------------
Merging in Padraig's final I_S plugin work
Removing a constructor in the InfoSchemaTable class that is no longer needed
Updating I_S test case and result file as the queries on the STATUS and
Updated I_S test case and result file
Updated the I_S test case and result file after extracting the remainder of
Extracted the VARIABLES tables into the I_S plugin
Extracted the 3 STATUS tables into the I_S plugin
Removed using namespace entries from bare headers
Added in global.h to the includes so that flags are set correctly
Merge Robert's readline/linebuffer work
Convert logic to use std::stringstream for buffer
Replace typedef struct LINE_BUFFER with class LineBuffer, encapsulating current logic
Revision 1098 - 2009-07-21
-------------------------------------
Solaris build fixes
Plugin class cleanup round 1
Removed a dynamic array
Naming cleanups
Split out handle and library
Split drizzle::plugin::Manifest into its own file
Rename of plugin classes
Revision 1097 - 2009-07-16
-------------------------------------
Fix Solaris linker error identified on bitters
Fixed mktime for sun studio debug builds
Solaris GCC fixes
Fixed some warning triggers for solaris gcc
Removed dangerous asserts
Fix for const char conversion failure on Solaris
Fixed uncrustify config. Added the clean_source script
Merged in trond's new autorun.sh from libmemcached
Got rid of #ifdef have utf8 stuff
Removed mentions of MB_IDENT - it's always true
Removed character_sets.m4 and the code around. There is no need to check to see if we're going to build utf8. We are always going to build utf8
Revision 1096 - 2009-07-15
-------------------------------------
Fix SHOW CREATE DATABASE for default collation
Move database metadata reading code around to be a bit more sane
Convert global_error_names from a c array to a c++ std::map
Remove a bunch of dead code and unused variables in drizzled.cc and server_includes.h
Revision 1095 - 2009-07-12
-------------------------------------
Formatting cleanup
Converted function/length into plugin/length
Added function alias octet_length
Removed item_func_length from item/create.cc
Fixed #includes in plugin/length/length.cc
Fixed length/plugin.ini
Refactored function/length into plugin/length
Cleaned up commented-out sections from item/create.cc
Refactored function/benchmark into plugin/benchmark
Refactored function/connection_id into plugin/connection_id
refactored function/version into plugin/version
Converted function/char_length to plugin/charlength
Corrected function name, now char_length and character_length
Fixed plugin/charlength/charlength.cc
Removed char_length from item/create.cc
Refactored functin/charlength into plugin/charlength
Refactored function/ascii into plugin/ascii
Fixed case: crc32Function -> Crc32Function
Fixed case: md5Function -> Md5Function
Cleaned up formatting in md5.cc
Revision 1094 - 2009-07-11
-------------------------------------
Fix func_in test to include explain for some MRR queries again
Merge in temp MyISAM UPDATE is TRUNCATE bugfix and fix tests accordingly
Fix bug 387627: UPDATE can be TRUNCATE on TEMPORARY TABLE
Remove HA_EXTRA_MMAP, only ever used by MyISAM for non-temp tables
mysqldump-max test: MyISAM table would not be dumped due to being temporary only. Use another non-txnal engine (ARCHIVE)
Fix tests for MyISAM as temp table only
Fix myisamcheck for MyISAM as temp only: MyISAM tables are no longer cross-session
t5_nontrans in innodb_trx_weight test needs to be non-transactional table - else we hit innodb lock timeouts
Revision 1093 - 2009-07-11
-------------------------------------
Fix TABLE_REF structure
Sorting methods into class files
Refactor dynamic out to its own files
Cleanup on enum
Remove dead caller
Revision 1092 - 2009-07-11
-------------------------------------
Collection of patches/bug fixes from new-cleanup tree
Put in configure trap for libdrizzle version
Bug #385227 ! fixes for grouping of min() max() calls. ! operator should be for entire statement, rather then the AND block
Changed Trond's patch to also support libumem on Linux
Fix correct result for drizzledump
Remove unused #ifndef DONT_ALLOW_USER_CHANGE from client programs
Fix version printouts for drizzledump
Fix drizzledump copyright header
Modified the flags member of the Alter_info class to be std::bitset instead of uint32_t
Replaced an instance where a uint8_t type was being used to hold a collection of flags, converted to a std::bitset<2>
Modified the size of the test_flags bitset to be 12 bits instead of 32, no bit past 11 is ever used so no need to a bitset of size 32
Converted the test_flags variable from a uint32_t to std::bitset
Bug 397023: --core-file doesn't work as intended
Allow linking with libumem instead of libmtmalloc
Put CachedDirectory in mysys namespace
Added std namespace to sql_base.cc and default.cc to replace std::
Replace use of MY_DIR in sql_base.cc with CachedDirectory class
Replace use of opendir/readdir in default.cc with CachedDirectory
Add a new CachedDirectory class that handles opendir/readdir operations for all systems
Revision 1091 - 2009-07-10
-------------------------------------
Collection of patches from new-cleanup (includes asserts for field in debug)
Updating ignore file to remove TAG
Shuffled free_cached_table() to table
Removed dead flag code, style cleanup in FK. Removed dead structs
Cleanup of user_var
Optimization for createKey(). Removes the need to initialize some structures
Fix protobuf to release memory
Add in assert() for wrong column usage
Fix memory leak in temporal
Remove of JOIN_TAB to JoinTable
Revision 1090 - 2009-07-09
-------------------------------------
Fix canonical_target args
Removed unused macros
Split out warnings
Start using the pandora build system
Fixed -Wmissing-declarations
Added initialization to XARecover::result
Revision 1089 - 2009-07-04
-------------------------------------
Merge metadata test fix
Fix length of timestamp type for metadata test (and fix its result)
dtoa can pass NULL to Bfree. so just ignore those calls
Correct Bcopy in dtoa() now that the ULong doesn't come directly after the Bigint.
Add in sanity checking assert() for if we're going to clobber memory
Remove dtoa_alloc and dtoa_free and replace with just malloc() and free() calls directly
Convert dtoa to use plain malloc() and free() instead of custom allocator
dtoa wasn't allocating enough memory for trailing \0, causing crashes on 32bit x86
Replace MAX_(DATE|TIME).*_WIDTH defines in definitions.h with real (and correct) static const members to Temporal types
Change temporal to_string routines to use snprintf instead of sprintf
Revision 1088 - 2009-07-04
-------------------------------------
Reversing patch that Solaris has issues with
Revision 1087 - 2009-07-03
-------------------------------------
Further removal of dead dir sym code
Removed st_add_schema_table struct and moved data members into the AddSchemaTable class/functor
Converted st_add_schema_table::files from List<LEX_STRING> to std::vector<LEX_STRING*>
Refactored find_files function
Revision 1086 - 2009-07-02
-------------------------------------
Removed use of my_dir in sql_base.cc
Add missing call to closedir()
Revision 1085 - 2009-07-02
-------------------------------------
Code style clean
Revision 1084 - 2009-06-30
-------------------------------------
Updating I_S result file after extracting STATISTICS table into I_S plugin
Extracted the STATISTICS table into the I_S plugin
Updating the I_S test case and result file after extracting the SCHEMATA
Extracted the SCHEMATA table into the I_S plugin
Updating doxygen comments in I_S related classes to be of the correct format
Extracted OPEN_TABLES into the I_S plugin
Updated the I_S test case and result file after extracting TABLES into the
Extracted TABLES into the I_S plugin
Extracted the TABLE_NAMES table into the I_S plugin
Updated I_S test case and result file after extracting COLUMNS table into
Extract the COLUMNS table into the I_S plugin
Revision 1083 - 2009-06-30
-------------------------------------
Renamed file
Removed unneeded code in drizzlecheck
Added file existence test for gcc-4.2 check on osx
Build fixes
Revision 1082 - 2009-06-30
-------------------------------------
Fixed a few more system dependent type errors (size_t vs unsigned vs long unsigned)
Fixed type differences for min/max calls on OSX
Converted all cmin/cmax usages in the mysys, mystrings and plugin directory to std::min/max
Converted all usages of cmax in drizzled/field/ and drizzled/function/ to std::max
Converted single usage of cmin in drizzletest to std::min
All files in drizzled/item/ now use std::min instead of cmin
All files in drizzled/function/ now use std::min instead of cmin
Revision 1081 - 2009-06-29
-------------------------------------
Updated the I_S test case result files
Extracted TABLE_CONSTRAINTS, KEY_COLUMN_USAGE, REFERENTIAL_CONSTRAINTS and PLUGINS tables into the I_S plugin
Revision 1080 - 2009-06-29
-------------------------------------
Remove use of my_dir() from defaultcc
Revision 1079 - 2009-06-28
-------------------------------------
Modifying the way the vector of column's are cleared up
Updating Doxygen comments in the I_S plugin
Updated I_S test cases and result file
Extracted the character set applicability table into the I_S plugin
Extracted the COLLATIONS table into the I_S plugin
Extracted the CHARACTER_SET table into the I_S plugin
Removing unused parameters from some functions in showcc
Converted the const char * members of InfoSchemaTable to be std::string
Converted the const char * members of ColumnInfo to be std::string
Revision 1078 - 2009-06-27
-------------------------------------
Use PCRE_HEADER instead of <pcreh>
Revision 1077 - 2009-06-27
-------------------------------------
Converted SEL_TREE::merges to a vector<SEL_IMERGE*>
Revision 1076 - 2009-06-25
-------------------------------------
Fixed bind conflict
Fixed uninitialized variable
Cleaned up error messages and a few other things from Jay's review
Finished up new Listen plugin interface
Removed log option in test runner, no longer used
New Listen interface
Revision 1075 - 2009-06-25
-------------------------------------
Fix issue for CentOS
Revision 1074 - 2009-06-25
-------------------------------------
Remove obsolete tests
Revision 1073 - 2009-06-25
-------------------------------------
Adding some extra doxygen comments to the ColumnInfo class
Removed the getSpecificColumn(), beginColumnInfo(), endColumnInfo() methods
Converting arguments and member variables for ColumnInfo and InfoSchemaTable
Updating the doxygen comments for the I_S plugin
Modularized the info schema plugin
Modified the InfoSchemaTable class to now hold information on columns in a std::vector
Updated the I_S test case to perform queries on the PROCESSLIST table
Created an I_S plugin Extracted the PROCESSLIST table into this plugin
Revision 1072 - 2009-06-25
-------------------------------------
Remove dead SHOW ENGINE LOGS code
Have SHOW_ENGINE_STATUS use Lex->show_engine instead of HA_CREATE_INFO.db_type as it will be going away
Remove unused log-isam server option
Remove (unused) myisam_recover_options now that REPAIR is gone
Remove keep_files_on_create
Beginning of create table proto in parser
Revision 1071 - 2009-06-24
-------------------------------------
Reintroduce the ALTER TABLE tests from CSV.test
Re-introduce csv.test
CSV as temporary only engine
Preserve temp table status across ALTER TABLE
Add support for temporary only engines
Revision 1070 - 2009-06-24
-------------------------------------
Fix for Centos 5.2
Revision 1069 - 2009-06-24
-------------------------------------
Check result from symlink() in ha_archive and do the right thing
Fix build warning that were ignoring the result of symlink
Removed my_realpath from my_symlink and replaced it with calls to posix realpath
Remove declaration and definition of my_readlink, it is no longer used
Replace calls to my_readlink with readlink
Revision 1068 - 2009-06-24
-------------------------------------
Fix protobuf 2.1 issue
Revision 1067 - 2009-06-19
-------------------------------------
Changing name of FieldInfo class to ColumnInfo
Converted the ST_FIELDS_INFO structure to a class named FieldInfo
Added a new header file which contains the InfoSchemaTable class and the InfoSchemaMethods class
Modifying the addInfoSchemaMethods method to pass a parameter as a reference
Removed the function pointers in the InfoSchemaTable class
Updated patch to follow the coding standards when it comes to variable names
Re-factored the InfoSchemaTable structure to now be a class
Revision 1066 - 2009-06-19
-------------------------------------
Remove ha_check_and_repair Engines should take care of this themselves
Revision 1065 - 2009-06-19
-------------------------------------
Mark ER_NISAMCHK and ER_HASHCHK as unused
Revision 1064 - 2009-06-19
-------------------------------------
remove REPAIR TABLE
Revision 1063 - 2009-06-13
-------------------------------------
More style cleanup in files associated with Copy_field to CopyField change
Changed container from list to vector for CreateField::interval_list
Changed Send_field to SendField to be consistent with coding standards
Changed Create_field to CreateField to be consistent with coding standards
Changed Copy_field to CopyField, to reflect the coding standards
Converted Create_field::interval_list to a std::list<String*>
Revision 1062 - 2009-06-13
-------------------------------------
Clean up unused targets in top level Makefile, remove LOCK TABLES from csv.test
Move csv tests back to regular test suite, remove dead test files, add top level test
-all target
Removed all master/slave-specific code in drizzledump
Removed rm_dir_w_symlink method call with rmdir since dir should not be a sym link in
the first place
Revision 1061 - 2009-06-11
-------------------------------------
Doxygenates documentation for name_resolution_context.h
Documents and doxygenates all the myriad classes in opt_range.h
Documentation and indentation/style cleanups in sql_select, opt_range.h and join_tab.h
Refactors sys_var class -- doxygenates and documents the class members and functions
Removes dead set_empty_value_allowed() method of set_var
Removes dead variables in set_var.h
More style cleanups in Session
Removes dead Session::catalog member variable
Removed unused cached character set variables in Session along with dead update_chars
et() method
Remove dead Session::compression member variable
Documentation and style fixes in Session and Item class
Move Create_field implementation out into its own implementation file
Remove dead get_blob_type_from_length() function
Breaks Create_field definition out into its own header file
More documentation cleanup for Field class
Removal of dead Field::image_type and st_key_part::image_type member variables
Style, indentation, and doxygen/documentation cleanup on Field class. Removal of dead
methods in Field
Removed dead Table::table_check_intact() method
Cleanup of style, indentation, and documentation of Table class members. Removed dead
Table member variablesRemoves dead st_table_field_w_type structure
Revision 1060 - 2009-06-10
-------------------------------------
Fixed file encoding on OSX
Modified the show_wild rule to also support WHERE clauses
Removed leftover debuggig printf
Made tablename_to_filename available across the server now
Removed my_charset_filename
Fixed the drizzlecheck bug
Removed extra unused TableList from table.proto
Went to 4 byte encoding instead of three
Removed strconvert
Removed copy_and_convert
Removed more charset conversion code
Removed CHARSET_INFO stuff from protocol plugin interface
Revision 1059 - 2009-06-09
-------------------------------------
Fixed my libdrizzle version mismatch fix
Fixed missing return code. This will be removed later and is just until we want to make libdrizzle 0.3 a requirement
Disabled tcmalloc to be on by default, this was the cause of a significant regression
Fixed return code reporting with new libdrizzle for drizzletest
Revision 1058 - 2009-06-08
------------------------------------
Remove dead lock.cc commands
Move open_table() to session
This is a large number of refactors against the Session class for its
Remove lock_tables list from session
Refactor TableList methods
Revision 1057 - 2009-06-08
------------------------------------
Fix staging build issue
Revision 1056 - 2009-06-08
------------------------------------
Removde unused new/delete operators
Kill file related memory leaks. Unfortunately, we need to convert close(2) over to my_close() since files are being opened with my_open() which obtains memory through strdup(3)
Add memory allocation check and fix SEGV problem caused in statement_cleanup() by using calloc. This is temporary
Fixed a . vs -> typo
Changed all instances of I_List<COND_CMP> to vector<COND_CMP>
Fix bug and add tests for #309547. Also identified by MySQL #41610
table_map takes ints, not pointers
Revision 1055 - 2009-06-07
------------------------------------
* Removal of LOCK TABLES.
* Remove dead lock functions, and remove bits from sql_lex.h/sql_yacc union.
* Remove SQLCOM_LOCK_TABLES
Revision 1054 - 2009-06-05
-------------------------------------
* Logging plugin improvements, additional logging
* Add PCRE matching to logging to file
Revision 1053 - 2009-06-05
-------------------------------------
* Fix LOCK (it was dead, only for dead RENAME SCHEMA code)
* Remove unused ha_prepare(), prepare is always called on specific engine
* Add result file for createdb INFORMATION_SCHEMA test
* Add code coverage for ALTER DATABASE
* Add test for CREATE DATABASE INFORMATION_SCHEMA returning ER_DB_CREATE_EXISTS
* Remove old handler methods for DDL from handler.h
* Remove old code for changing databases only called from stored procedures
* Remove dead code from db.cc
* Remove handler::ha_delete_table and have StorageEngine::deleteTable instead
* Move ha_rename_table to just be StorageEngine::renameTable with engines implementing renameTableImpl
* Re-introduce marking transaction as read-write for engine on create_table
* Remove handler::ha_create and just use StorageEngine::create_table
* Fix myisam delete_table path: should be in StorageEngine
* Move handler::rename_table to StorageEngine
* Move handler::create to StorageEngine::create_table
* Move delete_table out of handler and up into StorageEngine where it belongs
* Move bas_ext to StorageEngine instead of handler
Revision 1052 - 2009-06-04
-------------------------------------
* Caught leftover printf()
Revision 1051 - 2009-06-04
-------------------------------------
* Remove lock count call
* More redactoring of all lock issue code that is session bound
* Remove malloc() of table
* Simplify close_cached_tables() (it now always locks)
* Refactor call close_old_data_files to Session object
Revision 1050 - 2009-06-04
-------------------------------------
* Remove caller that wasn't correctly locking, and reverted code to 5.1 locking
* Remove race condition around refresh
Revision 1049 - 2009-06-03
--------------------------------------
* Additional Style cleanup
Revision 1048 - 2009-06-03
-------------------------------------
* Removed useless handler call (was for MERGE)
Revision 1047 - 2009-06-03
-------------------------------------
* Formatting/style cleanup
* Move lazy read of refresh to outside of LOCK_open (we don't lock the refresh
* Remove double lookup for cleaning open table cache
* Comments on LOCK_open
* Remove dead code
Revision 1046 - 2009-05-31
-------------------------------------
* More code style clean up
* Move JOIN_TAB definition out into its own header
* Phase 2 and 3 of refactoring JOIN
Revision 1045 - 2009-05-31
-------------------------------------
* Factored out dead enum
* Remove "dead" table definitions
Revision 1044 - 2009-05-30
-------------------------------------
* Be a little bit more verbose. Also, prefer newer autoconf/automake/libtoolize if they are available
* Ensure that the dirlist is sorted
* Moved pthread check so that the protobuf check works right for real
* Added toupper to registry
* Changed name to std::string
* Moved more tolower calls to setup rather than during runtime
Revision 1043 - 2009-05-29
-------------------------------------
* First phase refactoring the JOIN class:
Revision 1042 - 2009-05-29
-------------------------------------
* Fix for gcc 4.1
* Removed dead bit in Session
* Removed dead code around alter table/MERGE tables
* Refactor function to make sense
* Partial Refactor of TableShare
* Style cleanup
Revision 1041 - 2009-05-27
-------------------------------------
* Comment out failing tests until 364991 and 377826 are fixed
* Remove bit_count
* Remove bit_length
* Fixed md5 check on OpenSolaris
Revision 1040 - 2009-05-27
-------------------------------------
* Remove second load file for open_table parsing of DFE
* Refactor for build_table_filename()
* Remove lower case filename bits
* Modified alias to being const
* Remove dead bits from db create/rm
* Remove bits of dead code from Storage Engine interface
Revision 1039 - 2009-05-25
-------------------------------------
* Removed thread-safe in MY_BITMAP
* Made REGINFO into RegInfo and responsible for initializing itself
* Replaced a malloc with a calloc
* Finished splitting out per-platform logic for tcmalloc/mtmalloc
* Fixed an overzealouse no-inline fix
* Fixed some no-inline warnings
* Build/dist fixes. Added my_print_defaults back for now - test_run needs it.
* Removed unneeded deps on mysys and mystrings from myisam plugin
* Imported manpages for the things we ship
* Removed my_print_defaults, innochecksum and mysql_waitpid
* Delete drizzled_safe and drizzleddumpslow
* First stab at a #define to template replace
Revision 1038 - 2009-05-23
-------------------------------------
* Remove locks around my_open()
Revision 1037 - 2009-05-22
-------------------------------------
* Remove dead bits to the end of functions
* Increase the default sort buffer size
* Small refactor of db.cc
* Fixed TableList to correctly construct (and removed memset() calls
Revision 1036 - 2009-05-22
-------------------------------------
* Remove dead code for bit operations
* Fix buffer overrun in string::c_ptr, now handles all cases properly
* First attempt at supporting gcc-4.4
Revision 1035 - 2009-05-22
-------------------------------------
* Collapse field classes
* Correct if() style
Revision 1034 - 2009-05-21
-------------------------------------
* Remove dead code
Revision 1033 - 2009-05-21
-------------------------------------
* Fix almost_full test
* Fix missing drop table at end of almost_fulltest
* Remove unused extern specialflag
* Add simple test for LIMIT X OFFSET Y Increases parser code coverage testing
* Add test for ALTER column DROP DEFAULT Improves sql_yaccyy code coverage
* Remove unused isDatabaseLowByteFirst()
* Remove handler::table_type() as same information can be retrieved from handler::engine->getName()
* Slight semantic improvement in handler::can_switch_engines
* Fix setting table type in proto for CREATE LIKE schema table
* Remove unused ha_create_handler_files
* Add table type to table proto generated in parser
* Put table_name into table proto in parser, and use that when creating table proto file
* Merge initial work for creating table proto in parser
* Remove (old) code to default back to default storage engine
* Set create_table_proto to NULL in lex_start
* Start work to construct table proto in parser
Revision 1032 - 2009-05-21
-------------------------------------
* Final bits to structure alignment
* More alignment for structures
* Straighten out structures (remove some some dead bits)
Revision 1031 - 2009-05-20
-------------------------------------
* added a test-all target that runs all the test suites specified by macro
* remove --big-test flag
* move csv tests suite suite/csv
* add tests for hello_world plugin and add target in tests/Makefile to run all plugin tests
* Added support for protobuf v210
* Remove ilink inheritance from Statement
* Reformatted refactored bits per monty's suggestion
* Replaced global I_List<Session> with std::vector<Session*>
* Added support for using gnutls instead of openssl for the md5 plugin On Debian,
* auth_pam plugin check needs stdlib to compile
Revision 1030 - 2009-05-18
-------------------------------------
* Updated the pluginac to not break sun
* Add a header to the auth_pam check
* Fixed turning off plugins
* Fixed help text/ argument mismatch
* Small cleanup inspired by merge
* Merge duplication between uniregh and definitionsh
Revision 1029 - 2009-05-18
-------------------------------------
* Remove mysqldump-no-binlog tests obsolete
* Remove strict_autoinc tests as this mode is inappropriate for Drizzle
* Fix mysqldump test to work with drizzle -> drizzledumptest
* Fix drizzledump dying on connection error (int as %s arg)
* Always use backticks in drizzledump
* Always clear destination string when parsing arguments in drizzletest
* Remove evil that is operator overloading
* Fix print of error in drizzledump
* Fix test result now that SHOW CREATE TABLE is fixed
* Fix SHOW CREATE TABLE output for index part length
* Fix 2 drizzledump bugs in processing of --compatible arguments
* Remove unused global variable in drizzledump (from DBUG)
* Remove strict_autoinc test files as that sql_mode makes it impossible to restore sql dumps, Drizzle won't have this
Revision 1028 - 2009-05-18
-------------------------------------
* Remove output from ed during smf install
* Add configuration files to integrate to Solaris SMF
Revision 1027 - 2009-05-18
--------------------------------------
* Code style cleanups and removal of st_parsing_options
* Code style cleanup and removal of dead LEX_SERVER_OPTIONS struct
* Split Lex_input_stream out into its own header
* More documentation of LEX member variables and removal of slave_session_opt unused member variable
* Remove useless autocommit member variable of LEX
* Cleanup of LEX structure Removed unused xid member variable, documented a number of member variables
* Removed unused set_query_tables_list() method of Query_tables_list class
Revision 1026 - 2009-05-16
--------------------------------------
* Add test cases for crc32 plugin, remove old tests
Revision 1025 - 2009-05-15
-------------------------------------
* Removed unused st_lex_local struct
* Cosmetic: make sql_lexh include guard match rest of drizzled/ headers
* Adds a md5 test case suite for the md5 UDF plugin
Revision 1024 - 2009-05-15
-------------------------------------
* Fix for breakage in merge
Revision 1023 - 2009-05-15
-------------------------------------
* Merge in changes for charset and dead code cleanup
* Force UTF8 (remove the bits for looking for ascii)
* Remove dead convert functions for character sets and dead code in mysys
Revision 1022 - 2009-05-15
-------------------------------------
* Merge some auto-inc fixes
* Make sql_mode=NO_AUTO_VALUE_ON_ZERO default
* Move Item_default_value out into its own files under drizzled/item/
Revision 1021 - 2009-05-15
-------------------------------------
* Remove thread_specific_used
* Remove old keywords/small bits of lex cleanup
* Remove Dead code (factord out a bit ago)
* Removed dead code from table_list
Revision 1020 - 2009-05-14
-------------------------------------
* Remove session from show variables
Revision 1019 - 2009-05-14
-------------------------------------
* Remove the need for TMP_TABLE_KEY_EXTRA (we don't replicate temp tables)
Revision 1018 - 2009-05-14
-------------------------------------
* Remove "BINLOG" from variables, not needed for Drizzle replication
Revision 1017 - 2009-05-14
--------------------------------------
* Drop dead session pass
Revision 1016 - 2009-05-14
-------------------------------------
* Remove dead session calls
* Factor out need for session in many "schema" calls
* Removed variable about collation for schema from session
* Simplify the calling stack for getting schema collation
Revision 1015 - 2009-05-14
-------------------------------------
* Fixed result sets for tests with new repair code
* mysql_admin_table() now properly sets HA_ADMIN_CORRUPT before sending back a result for a table that is unopenable
* Look for ''/bzr in configure when checking for bison, not bzr
* Add test for CREATE TABLE SELECT column order for insert if table already exists
* Release latches in case bulk insert takes a long time - bug 32149
* Fixes 376322: configure fails on CentOS machines
Revision 1014 - 2009-05-13
------------------------------------------
* Fix for processlist
Revision 1013 - 2009-05-12
-------------------------------------
* Merge in refactoring around lock system
* Remove LOW_PRIORITY call
* Removed TL_READ_HIGH_PRIORITY
* Remove dead TL_WRITE_LOW_PRIORITY
* Removed old DELAYED keyword from parser (plus cleaned up tests)
Revision 1012 - 2009-05-13
--------------------------------------
* Remove dead lock code around delayed INSERT
Revision 1011 - 2009-05-11
-------------------------------------
* Fixed more autoconf bugs
* Fix for bug #372367, pcre header detection
* Fixed copyright on gearman_udf plugin
* Solaris fixes for Gearman UDF
* Rewrote gearman add function to use string properly, fixed plugin dependency issue with drizzled
* Fixed gearman_udf plugin to use new plugin system
* Complete Gearman UDFs
Revision 1010 - 2009-05-11
-------------------------------------
Replacing Sun employee copyright headers
Revision 1009 - 2009-05-10
-------------------------------------
* Removed unneeded code
* Removed stored_fields
* More my_bitmap header cleanup
* Removed vestigal bitset<MAX_FIELDS> references
* Turned macros in my_bitmap into honest inline methods
* Removed open_by_handler
* Got rid of column_bitmap_signal Unused
* Removed register_field_in_bitmap - unused
* Removed is_stored - was only used for VCOL
* Re-added bitset<> as a replacement for Bitmap<>
* Reverted earlier bitset patch
Revision 1008 - 2009-05-06
--------------------------
* Updated po files
* Fix function argument checking for (un)compress(ed_length) functions also add tests
* Add tests to func_crc32 to check that parameter count is checked
* Add check for argument numbers for UDFs Fix crc32 and md5
Revision 1007 - 2009-05-05
-------------------------------------
* Merge handler cleanup (and ALTER TABLE cleanup)
* Remove dead definition bits
* Removed query cache bit
* First pass in alter table cleanup
* Enable "old" alter table by default
* Memset should be used for init
* Begin of abstract out the bitmap from direct reference
* Remove dead in_read_set() from blob fields
* Cleanup to use new/delete
* The call for setting columns was backwards
* Add mark_columns_used_by_index_no_reset() with just index (assumes read_set then)
Revision 1007 - 2009-05-05
-------------------------------------
* Move rename back
Revision 1005 - 2009.05.04
-------------------------------------
* Fixed a race condition build problem that showed up with make -j32
* Removing commented-out sprintf instance
* Added POTFILES in the .bzrignore file.
* Created test case for default database collation
* Initializing ret in function row_raw_format
* Fixed autorunsh to actually work from a tarball.
Revision 1004 - 2009-05-04
-------------------------------------
* Remove creation of datadir in make install
* Added interface for field to get read/write on its own
* Factored out is_stored
* Removing dead column_bitmaps_signal() call
* Remove dead bit around SQL handler
* Removed dead no_replicate
Revision 1003 - 2009-05-03
-------------------------------------
* Fixed gnulib/gettext
* Cleaning up extern reference to errbuff
* Added else in Date::to_time_t
* Removed str2int() from the original string library Use strtol(3) instead.
* Reverted back to building drizzled in drizzled
* Fixed the isainfo check progs to prevent it being called on _NOT_ Solaris
* Fixed deinit.. should call remove, not add
* Made client programs install properly
* Made better warning messages
* Remove comments, do/while, spaces per Monty review
* Replace macros around uniregh, store_record,restore_record,cmp_record,empty_record
* Fixed CLEANFILES
* Removed the m4-based plugin system
* Added support for list of headers in pluginini
* Adding plugins to new plugin system, reworking plugin infrastructure
* Added support for default sources= .. when there is only one file and it's the same name as the plugin, you don't have to say so.
* First pass at replacing pluginm4.
* Removed the to_string() method call on std::bitset
* Removing an unused parameter in a function in the MyISAM storage engine
* Printing of bitsets now working correctly
* Removed dependence on ostringstream for the print method Now
* Hexadecimal output to be in uppercase
* Fixing the way a key_map is created in myisam
* Removing calls to to_ulong() This could have thrown an out_of_range
* Removing the is_subset method from key_mapcc file.
* Fixing the is_prefix method in key_mapcc file to work correctly.
* Defining key_map to be std::bitset<64> when MAX_INDEXES is less than or
* Cleaning some header file includes after removing my_bitmaph.
* Removed my_bitmap[cc,h] files from the mysys directory.
* Initial work on replacement of Bitmap<>
* Able to specify the gearman function the gearman logging is sent to
* Updated po files
Revision 1002 - 2009-05-01
-------------------------------------
* Refactored out the share to being an object
Revision 1001 - 2009-04-28
-------------------------------------
* Simple bit for dead init
* Refactoring TableShare object
* Turn init_tmp_table_share into a method (the memset of the object.. cute).
* Remove dead call to init_tmp_table_share()
* Remove dead table bits from old replication for ROW
Revision 1000 - 2009-04-28
-------------------------------------
* Fixed crash in show processlist
Revision 999 - 2009-04-27
-----------------------------------
* Remove vcol tests
* Remove Final bits for Virtual Column code
* Removed dead files
Revision 998 - 2009-04-27
-----------------------------------
* Patch on show processlist