Changes from alpha 4 to alpha 5
===============================
2010-10-21 senator
* Open-ILS/web/js/ui/default/serial/subscription.js: Backport r18442 from trunk,
autogrid cut-off tweak
2010-10-21 phasefx
* Open-ILS/xul/staff_client/server/circ/checkout.js: ilsevent is no longer a
number, but a string. I knew that, but missed this test
2010-10-21 gmc
* Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher/asset.pm,
Open-ILS/src/perlmods/OpenILS/Application/SuperCat.pm,
Open-ILS/src/sql/Pg/002.functions.config.sql,
Open-ILS/src/sql/Pg/002.schema.config.sql,
Open-ILS/src/sql/Pg/040.schema.asset.sql,
Open-ILS/src/sql/Pg/1.6.1-2.0-upgrade-db.sql,
Open-ILS/src/sql/Pg/upgrade/0444.schema.upper-bytea.sql: improve call number
sorting
oils_text_as_bytea now does uppercasing in addition
to converting strings to bytea, working around
the limitation that json_query can't stack transforms
Signed-off-by: Galen Charlton <email address hidden>
2010-10-20 gmc
* Open-ILS/src/perlmods/OpenILS/Application/Circ/Holds.pm: use a transaction when
searching for the nearest hold request
Solves the following problem in a setup that uses Slony - if
multiple items that can fulfill the same hold are checked
in one after another, occassionally two items will end up
being put in transit for the same hold request.
Signed-off-by: Galen Charlton <email address hidden>
2010-10-20 erickson
* Open-ILS/src/perlmods/OpenILS/SIP.pm,
Open-ILS/src/perlmods/OpenILS/SIP/Patron.pm,
Open-ILS/src/perlmods/OpenILS/SIP/Transaction/Checkin.pm: added some time
diagnostics to checkin process; more org unit caching; do less user fleshing on
hold user during checkin (only card and name is needed)
2010-10-20 miker
* Open-ILS/examples/fm_IDL.xml: These fields exist ... tell the IDL about them
* Open-ILS/src/perlmods/OpenILS/Application/SuperCat.pm: add start_date and
end_date to scap serialization
2010-10-20 phasefx
* Open-ILS/web/opac/extras/selfcheck/selfcheck.js: don't allow inactive cards with
web-selfcheck
2010-10-20 senator
* Open-ILS/src/perlmods/OpenILS/Application/SuperCat.pm: Backport r18421 from
trunk
* Open-ILS/examples/fm_IDL.xml,
Open-ILS/src/perlmods/OpenILS/Application/SuperCat.pm: Backport r18419 from
trunk: supercat bugs on records with serials data attached
2010-10-20 miker
* Open-ILS/src/perlmods/OpenILS/Application/Circ/Circulate.pm: Patch from tsbere
to address backporting issue of hard due dates patch against trunk (also, get
rid of 3-space indentation..)
2010-10-20 senator
* Open-ILS/src/perlmods/OpenILS/Application/Trigger/Event.pm: Backport r18416 from
trunk: a/t use rstore to flesh if cstore not available
* Open-ILS/examples/fm_IDL.xml: Backport r18414 from trunk
2010-10-20 miker
* Open-ILS/src/sql/Pg/1.6.1-2.0-upgrade-db.sql: 1.6.1-2.0 upgrade script needs to
fall in line with reality, re 0442
2010-10-20 dbs
* Open-ILS/src/sql/Pg/002.schema.config.sql,
Open-ILS/src/sql/Pg/1.6.1-2.0-upgrade-db.sql,
Open-ILS/src/sql/Pg/999.functions.global.sql,
Open-ILS/src/sql/Pg/upgrade/0443.schema.authority_ingest.sql: Prevent "Validate"
from matching against deleted authority records
2.0 introduces the ability to delete authority records. The routines in
OpenILS:Application:Storage:Publisher:authority check for matching values
of authority.full_rec without concern about whether the corresponding
entry in authority.record_entry has been deleted or not.
This change removes entries from authority.full_rec when an
authority.record_entry row is deleted, with the (possibly incorrect)
assumption that there won't be many cases where users will want to
search for deleted authority records and undelete them. If that
assumption turns out to be incorrect, then further changes can follow;
this change at least makes the current behaviour for user-visible
actions work as expected.
2010-10-20 senator
* Open-ILS/web/js/ui/default/serial/list_stream.js,
Open-ILS/web/js/ui/default/serial/list_subscription.js,
Open-ILS/web/js/ui/default/serial/subscription.js,
Open-ILS/web/templates/default/serial/list_stream.tt2,
Open-ILS/web/templates/default/serial/list_subscription.tt2,
Open-ILS/web/templates/default/serial/subscription.tt2,
Open-ILS/xul/staff_client/chrome/content/cat/opac.js: Backport r18407 from
trunk: alt serials interface tweak
2010-10-20 erickson
* Open-ILS/src/perlmods/OpenILS/SIP.pm,
Open-ILS/src/perlmods/OpenILS/SIP/Transaction/Checkin.pm: during checkin, an
item's hold may have a fleshed pickup_lib. added code to detect and protect
against treating a ref as an ID. minor cleanup
2010-10-20 miker
* Open-ILS/examples/crontab.example, Open-ILS/examples/fm_IDL.xml,
Open-ILS/src/Makefile.am, Open-ILS/src/perlmods/OpenILS/Application/AppUtils.pm,
Open-ILS/src/perlmods/OpenILS/Application/Circ/Circulate.pm,
Open-ILS/src/sql/Pg/002.schema.config.sql,
Open-ILS/src/sql/Pg/100.circ_matrix.sql,
Open-ILS/src/sql/Pg/upgrade/0442.schema.due_date_ceiling_alt_impl.sql,
Open-ILS/src/support-scripts/update_hard_due_dates.srfsh,
Open-ILS/web/templates/base.tt2: Backporting r18396 from trunk: Patch from
Thomas Berezansky providing an alternate implementation of Hard Due Dates
2010-10-19 miker
* Open-ILS/web/opac/skin/default/js/result_common.js: expand the scope of BT on
the result list page, allowing simpler slots
2010-10-18 gmc
* Open-ILS/src/sql/Pg/1.6.1-2.0-upgrade-db.sql: update 1.6.1 to 2.0 upgrade script
for 0441
Signed-off-by: Galen Charlton <email address hidden>
* Open-ILS/src/sql/Pg/002.schema.config.sql,
Open-ILS/src/sql/Pg/020.schema.functions.sql,
Open-ILS/src/sql/Pg/upgrade/0441.schema.naco-normalized-crossed-d.sql: fix
mapping of the crossed D character in naco_normalize
Signed-off-by: Galen Charlton <email address hidden>
2010-10-18 senator
* Open-ILS/src/perlmods/OpenILS/Application/Cat.pm,
Open-ILS/web/js/dojo/openils/widget/AutoGrid.js,
Open-ILS/web/js/dojo/openils/widget/EditPane.js,
Open-ILS/web/js/ui/default/conify/global/asset/copy_template.js,
Open-ILS/web/templates/default/conify/global/asset/copy_template.tt2: Backport
r18386 from trunk, asset.copy_template editing improvement
* Open-ILS/src/perlmods/OpenILS/Application/Serial.pm: Backport r18384 from trunk:
serials previous issue copy location moving
2010-10-18 dbs
* Open-ILS/src/sql/Pg/002.schema.config.sql,
Open-ILS/src/sql/Pg/030.schema.metabib.sql,
Open-ILS/src/sql/Pg/1.6.1-2.0-upgrade-db.sql,
Open-ILS/src/sql/Pg/upgrade/0440.schema.biblio_extract_located_uris.sql: Protect
biblio.extract_located_uris() from a NULL uri_use value by using the href as a
fallback
If an 856 field contained a subfield "9" but did not contain a subfield
"z", "2", or "n", then ingest of the MARC record would fail as it attempted
to retrieve an asset.uri row where uri_use = NULL - which was never true.
This change adds the subfield "u" to fall back to for the uri_use variable,
just like we do for the uri_label variable, and prevents ugly ingest errors
from getting thrown back at the client.
2010-10-18 phasefx
* Open-ILS/xul/staff_client/server/patron/display.js: stop sign page was
incorrectly coming up for all penalties
* Open-ILS/xul/staff_client/chrome/content/main/menu.js: make Circulation -> Enter
Offline Interface open a new window instead of a tab, like the button from the
login window. This works around a permission issue with loading the offline
receipt templates
* Open-ILS/xul/staff_client/chrome/content/OpenILS/data.js,
Open-ILS/xul/staff_client/server/patron/bill2.js: merge r18374-18375 from trunk
for bill receipt fixes
2010-10-16 miker
* Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher/asset.pm,
Open-ILS/src/perlmods/OpenILS/Application/SuperCat.pm,
Open-ILS/src/sql/Pg/002.functions.config.sql,
Open-ILS/src/sql/Pg/002.schema.config.sql,
Open-ILS/src/sql/Pg/040.schema.asset.sql,
Open-ILS/src/sql/Pg/1.6.1-2.0-upgrade-db.sql,
Open-ILS/src/sql/Pg/upgrade/0439.schema.function-bytea-index-label.sql:
Backporting r18364-r18366 from trunk: use a function to wrap up escaping of
solidus and casting to bytea, propogate to indexing and where/order_by
2010-10-15 miker
* Open-ILS/src/sql/Pg/1.6.1-2.0-upgrade-db.sql: Poked by scottmk to incorporate
0438 into the 1.6.1-2.0 upgrade script. This may duplicate effort if one is
already on 1.6.1.3+ (when it exists) but there is no harm in it either.
2010-10-15 gmc
* Open-ILS/src/perlmods/OpenILS/Application/Storage/QueryParser.pm: tweak
expanding search field aliases
Avoids a glitch that can occur if a search field alias
exists that happens to have the same name as a search field.
Signed-off-by: Galen Charlton <email address hidden>
2010-10-14 erickson
* Open-ILS/src/perlmods/OpenILS/SIP/Item.pm: If an item is captured for a hold,
but not in transit (i.e. on holds shelf), set the destination_location equal to
the pickup library (i.e where it's supposedly on the shelf). This is useful for
autmated sorting so that the item will return to the branch whose shelf where it
belongs.
* Open-ILS/src/perlmods/OpenILS/Application/Trigger.pm,
Open-ILS/src/perlmods/OpenILS/Application/Trigger/Event.pm,
Open-ILS/src/support-scripts/action_trigger_runner.pl: Back-porting a number of
action/trigger fixes from trunk:
parallel collection and reaction with multisession
cut down xact begin/rollbacks to reduce call overhead during collection
force granularity-only when running w/ --granularity
2010-10-14 miker
* Open-ILS/src/sql/Pg/upgrade/0438.schema.bytea-index-label.sql: upgrade version
number fix
* Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher/asset.pm,
Open-ILS/src/sql/Pg/040.schema.asset.sql,
Open-ILS/src/sql/Pg/upgrade/0438.schema.bytea-index-label.sql: "as" not "to" ...
you pointed that out the first time, miker, what is your deal?
* Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher/asset.pm,
Open-ILS/src/sql/Pg/002.schema.config.sql,
Open-ILS/src/sql/Pg/040.schema.asset.sql,
Open-ILS/src/sql/Pg/upgrade/0438.schema.bytea-index-label.sql: backward compat
indexing for label instead of label_sortkey
* Open-ILS/src/perlmods/OpenILS/Application/SuperCat.pm,
Open-ILS/src/sql/Pg/002.schema.config.sql,
Open-ILS/src/sql/Pg/040.schema.asset.sql,
Open-ILS/src/sql/Pg/1.6.1-2.0-upgrade-db.sql,
Open-ILS/src/sql/Pg/upgrade/0437.schema.bytea-index-label_sortkey.sql: cast
label_sortkey to bytea in order to get ascii-betical sorting in any locale, even
C. stupid glibc ...
* Open-ILS/xul/staff_client/server/patron/ue_config.js: patch from Steve Callendar
to avoid resetting the passwd every time a phone number changes
* Open-ILS/src/perlmods/OpenILS/Application/SuperCat.pm: correct top-half ordering
by label_sortkey
2010-10-14 phasefx
* Open-ILS/web/opac/locale/en-US/lang.dtd,
Open-ILS/xul/staff_client/server/cat/marcedit.js,
Open-ILS/xul/staff_client/server/cat/marcedit.xul: change the Swap Editor button
to a persisted checkbox
2010-10-13 scottmk
* Open-ILS/src/c-apps/oils_sql.c: Change the treatment of ORDER BY. Except as
noted, these changes
apply only to methods other than json_query.
1. Allow the use of array syntax for specifying an ORDER BY clause
as an array of field specifications, such as can be used in json_query.
The older syntax, using a hash based on class name, is still
available.
2. For json_query, using the array syntax: relax the requirement that a
class be in scope. A field from an out-of-scope class will now be
silently ignored. This change avoids certain problems with fleshing
queries, which use the same order_by array at multiple levels.
3. For the hash syntax: relax the requirement that the class be
referenced in the SELECT clause. Now it suffices that it be in
scope in the generated SQL. As a result, you can now sort by a
column in a joined class without artificially including that column
in the SELECT list.
4. When all or part of an ORDER BY clause is expressed as a string
literal: require that the string not contain any semicolons, in order
to block certain kinds of SQL injection. This measure could create
problems if a semicolon appears within a quoted string -- which is
possible in theory but highly improbable in practice.
5. Don't include a virtual field in an ORDER BY clause. If one is
specified, silently ignore it.
M Open-ILS/src/c-apps/oils_sql.c
2010-10-13 erickson
* Open-ILS/src/perlmods/OpenILS/Utils/Penalty.pm: clean up duplicate
system-controlled penalties during penalty calculation; perform penalty trigger
event creation after the standalone commit occurs. todo, handle non-standalone
post-commit penalty trigger event creation
2010-10-13 miker
* Open-ILS/src/sql/Pg/002.schema.config.sql,
Open-ILS/src/sql/Pg/012.schema.vandelay.sql,
Open-ILS/src/sql/Pg/1.6.1-2.0-upgrade-db.sql,
Open-ILS/src/sql/Pg/upgrade/0436.schema.multiple-rules.sql: thinko supporting
multiple rules of the same type in in-line merge rulesets
2010-10-12 miker
* Open-ILS/web/js/dojo/MARC/Field.js, Open-ILS/web/js/dojo/MARC/Record.js:
Backporting MARC js fixes from trunk
2010-10-12 atz
* build/tools/update.sh: Be sure to copy new JS files from OpenSRF on a FULL
update/install
2010-10-12 scottmk
* Open-ILS/src/sql/Pg/1.6.1-2.0-upgrade-db.sql: Incorporate upgrade # 0433 into
the consolidated upgrade script.
M Open-ILS/src/sql/Pg/1.6.1-2.0-upgrade-db.sql
2010-10-11 phasefx
* Open-ILS/src/perlmods/OpenILS/Application/Actor.pm,
Open-ILS/web/js/ui/default/actor/user/register.js: avoid race condition with
post-save patron editor refresh and replicated databases
* Open-ILS/xul/staff_client/server/circ/alternate_copy_summary.js: initialize
these lists just once to prevent display glitch
2010-10-11 atz
* Open-ILS/src/support-scripts/edi_pusher.pl: Tighter verbose format for skipped
POs
2010-10-11 erickson
* Open-ILS/src/support-scripts/action_trigger_runner.pl: wait to run-pending if a
specific granularity used
2010-10-08 erickson
* Open-ILS/web/js/ui/default/conify/global/action_trigger/event_definition.js,
Open-ILS/web/templates/default/conify/global/action_trigger/event_definition.tt2:
mild fixes for a/t interface admin interface. sort by def name instead of hook,
which probably makes more sense to a human. hide the opt-in and max-delay
columns to free up some badly needed horizontal space. use percentage width for
name column, which acts a lot like 'auto', but allows the user to manually
resize
2010-10-08 phasefx
* Open-ILS/xul/staff_client/server/circ/util.js: typo
2010-10-08 senator
* Open-ILS/src/perlmods/OpenILS/Application/Circ/Holds.pm: Backport r18249 from
trunk: clear hold shelf work even on brokenish holds
2010-10-08 phasefx
* Open-ILS/xul/staff_client/server/circ/util.js: fix logic error where we were
just testing for the presence of a user setting instead of its value
* Open-ILS/xul/staff_client/server/patron/info_group.js: moving users in and out
of groups produced dialogs that expected vertical patron summaries. this fixes
that
2010-10-08 dbs
* Open-ILS/examples/apache/eg.conf: Avoid scary SSL / HTTPS errors in Apache
configuration
When port 443 is the last listener port, Apache generates lots
of "unknown protocol speaking not SSL to HTTPS port!?" errors in
the logs - which are scary, but harmless. Putting port 80 last
avoids those errors entirely, per
http://wiki.apache.org/httpd/InternalDummyConnection
2010-10-08 gmc
* Open-ILS/src/perlmods/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm: do
not apply superpage limit inside bib search joins
Oddly, empirical evidence suggests that this might actually
be faster, and if this pans out, search results will definitely
be more complete.
Signed-off-by: Galen Charlton <email address hidden>
2010-10-07 senator
* Open-ILS/src/perlmods/OpenILS/Application/Circ/Holds.pm,
Open-ILS/web/opac/extras/circ/alt_holds_print.html,
Open-ILS/web/opac/extras/circ/alt_holds_print.js: Backport r18230 and 18231,
hold shelf clearer/printer
2010-10-07 gmc
* Open-ILS/src/perlmods/OpenILS/Utils/PermitHold.pm: choose the hold permit test
variant correctly
Signed-off-by: Galen Charlton <email address hidden>
2010-10-07 senator
* Open-ILS/web/opac/extras/circ/alt_holds_print.html: Backport r18226 from trunk
2010-10-07 atz
* Open-ILS/src/sql/Pg/002.schema.config.sql,
Open-ILS/src/sql/Pg/950.data.seed-values.sql,
Open-ILS/src/sql/Pg/upgrade/0433.edi_orders_template.sql: EDI template update
for ORDERS
This template produces JSON for the edi translator to convert into
actual EDI lines. It now handles vendor-specific requirements for
account and sub-account identification, and also transmits notes
of the vendor-public variety as FTX segments in the lineitem.
2010-10-07 senator
* Open-ILS/web/opac/extras/circ/alt_holds_print.html: Backport r18222 from trunk:
reasonable default sorting for expired holds list
2010-10-07 phasefx
* Open-ILS/xul/staff_client/server/circ/util.js: merge r18220 from trunk for
%destination_shelf% macro in hold and hold/transit slip templates
2010-10-06 atz
* build/tools/update_db.sh: Warn but continue on skipped upgrade revs.
2010-10-06 senator
* Open-ILS/src/perlmods/OpenILS/Application/Circ/Holds.pm,
Open-ILS/web/opac/extras/circ/alt_holds_print.html,
Open-ILS/web/opac/extras/circ/alt_pull_list.html,
Open-ILS/web/opac/locale/en-US/lang.dtd,
Open-ILS/xul/staff_client/server/admin/index.xhtml,
Open-ILS/xul/staff_client/server/patron/holds.js,
Open-ILS/xul/staff_client/server/patron/holds_overlay.xul: Backport r18215 from
trunk: alternate printing for expired holds shelf lists
This is slim so that it supports bigger datasets than the usual interface for
this. Needs improvment: make the template more customizable
2010-10-06 miker
* Open-ILS/src/sql/Pg/upgrade/0429.noop-because-miker-skipped-it.sql: Backport
spackling from trunk: db upgrade script dislikes holes -- spackle this one
2010-10-06 scottmk
* Open-ILS/src/sql/Pg/1.6.1-2.0-upgrade-db.sql: Incorporate upgrades 0427 and 0428
into the consolidated upgrade script.
M Open-ILS/src/sql/Pg/1.6.1-2.0-upgrade-db.sql
2010-10-06 erickson
* Open-ILS/src/perlmods/OpenILS/Application/Trigger/Event.pm: avoid
retreiving/searching a linked object, when there is no object to retrieve (i.e.
ident value is null) and silence various warnings by skipping this scenario.
mild variable refactor for easy reading for feeble eyes.
2010-10-06 phasefx
* Open-ILS/xul/staff_client/server/circ/util.js: hold/transit slips may want to
use stat cats as well
2010-10-06 scottmk
* Open-ILS/src/sql/Pg/110.hold_matrix.sql,
Open-ILS/src/sql/Pg/upgrade/0428.schema.hold_retarget.sql: Backporting a syntax
correction; SQL functions cannot reference
their parameters by name.
M Pg/upgrade/0428.schema.hold_retarget.sql
M Pg/110.hold_matrix.sql
2010-10-06 erickson
* Open-ILS/web/templates/default/conify/global/config/hold_matrix_matchpoint.tt2:
suppress usr_grp field in hold matrix matchpoint; see also 18188
2010-10-06 miker
* Open-ILS/src/sql/Pg/002.schema.config.sql,
Open-ILS/src/sql/Pg/110.hold_matrix.sql,
Open-ILS/src/sql/Pg/upgrade/0431.schema.hold_retarget.sql: Backport r18195 from
trunk: Make retargetting check less lax by including appropriate patron-side
test
2010-10-06 erickson
* Open-ILS/src/perlmods/OpenILS/Application/Trigger.pm: first level of groups hash
can be array or hash, leading to breakage; for now, keep it simple and return
continue-status to keep the caller alive
2010-10-06 miker
* Open-ILS/web/templates/default/conify/global/config/hold_matrix_matchpoint.tt2:
Backport r18188 from trunk: usr_grp is entirely unused currently; hide it
* Open-ILS/src/perlmods/OpenILS/Application/Circ/Holds.pm,
Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher/action.pm,
Open-ILS/src/perlmods/OpenILS/Utils/PermitHold.pm,
Open-ILS/src/sql/Pg/002.schema.config.sql,
Open-ILS/src/sql/Pg/110.hold_matrix.sql,
Open-ILS/src/sql/Pg/upgrade/0428.schema.hold_retarget.sql: Backport r18187 from
trunk: Add a retargetting specific version of the hold-permit function which
skips user tests
2010-10-05 gmc
* Open-ILS/src/sql/Pg/002.schema.config.sql,
Open-ILS/src/sql/Pg/110.hold_matrix.sql,
Open-ILS/src/sql/Pg/upgrade/0427.schema.hold_matrix_root_ou.sql: hold matrix
selection: treat root OU as just another OU
Treat the root OU as just another OU for the purpose of
calculating OU proximity adjustments when selecting a
matchpoint.
Signed-off-by: Galen Charlton <email address hidden>
2010-10-05 phasefx
* Open-ILS/xul/staff_client/chrome/content/util/list.js: be quiet with errors
retrieving remote column settings
2010-10-05 atz
* Open-ILS/src/support-scripts/edi_pusher.pl: The whole point of test mode, NOT
actually committing actions.
2010-10-05 senator
* Open-ILS/web/opac/extras/circ/alt_pull_list.html: Backport r18175
2010-10-05 atz
* Open-ILS/web/templates/default/acq/po/view.tt2: Add title to PO view page.
* Open-ILS/src/support-scripts/edi_fetcher.pl,
Open-ILS/src/support-scripts/edi_pusher.pl: EDI job POD
2010-10-05 phasefx
* Open-ILS/xul/staff_client/server/patron/bill2.xul: merge r18169 from trunk for
CSS hooks
2010-10-05 gmc
* Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher/metabib.pm: make it
easier to grep for bib search durations from the Pg log
Signed-off-by: Galen Charlton <email address hidden>
2010-10-05 erickson
* Open-ILS/src/perlmods/OpenILS/Application/Acq/Order.pm: avoid running activated
hook when in dry run mode
2010-10-04 dbs
* Open-ILS/src/templates/password-reset/strings.fr-CA: French translation of
password reset form and prompts at /opac/password/fr-CA/
2010-10-04 senator
* Open-ILS/src/perlmods/OpenILS/Application/Circ/Holds.pm,
Open-ILS/xul/staff_client/server/circ/util.js,
Open-ILS/xul/staff_client/server/locale/en-US/circ.properties,
Open-ILS/xul/staff_client/server/patron/hold_details.js,
Open-ILS/xul/staff_client/server/patron/holds.js: Backport r18158 from trunk:
patron alias column in some holds interfaces
2010-10-04 erickson
* Open-ILS/web/js/ui/default/vandelay/vandelay.js: fixed typo in vandelay merge
profile permission check
2010-10-04 senator
* Open-ILS/src/perlmods/OpenILS/Application/Circ/Holds.pm: Backport r18148 from
trunk: fix pull list retrieval bug for alt pull list print