[queue tool] magic debdiff

Right, after finishing edgy-open task I think we can go throught it as suggested in __empty__ spec https://launchpad.net/products/soyuz/+spec/package-diff .

The most important place to have diffs it the UNAPPROVED queue (we can have diffs for NEW), so we can start with them.

{{{
debdiff parent.dsc current.dsc > SPR.debfiff (LFA FK)

debdiff parent.deb current.deb > BPR.debdiff (LFA FK)
(binary requires diffs and different origs in place)
}}}

Obvious DB patch to add debdiff as LFA FK nullable and also web UI extension to present queue item page (edgy/+queue/QUEUEID)

Later we can think about extending this feature for all know versions and make debdiff visible from SPR/BPR pages.

Malcc is a good candidate to drive this implementation, he will achieve good experience by implementing orthogonal changes such this one.

Having this both from the command-line queue, and the LP UI for the queue would be very useful!

This bug seems that it was due to be started over two years ago. Will this happen any time soon?

RIght, command-line diff requests is a deprecated requirement.

The missing bits to complete the package-diff implementation is to allow users to request arbitrary diffs via the UI and expose available diffs in the upload queue pages.

Hmm. Is this really a duplicate of bug 259422? I realise that they are somewhat similar, but the work required to display diffs on PPA archive pages and to display diffs on queue administration pages seems to me to be somewhat separate. Am I missing something that makes it obvious why they're the same piece of work?

Colin,

Right now, displaying diffs already available in the +queue page is just a matter of adding a template call. Diffs are requested in upload time (even for NEW packages) and attached to SourcePackageReleases, that's what we do for PPA packages.

We will be discussing UI solutions for that page this week and it will include finding a place for available diffs. I will let you know as soon as we have a mockup.

Also, you are right, maybe it could have been better handled if it wasn't a dup.

In fact, this bug could be a "Won't Fix" because we're doing it all via
the UI rather than the command line (which IS wants to deprecate).

Feel free to transform it into a request for making diffs available from the queue UI; I don't think it should be "Won't Fix" since that facility is not available either. I don't think we would be all that bothered about command line provision if it were available in the UI.

Colin Watson wrote:
> Feel free to transform it into a request for making diffs available from
> the queue UI; I don't think it should be "Won't Fix" since that facility
> is not available either. I don't think we would be all that bothered
> about command line provision if it were available in the UI.
>

Right, we won't be removing command line tools until you're totally
happy with the UI.

We're currently sprinting and talking about fixing up a lot of UI stuff
like this =)