diff -u audiolink-0.05/debian/changelog audiolink-0.05/debian/changelog --- audiolink-0.05/debian/changelog +++ audiolink-0.05/debian/changelog @@ -1,3 +1,12 @@ +audiolink (0.05-1.1) unstable; urgency=low + + * Non-maintainer upload. + * Move debhelper to Build-Depends, to get rid of lintian error + preventing upload. + * Use File:Temp to generate a temporary file (Closes: #496433). + + -- Sebastien Delafond Wed, 03 Sep 2008 14:53:36 -0700 + audiolink (0.05-1) unstable; urgency=low * Initial Release (closes: #222450) diff -u audiolink-0.05/debian/control audiolink-0.05/debian/control --- audiolink-0.05/debian/control +++ audiolink-0.05/debian/control @@ -3,11 +3,12 @@ Priority: optional Maintainer: Amit Shah Standards-Version: 3.6.1 -Build-Depends-Indep: debhelper (>> 4.0.0), perl (>= 5.8.2-1) +Build-Depends-Indep: perl (>= 5.8.2-1) +Build-Depends: debhelper (>> 4.0.0) Package: audiolink Architecture: all -Depends: ${perl:Depends}, mysql-client (>= 4.0.16-2), libdbd-mysql-perl (>= 2.1027-1), libmp3-info-perl (>= 1.01-1), libogg-vorbis-header-perl (>= 0.03-1) +Depends: ${perl:Depends}, mysql-client (>= 4.0.16-2), libdbd-mysql-perl (>= 2.1027-1), libmp3-info-perl (>= 1.01-1), libogg-vorbis-header-perl (>= 0.03-1), libfile-temp-perl Recommends: mysql-server (>=4.0.16-2) Description: makes managing and searching for music easier AudioLink is a tool that makes searching for music on your local only in patch2: unchanged: --- audiolink-0.05.orig/code/audiolink +++ audiolink-0.05/code/audiolink @@ -28,6 +28,7 @@ use DBI; use Getopt::Long; use Pod::Usage; +use File::Temp qw/ tempfile /; # Options for the database $user = undef; @@ -174,15 +175,15 @@ print "\nCreating the AudioLink database..." if $verbose; -$ret = system("mysqladmin -u$user -p$password -h$host create $db_name 2>/tmp/audiolink.db.tmp"); +my ($tmpFh, $tmpFile) = tempfile("audiolink.db.tmpXXXXXXXXX", UNLINK => 1); +$ret = system("mysqladmin -u$user -p$password -h$host create $db_name 2> $tmpFile"); # or print "\nSome error occured. # If the error reported that the database already exists, it's okay. You already had the database created. # If it was some other error, consult the mysqladmin man page and/or notify the AudioLink developers.\n # Anyways, continuing to create AudioLink tables.\n"; -open (DBOP, "/tmp/audiolink.db.tmp"); -while () { +while (<$tmpFh>) { if ( /database exists/i) { print "The database already exists.\n" if $verbose; } else { @@ -191,18 +192,14 @@ } } -close DBOP; - print "\nCreating the AudioLink tables..." if $verbose; -$ret = system ("mysql -u$user -p$password -h$host $db_name < /usr/share/doc/audiolink/mysql.schema 2>/tmp/audiolink.tb.tmp"); +$ret = system ("mysql -u$user -p$password -h$host $db_name < /usr/share/doc/audiolink/mysql.schema 2> $tmpFile"); # or print "\nSome error occured. # If the error reported that the table already exists, it's okay. You already had the table created. # If it was some other error, consult the mysql man page and/or notify the AudioLink developers.\n"; -open (DBOP, "/tmp/audiolink.tb.tmp"); - -while () { +while (<$tmpFh>) { if ( /already exists/i) { print "The table already exists.\n" if $verbose; } else {