diff -Nru kio-5.31.0/debian/changelog kio-5.31.0/debian/changelog --- kio-5.31.0/debian/changelog 2017-02-14 22:50:48.000000000 +0000 +++ kio-5.31.0/debian/changelog 2017-03-02 21:55:03.000000000 +0000 @@ -1,3 +1,16 @@ +kio (5.31.0-0ubuntu2) zesty; urgency=medium + + * SECURITY UPDATE:Information Leak when accessing https when using a + malicious PAC file + - debian/patches/kio-sanitize-url-to-FindProxyForURL.patch + - Thanks to Safebreach Labs researchers Safebreach Labs researchers + Itzik Kotler, Yonatan Fridburg and Amit Klein for reporting this + issue, Albert Astals Cid for fixing this issue. + - No CVE number. + - fixes (LP: #1668871) + + -- Rik Mills Thu, 02 Mar 2017 21:55:03 +0000 + kio (5.31.0-0ubuntu1) zesty; urgency=medium [ José Manuel Santamaría Lema ] diff -Nru kio-5.31.0/debian/patches/kio-sanitize-url-to-FindProxyForURL.patch kio-5.31.0/debian/patches/kio-sanitize-url-to-FindProxyForURL.patch --- kio-5.31.0/debian/patches/kio-sanitize-url-to-FindProxyForURL.patch 1970-01-01 00:00:00.000000000 +0000 +++ kio-5.31.0/debian/patches/kio-sanitize-url-to-FindProxyForURL.patch 2017-03-02 21:55:03.000000000 +0000 @@ -0,0 +1,42 @@ +From f9d0cb47cf94e209f6171ac0e8d774e68156a6e4 Mon Sep 17 00:00:00 2001 +From: Albert Astals Cid +Date: Tue, 28 Feb 2017 19:00:48 +0100 +Subject: Sanitize URLs before passing them to FindProxyForURL + +Remove user/password information +For https: remove path and query + +Thanks to safebreach.com for reporting the problem + +CCMAIL: yoni.fridburg@safebreach.com +CCMAIL: amit.klein@safebreach.com +CCMAIL: itzik.kotler@safebreach.com +--- + src/kpac/script.cpp | 11 +++++++++-- + 1 file changed, 9 insertions(+), 2 deletions(-) + +diff --git a/src/kpac/script.cpp b/src/kpac/script.cpp +index a0235f7..2485c54 100644 +--- a/src/kpac/script.cpp ++++ b/src/kpac/script.cpp +@@ -754,9 +754,16 @@ QString Script::evaluate(const QUrl &url) + } + } + ++ QUrl cleanUrl = url; ++ cleanUrl.setUserInfo(QString()); ++ if (cleanUrl.scheme() == QLatin1String("https")) { ++ cleanUrl.setPath(QString()); ++ cleanUrl.setQuery(QString()); ++ } ++ + QScriptValueList args; +- args << url.url(); +- args << url.host(); ++ args << cleanUrl.url(); ++ args << cleanUrl.host(); + + QScriptValue result = func.call(QScriptValue(), args); + if (result.isError()) { +-- +cgit v0.11.2 diff -Nru kio-5.31.0/debian/patches/series kio-5.31.0/debian/patches/series --- kio-5.31.0/debian/patches/series 2017-02-14 22:50:48.000000000 +0000 +++ kio-5.31.0/debian/patches/series 2017-03-02 21:55:03.000000000 +0000 @@ -1,3 +1,4 @@ +kio-sanitize-url-to-FindProxyForURL.patch return_on_ACCESS_DENIED report_error_removing_dirs wait_for_a_bit_longer