diff -Nru slick-greeter-1.1.4/debian/changelog slick-greeter-1.1.4/debian/changelog --- slick-greeter-1.1.4/debian/changelog 2018-02-17 22:33:15.000000000 +0000 +++ slick-greeter-1.1.4/debian/changelog 2020-11-05 10:07:31.000000000 +0000 @@ -1,3 +1,11 @@ +slick-greeter (1.1.4-1ubuntu0.18.04.1) bionic; urgency=medium + + * debian/patches/git-new-systemd.patch: + - remove a memory protection call which is leading to the greeter to + error out with the new systemd (lp: #1902879) + + -- Sebastien Bacher Thu, 05 Nov 2020 11:07:31 +0100 + slick-greeter (1.1.4-1) unstable; urgency=medium * New upstream release diff -Nru slick-greeter-1.1.4/debian/patches/git-new-systemd.patch slick-greeter-1.1.4/debian/patches/git-new-systemd.patch --- slick-greeter-1.1.4/debian/patches/git-new-systemd.patch 1970-01-01 00:00:00.000000000 +0000 +++ slick-greeter-1.1.4/debian/patches/git-new-systemd.patch 2020-11-05 10:07:31.000000000 +0000 @@ -0,0 +1,46 @@ +From f9af95ea3f71511980438b80c85ea2bd19500f99 Mon Sep 17 00:00:00 2001 +From: Leigh Scott +Date: Wed, 20 Feb 2019 10:40:36 +0000 +Subject: [PATCH] remove mlockall (#127) + +--- + src/slick-greeter.vala | 26 ++++++++++++++++++++++++-- + 1 file changed, 24 insertions(+), 2 deletions(-) + +Index: slick-greeter-1.1.4/src/slick-greeter.vala +=================================================================== +--- slick-greeter-1.1.4.orig/src/slick-greeter.vala ++++ slick-greeter-1.1.4/src/slick-greeter.vala +@@ -543,8 +543,30 @@ public class SlickGreeter + + public static int main (string[] args) + { +- /* Protect memory from being paged to disk, as we deal with passwords */ +- Posix.mlockall (Posix.MCL_CURRENT | Posix.MCL_FUTURE); ++ /* Protect memory from being paged to disk, as we deal with passwords ++ ++ According to systemd-dev, ++ ++ "mlockall() is generally a bad idea and certainly has no place in a graphical program. ++ A program like this uses lots of memory and it is crucial that this memory can be paged ++ out to relieve memory pressure." ++ ++ With systemd version 239 the ulimit for RLIMIT_MEMLOCK was set to 16 MiB ++ and therefore the mlockall call would fail. This is lucky becasue the subsequent mmap would not fail. ++ ++ With systemd version 240 the RLIMIT_MEMLOCK is now set to 64 MiB ++ and now the mlockall no longer fails. However, it not possible to mmap in all ++ the memory and because that would still exceed the MEMLOCK limit. ++ " ++ See https://bugzilla.redhat.com/show_bug.cgi?id=1662857 & ++ https://github.com/CanonicalLtd/lightdm/issues/55 ++ ++ RLIMIT_MEMLOCK = 64 MiB means, slick-greeter will most likely fail with 64 bit and ++ will always fail on 32 bit systems. ++ ++ Hence we better disable it. */ ++ ++ /*Posix.mlockall (Posix.MCL_CURRENT | Posix.MCL_FUTURE);*/ + + /* Disable global menubar */ + Environment.unset_variable ("UBUNTU_MENUPROXY"); diff -Nru slick-greeter-1.1.4/debian/patches/series slick-greeter-1.1.4/debian/patches/series --- slick-greeter-1.1.4/debian/patches/series 2018-02-17 22:33:15.000000000 +0000 +++ slick-greeter-1.1.4/debian/patches/series 2020-11-05 10:07:22.000000000 +0000 @@ -1,2 +1,3 @@ sans-schema-font.patch mint-master-unstable-19.patch +git-new-systemd.patch