Initscript does not use lsb-base functions

Bug #34217 reported by Lionel Le Folgoc
10
Affects Status Importance Assigned to Milestone
firestarter (Ubuntu)
Medium
Zak B. Elep

Bug Description

Package : Firestarter 1.0.3-1.1ubuntu1
Distribution : Ubuntu Breezy Badger/Dapper Drake

Firestarter initscript does not use lsb-base init functions. Instead of displaying :
$ /etc/init.d/firestarter start
* Starting the Firestarter firewall... [ok]

it only shows :
$ /etc/init.d/firestarter start
* Starting the Firestarter firewall:done

(And i suppose that this output won't match with some programs like usplash.)

And "Depends lsb-base (>=3.0-1ubuntu8)" should be added to debian/control

Revision history for this message
Lionel Le Folgoc (mrpouit) wrote : A maybe more correct initscript

debian/Firestarter.init, using lsb-base init-functions

description: updated
description: updated
Revision history for this message
Daniel Robitaille (robitaille) wrote :

Interestingly one year ago I sent a similar patch to the -devel mailing list:
https://lists.ubuntu.com/archives/ubuntu-devel/2005-March/005895.html

A perfect example why people should use Malone to keep track of problem and fixes. Emails to the mailing lists tend to be quickly forgotten, even by the author of the email :)

Changed in firestarter:
assignee: nobody → motu
Revision history for this message
Lionel Le Folgoc (mrpouit) wrote : Patch for this init-script

I uploaded a patch for the proposed initscript

Zak B. Elep (zakame)
Changed in firestarter:
assignee: motu → motureviewers
Zak B. Elep (zakame)
Changed in firestarter:
status: Unconfirmed → In Progress
Revision history for this message
Zak B. Elep (zakame) wrote :

Hi!

Does the problem still persist in the latest Dapper release (1.0.3-1.1ubuntu2)?

Thanks,

Revision history for this message
Lionel Le Folgoc (mrpouit) wrote :

Yes, the initscript is still the same. It does not prevent usplash from working, except that it doesn't display any message during boot/shutdown.

The actual initscript works without problem, so that's only a "cosmetic" request. :-)

Revision history for this message
Zak B. Elep (zakame) wrote :

Patches look good.

Changed in firestarter:
assignee: motureviewers → zakame
Revision history for this message
Zak B. Elep (zakame) wrote :

Fix included in latest Dapper upload (1.0.3-1.1ubuntu3). Thanks everyone! =)

Changed in firestarter:
status: In Progress → Fix Committed
Zak B. Elep (zakame)
Changed in firestarter:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers