strip won't strip non-executable files on XFS

I have opened up a bug upstream:

http://bugme.osdl.org/show_bug.cgi?id=4258

Regards
chuck

I think an strace of the strip command would be in order

I've been talking to Eric Sandeen of SGI about this, and am running through a
xorg build now to get an strace (diverted /usr/bin/strip).

I thought fakeroot may have been causing it, but no dice:
daniels@brainfreeze:~/tmp% cp -a
~/canonical/xorg/xorg-6.8.2/build-tree/xc/programs/Xserver/hw/xfree86/drivers/ati/radeon_drv.o
radeon_drv.o.orig
daniels@brainfreeze:~/tmp% ls -lh radeon_drv.o.orig
-rw-r--r-- 1 daniels daniels 2.5M 2005-02-27 22:50 radeon_drv.o.orig
daniels@brainfreeze:~/tmp% cp -a radeon_drv.o{.orig,} && strip
--remove-section=.comment --remove-section=.note --strip-unneeded radeon_drv.o
&& ls -lh radeon_drv.o
-rw-r--r-- 1 daniels daniels 262K 2005-02-28 00:57 radeon_drv.o
daniels@brainfreeze:~/tmp% cp -a radeon_drv.o{.orig,} && fakeroot strip
--remove-section=.comment --remove-section=.note --strip-unneeded radeon_drv.o
&& ls -lh radeon_drv.o
-rw-r--r-- 1 daniels daniels 262K 2005-02-28 00:57 radeon_drv.o

strace to come in an attachment.

Created an attachment (id=1465)
strace of failing strip

(From update of attachment 1465)
wrong one

Created an attachment (id=1469)
the right strace this time

It appears from the strace that the file is simply read-only:

lstat("debian/xserver-xorg/usr/X11R6/lib/modules/input/wacom_drv.o",
{st_mode=S_IFREG|0444, st_size=1299451, ...}) = 0
getpid() = 19803
semop(655362, 0x131, 140737488348032) = 0
msgsnd(1179650, {0, 0x8}, 140737488348112, 0x38) = 0
msgrcv(1212419, {12314923993692930047, "\252*"}, 140737488348112, 4213414, 0x38)
= 56
semop(655362, 0, 140737488348032) = 0
open("debian/xserver-xorg/usr/X11R6/lib/modules/input/stnn8Z4z", O_RDONLY) = 3
open("debian/xserver-xorg/usr/X11R6/lib/modules/input/wacom_drv.o",
O_WRONLY|O_CREAT|O_TRUNC, 0777) = -1 EACCES (Permission denied)

Easily reproducible:

mizar:[/tmp] cp /bin/ls .
mizar:[/tmp] chmod 444 ls
mizar:[/tmp] strip ls
strip: unable to copy file 'ls' reason: Permission denied

And yet, this only occurs on XFS for some reason ... I'm willing to bet this
isn't unrelated to Debian #296586.

dh_strip \
  -Nlibdps1-dbg \
  [...]
strip: unable to copy file
'debian/xlibmesa-dri/usr/X11R6/lib/modules/dri/ffb_dri.so' reason: Permission denied
strip: unable to copy file
'debian/xlibmesa-dri/usr/X11R6/lib/modules/dri/gamma_dri.so' reason: Permission
denied
strip: unable to copy file
'debian/xlibmesa-dri/usr/X11R6/lib/modules/dri/i810_dri.so' reason: Permission
denied
[...]

Does this still affect current breezy kernels?

sorry, missed the bug mail. it does appear to still be occurring, yes.

This bug has been flagged because it is old and possibly inactive. It may or may
not be fixed in the latest release (Breezy Badger 5.10). It is being marked as
"NEEDSINFO". In two weeks time, if the bug is not updated back to "NEW" and
validated against Breezy, it will be closed.

This is needed in order to help manage the current bug list for the kernel. We
would like to fix all bugs, but need users to test and help with debugging.

If this change was in error for this bug, please respond and make the
appropriate change (or email <email address hidden> if you cannot make the
change).

Thanks for your help.

Daniel, does this still affect breezy and/or dapper?

Keybuk and pitti reported that they were able to strip 644 binaries on xfs
without any problems with dapper 2.6.15 kernel.

i've always been able to strip random arbitrary files normally (even copying the
same files over and running strip on them); it's only ever been the monolithic
xfree86/xorg build that's been affected, but I'm not convinced I care enough now.