[SRU] Edgy: Urgent patch to solve upload problem

Bug #83731 reported by spiralvoice
16
Affects Status Importance Assigned to Milestone
mldonkey (Debian)
Fix Released
Unknown
mldonkey (Ubuntu)
Fix Released
Undecided
John Dong
Nominated for Dapper by StefanPotyra
Nominated for Edgy by StefanPotyra

Bug Description

Hi,

MLDonkey has a very serious bug which leeds to uploading
data blocks twice to eMule clients.

This is due to the fact that MLDonkey gets confused by
eMule rotating block request scheme.

http://hydranode.com/docs/ed2k/ed2kproto.php#upload
> Namely, eMule (and compatible) clients use "rotational chunkrequest" scheme,
> where each REQCHUNKS packet contains one new chunk and two older chunks
> ...
> This can lead to duplicate data being sent by mldonkeys, if a rotational
> chunkrequest scheme is used when communicating with them.

More infos about it, including logs proving the problem, can be found here:
http://mldonkey.sourceforge.net/forums/viewtopic.php?t=4576

On https://savannah.nongnu.org/patch/index.php?5664 you will find patches
for all MLDonkey versions since 2.6.0. I tested the patch with 2.6.0,
without it it uploaded 700MB for a 350MB file to eMule 0.47c, with the
patch it send 350MB, nothing more.

Please update the MLDonkey package in Ubuntu edgy.
I am posting this seperate ticket as advised in
https://launchpad.net/ubuntu/+source/mldonkey/+bug/78607/comments/6

Revision history for this message
spiralvoice (spiralvoice) wrote :
Changed in mldonkey:
status: Unknown → Fix Released
Changed in mldonkey:
status: Unconfirmed → Fix Committed
Revision history for this message
StefanPotyra (sistpoty) wrote :

Hi,

marking this as fix released, since 2.8.2-2 which has the patch applied is already in feisty.

Cheers,
   Stefan.

Changed in mldonkey:
status: Fix Committed → Fix Released
Revision history for this message
spiralvoice (spiralvoice) wrote :

Please re-open this bug.
I filled it specifically for updating the MLDonkey package in Edgy.
On the IRC channel I even met Dapper users using MLDonkey 2.7.1,
which also needs an update.

Revision history for this message
spiralvoice (spiralvoice) wrote :

This is not enough, older versions need also to be updated, thats the reason I filed this bug report.

Changed in mldonkey:
status: Fix Released → In Progress
Revision history for this message
spiralvoice (spiralvoice) wrote :

https://launchpad.net/ubuntu/+source/mldonkey/+bug/78607/comments/6
"spiralvoice, please open separate backport tickets for Edgy and Dapper versions, thanks."

I am surprised that this bug was closed without updating Edgy.

Revision history for this message
StefanPotyra (sistpoty) wrote :

Hi,

sorry, I didn't read that you meant the edgy version.

I'll prepare an update for edgy in a few minutes.

Cheers,
   Stefan.

Changed in mldonkey:
assignee: nobody → sistpoty
Revision history for this message
StefanPotyra (sistpoty) wrote :
Revision history for this message
StefanPotyra (sistpoty) wrote :

Format: 1.7
Date: Sat, 10 Mar 2007 00:25:57 +0000
Source: mldonkey
Binary: mldonkey-gui mldonkey-server
Architecture: source
Version: 2.8.1-1ubuntu0.1~proposed1
Distribution: edgy-proposed
Urgency: low
Maintainer: Debian OCaml Maintainers <email address hidden>
Changed-By: Stefan Potyra <email address hidden>
Description:
 mldonkey-gui - Graphical frontend for mldonkey based on GTK
 mldonkey-server - Door to the 'donkey' network
Changes:
 mldonkey (2.8.1-1ubuntu0.1~proposed1) edgy-proposed; urgency=low
 .
   * Add debian/patches/avoid-duplicate-sending.dpatch taken from
     2.8.1-2etch1, to avoid sending duplicate packages with
     clients using rotational chunkrequests. Closes lp#83731. Thanks
     to spiralvoice.
   * SRU: lp#83731.
   * Disable update-podebconf for SRU in debian/rules.
Files:
 306e5a38374e2bcfbfc70c2efbcdd494 1110 net optional mldonkey_2.8.1-1ubuntu0.1~proposed1.dsc
 a22f36ca1aee4f7d0333960c9bd4b02f 117215 net optional mldonkey_2.8.1-1ubuntu0.1~proposed1.diff.gz

Revision history for this message
Tollef Fog Heen (tfheen) wrote :

Accepted into -proposed; please solicit testing

Changed in mldonkey:
status: In Progress → Fix Committed
Revision history for this message
StefanPotyra (sistpoty) wrote :

Hi,

@spiralvoice: can you please test mldonkey from the edgy-proposed repository and report here if it works for your? (and if you find other people who could test the update, that would be absolutoley fantastic!)

Thanks,
    Stefan.

Revision history for this message
spiralvoice (spiralvoice) wrote :

Hi,

good luck that I had Kubuntu installed on a spare partition;-)

I tested the normal package mldonkey-server-2.8.1-1, which showed the error described in this bug report.

Then I installed
ftp://ftp.ubuntu.com/ubuntu/pool/universe/m/mldonkey/mldonkey-server_2.8.1-1ubuntu0.1~proposed1_i386.deb
and the error is not present anymore.

I tested with Lugdunums eserver 17.14 and eMule 0.47 (run by Wine) and MLDonkey all locally run on the Kubuntu workstation.

Revision history for this message
spiralvoice (spiralvoice) wrote :

Small note for this patch:

- Please do not forget to update the version in Dapper as well,
as mentioned in bug #83732

https://launchpad.net/ubuntu/+source/mldonkey/+bug/83732/comments/2
"Thank you for your work on that. Marking duplicate from #83731, one bug is enough launchpad allow to open different tasks for dapper and edgy for example"

I do not know how to open a task here for Dapper.

Revision history for this message
Emmet Hikory (persia) wrote :

I'm unsubscribing ubuntu-universe-sponsors, as there is currently nothing to sponsor in this bug. If an SRU is prepared for dapper, and sponsorship is required for upload, please resubscribe ubuntu-universe-sponsors. Thank you.

Revision history for this message
Martin Pitt (pitti) wrote :

This got one test so far, it should get another one. However, someone needs to do an upload to edgy-updates and drop the ~proposed1 part from the version number (yes, it's *that* old).

Revision history for this message
John Dong (jdong) wrote :

Hi, is anyone subscribed to this bug still on Edgy and willing to commit to verifying the fix if I were to update this to comply with the new SRU process?

Please comment on this bug report if you are willing to test.

Thanks

Emmet Hikory (persia)
Changed in mldonkey:
assignee: sistpoty → jdong
Revision history for this message
StefanPotyra (sistpoty) wrote :

@John: thanks for taking over, while the update worked for me (back when I prepared it), I must admit that I wasn't really sure if it fixes the bug in question. Would be great if we could find someone else to test it and get it finally into -updates.

Revision history for this message
Martin Pitt (pitti) wrote :

Will remove this SRU on my archive day tomorrow, since nobody seems to be interested in this any more (Edgy is getting old and thus less and less popular, and its universe even more so).

Revision history for this message
Martin Pitt (pitti) wrote :

I removed mldonkey from edgy-proposed. It had been there for 310 days without sufficient activity. I close the bug since this is (hopefully) fixed in Hardy.

Changed in mldonkey:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.