Merge lp:~alecu/ubuntuone-client/gsd-plugin into lp:ubuntuone-client
| Status: | Merged |
|---|---|
| Approved by: | John Lenton on 2010-07-15 |
| Approved revision: | 568 |
| Merged at revision: | 578 |
| Proposed branch: | lp:~alecu/ubuntuone-client/gsd-plugin |
| Merge into: | lp:ubuntuone-client |
| Diff against target: |
614 lines (+499/-4) 12 files modified
.bzrignore (+2/-0) Makefile.am (+1/-1) configure.ac (+13/-0) gsd-plugin/Makefile.am (+62/-0) gsd-plugin/gsd-ubuntuone.c (+167/-0) gsd-plugin/gsd-ubuntuone.h (+66/-0) gsd-plugin/test-gsd-ubuntuone.c (+61/-0) gsd-plugin/test-send-signal.py (+82/-0) gsd-plugin/ubuntuone.gnome-settings-plugin.in (+8/-0) libsyncdaemon/syncdaemon-daemon.c (+33/-3) libsyncdaemon/syncdaemon-daemon.h (+2/-0) po/POTFILES.in (+2/-0) |
| To merge this branch: | bzr merge lp:~alecu/ubuntuone-client/gsd-plugin |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| John Lenton | Approve on 2010-07-15 | ||
| Rodrigo Moya (community) | 2010-07-14 | Approve on 2010-07-15 | |
|
Review via email:
|
|||
Commit Message
A plugin for gnome-settings-
Description of the Change
A plugin for gnome-settings-
- 568. By Alejandro J. Cura on 2010-07-15
-
tab/spaces fixes
| dobey (dobey) wrote : | # |
+_Name=Ubuntu One
This shouldn't be marked for translation. Just remove the _ here. :)
114 +CLEANFILES = \
115 + $(plugin_DATA)
116 +
117 +DISTCLEANFILES = \
118 + $(plugin_DATA)
You don't need to add the same thing to multiple CLEANFILES variables. maintainer-clean depends on distclean depends on clean. :)
So you can just remove the DISTCLEANFILES here. You should add Makefile.in to MAINTAINERCLEAN
- 569. By Alejandro J. Cura on 2010-07-15
-
autoconf fixes


It looks ok, and seems to work. Only a few formatting issues:
* In Makefile.am some lines seem to use 8-spaces and others 4, so please use a TAB everywhere
* Also here:
583 + dbus_g_ proxy_connect_ signal (DBUS_G_PROXY (proxy), "QuotaExceeded", exceeded_ cb), daemon, NULL);
584 + G_CALLBACK (quota_
Approving anyway, so just fix this please before merging the branch