diff -Nru indicator-sound-12.10.2+18.10.20180612/debian/bzr-builder.manifest indicator-sound-12.10.2+18.10.20180612/debian/bzr-builder.manifest --- indicator-sound-12.10.2+18.10.20180612/debian/bzr-builder.manifest 2018-10-04 21:56:29.000000000 +0000 +++ indicator-sound-12.10.2+18.10.20180612/debian/bzr-builder.manifest 2019-03-22 15:44:26.000000000 +0000 @@ -1,2 +1,2 @@ -# bzr-builder format 0.3 deb-version {debversion}+201810042156 -lp:~khurshid-alam/indicator-sound/disable-failed-tests revid:khurshid.alam@linuxmail.org-20181004200119-noj20m2umkz9sswe +# bzr-builder format 0.3 deb-version {debversion}+201903221544 +lp:~khurshid-alam/indicator-sound/gicon-regression-fix revid:khurshid.alam@linuxmail.org-20190212073240-bhsaqpyrpy654hax diff -Nru indicator-sound-12.10.2+18.10.20180612/debian/changelog indicator-sound-12.10.2+18.10.20180612/debian/changelog --- indicator-sound-12.10.2+18.10.20180612/debian/changelog 2018-10-04 21:56:29.000000000 +0000 +++ indicator-sound-12.10.2+18.10.20180612/debian/changelog 2019-03-22 15:44:26.000000000 +0000 @@ -1,8 +1,8 @@ -indicator-sound (12.10.2+18.10.20180612-0ubuntu1+201810042156~ubuntu18.10.1) cosmic; urgency=low +indicator-sound (12.10.2+18.10.20180612-0ubuntu1+201903221544~ubuntu18.10.1) cosmic; urgency=low * Auto build. - -- Khurshid Alam Thu, 04 Oct 2018 21:56:29 +0000 + -- Khurshid Alam Fri, 22 Mar 2019 15:44:26 +0000 indicator-sound (12.10.2+18.10.20180612-0ubuntu1) cosmic; urgency=medium diff -Nru indicator-sound-12.10.2+18.10.20180612/src/accounts-service-access.vala indicator-sound-12.10.2+18.10.20180612/src/accounts-service-access.vala --- indicator-sound-12.10.2+18.10.20180612/src/accounts-service-access.vala 2018-10-04 21:56:28.000000000 +0000 +++ indicator-sound-12.10.2+18.10.20180612/src/accounts-service-access.vala 2019-03-22 15:44:25.000000000 +0000 @@ -25,7 +25,7 @@ [DBus (name="com.canonical.UnityGreeter.List")] interface GreeterListInterfaceAccess : Object { - public abstract async string get_active_entry () throws IOError; + public abstract async string get_active_entry () throws GLib.Error; public signal void entry_selected (string entry_name); } diff -Nru indicator-sound-12.10.2+18.10.20180612/src/freedesktop-interfaces.vala indicator-sound-12.10.2+18.10.20180612/src/freedesktop-interfaces.vala --- indicator-sound-12.10.2+18.10.20180612/src/freedesktop-interfaces.vala 2018-10-04 21:56:28.000000000 +0000 +++ indicator-sound-12.10.2+18.10.20180612/src/freedesktop-interfaces.vala 2019-03-22 15:44:25.000000000 +0000 @@ -19,7 +19,7 @@ [DBus (name = "org.freedesktop.DBus")] public interface FreeDesktopObject: Object { - public abstract async string[] list_names() throws IOError; + public abstract async string[] list_names() throws GLib.Error; public abstract signal void name_owner_changed ( string name, string old_owner, string new_owner ); @@ -27,7 +27,7 @@ [DBus (name = "org.freedesktop.DBus.Introspectable")] public interface FreeDesktopIntrospectable: Object { - public abstract string Introspect() throws IOError; + public abstract string Introspect() throws GLib.Error; } [DBus (name = "org.freedesktop.DBus.Properties")] diff -Nru indicator-sound-12.10.2+18.10.20180612/src/greeter-broadcast.vala indicator-sound-12.10.2+18.10.20180612/src/greeter-broadcast.vala --- indicator-sound-12.10.2+18.10.20180612/src/greeter-broadcast.vala 2018-10-04 21:56:28.000000000 +0000 +++ indicator-sound-12.10.2+18.10.20180612/src/greeter-broadcast.vala 2019-03-22 15:44:25.000000000 +0000 @@ -20,11 +20,11 @@ [DBus (name = "com.canonical.Unity.Greeter.Broadcast")] public interface GreeterBroadcast : Object { // methods - // unused public abstract async void RequestApplicationStart(string name, string appid) throws IOError; - // unused public abstract async void RequestHomeShown(string name) throws IOError; - public abstract async void RequestSoundPlayPause(string name) throws IOError; - public abstract async void RequestSoundNext(string name) throws IOError; - public abstract async void RequestSoundPrev(string name) throws IOError; + // unused public abstract async void RequestApplicationStart(string name, string appid) throws GLib.Error; + // unused public abstract async void RequestHomeShown(string name) throws GLib.Error; + public abstract async void RequestSoundPlayPause(string name) throws GLib.Error; + public abstract async void RequestSoundNext(string name) throws GLib.Error; + public abstract async void RequestSoundPrev(string name) throws GLib.Error; // signals // unused public signal void StartApplication(string username, string appid); // unused public signal void ShowHome(string username); diff -Nru indicator-sound-12.10.2+18.10.20180612/src/media-player-list-greeter.vala indicator-sound-12.10.2+18.10.20180612/src/media-player-list-greeter.vala --- indicator-sound-12.10.2+18.10.20180612/src/media-player-list-greeter.vala 2018-10-04 21:56:28.000000000 +0000 +++ indicator-sound-12.10.2+18.10.20180612/src/media-player-list-greeter.vala 2019-03-22 15:44:25.000000000 +0000 @@ -19,7 +19,7 @@ [DBus (name="com.canonical.UnityGreeter.List")] public interface UnityGreeterList : Object { - public abstract async string get_active_entry () throws IOError; + public abstract async string get_active_entry () throws GLib.Error; public signal void entry_selected (string entry_name); } diff -Nru indicator-sound-12.10.2+18.10.20180612/src/mpris2-interfaces.vala indicator-sound-12.10.2+18.10.20180612/src/mpris2-interfaces.vala --- indicator-sound-12.10.2+18.10.20180612/src/mpris2-interfaces.vala 2018-10-04 21:56:28.000000000 +0000 +++ indicator-sound-12.10.2+18.10.20180612/src/mpris2-interfaces.vala 2019-03-22 15:44:25.000000000 +0000 @@ -28,8 +28,8 @@ public abstract string Identity{owned get; set;} public abstract string DesktopEntry{owned get; set;} // methods - public abstract async void Quit() throws IOError; - public abstract async void Raise() throws IOError; + public abstract async void Quit() throws GLib.Error; + public abstract async void Raise() throws GLib.Error; } [DBus (name = "org.mpris.MediaPlayer2.Player")] @@ -42,10 +42,10 @@ public abstract bool CanGoNext{owned get; set;} public abstract bool CanGoPrevious{owned get; set;} // methods - public abstract async void PlayPause() throws IOError; - public abstract async void Next() throws IOError; - public abstract async void Previous() throws IOError; - public abstract async void Seek(int64 offset) throws IOError; + public abstract async void PlayPause() throws GLib.Error; + public abstract async void Next() throws GLib.Error; + public abstract async void Previous() throws GLib.Error; + public abstract async void Seek(int64 offset) throws GLib.Error; // signals public signal void Seeked(int64 new_position); } @@ -71,11 +71,11 @@ public abstract ActivePlaylistContainer? ActivePlaylist {owned get; set;} //methods - public abstract async void ActivatePlaylist(ObjectPath playlist_id) throws IOError; + public abstract async void ActivatePlaylist(ObjectPath playlist_id) throws GLib.Error; public abstract async PlaylistDetails[]? GetPlaylists ( uint32 index, uint32 max_count, string order, - bool reverse_order ) throws IOError; + bool reverse_order ) throws GLib.Error; //signals public signal void PlaylistChanged (PlaylistDetails details); diff -Nru indicator-sound-12.10.2+18.10.20180612/src/options-gsettings.vala indicator-sound-12.10.2+18.10.20180612/src/options-gsettings.vala --- indicator-sound-12.10.2+18.10.20180612/src/options-gsettings.vala 2018-10-04 21:56:28.000000000 +0000 +++ indicator-sound-12.10.2+18.10.20180612/src/options-gsettings.vala 2019-03-22 15:44:25.000000000 +0000 @@ -35,9 +35,9 @@ /** MAX VOLUME PROPERTY **/ - private static const string AMP_dB_KEY = "amplified-volume-decibels"; - private static const string NORMAL_dB_KEY = "normal-volume-decibels"; - private static const string ALLOW_AMP_KEY = "allow-amplified-volume"; + private const string AMP_dB_KEY = "amplified-volume-decibels"; + private const string NORMAL_dB_KEY = "normal-volume-decibels"; + private const string ALLOW_AMP_KEY = "allow-amplified-volume"; private void init_max_volume() { _settings.changed[NORMAL_dB_KEY].connect(() => update_max_volume()); @@ -66,8 +66,8 @@ /** LOUD VOLUME **/ - private static const string LOUD_ENABLED_KEY = "warning-volume-enabled"; - private static const string LOUD_DECIBEL_KEY = "warning-volume-decibels"; + private const string LOUD_ENABLED_KEY = "warning-volume-enabled"; + private const string LOUD_DECIBEL_KEY = "warning-volume-decibels"; private void init_loud_volume() { _settings.changed[LOUD_ENABLED_KEY].connect(() => update_loud_volume()); diff -Nru indicator-sound-12.10.2+18.10.20180612/src/volume-warning.vala indicator-sound-12.10.2+18.10.20180612/src/volume-warning.vala --- indicator-sound-12.10.2+18.10.20180612/src/volume-warning.vala 2018-10-04 21:56:28.000000000 +0000 +++ indicator-sound-12.10.2+18.10.20180612/src/volume-warning.vala 2019-03-22 15:44:25.000000000 +0000 @@ -133,7 +133,7 @@ **/ private Settings _settings = new Settings ("com.canonical.indicator.sound"); - private static const string TTL_KEY = "warning-volume-confirmation-ttl"; + private const string TTL_KEY = "warning-volume-confirmation-ttl"; private uint _approved_timer = 0; private int64 _approved_at = 0; private int64 _approved_ttl_usec = 0; diff -Nru indicator-sound-12.10.2+18.10.20180612/tests/integration/indicator-sound-test-base.cpp indicator-sound-12.10.2+18.10.20180612/tests/integration/indicator-sound-test-base.cpp --- indicator-sound-12.10.2+18.10.20180612/tests/integration/indicator-sound-test-base.cpp 2018-10-04 21:56:28.000000000 +0000 +++ indicator-sound-12.10.2+18.10.20180612/tests/integration/indicator-sound-test-base.cpp 2019-03-22 15:44:25.000000000 +0000 @@ -422,8 +422,8 @@ .double_attribute("max-value", 1.0) .double_attribute("step", 0.01) .string_attribute("x-canonical-type", "com.canonical.unity.slider") - .themed_icon("max-icon", {"audio-input-microphone-high-panel", "audio-input-microphone-high", "audio-input-microphone", "audio-input", "audio", "audio-input-microphone-high-panel-symbolic", "audio-input-microphone-high-symbolic", "audio-input-microphone-symbolic", "audio-input-symbolic", "audio-symbolic"}) - .themed_icon("min-icon", {"audio-input-microphone-low-zero-panel", "audio-input-microphone-low-zero", "audio-input-microphone-low", "audio-input-microphone", "audio-input", "audio", "audio-input-microphone-low-zero-panel-symbolic", "audio-input-microphone-low-zero-symbolc", "audio-input-microphone-low-symbolic", "audio-input-microphone-symbolic", "audio-input-symbolic", "audio-symbolic"}) + .themed_icon("max-icon", {"audio-input-microphone-high-panel", "audio-input-microphone-high", "audio-input-microphone", "audio-input", "audio"}) + .themed_icon("min-icon", {"audio-input-microphone-low-zero-panel", "audio-input-microphone-low-zero", "audio-input-microphone-low", "audio-input-microphone", "audio-input", "audio"}) .pass_through_double_attribute("action", volume); } diff -Nru indicator-sound-12.10.2+18.10.20180612/tests/integration/test-indicator.cpp indicator-sound-12.10.2+18.10.20180612/tests/integration/test-indicator.cpp --- indicator-sound-12.10.2+18.10.20180612/tests/integration/test-indicator.cpp 2018-10-04 21:56:28.000000000 +0000 +++ indicator-sound-12.10.2+18.10.20180612/tests/integration/test-indicator.cpp 2019-03-22 15:44:25.000000000 +0000 @@ -154,7 +154,6 @@ ).match()); */ - // unplug the external mic EXPECT_TRUE(plugExternalMic(false));