Merge lp:~victor-launchpad/network-manager-applet/bugfix-lp-386900 into lp:network-manager-applet

Proposed by Victor N on 2010-02-13
Status: Rejected
Rejected by: Max Bowsher on 2012-04-09
Proposed branch: lp:~victor-launchpad/network-manager-applet/bugfix-lp-386900
Merge into: lp:network-manager-applet
Diff against target: 38 lines (+6/-6)
1 file modified
src/applet-device-wired.c (+6/-6)
To merge this branch: bzr merge lp:~victor-launchpad/network-manager-applet/bugfix-lp-386900
Reviewer Review Type Date Requested Status
Martin Pitt (community) Disapprove on 2010-11-26
Mathieu Trudel-Lapierre (community) Disapprove on 2010-11-08
VCS imports 2010-02-13 Pending
Review via email: mp+19274@code.launchpad.net
To post a comment you must log in.
Victor N (victor-launchpad) wrote :

I removed "Auto Eth" from the wired network notifications to fix hundred-papercuts bug 386900.

Mathieu Trudel-Lapierre (cyphermox) wrote :

This is sadly not where such a change would be made. You'll likely want to delete this merge request and file another against lp:~network-manager/network-manager/ubuntu.head which contains just the Ubuntu changes (and also make it as a patch rather than direct changes).

Note that you should check the comment I left in the bug, I'm not sure changing just the tooltip texts will be sufficient, what really needs changing seems to me more like just the "default" name for a connection created automatically by NetworkManager.

review: Disapprove
Martin Pitt (pitti) wrote :

Indeed we don't want to apply this in Ubuntu without it being applied upstream first, otherwise we'd have a permanent delta on user-visible strings. This would keep breaking all translations.

Also, please don't drop the interface name from the string, as it's not uncommon to have more than one. I think "wired connection (eth0)" is a good enough compromise.

review: Disapprove
Max Bowsher (maxb) wrote :

Marked Rejected, as this is proposed against an automatic import branch. And change would need to be submitted upstream instead.

Unmerged revisions

1375. By Victor N on 2010-02-13

Fix Launchpad bug #386900 by removing "Auto Eth0" from notifications.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/applet-device-wired.c'
2--- src/applet-device-wired.c 2009-10-01 05:47:52 +0000
3+++ src/applet-device-wired.c 2010-02-13 17:03:14 +0000
4@@ -267,7 +267,7 @@
5 s_con = NM_SETTING_CONNECTION (nm_connection_get_setting (connection, NM_TYPE_SETTING_CONNECTION));
6 id = s_con ? nm_setting_connection_get_id (s_con) : NULL;
7 if (id)
8- str = g_strdup_printf (_("You are now connected to '%s'."), id);
9+ str = g_strdup_printf (_("You are now connected to a wired network."));
10 }
11
12 applet_do_notify_with_pref (applet,
13@@ -298,20 +298,20 @@
14
15 switch (state) {
16 case NM_DEVICE_STATE_PREPARE:
17- *tip = g_strdup_printf (_("Preparing wired network connection '%s'..."), id);
18+ *tip = g_strdup_printf (_("Preparing wired network connection..."));
19 break;
20 case NM_DEVICE_STATE_CONFIG:
21- *tip = g_strdup_printf (_("Configuring wired network connection '%s'..."), id);
22+ *tip = g_strdup_printf (_("Configuring wired network connection..."));
23 break;
24 case NM_DEVICE_STATE_NEED_AUTH:
25- *tip = g_strdup_printf (_("User authentication required for wired network connection '%s'..."), id);
26+ *tip = g_strdup_printf (_("User authentication required for a wired network connection..."));
27 break;
28 case NM_DEVICE_STATE_IP_CONFIG:
29- *tip = g_strdup_printf (_("Requesting a wired network address for '%s'..."), id);
30+ *tip = g_strdup_printf (_("Requesting a wired network address..."));
31 break;
32 case NM_DEVICE_STATE_ACTIVATED:
33 pixbuf = applet->wired_icon;
34- *tip = g_strdup_printf (_("Wired network connection '%s' active"), id);
35+ *tip = g_strdup_printf (_("Wired network connection active"));
36 break;
37 default:
38 break;

Subscribers

People subscribed via source and target branches

to all changes: