Reddit application reports new mail incorrectly
Bug #1029444 reported by
Xoimai
This bug affects 4 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| WebApps: Applications Data |
In Progress
|
Medium
|
Alexandre Abreu | ||
Bug Description
When I have no mail (from other Reddit users) the notification menu becomes blue instead of being grey when there is no mail.
It appears that the incorrect class is used in the script (maybe it changed?); changing it to "nohavemail" or removing the exclamation mark in the same line solves the problem. I have tested the attached patch which seems to give the correct behaviour.
Related branches
lp:~abreu-alexandre/webapps-applications/fix-reddit-integration-script
- Robert Bruce Park (community): Needs Resubmitting
- Maxim Ermilov (community): Needs Fixing
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 91 lines (+54/-16)1 file modifiedsrc/Reddit/Reddit.user.js (+54/-16)
Revision history for this message
| Xoimai (xoimai) wrote | #2 |
| visibility: | private → public |
Revision history for this message
| José Antonio Rey (jose) wrote | #3 |
| Changed in webapps-applications: | |
| status: | New → Confirmed |
| Changed in webapps-applications: | |
| importance: | Undecided → Medium |
| Changed in webapps-applications: | |
| assignee: | nobody → Alexandre Abreu (abreu-alexandre) |
| status: | Confirmed → In Progress |
To post a comment you must log in.
Scrap that last patch. I forgot to test it being logged out, the class nohavemail doesn't exist then. New patch seems to work also when logged out.