Get rid of some more perl (Unity support test)

Bug #1087777 reported by Jeff Lane 
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Checkbox
Fix Released
Undecided
Jeff Lane 

Bug Description

graphics.txt has two jobs that run unity_support_test from nux tools.

They both use perl to do some sustitution and essentially remove the ansi stuff from the output:

bladernr@klaatu:~/development/checkbox/jobs$ grep unity_support *
graphics.txt.in: perl -e '$a=`/usr/lib/nux/unity_support_test -c -p`;$a=~s/\e\[[\d;]*m//g;print $a;exit($? ? 1:0)'
graphics.txt.in: perl -e '$a=`/usr/lib/nux/unity_support_test -p`;$a=~s/\e\[[\d;]*m//g;print $a;exit($? ? 1:0)'

Checkbox, for some time, has had ansi_parser that does this internally.

We should remove the perl bits in favor of using ansi_parser. This removes some of that perl mess ;-) but also puts the tests in line with other tests that use ansi_parser to remove ansi charactres from the output.

Related branches

Jeff Lane  (bladernr)
Changed in checkbox:
status: New → Fix Committed
assignee: nobody → Jeff Lane (bladernr)
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Accidently changed to Fix Released by script. Is still only in trunk, not the public PPA

Changed in checkbox:
status: Fix Committed → Fix Released
status: Fix Released → Fix Committed
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Don't forget to add:

set -o pipefail

otherwise the exit code will always be true.
I'll propose a merge request to fix the problem.

Changed in checkbox:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.