Checkbox

Vagrantfile (+25/-16)
bin/checkbox-hw-collection (+19/-0)
checkbox/contrib/xrandr.py (+132/-59)
checkbox/lib/fifo.py (+6/-1)
checkbox/lib/template.py (+4/-4)
checkbox/message.py (+17/-15)
checkbox/parsers/submission.py (+1/-1)
checkbox/parsers/tests/fixtures/submission_info_memory.xml (+1/-1)
checkbox/parsers/tests/test_cputable.py (+4/-4)
checkbox/parsers/tests/test_description.py (+17/-17)
checkbox/parsers/tests/test_dmi.py (+13/-13)
checkbox/parsers/tests/test_efi.py (+5/-5)
checkbox/parsers/tests/test_submission.py (+43/-50)
checkbox/parsers/tests/test_xinput.py (+21/-26)
checkbox/parsers/udevadm.py (+3/-2)
checkbox/test_resource.py (+347/-0)
checkbox/tests/__init__.py (+49/-0)
checkbox/tests/test_job.py (+5/-4)
checkbox/tests/test_message_files.py (+3/-2)
checkbox/tests/test_setup_files.py (+4/-2)
checkbox/user_interface.py (+6/-11)
checkbox/variables.py (+2/-1)
checkbox_cli/cli_interface.py (+3/-3)
checkbox_gtk/gtk_interface.py (+2/-2)
checkbox_qt/qt_interface.py (+3/-3)
checkbox_urwid/urwid_interface.py (+2/-2)
data/whitelists/hwsubmit.whitelist (+24/-0)
data/whitelists/sru.whitelist (+114/-0)
debian/changelog (+142/-0)
debian/checkbox-hw-collection.install (+2/-0)
debian/checkbox-hw-collection.links (+1/-0)
debian/checkbox-hw-collection.postinst (+7/-0)
debian/checkbox.install (+1/-0)
debian/control (+13/-0)
debian/po/ast.po (+3/-4)
debian/po/cs.po (+3/-4)
debian/po/de.po (+5/-5)
debian/po/en_AU.po (+3/-4)
debian/po/en_GB.po (+3/-4)
debian/po/es.po (+7/-6)
debian/po/fr.po (+3/-4)
debian/po/gl.po (+3/-4)
debian/po/he.po (+3/-4)
debian/po/hu.po (+3/-4)
debian/po/id.po (+3/-4)
debian/po/it.po (+3/-4)
debian/po/ja.po (+3/-4)
debian/po/nl.po (+3/-4)
debian/po/oc.po (+3/-4)
debian/po/pl.po (+3/-4)
debian/po/pt_BR.po (+3/-4)
debian/po/ro.po (+3/-4)
debian/po/ru.po (+3/-4)
debian/po/tr.po (+3/-4)
debian/po/uk.po (+3/-4)
debian/po/zh_CN.po (+3/-4)
debian/po/zh_TW.po (+3/-4)
debian/rules (+1/-0)
examples/checkbox-cli.ini (+3/-0)
examples/checkbox-hw-collection.ini (+18/-0)
examples/checkbox-qt.ini (+4/-0)
examples/checkbox-urwid.ini (+3/-0)
examples/network.cfg (+4/-0)
jobs/audio.txt.in (+4/-0)
jobs/benchmarks.txt.in (+68/-0)
jobs/camera.txt.in (+0/-1)
jobs/esata.txt.in (+1/-1)
jobs/firewire.txt.in (+1/-1)
jobs/graphics.txt.in (+3/-1)
jobs/hibernate.txt.in (+8/-2)
jobs/info.txt.in (+1/-1)
jobs/input.txt.in (+11/-1)
jobs/keys.txt.in (+8/-2)
jobs/led.txt.in (+45/-14)
jobs/local.txt.in (+7/-0)
jobs/mediacard.txt.in (+50/-33)
jobs/miscellanea.txt.in (+52/-1)
jobs/mobilebroadband.txt.in (+21/-0)
jobs/monitor.txt.in (+4/-4)
jobs/networking.txt.in (+4/-4)
jobs/power-management.txt.in (+57/-21)
jobs/rendercheck.txt.in (+1/-1)
jobs/resource.txt.in (+13/-0)
jobs/stress.txt.in (+15/-3)
jobs/suspend.txt.in (+96/-39)
jobs/usb.txt.in (+6/-6)
jobs/virtualization.txt.in (+16/-0)
jobs/wireless.txt.in (+13/-13)
plainbox/.coveragerc (+11/-0)
plainbox/MANIFEST.in (+5/-0)
plainbox/README.md (+0/-122)
plainbox/README.rst (+23/-0)
plainbox/Vagrantfile (+42/-0)
plainbox/daily-package-testing/README (+18/-0)
plainbox/daily-package-testing/Vagrantfile (+48/-0)
plainbox/daily-package-testing/test-in-vagrant.sh (+59/-0)
plainbox/docs/appdev/index.rst (+39/-0)
plainbox/docs/author/index.rst (+63/-0)
plainbox/docs/conf.py (+13/-1)
plainbox/docs/dev/architecture.rst (+7/-305)
plainbox/docs/dev/config.rst (+253/-0)
plainbox/docs/dev/index.rst (+12/-7)
plainbox/docs/dev/old.rst (+339/-0)
plainbox/docs/dev/reference.rst (+15/-0)
plainbox/docs/dev/resources.rst (+259/-0)
plainbox/docs/index.rst (+8/-5)
plainbox/docs/usage.rst (+29/-5)
plainbox/mk-interesting-graphs.sh (+2/-2)
plainbox/mk-venv.sh (+181/-26)
plainbox/plainbox/data/org.freedesktop.policykit.pkexec.policy (+30/-0)
plainbox/plainbox/data/plainbox-ci-mailer.conf (+44/-0)
plainbox/plainbox/data/plainbox.conf (+26/-0)
plainbox/plainbox/data/plainbox.desktop (+10/-0)
plainbox/plainbox/data/report/hardware-1_0.rng (+533/-0)
plainbox/plainbox/impl/applogic.py (+173/-0)
plainbox/plainbox/impl/box.py (+13/-386)
plainbox/plainbox/impl/checkbox.py (+161/-74)
plainbox/plainbox/impl/commands/check_config.py (+92/-0)
plainbox/plainbox/impl/commands/checkbox.py (+101/-0)
plainbox/plainbox/impl/commands/run.py (+319/-0)
plainbox/plainbox/impl/commands/special.py (+133/-0)
plainbox/plainbox/impl/commands/sru.py (+270/-0)
plainbox/plainbox/impl/commands/test_run.py (+28/-0)
plainbox/plainbox/impl/commands/test_sru.py (+63/-0)
plainbox/plainbox/impl/config.py (+538/-0)
plainbox/plainbox/impl/depmgr.py (+59/-5)
plainbox/plainbox/impl/exporter/__init__.py (+53/-8)
plainbox/plainbox/impl/exporter/json.py (+12/-5)
plainbox/plainbox/impl/exporter/rfc822.py (+5/-2)
plainbox/plainbox/impl/exporter/test_init.py (+22/-3)
plainbox/plainbox/impl/exporter/test_json.py (+13/-7)
plainbox/plainbox/impl/exporter/test_rfc822.py (+47/-0)
plainbox/plainbox/impl/exporter/test_text.py (+43/-0)
plainbox/plainbox/impl/exporter/test_xml.py (+96/-0)
plainbox/plainbox/impl/exporter/text.py (+3/-3)
plainbox/plainbox/impl/exporter/xml.py (+385/-0)
plainbox/plainbox/impl/integration_tests.py (+8/-5)
plainbox/plainbox/impl/job.py (+36/-46)
plainbox/plainbox/impl/mock_job.py (+1/-1)
plainbox/plainbox/impl/rfc822.py (+4/-19)
plainbox/plainbox/impl/runner.py (+90/-42)
plainbox/plainbox/impl/secure/__init__.py (+27/-0)
plainbox/plainbox/impl/secure/checkbox_trusted_launcher.py (+402/-0)
plainbox/plainbox/impl/secure/test_checkbox_trusted_launcher.py (+268/-0)
plainbox/plainbox/impl/session.py (+95/-9)
plainbox/plainbox/impl/test_applogic.py (+108/-0)
plainbox/plainbox/impl/test_box.py (+24/-9)
plainbox/plainbox/impl/test_checkbox.py (+83/-0)
plainbox/plainbox/impl/test_config.py (+153/-0)
plainbox/plainbox/impl/test_depmgr.py (+22/-2)
plainbox/plainbox/impl/test_job.py (+142/-66)
plainbox/plainbox/impl/test_result.py (+2/-2)
plainbox/plainbox/impl/test_rfc822.py (+27/-19)
plainbox/plainbox/impl/test_runner.py (+62/-0)
plainbox/plainbox/impl/test_session.py (+123/-11)
plainbox/plainbox/impl/testing_utils.py (+1/-1)
plainbox/plainbox/impl/transport/__init__.py (+95/-0)
plainbox/plainbox/impl/transport/certification.py (+132/-0)
plainbox/plainbox/impl/transport/test_certification.py (+183/-0)
plainbox/plainbox/impl/transport/test_init.py (+68/-0)
plainbox/plainbox/test-data/xml-exporter/example-data.json (+19037/-0)
plainbox/plainbox/test-data/xml-exporter/example-data.xml (+15749/-0)
plainbox/plainbox/test-data/xml-exporter/test_dump_with_binary_attachment.json (+7/-0)
plainbox/plainbox/test-data/xml-exporter/test_dump_with_binary_attachment.xml (+21/-0)
plainbox/plainbox/test-data/xml-exporter/test_dump_with_comments.json (+13/-0)
plainbox/plainbox/test-data/xml-exporter/test_dump_with_comments.xml (+30/-0)
plainbox/plainbox/test-data/xml-exporter/test_dump_with_hardware_info.json (+10/-0)
plainbox/plainbox/test-data/xml-exporter/test_dump_with_hardware_info.xml (+22/-0)
plainbox/plainbox/test-data/xml-exporter/test_dump_with_io_log.json (+14/-0)
plainbox/plainbox/test-data/xml-exporter/test_dump_with_io_log.xml (+30/-0)
plainbox/plainbox/test-data/xml-exporter/test_dump_with_text_attachment.json (+7/-0)
plainbox/plainbox/test-data/xml-exporter/test_dump_with_text_attachment.xml (+21/-0)
plainbox/plainbox/testing_utils/__init__.py (+50/-1)
plainbox/requirements/rtfd.txt (+5/-0)
plainbox/setup.py (+20/-2)
plainbox/test-in-vagrant.sh (+82/-0)
plainbox/test-with-coverage.sh (+4/-4)
plugins/environment_info.py (+7/-0)
plugins/hexr_prompt.py (+32/-0)
plugins/hexr_transport.py (+169/-0)
plugins/jobs_prompt.py (+0/-1)
plugins/launchpad_exchange.py (+1/-1)
plugins/launchpad_prompt.py (+3/-2)
plugins/launchpad_report.py (+2/-1)
plugins/lock_prompt.py (+16/-8)
plugins/message_info.py (+4/-2)
plugins/persist_info.py (+1/-1)
po/POTFILES.in (+1/-0)
po/ace.po (+3/-3)
po/af.po (+3/-3)
po/am.po (+3/-3)
po/ar.po (+3/-3)
po/ast.po (+3/-3)
po/az.po (+3/-3)
po/be.po (+3/-3)
po/bg.po (+3/-3)
po/bn.po (+3/-3)
po/bo.po (+3/-3)
po/br.po (+3/-3)
po/bs.po (+5/-5)
po/ca.po (+3/-3)
po/ca@valencia.po (+3/-3)
po/ckb.po (+3/-3)
po/cs.po (+13/-3)
po/cy.po (+3/-3)
po/da.po (+3/-3)
po/de.po (+3/-3)
po/dv.po (+3/-3)
po/el.po (+3/-3)
po/en_AU.po (+3/-3)
po/en_CA.po (+3/-3)
po/en_GB.po (+3/-3)
po/eo.po (+3/-3)
po/es.po (+113/-113)
po/et.po (+3/-3)
po/eu.po (+3/-3)
po/fa.po (+3/-3)
po/fi.po (+3/-3)
po/fr.po (+3/-3)
po/ga.po (+3/-3)
po/gd.po (+3/-3)
po/gl.po (+242/-213)
po/he.po (+3/-3)
po/hi.po (+3/-3)
po/hr.po (+3/-3)
po/hu.po (+3/-3)
po/hy.po (+3/-3)
po/id.po (+3/-3)
po/is.po (+3/-3)
po/it.po (+11/-10)
po/ja.po (+174/-160)
po/jbo.po (+3/-3)
po/ka.po (+3/-3)
po/kk.po (+3/-3)
po/km.po (+3/-3)
po/kn.po (+3/-3)
po/ko.po (+3/-3)
po/ku.po (+3/-3)
po/ky.po (+3/-3)
po/lt.po (+3/-3)
po/lv.po (+4/-4)
po/mk.po (+3/-3)
po/ml.po (+3/-3)
po/mr.po (+3/-3)
po/ms.po (+3/-3)
po/my.po (+3/-3)
po/nb.po (+3/-3)
po/nds.po (+3/-3)
po/ne.po (+3/-3)
po/nl.po (+3/-3)
po/nn.po (+3/-3)
po/oc.po (+5/-5)
po/pl.po (+3/-3)
po/ps.po (+3/-3)
po/pt.po (+20/-20)
po/pt_BR.po (+14/-14)
po/ro.po (+3/-3)
po/ru.po (+5/-5)
po/sd.po (+3/-3)
po/shn.po (+3/-3)
po/si.po (+3/-3)
po/sk.po (+3/-3)
po/sl.po (+43/-43)
po/sq.po (+3/-3)
po/sr.po (+3/-3)
po/sv.po (+3/-3)
po/ta.po (+3/-3)
po/te.po (+3/-3)
po/th.po (+3/-3)
po/tr.po (+3/-3)
po/ug.po (+3/-3)
po/uk.po (+3/-3)
po/ur.po (+3/-3)
po/uz.po (+3/-3)
po/vi.po (+3/-3)
po/zh_CN.po (+3/-3)
po/zh_HK.po (+3/-3)
po/zh_TW.po (+3/-3)
qt/frontend/qtfront.cpp (+11/-1)
qt/frontend/qtfront.h (+2/-1)
qt/frontend/qtfront.ui (+20/-4)
scripts/alsa_record_playback (+1/-1)
scripts/bluetooth_test (+1/-1)
scripts/camera_test (+76/-46)
scripts/cpu_offlining (+25/-13)
scripts/cpu_topology (+1/-1)
scripts/create_connection (+172/-55)
scripts/fwts_test (+26/-23)
scripts/glob_test (+121/-0)
scripts/gpu_test (+74/-71)
scripts/gputest_benchmark (+110/-0)
scripts/graphics_stress_test (+6/-0)
scripts/lsmod_info (+6/-3)
scripts/memory_compare (+6/-3)
scripts/mm-test (+527/-0)
scripts/network (+382/-0)
scripts/network_check (+5/-1)
scripts/network_device_info (+11/-10)
scripts/rendercheck_test (+7/-0)
scripts/sleep_test_log_check (+72/-0)
scripts/sources_test (+11/-8)
scripts/virtualization (+82/-29)
scripts/xen_test (+74/-0)
setup.cfg (+1/-0)
setup.py (+6/-6)
tarmac-verify (+15/-5)
test-in-vagrant.sh (+101/-20)
test_scripts/tests/test_gputest_benchmark.py (+82/-0)

lp:ubuntu/saucy/checkbox

lp:ubuntu/saucy-proposed/checkbox

Revision history for this message

Daniel Manrique (roadmr) wrote on 2013-04-16:

Hi Jeffrey,

The script uses dpkg to check whether obexftp is installed. The only instance of this is calling:

dpkg -l

Could you please run the following command and tell me what it outputs?

if ! dpkg -l | grep -q obexftp; then echo "You must install obexftp to run this script"; fi

Also, please separately run these two commands and also tell me what it outputs:

dpkg -l
dpkg -l | grep -q obexftp

Changed in checkbox:
status:	New → Incomplete

Revision history for this message

Jeffrey Chang (modern911) wrote on 2013-04-17:

both work as expected.
dpkg -l listed all my packages,
dpkg -l | grep -q obexftp, shows nothing, then echo $? will get 0, cause I have obexftp installed.

Revision history for this message

Daniel Manrique (roadmr) wrote on 2013-04-17:

OK, so that's covered, let's try running the command manually.

You need to know your bluetooth target's address (a hex number like 00:1B:B1:16:D2:40).

Then do:

/usr/share/checkbox/scripts/obex_send <bluetooth-target> /etc/hosts

this will try sending a small file, let me know what the tests output when run manually.

Thanks!

Revision history for this message

Jeffrey Chang (modern911) wrote on 2013-04-19:

The test is actually passing, I can see the file on another pc.
Just the error message is really annoying.

I saw this on multiple submissions, so I believe this should not caused by my environment.
Another example here https://certification.canonical.com/hardware/201304-13203/submission/90634/test-results/pass/?page=3

Revision history for this message

Jeff Lane  (bladernr) wrote on 2013-04-24:

Just a note, all the tests Jeffrey references use bluetooth_test, not obex_send.

Also, for reference, this is the sort of output that is confusing:

dpkg-query: error: error writing to '<standard output>': Broken pipe
Checking 00:02:72:DC:5E:38 for JPEG_Color_Image_Ubuntu.jpg
Will check for a filesize of 25770
Browsing 00:02:72:DC:5E:38 ...
Connecting..\done
Tried to connect for 9ms
Receiving "(null)"...|done
Disconnecting../done
<file name="JPEG_Color_Image_Ubuntu.jpg" size="25770" user-perm="RWD" modified="20130110T021952Z" created="20130110T021952Z" accessed="20130418T054757Z" />
PASS

Revision history for this message

Jeff Lane  (bladernr) wrote on 2013-04-24:

The bit in question seems innocuous enough:

if ! dpkg -l | grep -q obexftp; then
echo "You must install obexftp to run this script"
exit 1

Would it make a difference if run in a subshell like this:

if ( ! dpkg -l | grep -q obexftp ); then
echo "You must install obexftp to run this script"
exit 1

or better yet, is there a better way to determine if a package is installed?

Revision history for this message

Daniel Manrique (roadmr) wrote on 2013-04-24:

dpkg -s seems to output some text, but exit status 1 for a non-installed package, and 0 for an installed package.

This bears testing in all three possible scenarios:

- Package has never been installed
- Package is currently installed
- Package was installed, then removed

The other option I've frequently seen used is

dpkg -l packagename |grep ^ii

but this has the potential same problem of piping dpkg output to grep.

It'd be great to somehow reproduce Jeffrey's error message so we know what causes it, and we can test that any proposed solution does *not* exhibit that behavior.

Daniel Manrique (roadmr) on 2013-04-24

Changed in checkbox:
status:	Incomplete → Confirmed
importance:	Undecided → Medium

Revision history for this message

Jeff Lane  (bladernr) wrote on 2013-04-25:

bluetooth_test Edit (1.4 KiB, text/plain)

Jeffrey, can you have someone do the following:

replace /usr/share/checkbox/scripts/bluetooth_test with the version attached here
re-run the bluetooth tests
check the resulting output for the error and verify that the test works.

Rather than muck about with subshells, let's try changing how we determine if obexftp is present.

Changed in checkbox:
status:	Confirmed → Incomplete

Revision history for this message

Jeff Lane  (bladernr) wrote on 2013-04-25:

I should add that I am not able to test this locally as I don't have the hardware to do so.

Revision history for this message

Jeff Lane  (bladernr) wrote on 2013-04-25:

#10

Hah, I didn't even realize Daniel had replied until after I posted all that.

So FWIW, my proposed fix is this:

dpkg-query -W obexftp >/dev/null 2>&1

which will give us a 0 if installed, or 1 otherwise, and no output at all. It also avoids any wonky subshell weirdness, which is what I think was happening here (dpkg maybe trying to write to stderr but getting the descriptor for the parent shell the script was running in instead of the local shell??) or some other madness.

So at the very least, eliminating the pipe and grep stuff should resolve it.

Revision history for this message

Jeff Lane  (bladernr) wrote on 2013-04-25:

#11

Another suggestion would be to just remove that check from the script alltogether. The job descriptions all specify the requirement package.name == 'obexftp'

BUT that has a caveat:

it removes the bit that stops the script cleanly if obexftp isn't installed which makes the script brittle if run stand-alone.

I'd prefer, personally, to see if my suggested patch fixes the issue before taking more drastic measures.

Revision history for this message

Jeffrey Chang (modern911) wrote on 2013-04-25:

#12

The new script in #8 does fix my problem.
Please see https://certification.canonical.com/hardware/201111-10185/submission/90828/test-results/pass/

Revision history for this message

Jeff Lane  (bladernr) wrote on 2013-04-25:

#13

Awesome. Thanks for verifying. I'll push that branch now and it should land in trunk shortly.

Changed in checkbox:
assignee:	nobody → Jeff Lane (bladernr)
status:	Incomplete → Triaged
status:	Triaged → In Progress

Jeff Lane  (bladernr) on 2013-04-25

Changed in checkbox:
status:	In Progress → Fix Committed

Brendan Donegan (brendan-donegan) on 2013-05-08

Changed in checkbox:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Bug attachments

bluetooth_test Edit

Add attachment

Remote bug watches

Bug watches keep track of this bug in other bug trackers.