Mir

tests stuck on armhf

Bug #1195265 reported by Didier Roche-Tolomelli
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Critical
Stephen M. Webb
Mir 0.0.8

Bug Description

I reenabled the tests on armhf as it's our main target right now. Added a valgrind build-dep (see the attached branch). however, the tests are stuck on armhf:

https://launchpad.net/~ubuntu-unity/+archive/daily-build-next/+build/4751091

See original description

Related branches

lp:~didrocks/mir/add-valgrind-build-dep
PS Jenkins bot (community): Approve (continuous-integration)
Daniel van Vugt: Disapprove
Chris Halse Rogers: Approve
Thomas Voß (community): Approve
Diff: 11 lines (+1/-0)
1 file modified
debian/control (+1/-0)
lp:~bregma/mir/lp-1195265
PS Jenkins bot (community): Approve (continuous-integration)
Didier Roche-Tolomelli: Needs Fixing
Kevin DuBois (community): Approve
Alan Griffiths: Needs Information
Diff: 136 lines (+22/-12)
4 files modified
cmake/MirCommon.cmake (+2/-1)
debian/control (+9/-9)
debian/rules (+8/-1)
tests/integration-tests/CMakeLists.txt (+3/-1)
lp:~thomas-voss/mir/disable_acceptance_integration_tests_on_armhf
PS Jenkins bot (community): Approve (continuous-integration)
Didier Roche-Tolomelli: Approve
Diff: 55 lines (+19/-7)
3 files modified
debian/rules (+2/-1)
tests/CMakeLists.txt (+16/-3)
tests/integration-tests/CMakeLists.txt (+1/-3)
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Adding the valgrind dependency is a first step, but make some tests stuck on armhf: https://launchpad.net/~ubuntu-unity/+archive/daily-build-next/+build/4751091

Didier Roche-Tolomelli (didrocks)
summary: - no valgrind makes tests failing on armhf
+ tests stuck on armhf
description: updated
Changed in mir:
importance: Undecided → High
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.0.6

Changed in mir:
status: New → Fix Committed
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Reverting to triage, the fix is only adding the build-dep, and so, we have the tests stucking on armhf now.

Changed in mir:
status: Fix Committed → Triaged
importance: High → Critical
Revision history for this message
Stephen M. Webb (bregma) wrote :

Problem is actually flawed logic in MirCommon.cmake: the cmake code assumes valgrind is always available on android builds.

Changed in mir:
assignee: nobody → Stephen M. Webb (bregma)
status: Triaged → In Progress
kevin gunn (kgunn72)
Changed in mir:
status: In Progress → Fix Committed
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir at revision 854, scheduled for release in mir, milestone 0.0.7

Robert Ancell (robert-ancell)
Changed in mir:
milestone: none → 0.0.8
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir at revision 869, scheduled for release in mir, milestone 0.0.8

Robert Ancell (robert-ancell)
Changed in mir:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.