A high failure in hibernate log was not detected by log_check script

OK, I confirmed this by downloading the attached hibernate_30_cycles.log file as provided, then running:

/usr/share/checkbox/scripts/sleep_test_log_check -v s4 hibernate_30_cycles.log

the output was:

No errors detected

even though as you mention, there are some errors in the file.

Looking at the script/parser, the output from fwts appears to have changed, which is why the parser doesn't detect the error.

The test summary section now looks like this:

Test Failure Summary
================================================================================

Critical failures: NONE

High failures: 2
 s4: Found 1 differences in device configuation during S4 cycle.
 s4: Failed to restore hibernate image.

Medium failures: NONE

Low failures: NONE

Other failures: NONE

Work to do:

1- Fix the parser so it recognizes the "new" fwts file format
2- Have the parser somehow recognize if the log format is possibly unparsable and report this, so a format change doesn't slip by us and cause false negatives.

Also, this high failure cannot be correctly parsed as well:

FAILED [HIGH] HibernateImageRestore: Test 1, Failed to restore hibernate image.

ubuntu@201304-13208: $ /usr/share/checkbox/scripts/sleep_test_log_check s4 ~/.checkbox/hibernate-single.log
No errors detected

hibernate-single.log attached

I see merged branches so I assume this is Fix Commited.